dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1474 Commits

Author SHA1 Message Date
Brian Wilkerson 1c34d8ce57 Add a new command-line flag for server to enable the new relevance computations 
Change-Id: If4c9e95a6e5e804fe480cf8a061ff95ec37651e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138002
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-02 18:55:32 +00:00
Konstantin Shcheglov 34fcc56458 Fix for renaming named formal parameters from invocations, when synthetic. 
R=brianwilkerson@google.com

Change-Id: I4dc57cfc2a941229f2ba8b8b262ed49ecdd6b170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137825
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-28 23:11:00 +00:00
Brian Wilkerson b03ef5b3fe Convert more doc comments in analysis_server 
Change-Id: I333d0af4444226a8152e840c4d9015fb4c30bd32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-13 19:29:28 +00:00
Konstantin Shcheglov 5c332bea91 Stop using 'factory something() => null;' in most cases. 
I did not change MockSdk, to avoid conflict with
https://dart-review.googlesource.com/c/sdk/+/135241

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/40603
Change-Id: I9f0af20f5914b5ac1aefee02aa8052db269529b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135532
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-12 22:58:57 +00:00
Konstantin Shcheglov abf7d1fc08 Issue 40572. Pass Packages to AnalysisDriver. 
Just as SourceFactory is given to AnalysisDriver, so should be Packages.
Understanding --packages and discovery in out of scope.

Bug: https://github.com/dart-lang/sdk/issues/40572
Change-Id: Id120fba0f23a4423797fa9976c4cda5ed54dad53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135188
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-11 00:57:45 +00:00
pq f0df6039bf extended member completions in extensions 
See: https://github.com/dart-lang/sdk/issues/39093

Change-Id: I1848be7f9da0e9f424bcfe3c2dd7e50c194e5f0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134784
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-06 23:31:54 +00:00
Brian Wilkerson 58a9c22f80 Add return types to more methods in analysis_server 
Change-Id: I65bed353bcff4f991faf8c3bdde979789a8d962b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-30 21:43:34 +00:00
pq 9a572c70fa call() suggestions for FunctionTypes 
Fixes: https://github.com/dart-lang/sdk/issues/40270

Change-Id: Ic6f882391d1450b43cc224d5ec908589239c590e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133941
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-01-30 17:43:40 +00:00
Brian Wilkerson d6206fbbc7 Add return types to more tests in analysis_server 
Change-Id: Ib85d299a34cfda6bc4772d53f16d9ba44251bfbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-30 14:30:18 +00:00
Brian Wilkerson 9918987c59 Enable prefer_if_null_operators and prefer_spread_collections in analysis_server 
Change-Id: I14fa2e9a3196be1d5f5d7991104e7363c72b3fe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133334
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-25 16:31:07 +00:00
pq 169dd530f3 de-dup mutiply exported elements 
Change-Id: Id83d93207e32d069274b61a1352c99fb1bb940ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133151
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-23 23:54:01 +00:00
pq 90b74dcc97 element info for Function call suggestions 
Fixes: https://github.com/dart-lang/sdk/issues/40286

Change-Id: Iaf9e36d4f29f4b2908be4ab42f0e8e997bdc8a90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-23 00:40:01 +00:00
pq 6e091bd781 Function call() suggestions 
Fixes: https://github.com/dart-lang/sdk/issues/39761

Change-Id: If7dbe8b29fd081cd77310343a4cba0d7355c45e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132920
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-01-22 19:44:48 +00:00
Brian Wilkerson 5584c96fde Enable prefer_single_quotes in analysis_server 
All of the changes except in the analysis options file are from dartfix.

Change-Id: Icd9bf02ad07f71d1fc365979c7dfe18a792dc595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132624
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-21 17:52:52 +00:00
pq 87fe06a03e stop suggesting keywords in method type argument lists 
Fixes: https://github.com/dart-lang/sdk/issues/40213

Change-Id: I2779d445e98c9056dd15afd2de657d92087ebff1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132400
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-17 21:56:35 +00:00
pq 819a97a0ef type argument completions for generic method invocations 
Fixes: https://github.com/dart-lang/sdk/issues/40190

Change-Id: Ic44dca751e08a7fdd540c96172f07cb8ee1d1850
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132382
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-17 21:56:26 +00:00
pq 8fda644e10 lambda generation for positional args 
Fixes: https://github.com/dart-lang/sdk/issues/40202

(See issue for animation of UX.)

Change-Id: I029a7768b887fedef4873f3fa23171d21df8808f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132380
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-17 21:10:17 +00:00
pq c7745a1a0d contribute local completions for mixin members 
Fixes: https://github.com/dart-lang/sdk/issues/39795

Change-Id: I1a186dd63e59463706d18dd484653c0bee70ba90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132165
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-16 22:55:53 +00:00
pq 81003d8147 fix extension completions in mixins 
* ensures extension member completions get added for mixins
* restructures and adds tests

Change-Id: I525450584b05e485027e46d775423e6d6f9f8e99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132030
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-16 20:48:48 +00:00
pq 05fdb62234 extension completions w/o dotTarget 
Fixes: https://github.com/dart-lang/sdk/issues/39093

Change-Id: I9a576e4387b6a869a4779f15c16f7272f99d2acd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131848
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-16 14:54:01 +00:00
pq 8163dbea4f completions for yield statements 
Change-Id: I4ac28ebf4d5b2c49926a31704a81ccf2fd14106d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131718
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-15 00:49:24 +00:00
pq e0c178b38e closure arg code completion 
Change-Id: I99b97c967f017492a711e30fe183dba52e05d190
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131713
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-14 23:17:34 +00:00
Jaime Wren 82785b6762 This is a failing test for http://dartbug.com/37907 using the new DartCompletionManagerTest 
Change-Id: Id852d5f2894f5e0ba12127a04fad2f9c91593cd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131702
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-14 21:11:46 +00:00
Jaime Wren 226f0c4523 Refactor the 3 implementations of Comparator<CompletionSuggestion> down to a single implementation. 
Change-Id: I39cde605c53dbe2dded60278bd128e7d32e2a763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131580
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
 2020-01-14 07:25:25 +00:00
pq fd9d3f9786 relevance test re-structure 
See: https://github.com/dart-lang/sdk/issues/40104

Change-Id: I79635831d92313f6c55c9a7c4a7b1fb0eeb41c06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-13 23:59:30 +00:00
Brian Wilkerson 5b1065ac60 Enable avoid_init_to_null in analysis_server 
Change-Id: I1909b0d8939d9b436fce772bd97dc4835f1093ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-13 00:35:34 +00:00
pq 113f034550 completion manager test harness 
Adds a new `DartCompletionManagerTest` base class for testing suggestions in aggregate.

Existing `DartCompletionContributorTest` work as expected.


Example use:


@reflectiveTest
class CombinedContributorsTest extends DartCompletionManagerTest {
  test_printAll() async {
    addTestSource('''
class A {
  void operator &(A other) {
    ^
  }
}
''');

    await computeSuggestions();

    suggestions.forEach(print);
  }
}




Change-Id: I95852a0d55d1a634bee9c88bee77c9455853b02e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131205
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-12 15:35:03 +00:00
Brian Wilkerson 32ce9c7872 Enable prefer_collection_literals in three packages 
Other than the following changes, all of the changes were made by dartfix:
- the analysis options files
- one line to enable the fix through dartfix (missed in an earlier CL)
- three places where a bug in the fix produced invalid code (issue and fix TBD)

Change-Id: If8660700792561805f4d1c96ccecd81abcebfeb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131209
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-11 20:39:02 +00:00
Konstantin Shcheglov 75613fd77a Issue 40062. Restore check for extededType subtype. 
R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/sdk/issues/40062
Change-Id: I0c9abad8e7af7bc025af0224ba8b15eb65af7210
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131204
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-11 17:30:12 +00:00
pq 30b5aaa889 fix override change edit for super operators 
Currently, wrongly generating:

  @override
  bool operator ==(other) {
    // TODO: implement ==
    return super.==(other);
  }




Change-Id: I99a2584e5e921d0dd5639c45a9ec8fe27f082ccd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131041
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-10 18:55:12 +00:00
pq 6a754445a0 stop proposing new 
Fixes: https://github.com/dart-lang/sdk/issues/40047

Change-Id: I50ae3b6843d57f6c3640caa5d7a4fae03f845708
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-10 14:42:17 +00:00
Brian Wilkerson e5705943d8 Enable prefer_conditional_assignment in several packages 
Other than the changes to the code generators and the analysis options
files, the changes were all generated by dartfix.

Change-Id: I80055e3992452c5b40eed41ac79807cf5c932976
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-06 05:19:19 +00:00
Brian Wilkerson 91d6e1a0a7 Enable annotate_overrides in several packages 
Other than analysis_server/test/analysis/notification_overrides_test.dart,
which had a naming conflict, all of the changes were made using dartfix.

Change-Id: I911dd75dcdee00420caa48724125e86d47c8857d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 21:31:40 +00:00
Brian Wilkerson 7d41ae7d15 Enable unnecessary_this in several packages 
Change-Id: I743066d66dbf1dff984e8f8bf5b7a472c9bc7ff7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129821
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-28 20:43:16 +00:00
Brian Wilkerson 52c6620986 Enable unnecessary_const in analysis_server 
Change-Id: I44d9902cb23d005ebedd4bc37d57d3751a8ebdc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-19 17:32:52 +00:00
Brian Wilkerson 4043a6fce3 Remove unnecessary uses of new in analysis_server 
Other than analysis_options.yaml, all of the changes were from running
dartfix.

Change-Id: I92411642f12a00fc6bd0bfd24dd60fe67f0fed16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 19:01:51 +00:00
Konstantin Shcheglov 3389b3bd32 Remove Packages from SourceFactory. 
We have PackageMapUriResolver, this should be the way to resolve
all `package:xyz` URIs. We should not repeat it in SourceFactory.

Change-Id: I52d33dbf7e2d44f2c53521f6a51b0aea70507d3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128106
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-12 17:10:00 +00:00
Konstantin Shcheglov 9456316b51 ErrorReporter should know isNonNullableByDefault. 
So, when we call DartType.getDisplayString() we know if the type
presentation should include nullability suffixes.

This fixes many, but not all places where we need to present types.
There are places where we don't go through ErrorReporter, but call
ErrorListener directly. I plan to replace all these with ErrorReporter.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/39651
Change-Id: Ic77a556e7834d8f757c8b13eed37ed1d34f47348
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-10 01:31:22 +00:00
Brian Wilkerson 4ba61bbbbc Fix exception in ML ranking (issue 39537) 
Change-Id: I5667060acb3392da60956176e1edd35dd8098b2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2019-11-28 00:03:51 +00:00
Konstantin Shcheglov 8fbb053092 Issue 39021. Guard against invalid generic type alias, without function type. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39021
Change-Id: I0259ef04f95e1935ca273b5540aafb069c7ad455
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125526
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 16:06:53 +00:00
Konstantin Shcheglov fe3fadbdba Issue 39025. ForEachPartsWithIdentifier does not define anything, don't pretend that it is a LocalVariableElement. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39025
Change-Id: Ieda56c73a1928434a29aa947c44fc29b66a79464
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125525
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 15:44:13 +00:00
Konstantin Shcheglov 3a17bebf9c Issue 39028. Guard against mixin constructor in FieldFormalParameter completion. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39028
Change-Id: I78e4df6baa8424231aeb2c8044d9cb5c685dcdbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 15:36:48 +00:00
Ari Aye 5bae0f23cf Increase completion model token lookback to 100 
In moving to a pointer mixture network from a traditional language
model I had initially decreased model lookback to 50 tokens to
facilitate faster model training iteration. Now that we've landed
on a configuration that works well, increasing lookback to 100 tokens
improves accuracy further.

I also went ahead and followed a recommendation from Jacob to
oversample Flutter sources since they're greatly underrrepresented
in our training corpus compared to our users' code at prediction time.

Change-Id: I885ddb606270394198f3aca2554e381f4465bdae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-11-04 18:00:16 +00:00
Ari Aye 5edeee8907 Transform hexadecimal numbers coming into model to <num> like we do for decimal numbers 
Not hugely important since hexadecimal usage is very low in Dart in general, but
this is consistent with the transformation we apply at training time.

Change-Id: I45875fd46cd172374acba14251a8d86264339c47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-10-24 21:45:07 +00:00
Ari Aye f2e2b3257b Fix code completion performance regression introduced by pointer mixture network 
Latency had grown to over 100ms and after this change we're consistently
under 100ms https://i.imgur.com/CCo0iQa.png. In addition, I was able to reduce
the number of isolates to two from four, lowering the memory footprint of model.

The biggest change is that we're moving from taking a map of size |V| = 100k
like {"foo" => 0.2, "bar" => 0.3} and sorting it to find the top n completions
to simply filtering / selecting lexemes with probability greater than a min
threshold (set for now to be a percent of a percent, 0.0001).

Change-Id: I721e6de343add6b8ebcf3ef4fad20f136302808e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122842
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-24 20:31:52 +00:00
Konstantin Shcheglov cb9eefca4f Issue 142793249. Never remove directive with unresolved URIs. 
Bug: https://buganizer.corp.google.com/issues/142793249
Change-Id: I5ced1bcf4cb5d634f8e11555bb464f10c4bac68c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121926
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-18 17:06:50 +00:00
Sam Rawlins 680a880c10 Move string utils from services/correction to utilities; more generally used 
Change-Id: Idb81b54fe380e6af00af5ddee3977705ff58c741
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121912
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-10-17 15:04:00 +00:00
Ari Aye e642af52a5 Fix behavior of ML query construction 
This is one of the rare cases where the comment was correct
and the code was wrong. If we've typed class FooB^ then the
query should be ['class'] whereas typing void main(^ should
result in the query ['void', 'main', '('].

Change-Id: I5f53fa70c1ddfd1803e5697cdaaaf7d3b73f5ae2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121778
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-10-15 22:33:25 +00:00
Konstantin Shcheglov c5498891fc Don't suggest class member completions for ExtensionOverride targets. 
Change-Id: Ic3e2ef31cc42ccf4d16688050b894a50e5a8f51e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121765
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-15 20:58:29 +00:00
Ari Aye 70a7ef3f58 Implement pointer mixture network 
Here we can see the mixture network is assigning probability mass
to a new, project-specific name by reference https://i.imgur.com/6Zbs2qf.png.

I also took this opportunity to decrease model size targeting 100M, in line
with our original size goals.

My initial strategy was to implement a separate pointer network
in https://dart-review.googlesource.com/c/sdk/+/117005 but having
a single network that can assign probability mass across local
references and vocabulary lexemes is better since

1) only one network and model file
2) no need to coalesce predictions from multiple models

Change-Id: I23cfc2ece61ce30bb69785149a5a6cf1604af18d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121461
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-14 18:25:56 +00:00