dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

292 Commits

Author SHA1 Message Date
Brian Wilkerson 42d1d4532d Reformat code to minimize churn 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1310263003 .
 2015-09-09 08:19:18 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
Brian Wilkerson 27f600058e Improve propagation in binary expressions 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1226823003 .
 2015-07-08 08:02:05 -07:00
Brian Wilkerson 40e925078f Bug fixes for the new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1144393006
 2015-06-01 16:42:36 -07:00
Konstantin Shcheglov f1d4ef9164 Issue 23409. Don't set 'propagatedType' in (vs. after) 'name is Type'. 
This fixes the corresponding 'Extract Method' issue.

R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23409

Review URL: https://codereview.chromium.org//1161343002
 2015-06-01 12:40:30 -07:00
Konstantin Shcheglov 5b44136f2a Issue 23389. Report error in the renamed element be invisible after rename. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23389

Review URL: https://codereview.chromium.org//1153253004
 2015-06-01 10:40:59 -07:00
Konstantin Shcheglov 4936eb8d5d Fix for 'Create part' Quick Fix. 
1. NonExistingSource.modificationStamp should return -1.
2. NonExistingSource.fullName should be always an absolute path, not a URI.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1135073004
 2015-05-18 11:55:23 -07:00
scheglov@google.com b909e13241 Ignore synthetic tokens when search for AstNode. 
This fixes the exception you saw during 'Extract Local' refactoring.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1117183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45481 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-03 20:29:38 +00:00
scheglov@google.com 9efb25fa50 Use package:test_reflective_loader instead of reflective_tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1101003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45365 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-22 20:54:29 +00:00
scheglov@google.com 3acb224c1d Add await/async when a method with 'await' in its body is extracted. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1055183004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45036 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 21:16:17 +00:00
scheglov@google.com 8a1f8b158b Issue 23091. Fix for adding import prefix before string-interpolated identifier. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23091

Review URL: https://codereview.chromium.org//1059133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44893 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 21:58:59 +00:00
scheglov@google.com cadcd05f73 Issue 22988. Improve checking for conflicts between parameters and local elements during extracting methods. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22988

Review URL: https://codereview.chromium.org//1053323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44891 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 21:04:26 +00:00
scheglov@google.com 17ea180d2c Issue 23081. Fix for inlining into IndexExpression index. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23081

Review URL: https://codereview.chromium.org//1052243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44863 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-02 17:19:08 +00:00
scheglov@google.com 1dc26d9f06 Issue 23018. Fix for inlining multiline strings with leading whitespaces. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23018

Review URL: https://codereview.chromium.org//1042033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44771 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-28 02:31:07 +00:00
scheglov@google.com cd1b09f5c3 Simplify rules for extracting getters. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1026503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44607 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-20 18:54:56 +00:00
scheglov@google.com 4cdce46316 Issue 22757. Update self references on package rename. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22757

Review URL: https://codereview.chromium.org//1010803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44524 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 21:28:57 +00:00
scheglov@google.com a28e99b719 Issue 22757. Create pubspec.yaml file change on project rename. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22757

Review URL: https://codereview.chromium.org//1015513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44515 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-16 18:59:16 +00:00
scheglov@google.com da0cecb331 Issue 22845. Rename should prevent the use of invalid identifiers. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22845

Review URL: https://codereview.chromium.org//1011613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44495 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-15 19:55:57 +00:00
scheglov@google.com 1183b3b35a When a closure is extracted as a method, it does not have any return type. 
But it should not be returned as 'void'.
It should be an empty string, as any other method with unknown return type.
I guess we could improve this in the future, e.g. promote type of a returned expression into the signature.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//970063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44177 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-03 16:17:33 +00:00
scheglov@google.com d69f9043cd Don't allow to extract a closure as a getter. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//971203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44176 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-03 16:15:47 +00:00
brianwilkerson@google.com cd58e290c4 Reformat 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//969113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-02 22:43:12 +00:00
scheglov@google.com 98c9558a23 Issue 20827. Import required type in 'Extract Method' refactoring. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20827

Review URL: https://codereview.chromium.org//956393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44059 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-26 17:08:13 +00:00
scheglov@google.com acec842aee Add 'Convert Method to Getter' proposal only if it is an available refactoring. 
So, that we don't show it for method with parameter or returning null.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//945113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43936 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 23:18:21 +00:00
scheglov@google.com 0348d0decd Issue 22288. Rename named parameters in hierarchy. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22288

Review URL: https://codereview.chromium.org//945693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43931 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 22:08:18 +00:00
paulberry@google.com acaed71dba Clean up analyzer and analysis server hints. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43667 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 20:40:26 +00:00
scheglov@google.com ff4e2bfce1 Issue 22188. Verify that none or all execution flows return. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22188

Review URL: https://codereview.chromium.org//871013012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43663 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 19:14:01 +00:00
scheglov@google.com 8d35890475 Convert refactoring tests to use 'await'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//908463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43573 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 22:13:37 +00:00
scheglov@google.com 81ebd5fd77 Fix for extracting local variable in if-else-if statements. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//879463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43528 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 22:36:56 +00:00
scheglov@google.com 36ce6423a6 Fix for two semantic highlighting problems. 
1. We need to dispose the existing semantic highlighting manager before setting a new input.
   So, we would not apply old highlighting to the new file.

2. We need to clear "input" fields to correctly determine full file path.

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//882203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43254 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-28 19:55:25 +00:00
scheglov@google.com c5af5132fc Issue 22191. Grab the document lock before positionsLock to prevent deadlock. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22191

Review URL: https://codereview.chromium.org//885653005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43251 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-28 18:33:16 +00:00
scheglov@google.com a016a7b56e Fix for 'Convert Method to Getter' when multiple files are changed. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//881943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43221 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 23:12:23 +00:00
scheglov@google.com 2b8c66ea79 Rename ChangeNotice resolved Dart/Html unit fields. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//881463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43147 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-26 19:58:19 +00:00
scheglov@google.com a38a503d86 Replace @ReflectiveTestCase() with @reflectiveTest. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//849863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 17:11:24 +00:00
scheglov@google.com 9f64a926e6 Issue 21959. Check that type of parameters in 'Extract Method' occurrences are exactly the same. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21959

Review URL: https://codereview.chromium.org//832343004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42615 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-05 23:12:27 +00:00
scheglov@google.com dca42cafab Check if the method / accessor being inlined is synthetic. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//835093005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42606 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-05 19:36:39 +00:00
scheglov@google.com 97f90d4acc Fix for extracting from interpolated string. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21907

Review URL: https://codereview.chromium.org//820763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42528 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-19 22:11:13 +00:00
scheglov@google.com e30b2b313d Ignore ButtonType when computing an extracted method return type. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//789543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42201 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-09 02:19:54 +00:00
scheglov@google.com 3b73b01511 Issue 21740. Allow inlining local variables declared in SwitchCase. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21740

Review URL: https://codereview.chromium.org//780653005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42191 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-08 22:33:07 +00:00
scheglov@google.com 0cd030eeb8 Issue 21613. Fix for renaming FieldFormalParameterElement. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21613

Review URL: https://codereview.chromium.org//749173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41929 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-24 16:00:28 +00:00
scheglov@google.com b8da9bc651 Format and sort analyzer and analysis_server packages. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//725143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 22:23:53 +00:00
scheglov@google.com 30e11469c3 Use a better way to compute InterfaceTypes least upper bound. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//730803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41761 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-15 16:52:58 +00:00
scheglov@google.com 0f0a275fc7 Issue 21612. Support for multiple returns in the 'Extract Method' refactoring. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21612

Review URL: https://codereview.chromium.org//725393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41758 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-15 01:40:46 +00:00
scheglov@google.com 6a03e08cca Issue 21617. Replace explicit 'this' references and clean ups. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21617

Review URL: https://codereview.chromium.org//733663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41753 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-14 23:16:13 +00:00
paulberry@google.com 9bc06fbf41 Workaround for ConstantVisitor dependency issues. 
This restores proper test functionality on the buildbots.  I plan to
follow up with a more permanent fix.

BUG=dartbug.com/21572
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//701583003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41676 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-11 22:55:58 +00:00
scheglov@google.com 772a0c6b22 Fix 'Unused local variable' hints in analyzer and analysis_server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//709493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41576 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 18:32:54 +00:00
scheglov@google.com 1d69da9c39 Issue 21496. Fix for inlining negate/decrement into negate. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21496

Review URL: https://codereview.chromium.org//695383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41466 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 20:29:57 +00:00
scheglov@google.com 15743f701e Support for inlining methods when some arguments are missing. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//694373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41464 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 18:35:58 +00:00
scheglov@google.com 47532a7ba5 Tweak test for the new resolved/parsed AST management and restore it. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//695923003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41454 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-01 05:28:46 +00:00
brianwilkerson@google.com 9dad99f92c Disable a test until I can fix it 
Review URL: https://codereview.chromium.org//655353005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41428 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-30 21:47:58 +00:00
scheglov@google.com e446dd5227 Issue 21333. Constant names are not special anymore in the style guide (Dart version). 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21333

Review URL: https://codereview.chromium.org//684863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41373 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-28 21:42:46 +00:00