dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

36 Commits

Author SHA1 Message Date
Brian Wilkerson 54fc28ec25 Migrate remaining unblocked tests 
Change-Id: I30e3c22db7df6e78be88125f20eea2dce054f446
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195860
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-19 15:57:38 +00:00
Konstantin Shcheglov e97f1bdbf0 Switch analysis_server to language 2.12, so null safety, but opt-out files. 
This should allow doing partial migration, specifically protocol files,
which are imported by other libraries, but are a small library cycle
that does not import much outside of it.

Change-Id: I904c05d6d5b444ee9a9dbd1f7ada12aabdcc5165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-30 23:39:37 +00:00
Brian Wilkerson d6206fbbc7 Add return types to more tests in analysis_server 
Change-Id: Ib85d299a34cfda6bc4772d53f16d9ba44251bfbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-30 14:30:18 +00:00
Brian Wilkerson 47e988b781 Clean up the remaining copyright notices in analysis_server 
Change-Id: Iee3110f92ab0f24312ddd1eff407d2229f895321
Reviewed-on: https://dart-review.googlesource.com/c/89101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-11 15:38:56 +00:00
Brian Wilkerson e454986288 Add code to run more tests from test_all 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2968233002 .
 2017-07-06 12:24:01 -07:00
Brian Wilkerson db0a8a76ae Move CompletionTarget and OpType for use by plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2924703002 .
 2017-06-06 07:07:19 -07:00
Brian Wilkerson 7d26ff6d4f Remove some more library directives 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884233004 .
 2017-05-17 08:02:08 -07:00
Steve Messick eadc6af226 Statement completion framework with a few examples 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2803313002 .
 2017-04-07 13:55:50 -07:00
Konstantin Shcheglov 05a86a7495 Remove 'initializeTestEnvironment' from 'analysis_server'. 
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2402483002 .
 2016-10-06 10:26:17 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'. 
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
 2016-10-06 08:47:15 -07:00
Dan Rubel 43ee7b5bc9 move OpType into dart folder 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1523243006 .
 2015-12-19 11:11:04 -05:00
Dan Rubel b3fa2629bf remove CompletionCache and obsolete tests, and cleanup imports 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1533973002 .
 2015-12-17 16:00:34 -05:00
Dan Rubel 0de484bb8b convert ImportedReferenceContributor to new API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1526303003 .
 2015-12-16 21:17:27 -05:00
danrubel 6464160147 move LocalDeclarationVisitor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1529653003 .
 2015-12-14 20:36:57 -05:00
danrubel d8494d2f50 move LocalReferenceContributor to new API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1528633002 .
 2015-12-14 13:57:51 -05:00
danrubel e03c395a8c extract TypeMemberContributor from prefixed element contributor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1504223005 .
 2015-12-09 07:38:20 -05:00
Dan Rubel a5e4c81b7f move combinator contributor to new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1503463002 .
 2015-12-04 15:48:21 -05:00
danrubel 9f033a9d94 convert uri contributor to use new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1498733005 .
 2015-12-04 07:49:31 -05:00
danrubel 4379efb6b4 rework ArgListContributor to use new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1500793003 .
 2015-12-03 18:00:50 -05:00
danrubel b9ad8a15e4 hook new DartCompletionContributor API into existing framework 
and convert KeywordContributor to use new DartCompletionContributor API

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1471173003 .
 2015-11-24 12:03:44 -05:00
danrubel 594183e0db Rework contribution sorter to use futures 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1470863003 .
 2015-11-23 21:35:52 -05:00
danrubel 38cec67d03 step toward new completion API 
- separate new CompletionContributor and DartCompletionContributor APIs
- revise new APIs and implementations to be Futures based
- revise InheritedContributor to use new Futures based contributor API
- remove unused classes

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1467023002 .
 2015-11-23 12:50:12 -05:00
Brian Wilkerson f4b1879180 Add a completion for inherited methods 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1338173002 .
 2015-09-18 08:59:56 -07:00
danrubel 07184f6cdd rename ImportUriContributor to UriContributor 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1329463002 .
 2015-09-01 11:11:36 -04:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
brianwilkerson@google.com 0bf3812043 Fix exception in code completion (issue 23439) 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1138963005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45805 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 00:00:59 +00:00
danrubel@google.com 6237c8909f add dart: and package: import uri suggestions 
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1100393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45398 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 12:51:52 +00:00
danrubel@google.com 1e83a73221 rename completion source files to match content 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1068483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44921 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-06 17:46:39 +00:00
danrubel@google.com a56ac2f521 update code completion suggestion relevance based on common usage 
BUG=
R=lukechurch@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//925723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43792 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-15 21:17:48 +00:00
danrubel@google.com ef89b4c21a tests for earlier CL 
BUG=dartbug.com/21768
R=paulberry@google.com

Review URL: https://codereview.chromium.org//882273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43295 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-29 16:50:24 +00:00
danrubel@google.com 049adb2777 refactor optype to be computed once per refactoring request 
and hide optype computation internals

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//807743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42412 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-16 22:15:38 +00:00
danrubel@google.com ddc3cae8bd refactor duplicate code into single visitor 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//804323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42398 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-16 16:53:24 +00:00
danrubel@google.com d3646956e8 first cut argument list completion suggestions 
- first cut simplistic insertion of params
- required params only for now
- move cursor after ) if no params
- don't insert () if identifier suggestion
- does not cover all method/function invocations yet
- updated comments in Server API
- extracted new declaration visitor

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//711533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41586 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 21:42:31 +00:00
danrubel@google.com 58b915ffea move import combinator suggestions into a separate computer 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//695773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41442 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 18:31:18 +00:00
danrubel@google.com 611e8ca216 rename completion class 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//551933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39987 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-08 18:38:36 +00:00
paulberry@google.com 7226309842 Import analysis_services.dart into analysis_server.dart. 
Having two separate packages doesn't really have any benefit, and has
the downside of forcing us to carefully avoid circular dependencies
between the two.  It makes more sense to just combine them.

This is largely a mechanical change consisting of the following renames:

1. pkg/analysis_services/lib/src/* -> pkg/analysis_server/lib/src/services/*
2. pkg/analysis_services/lib/* -> pkg/analysis_server/lib/src/services/*
3. pkg/analysis_services/test/* -> pkg/analysis_server/test/services/*

There were 4 instances where 1 and 2 created a collision:
.../services/correction/assist.dart, .../services/correction/fix.dart,
.../services/refactoring/refactoring.dart, and
.../services/search/search_engine_internal.dart.  To fix the
collision, the files coming from pkg/analysis_services/lib/src were
renamed to "..._internal.dart".

In addition, pkg/analysis_services/test/test_all.dart was modified to
call pkg/analysis_services/test/services/test_all.dart.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//484733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39349 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-18 20:17:49 +00:00