Brian Wilkerson
eb1ce5d640
Remove some unnecessary null checks
...
These were found using the unnecessary-null-checks lint. It has a bug
that prevents us from enabling it at the moment, but we should consider
enabling it once the bug has been fixed.
Change-Id: Ice250b5a6a8723c5f08dec5b07ae738e17c842cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196550
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-24 18:22:43 +00:00
Danny Tuppeny
8a0897c165
[analyzer] Fix a bug with completion ranking for items with 0 relevance in LSP
...
Change-Id: Ic4ef390ba4bdc627e075ae9dade8ced5a307a8ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196667
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-24 18:13:32 +00:00
Danny Tuppeny
a808d5ca20
[analyzer] Update LSP fix-all tests based on new server implementation
...
Change-Id: Iccc71d67c77eb2a372293e746ca12984f67a0579
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196285
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-21 19:48:00 +00:00
Danny Tuppeny
1b6399759a
[analyzer] Migrate remaining LSP tests to null-safe
...
Change-Id: I7a2befd9d46b93ebeb84c40f33121f077f3d6f1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196284
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-21 16:41:50 +00:00
Danny Tuppeny
56e5655353
[analyzer] Migrate more LSP tests to null-safety
...
Change-Id: Iaeb2152d47df05434ab470901900da56cae7e792
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196125
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-20 21:15:28 +00:00
Danny Tuppeny
9b529bb8fe
[analyzer] Fix handling of overlapping LSP SemanticTokens
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3289 .
Change-Id: I15c41f1519a0c06b810be8e840e8ef7c13af45ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195995
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-20 16:18:38 +00:00
Konstantin Shcheglov
5dd02f0583
Add getParsedLibrary2(), deprecate getParsedLibrary() and other parse related
...
Change-Id: I585fa1f01b71522dc99ba86c2b9e20da256b2d27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-04-19 15:52:39 +00:00
Danny Tuppeny
934be22ab5
[analyzer] Support package descriptions + version numbers in pubspec.yaml package completion
...
Change-Id: I064689814b1f81671be870bb5c8499ebf35ab468
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195077
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-15 20:24:32 +00:00
Danny Tuppeny
790ceec1ab
[analyzer] Support additional LSP completion trigger characters
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3211 .
Change-Id: Iad4db41b539990d39f641ff1dd07b174f207891b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-15 20:16:37 +00:00
Danny Tuppeny
2dcbd22e0c
[analyzer] Don't send Dart's trigger/commit characters for non-Dart LSP completion registrations
...
Change-Id: I703b183ebd9aedaf87dbbce664107d5bcff14367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195509
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-15 19:44:27 +00:00
Danny Tuppeny
dc28e1fee6
[analyzer] Fix unexpected completions at EOF in comments
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3281
Change-Id: Ica8160977ac682dbf4db0f0b8a64a1ec0d2d9a2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195505
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-15 15:36:57 +00:00
Danny Tuppeny
eb0e7199ac
[analyzer] Fix a null assertion error when completing in comments
...
Change-Id: I6456e951ec8cfe624efd6cbf7696c324e7a4b581
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195504
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-15 15:18:17 +00:00
Danny Tuppeny
133f9936e0
[analyzer] Ensure server-generated diagnostics are recorded to be merged in with plugin errors
...
Fixes https://github.com/dart-lang/sdk/issues/45678 .
Change-Id: I90d2908d1299f3b18efe74f3741d32bbd39e3beb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195270
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-04-14 16:11:38 +00:00
Danny Tuppeny
ea9c6484f1
[analyzer] Fix path format in test for windows
...
Change-Id: I20ddb29e18303ad38a29a98c8ace00ced858b120
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194763
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-04-09 14:11:28 +00:00
Danny Tuppeny
e8d53cff92
[analyzer] Improve handling of loose files and context rebuilds
...
Change-Id: Ifd047a29953503a70216ce29b3fe4cdbfc4132df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192926
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-08 17:49:35 +00:00
Konstantin Shcheglov
c5769f6604
Migrate lib/src/search/workspace_symbols.dart
...
R=brianwilkerson@google.com
Change-Id: I14e70698e91db02f3e49ced438668d0d903bf349
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194203
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-04-07 07:08:17 +00:00
Konstantin Shcheglov
d8da40ec52
Migrate lib/src/protocol_server.dart and related.
...
Change-Id: Ibb1e5a53aa8ad67fa43b315880c491093b051e20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-04-07 00:26:59 +00:00
Konstantin Shcheglov
e97f1bdbf0
Switch analysis_server to language 2.12, so null safety, but opt-out files.
...
This should allow doing partial migration, specifically protocol files,
which are imported by other libraries, but are a small library cycle
that does not import much outside of it.
Change-Id: I904c05d6d5b444ee9a9dbd1f7ada12aabdcc5165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-30 23:39:37 +00:00
Brian Wilkerson
d00ef8611a
Update the server protocol to support passing back the line and column numbers for the end of a range
...
Change-Id: I8310e4a32cacbe98310c1dbaa3b3563b1ff1a1ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191862
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-18 19:22:23 +00:00
Danny Tuppeny
44275c6001
[Analyzer] Add support for LSP experimental SnippetTextEdit
...
Change-Id: Id37a1954c71fb10c4968c5af6a873ad0ef864a5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-16 18:40:50 +00:00
Konstantin Shcheglov
9f5f825d96
Check that the element of MethodInvocatio is ExecutableElement.
...
Change-Id: Ibf414e624b32b6ac5a0b0fde13422db45f875a15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189262
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-05 16:50:56 +00:00
Danny Tuppeny
bacd31dcdf
[analyzer] Flatten capabilities into a wrapper to simplify checking capabilities
...
Change-Id: I184e8ce3379bbb6ae4d8e81d80979510a8f1f393
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-04 19:51:09 +00:00
Danny Tuppeny
dcc466919f
[analyzer] Suggest named args between partially-typed names and values
...
Fixes https://github.com/dart-lang/sdk/issues/35414 .
Change-Id: I847aa87c56de248e8e704790c163de4f83813bbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-04 18:39:49 +00:00
Danny Tuppeny
78dd7a4bb3
[analyzer] Suggest arg names in front of positionals
...
Fixes https://github.com/dart-lang/sdk/issues/40654 .
Change-Id: I329d8b4af9371e8d61c4044bb003f9c22cd72c41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182783
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-04 18:21:19 +00:00
Danny Tuppeny
0635916aeb
[analyzer] Set InsertTextMode.asIs for LSP completions when supported
...
Fixes https://github.com/dart-lang/sdk/issues/45147 .
Change-Id: Id6c758eadf9a79ec9cd285fef9e50a1540cdc280
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188723
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-04 16:44:49 +00:00
Danny Tuppeny
d901f7326a
[Analyzer] Add code completion for Pub package names
...
Change-Id: I0fa8fb1c2801e2acb2d2cf75f7efecf4f9058eeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jonas Jensen <jonasfj@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-03 17:12:58 +00:00
Danny Tuppeny
5c2afd5e34
[analyzer] Base LSP filterText on displayed label, not inserted text
...
Fixes https://github.com/dart-lang/sdk/issues/45157 .
Change-Id: I13d42a1c37b30c8e4d7969a6a20ed14f9fd1f0b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188466
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-02 17:41:32 +00:00
Danny Tuppeny
f77eba360e
[analyzer] Generate completion text more suited to replacements for LSP
...
Change-Id: Id8c20ea7e1c32759673c32c9f4b363345bc23116
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188290
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-02 16:14:12 +00:00
Danny Tuppeny
c4edcc4cfa
[analyzer] Support separate insert/replace ranges for completions
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/2998 .
Change-Id: I8e989932c16dc97f704c79c06374c8d1d1881f7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-02-23 17:43:11 +00:00
Danny Tuppeny
8f9cdb3b2f
[analyzer] Remove LSP fix-all-in-file functionality
...
To be replaced by new functionality that works with LSP + original protocol.
Change-Id: I59627e2c4e99b0a6aa0eb850168c870e5390e03b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-02-22 19:53:39 +00:00
pq
4302f058dd
disable legacy fix-all fix creation
...
Tests to be re-enabled when we wire-up `FixInFileProcessor`. (Or maybe we want a different approach to testing fix all fixes entirely? TBD.)
See: https://github.com/dart-lang/sdk/issues/45026
Change-Id: I66f83d06801a71143dcc770cc38d9e2f86782264
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185180
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-02-16 20:50:20 +00:00
Danny Tuppeny
c8c49c7cc8
[analyzer] Handle creating new files from code actions
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3141 .
Change-Id: I44d7f20962512988ff1d54c7b38b6a144f973a58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-02-16 18:54:39 +00:00
Konstantin Shcheglov
51950ab881
Add Resource.parent2 that returns non-null Folder, add Folder.isRoot
...
A bigger version of than https://dart-review.googlesource.com/c/sdk/+/184381
This is breaking change, so we do this in steps.
Change-Id: I0c7212a073b605ade56657036543c604651810c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184581
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-02-12 19:09:20 +00:00
pq
2d27b34b06
appliedTogetherMessages for fixable in file fixes
...
Change-Id: I674f0e79c5d7ce5c44bcbddff8e6866106e860c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-02-12 17:10:23 +00:00
Danny Tuppeny
235292605e
[analyzer] Filter code actions returned from LSP server based on params.context.only
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/2854 .
Change-Id: If6036a4361b68ae2daa66b99755dfa9b9a8adcfd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-02-11 18:16:20 +00:00
Danny Tuppeny
ab8335b4fd
[analyzer] Don't fail to initialize LSP server with non-file:// workspace folders/roots
...
Change-Id: I52fa0620ef563ff0362cb86b24ffc287e8e007c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184461
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-02-11 16:10:19 +00:00
Danny Tuppeny
74d8cc9636
Extend analysis server benchmarks to run for LSP too
...
Change-Id: Ib6522b8faaa5be272d8f97043a7aa1c345ea182c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-02-02 22:09:54 +00:00
Danny Tuppeny
b94adb2bc2
[Analyzer] Add folding regions for comment blocks
...
Change-Id: Iafe70e977065dc68230503349b8ba3abe9b4c0c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179777
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-20 16:23:45 +00:00
Danny Tuppeny
15cd98f511
[Analyzer] Add a custom semantic tokens modifier to named parameter labels
...
Change-Id: I5b5e4030a17bd894872884960d11eaa748c12e5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179769
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-19 15:51:22 +00:00
Danny Tuppeny
f0f4f58728
[analyzer] Use generated names for extracted methods
...
Change-Id: I2aeaac092bc2222d6116c2e7172e73406bfa2260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 18:51:38 +00:00
Danny Tuppeny
65af2a0941
[analyzer] Add ExtractLocalVariable to LSP server
...
Change-Id: I997b9914d0c451e69a914c75da0f313430ba3722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178987
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 18:48:52 +00:00
Danny Tuppeny
e5ed69d04d
[Analyzer] Add support for LSP semanticTokens/range
...
Change-Id: Iebd0a5bfca29b51fe6bb309f71c1ee476d4ed9f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177702
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-06 17:50:11 +00:00
Danny Tuppeny
ee2899ed17
[Analyzer] Update DartUnitHighlightsComputer to allow generating LSP semantic tokens directly
...
This allows additional types/modifiers that cannot be mapped from highlights region (for example where the existing `keyword` region type needs to be mapped into both `keyword` and `keyword.control` to support different colours as the original textmate grammar did.
Change-Id: Ie71b165fa6e4d902c068854cbbba4039ddefe185
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177605
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-06 17:50:11 +00:00
Danny Tuppeny
28523a5e31
[Analyzer] Fix race condition in LSP semantic tokens + re-enable
...
Change-Id: I52c4eb18dd09e3334f21bbf5fac9ce4e716ea234
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-06 17:50:11 +00:00
Danny Tuppeny
0d878d1d97
[Analyzer] Ensure semantic tokens are sorted correctly before handling overlaps
...
Change-Id: I10a236d7c911867c654939d25c02208fa465ea3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176524
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-12-22 18:15:41 +00:00
Danny Tuppeny
3ee3dac08e
[Analyzer] Disable LSP semantic tokens
...
There's a race condition in semantic tokens that's causing errors that I've yet to track down or reproduce in a test (though can relatively easily reproduce manually).
Change-Id: Icf65ec52e0307ed71f10c74ded120076e4fcd90c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176525
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-12-18 20:29:15 +00:00
Danny Tuppeny
5f28cb13f8
[Analyzer] Use "variable" LSP semantic token for field declaration/references
...
Change-Id: I4daef717459cc2d91c642b024f564368576f5512
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-12-17 16:59:33 +00:00
Danny Tuppeny
eb409d97bc
[Analyzer] Fix an issue where LSP semantic tokens may be missing for some "import" keywords
...
Change-Id: Idf5a60b1d41e12d07549865ad6d6bd26ef0ac6e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176446
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-12-16 18:23:07 +00:00
Danny Tuppeny
222f3dcd11
[Analyzer] Prevent two sets of parens being inserted for setState() when LSP's completeFunctionCalls is enabled
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3006 .
Change-Id: Idc1ac2b41208a13a887e0c0ece98a255114fc634
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176242
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-12-15 19:21:31 +00:00
Danny Tuppeny
26cee4e0db
[Analyzer] Produce string highlight tokens for literal string parts of interpolated strings
...
Change-Id: Idadfc90ba34d4a533964b34799585d7254b16830
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176121
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-12-14 20:37:29 +00:00