dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

579 Commits

Author SHA1 Message Date
Devon Carew f16a0a2a4d Use an import prefix in the analysis server tests; this fixes some issues conflicting with the 
'equals' symbol in the 1.4.0 version of package:path.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2518873002 .
 2016-11-20 10:26:27 -08:00
Mohamed Hayibor 5595b9698d Fix typos 'overriden' to 'overridden' and '@mustCall super' to '@mustCallSuper' (#27853) 
* fix overriden typos to overridden
* Fix @mustCall super to @mustCallSuper
 2016-11-18 09:36:25 -08:00
Brian Wilkerson 99ce88f8bc (TBR) Fix more failing tests 
Review URL: https://codereview.chromium.org/2426723002 .
 2016-10-17 12:57:56 -07:00
Konstantin Shcheglov 33ecec5d4f Replace expect() with outOfTestExpect() in Analysis Server performance benchmark. 
In package:test function expect() does not want to be used outside of
test() methods. So, we need a partial copy for using it in integration
tesitng code, and performance benchmarks.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2413573003 .
 2016-10-12 12:57:03 -07:00
Konstantin Shcheglov 05a86a7495 Remove 'initializeTestEnvironment' from 'analysis_server'. 
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2402483002 .
 2016-10-06 10:26:17 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'. 
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
 2016-10-06 08:47:15 -07:00
Brian Wilkerson 685e4ff9e1 Revert "Remove unused option in server API" 
Review URL: https://codereview.chromium.org/2382033003 .
 2016-09-30 10:14:12 -07:00
Brian Wilkerson 2972bd0d6b Remove unused option in server API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2382053002 .
 2016-09-30 09:04:38 -07:00
Konstantin Shcheglov 0223b08a34 Issue 27300. Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE. (Land again) 
The pkg/analysis_server/test/integration/analysis/error_test was fixed.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/27300

Review URL: https://codereview.chromium.org/2366963002 .
 2016-09-23 10:21:21 -07:00
Brian Wilkerson 74686371b3 Add support for getting the sessionId from instrumentation and sending it to the client 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2359233002 .
 2016-09-22 10:26:13 -07:00
William Hesse 92cd3e10f5 Fix test.py and tests to use an explicit --packages flag. 
BUG=https://github.com/dart-lang/sdk/issues/27412
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2361813003 .
 2016-09-22 17:51:09 +02:00
Konstantin Shcheglov f4186fb463 Issue 27244. Add 'isDeprecated' to HoverInformation. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27244

Review URL: https://codereview.chromium.org/2310153002 .
 2016-09-06 11:31:11 -07:00
Devon Carew c3e64df2af Fix an analysis server test. 
BUG=

Review URL: https://codereview.chromium.org/2294163002 .
 2016-08-30 17:58:31 -07:00
Brian Wilkerson 6ccbef94fc Convert analysis server over to use ContextBuilder 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2286923002 .
 2016-08-29 08:11:53 -07:00
Brian Wilkerson 40a310748a Correctly use sdk passed on command-line 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2276033003 .
 2016-08-24 12:38:21 -07:00
Konstantin Shcheglov 0522cad42a Convert to async/await parts that cause strong mode warnings. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2233633003 .
 2016-08-10 10:28:34 -07:00
Brian Wilkerson 38689cd848 Fix errors introduced by recent strong-mode changes 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2233913003 .
 2016-08-10 09:12:49 -07:00
Konstantin Shcheglov 34ae48a6b0 Don't run Analysis Server performance tests in checked mode. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2153163002 .
 2016-07-15 09:05:09 -07:00
Brian Wilkerson f3dc748db5 Add two memory usage benchmarks 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2111743002 .
 2016-06-30 07:44:41 -07:00
pq 270695fc31 Adds PID to server.connected notification (#26744). 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2088663004 .

Fixes: https://github.com/dart-lang/sdk/issues/26744.
 2016-06-21 16:00:27 -07:00
Brian Wilkerson 44836f8538 Support the name analysis_options.yaml for analysis options files 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1975963002 .
 2016-05-13 07:33:06 -07:00
Brian Wilkerson 08241e9072 More strong mode clean-up 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1947813002 .
 2016-05-04 07:42:46 -07:00
Brian Wilkerson 0d743fbacf Start making server strong mode clean 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1842063003 .
 2016-03-31 08:27:05 -07:00
Brian Wilkerson 8c22a5f807 Format code in analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1838933003 .
 2016-03-29 08:27:14 -07:00
Konstantin Shcheglov c0d40223bf Issue 25945. Include static/propagateInvokeType for MethodInvocation names into hover. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25945

Review URL: https://codereview.chromium.org/1814893002 .
 2016-03-17 10:29:10 -07:00
pq e7e205f00b Add error codes to server protocol (#25958). 
See: https://github.com/dart-lang/sdk/issues/25958

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1774913006 .
 2016-03-09 10:44:03 -08:00
Dan Rubel 9fe92127e5 update setAnalysisRoots to accept package spec file 
As part of addressing https://github.com/dartino/atom-dartino/issues/13,
this CL updates the setAnalysisRoots API to allow package spec files
in the packageRoots map.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1711353003 .
 2016-02-19 10:57:16 -05:00
Paul Berry bc551cb308 Beef up analysis server integration test messages. 
When an integration test fails, in can be difficult to figure out why,
especially if the test had to forcibly terminate the analysis server
process.  These messages should help debug the problem.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1669473004 .
 2016-02-04 12:48:21 -08:00
Ivan Posva a3f816e75b - Fix usage of Platform.packageRoot. 
BUG=

Review URL: https://codereview.chromium.org/1533693003 .
 2015-12-17 13:08:19 -08:00
Konstantin Shcheglov 2f0f398c73 Fix lints: unnecessary_brace_in_string_interp 
Also fixes two cases of empty_constructor_bodies.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1521883002 .
 2015-12-13 13:05:00 -08:00
Konstantin Shcheglov 168556a3e4 Tweaks for hover. 
1. Include full signature of classes - extends, with and implements clauses.

2. Provide statis type only for variables - for all other elements the static type is always the same as in the signature.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1513943005 .
 2015-12-11 14:25:46 -08:00
Konstantin Shcheglov 1f5973e24e Explicitly specify that FilePath is not just absolute, but also a normalized path. 
It was implied, and every client I know of uses absolute and normalized paths.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1506323002 .
 2015-12-09 11:30:54 -08:00
pq 2fdcb1bd74 Promote diagnostic.getDiagnostics() (#25061). 
* removes rolling average support
* removes "experimental" tag
* bumps API version

Fixes #25061.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1509033003 .
 2015-12-09 09:29:26 -08:00
Paul Berry 7d3c4743db Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27 2015-12-03 14:22:24 -08:00
Brian Wilkerson b9644af695 Remove the old task model 
Review URL: https://codereview.chromium.org/1490233007 .
 2015-12-03 10:14:06 -08:00
pq 43f027fc05 Analysis request getReachableSources (#24893). 
Implements a new request to get reachable sources.

This solves a specific issue for flutter (e.g., inferring execution type by checking the transitive closure of reachabe sources for `dart:flutter`) but can be more generallly useful for other client-side smarts (e.g., "is this a web entry point?" or "is this a test?").

More context here: https://github.com/dart-lang/sdk/issues/24893

R=brianwilkerson@google.com, devoncarew@google.com

Review URL: https://codereview.chromium.org/1491013002 .
 2015-12-02 13:26:35 -08:00
pq c0466f28f5 Rolling average work queue diagnostic (#24933). 
Background: https://github.com/dart-lang/sdk/issues/24933

Salient bits:

* sampling will only start if a client registers interest in diagnostics.
* sampling will stop if clients stop requesting diagnostics.
* sample results are coming back as a string (but a double would be better).
* the mapping of context folders to averages in not garbage collected; since it's only potentially leaking `_Average` objects (and not contexts) when folders are deleted, I think that's fairly benign.

BUG=24933
R=brianwilkerson@google.com, devoncarew@google.com

Review URL: https://codereview.chromium.org/1463923003 .
 2015-11-20 14:24:47 -08:00
pq 6d9cb5e48a Move diagnostics to diagnostics domain (#24931). 
Still flagged `experimental` so no docs created.

See: https://github.com/dart-lang/sdk/issues/24931

BUG=24931
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1453433002 .
 2015-11-16 14:10:10 -08:00
pq 82e83bb34d Experimental getDiagnostics request (#24480). 
* Adds `getDiagnostics` request with *very* provisional diagnostics payload (primary goal here is to plumb this fully through and iterate).
* Updates codegenerator to skip doc generation for experimental APIs.

Additional context here: https://github.com/dart-lang/sdk/issues/24480.

BUG=24480
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1416093007 .
 2015-11-05 15:05:21 -08:00
Konstantin Shcheglov 069ba985de Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths. 
Unfortunately we have to make coveringExpressionOffsets and coveringExpressionLengths optional.
Otherwise new clients cannot correctly parse responses from old servers.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1407333006 .
 2015-11-03 10:19:41 -08:00
pq c4ccdb462a LineInfo line-end detection fixes. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1413783005 .
 2015-10-27 09:39:30 -07:00
pq 808f32d61d Fix to give LineInfo to options error spans. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1417363007 .
 2015-10-26 21:09:48 -07:00
Konstantin Shcheglov c0d68a5437 DAS specification changes - spelling and ElementKind.FILE addition. 
ElementKind.FILE will be used in search.findElementReferences

1. In the 'element' field of responce when a URI is at the given offset.

2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1409333002 .
 2015-10-17 10:03:03 -07:00
pq 6bce9b2373 One extension manager (to bind them all). 
TL;DR Moves all plugin registration to AE's extension manager.

The rub is that plugin registration wasn't happening right which cropped up in integration testing.  Included is a test that verifies that options are getting properly threaded through to the linter.  (This test failed when we had two Extension Managers.)

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398033004 .
 2015-10-13 16:37:42 -07:00
Paul Berry 9767634564 Fix manual editing of integration_test_methods.dart. 
In commit 9ad256cf18,
integration_test_methods.dart (an auto-generated file) was edited
manually.  The only necessary changes were to imports--the other changes
were the result of sorting declarations and running the formatter.

This CL replicates the necessary changes in the code generator and
re-runs it, un-doing the other changes.  This should fix the test
"pkg/analysis_server/tool/spec/check_all_test".

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1397353002 .
 2015-10-12 06:49:02 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
Brian Wilkerson a296d57a5c Comment out debugging code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1398503004 .
 2015-10-09 08:09:53 -07:00
Brian Wilkerson 190cc1ae82 Remove an unused test 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1396983004 .
 2015-10-09 08:09:04 -07:00
Paul Berry b76da2d61e Turn on the new task model by default in analysis server. 
The previous option for enabling the task
model ("--enable-new-task-model") is replaced with an option for
disabling it ("--disable-new-task-model").

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1390843002 .
 2015-10-06 13:49:52 -07:00
danrubel d14a963546 only send final completion notification 
This shaves 1 ms off the average completion notification response time

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1389473002 .
 2015-10-06 14:21:29 -04:00