Commit Graph

26 Commits

Author SHA1 Message Date
Brian Wilkerson 30d27c6f61 Migrate all remaining server libraries except the library in bin
Change-Id: I2041763971a85fb8e9530b64ef30d106091c9739
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196547
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2021-04-24 04:19:22 +00:00
Konstantin Shcheglov e97f1bdbf0 Switch analysis_server to language 2.12, so null safety, but opt-out files.
This should allow doing partial migration, specifically protocol files,
which are imported by other libraries, but are a small library cycle
that does not import much outside of it.

Change-Id: I904c05d6d5b444ee9a9dbd1f7ada12aabdcc5165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-03-30 23:39:37 +00:00
Brian Wilkerson 8efdee06d6 Begin adding return types in analysis_server
Change-Id: Id0daa52236bdc90cba6bfd7cf81d1b4cf47603c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133544
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-01-28 21:18:30 +00:00
Brian Wilkerson 3019a8873a Check for completeness of test_all in analysis server and analyzer plugin
Change-Id: Ia25b1f93d5f2f3942f0c76d74556228a41410182
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97352
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-03-21 13:24:03 +00:00
pq ccf756dae5 Integration testing to ensure server lint name representations are correct.
If lint names do not match, associated fixes are never shown.

See https://dart-review.googlesource.com/c/sdk/+/95743 for the kind of bug this should guard against.


Change-Id: I27b33c56b9f9242497a03972129806863d2287a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-03-07 21:01:06 +00:00
Brian Wilkerson 47e988b781 Clean up the remaining copyright notices in analysis_server
Change-Id: Iee3110f92ab0f24312ddd1eff407d2229f895321
Reviewed-on: https://dart-review.googlesource.com/c/89101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-01-11 15:38:56 +00:00
Brian Wilkerson 37042bb59b Add an integration test for kythe support with bug fixes
R=jwren@google.com

Review-Url: https://codereview.chromium.org/3006693002 .
2017-08-28 10:07:04 -07:00
Brian Wilkerson e8a5e404c3 Move LocalDeclarationVisitor for use by contributors that will be moved to analyzer_plugin
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2918343002 .
2017-06-05 10:24:54 -07:00
Devon Carew 511963d715 Add an analytics domain to the analysis server.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2922603002 .
2017-06-02 14:38:53 -07:00
Brian Wilkerson 7d26ff6d4f Remove some more library directives
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884233004 .
2017-05-17 08:02:08 -07:00
Devon Carew b1bc83b6d2 Add an integration test for edit.format.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2695253002 .
2017-02-15 07:23:21 -08:00
Devon Carew 90bd4652aa Add an integration test for diagnostics.getDiagnostics.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2697833005 .
2017-02-14 14:36:38 -08:00
Devon Carew bc9cadac04 Add tests to vaildate the analysis server's integration test coverage.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2685883005 .
2017-02-09 14:26:26 -08:00
Brian Wilkerson a69189972c Add failing test
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2683793003 .
2017-02-08 08:13:37 -08:00
Konstantin Shcheglov 05a86a7495 Remove 'initializeTestEnvironment' from 'analysis_server'.
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2402483002 .
2016-10-06 10:26:17 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'.
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
2016-10-06 08:47:15 -07:00
Brian Wilkerson 190cc1ae82 Remove an unused test
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1396983004 .
2015-10-09 08:09:04 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
2015-08-05 08:13:28 -07:00
paulberry@google.com 7225ac4794 Enable asynchrony test.
This test passes now that dartbug.com/21252 has been fixed.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//700723006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41579 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 19:39:20 +00:00
paulberry@google.com 7611c5415a Add an integration test to verify that server I/O is asynchronous.
Currently disabled, since server I/O is currently synchronous.

BUG=dartbug.com/21252
R=danrubel@google.com

Review URL: https://codereview.chromium.org//668953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41246 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-22 15:48:06 +00:00
paulberry@google.com 19a44a67a6 Split up server_domain_int_test.dart; regularize integration test directories.
With this change, there is a separate subfolder in "test/integration"
for each domain, and each subfolder has its own "test_all.dart".

This change is almost entirely code motion.  The only material change
is that two tests have been dropped:

- test_connected(): this test is now unnecessary since every time the
  "server.connected" message is received, the generated code in
  integration_test_methods.dart verifies that it is well-formed.

- test_error(): this was a placeholder to remind us to test the
  "server.error" notification.  On further reflection, it's unlikely
  that we'll be able to integration test this notification, since it
  only occurs in the event of a server bug.

R=jwren@google.com

Review URL: https://codereview.chromium.org//458453003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39112 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 22:25:26 +00:00
paulberry@google.com 931b0afaa6 Split analysis_domain_int_test.dart into several test files.
This test was timing out on the debug build bots because it had 6
sub-tests, each of which started a separate instance of the analysis
server.  Split it out to one test per file.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//465513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39095 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 17:39:10 +00:00
paulberry@google.com df750aef30 Fix analysis server integration/test_all.dart.
This was accidentally broken when the integration test files were
renamed in r38661.

Also, remove a stray call to debugStdio() that was accidentally left
in the analysis domain integration tests.

R=danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//422343005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38687 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 18:09:31 +00:00
paulberry@google.com b598db2dcc Start writing analysis server integration test for 'completion.getSuggestions'.
The test is currently incomplete (and hence disabled) due to
dartbug.com/20188.

R=jwren@google.com

Review URL: https://codereview.chromium.org//412323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38559 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-24 22:08:10 +00:00
paulberry@google.com b660abdcc6 Three new analysis server integration tests
1. server.setSubscriptions (invalid service)
2. analysis.getHover (normal operation)
3. analysis.getHover (no hover information available)

Test 3 is disabled because it currently fails due to an analysis
server bug.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//405473006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38364 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-18 02:20:53 +00:00
paulberry@google.com 045aa3e5bd More integration tests for analysis server.
This covers everything in the "server" domain except for server.error
(which is difficult to test since it should only occur in the event of
a server bug).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//396383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38319 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-16 23:46:36 +00:00