Commit Graph

149 Commits

Author SHA1 Message Date
Brian Wilkerson 99ce88f8bc (TBR) Fix more failing tests
Review URL: https://codereview.chromium.org/2426723002 .
2016-10-17 12:57:56 -07:00
Konstantin Shcheglov 05a86a7495 Remove 'initializeTestEnvironment' from 'analysis_server'.
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2402483002 .
2016-10-06 10:26:17 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'.
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
2016-10-06 08:47:15 -07:00
Konstantin Shcheglov 0223b08a34 Issue 27300. Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE. (Land again)
The pkg/analysis_server/test/integration/analysis/error_test was fixed.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/27300

Review URL: https://codereview.chromium.org/2366963002 .
2016-09-23 10:21:21 -07:00
Brian Wilkerson 6ccbef94fc Convert analysis server over to use ContextBuilder
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2286923002 .
2016-08-29 08:11:53 -07:00
Brian Wilkerson 40a310748a Correctly use sdk passed on command-line
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2276033003 .
2016-08-24 12:38:21 -07:00
Konstantin Shcheglov 34ae48a6b0 Don't run Analysis Server performance tests in checked mode.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2153163002 .
2016-07-15 09:05:09 -07:00
Brian Wilkerson f3dc748db5 Add two memory usage benchmarks
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2111743002 .
2016-06-30 07:44:41 -07:00
Brian Wilkerson 44836f8538 Support the name analysis_options.yaml for analysis options files
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1975963002 .
2016-05-13 07:33:06 -07:00
Brian Wilkerson 8c22a5f807 Format code in analysis_server
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1838933003 .
2016-03-29 08:27:14 -07:00
Konstantin Shcheglov c0d40223bf Issue 25945. Include static/propagateInvokeType for MethodInvocation names into hover.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25945

Review URL: https://codereview.chromium.org/1814893002 .
2016-03-17 10:29:10 -07:00
Konstantin Shcheglov 168556a3e4 Tweaks for hover.
1. Include full signature of classes - extends, with and implements clauses.

2. Provide statis type only for variables - for all other elements the static type is always the same as in the signature.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1513943005 .
2015-12-11 14:25:46 -08:00
pq c4ccdb462a LineInfo line-end detection fixes.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1413783005 .
2015-10-27 09:39:30 -07:00
pq 808f32d61d Fix to give LineInfo to options error spans.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1417363007 .
2015-10-26 21:09:48 -07:00
pq 6bce9b2373 One extension manager (to bind them all).
TL;DR Moves all plugin registration to AE's extension manager.

The rub is that plugin registration wasn't happening right which cropped up in integration testing.  Included is a test that verifies that options are getting properly threaded through to the linter.  (This test failed when we had two Extension Managers.)

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398033004 .
2015-10-13 16:37:42 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
Paul Berry 03a156c891 Plumb "enableSuperMixins" option through analysis server (implements DEP 34).
Partially addresses #23772.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1301533003 .
2015-08-20 09:47:26 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
2015-08-05 08:13:28 -07:00
Konstantin Shcheglov d5d0017e21 Tweak for navigation for URIs.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1246833002 .
2015-07-20 15:07:00 -07:00
Konstantin Shcheglov 55cb93b422 Add '--useAnalysisHighlight2' option to generate version 2 of semantic highlight.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1241193002 .
2015-07-20 10:37:46 -07:00
Brian Wilkerson 10b7db100f Revert "Update Analysis Server highlight API and implementation."
This reverts commit 739847402b.

Rolling the wire protocol API version forward caused existing clients to break, so we're rolling it back until we can find a backward compatible way of adding the new functionality.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1236433003 .
2015-07-13 09:49:55 -07:00
Konstantin Shcheglov 739847402b Update Analysis Server highlight API and implementation.
I think this is a good enough compromise between the existing and IDEA granilarity.

Eclipse plugin CL will follow.

(IN)VALID_STRING_ESCAPE are not implemented yet.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1227143003 .
2015-07-09 11:19:44 -07:00
Konstantin Shcheglov 7e194d8fb5 Change navigation regions generation for constructors.
In IDEA we use navigation regions for resolution.
And so far all navigation regions are for separate identifiers.
This CL splits single regions like "new A.named()" into separate "A" and "named" regions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1218183007.
2015-07-06 11:27:19 -07:00
scheglov@google.com 9efb25fa50 Use package:test_reflective_loader instead of reflective_tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1101003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45365 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:54:29 +00:00
scheglov@google.com f11ca733d4 Fix 'getHover' integration test.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1054063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44862 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-02 17:16:44 +00:00
brianwilkerson@google.com cd58e290c4 Reformat
R=paulberry@google.com

Review URL: https://codereview.chromium.org//969113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 22:43:12 +00:00
scheglov@google.com a38a503d86 Replace @ReflectiveTestCase() with @reflectiveTest.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//849863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:11:24 +00:00
scheglov@google.com 8affb6c015 Upgrade unittest to be able to use isNotEmpty.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//790363006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42380 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 04:07:37 +00:00
scheglov@google.com 20d82e5135 Compressed/optimized navigation notification.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//766323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42049 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-01 22:21:28 +00:00
paulberry@google.com 651d589c2f Remove flaky check from reanalyze_concurrent_test.
This should avoid sporadic false failures with this test.  If in the
future we genuinely regress bug 21448, there is a danger that this
test won't catch it reliably, but that is mitigated by the fact that
(a) even flaky failures do get noticed, and (b) the bug was severe
enough that it probably would be noticed in manual testing.  The extra
risk seems worth it to avoid the sporadic false failures we've been
seeing.

BUG=dartbug.com/21638
R=scheglov@google.com

Review URL: https://codereview.chromium.org//724403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41870 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 22:52:30 +00:00
scheglov@google.com b8da9bc651 Format and sort analyzer and analysis_server packages.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//725143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 22:23:53 +00:00
paulberry@google.com e36820617a Fix integration test to avoid new 'Unused local variable' hint.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//700323004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41580 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 19:49:40 +00:00
paulberry@google.com 02dada3dec Avoid analysis server crash when reanalyze invoked during analysis.
BUG=dartbug.com/21448
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//678413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41372 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:15:59 +00:00
paulberry@google.com 7014ca0b76 Rename package_root.dart test to package_root_test.dart
So that the test will be run on the buildbots.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//685843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41370 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:10:17 +00:00
paulberry@google.com 0251bcdcf6 Add package root support to analysis server.
Not yet hooked up in Dart editor.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//679763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41292 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 20:29:24 +00:00
paulberry@google.com 1f50bf550a Remove special list behavior in analysis server protocol.
Previously, for optional lists, the absence of a list was treated by
the toJson and fromJson methods as equivalent to the presence of an
empty list.  This disagreed with the API documentation in several
places and created the risk of null reference exceptions in clients.

This change makes optional lists behave just like optional fields of
any other type.

BUG=dartbug.com/21230
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//625413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40939 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-06 16:32:14 +00:00
paulberry@google.com b4af87636b Change integration test notifications to use structured objects.
This allows us to use completions when writing code to handle server
notifications in integration tests.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//631553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40916 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-06 01:04:51 +00:00
paulberry@google.com 1363c77a02 Change integration test send...() methods to return structured objects.
This allows us to use completions when analyzing responses from the
server in integration tests.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//628783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40909 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-04 17:37:47 +00:00
paulberry@google.com a5e47c8eb2 Change integration test send...() methods to use structured objects.
This is less error prone than using raw JSON, and requires less effort
when writing integration tests.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//621383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40904 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-03 18:52:47 +00:00
paulberry@google.com bad1890ab3 Implement "analysis.reanalyze" in analysis server.
This is accomplished by instructing the context manager to remove all
contexts and recreate them from scratch.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//553193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40106 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 19:20:09 +00:00
paulberry@google.com 8d8ee25cff Merge analysis_testing package into analysis_server.
Note that analysis_server already contains a file test/mocks.dart, so
the mocks.dart file from analysis_testing has been imported as
test/mocks2.dart.  I will merge these two into a single file in a
future CL.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//533243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39814 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 18:11:42 +00:00
scheglov@google.com b7189ea678 New analyzer snapshot.
We compute the parameter element for 'object.field = 42' now, so:
1. We can stop doing it in InlineMethodRefactoring.
2. We need to update the corresponding hover integration test.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//535543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39772 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 20:10:47 +00:00
paulberry@google.com 4ab9bde919 Add an integration test for analysis.overrides.
Also remove the note from the API documentation saying that
analysis.overrides only works for overrides of a superclass.
Interface overrides work too.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//476163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39302 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 16:56:45 +00:00
paulberry@google.com fce2ad90a8 Add an integration test for analysis.outline.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//472933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39282 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 03:03:24 +00:00
paulberry@google.com 7e83cc7363 Add an integration test for analysis.occurrences.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//475903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39269 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 21:38:47 +00:00
paulberry@google.com c38a23704c Write an integration test for analysis.navigation notification.
Also, add the missing ElementKind "PARAMETER", and sort the
ElementKinds.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//468233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39267 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 21:06:50 +00:00
paulberry@google.com f822f41189 Update analysis server and integration tests to match new ChangeContentOverlay.
The spec was changed in r39199 so that ChangeContentOverlay contains a
list of edits rather than a single edit.  This updates the analysis
server and integration tests accordingly.

BUG=dartbug.com/20495
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//472613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39218 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 20:04:55 +00:00
paulberry@google.com 153e73e155 Add an integration test for analysis.highlights.
Also fix sort order in the API definition of HighlightRegionType.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//463643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39152 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 18:16:37 +00:00
paulberry@google.com 931b0afaa6 Split analysis_domain_int_test.dart into several test files.
This test was timing out on the debug build bots because it had 6
sub-tests, each of which started a separate instance of the analysis
server.  Split it out to one test per file.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//465513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39095 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 17:39:10 +00:00