02d50e7ebf
Migrate several test classes
...
Change-Id: I7477d5c42a8c2f953c51aca7ab6fff8b6fc930f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-19 00:38:19 +00:00
e97f1bdbf0
Switch analysis_server to language 2.12, so null safety, but opt-out files.
...
This should allow doing partial migration, specifically protocol files,
which are imported by other libraries, but are a small library cycle
that does not import much outside of it.
Change-Id: I904c05d6d5b444ee9a9dbd1f7ada12aabdcc5165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-30 23:39:37 +00:00
c38742cdbc
Migration: remove references from analysis_server to nnbd_migration.
...
Change-Id: I90b562b8b3e82b770f197d7ef2c4e10ac9f99100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148160
Reviewed-by: Janice Collins <jcollins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-05-15 16:49:32 +00:00
82e4a4465b
Migrator: change sdk constraints to >=2.9.0 <2.10.0
...
Bug: #38347
Change-Id: Iedb9acfe313a14d4c35f3637f3ef0104e836dd4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145260
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-04-29 17:47:44 +00:00
299c852b60
Migration: make an API for shutting down the preview server.
...
This will make it easier to write automated tests of the preview
server.
Change-Id: I4605beaa9ce3a8f43ec358568a53f24b4f05dece
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144801
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-04-24 22:53:17 +00:00
4f2e21b351
migrator: Update pubspec.yaml, not analysis_options.yaml
...
Fixes #38347
Change-Id: I201a02ad467401e8277631947dcdf3a19f74ddb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143440
Reviewed-by: Janice Collins <jcollins@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-04-16 17:35:34 +00:00
8969b1839c
Enable omit_local_variable_types in analysis_server
...
Change-Id: I7e5c13d40fd276854601681fc84be321e6031b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-30 03:58:44 +00:00
34fee361b6
Add sanity checks for NNBD state in migration.
...
Also adds some ability for the migration tool to abort itself on
a few known-fatal errors and armor-plates dartdev tests against
CWD problems.
Bug: https://github.com/dart-lang/sdk/issues/40329
Change-Id: I1cfa2c9dcc7815eed075ecb38c63a74c75889002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139282
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Janice Collins <jcollins@google.com >
2020-03-16 18:27:58 +00:00
58a9c22f80
Add return types to more methods in analysis_server
...
Change-Id: I65bed353bcff4f991faf8c3bdde979789a8d962b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-30 21:43:34 +00:00
61199914d7
Convert dartfix to use underscores rather than hyphens for fix names
...
Change-Id: I0bd264e8c0e196aa7a5a8cb46fc940242a844f07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133406
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-26 22:56:36 +00:00
d29c5c174c
Refactor dartfix to make the handling of lint fixes uniform
...
Change-Id: Ib329ec89bf19fa0c7d76b7f9ccdd796e20f71a9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133404
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-25 23:09:55 +00:00
c9b56d3530
Remove support for default fixes from dartfix
...
Change-Id: I497f48ee0930829adf44a510101181578a4a9c86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133242
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-24 18:33:05 +00:00
4a639e8df2
Add support to dartfix for the remaining pedantic lints (for which a fix is already implemented)
...
Change-Id: I6d7b0df1ce4fc7377697d4c66b78f2fb0e95b5c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129362
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-12-21 22:31:49 +00:00
efe76bd5c5
Add support to dartfix for prefer_single_quotes
...
Change-Id: Ifeb2ecdfcd391f22d90ee9ede5660d11ffb61804
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128986
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-19 01:59:49 +00:00
4043a6fce3
Remove unnecessary uses of new in analysis_server
...
Other than analysis_options.yaml, all of the changes were from running
dartfix.
Change-Id: I92411642f12a00fc6bd0bfd24dd60fe67f0fed16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-18 19:01:51 +00:00
2eba06d26f
Stop using preview-dir and preview-port values and always open the preview tool
...
Change-Id: I1ae6aeeb95b1a976c23fe23867a6bec9b453806e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128463
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-16 23:28:35 +00:00
bae7255c83
Add support to dartfix to fix unnecessary new and const lints
...
Change-Id: I8345ea6afd5aa43bda4855b24d101c04b177ae80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128522
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-16 15:33:11 +00:00
2c7c3a60e7
NNBD preview: Rip out static preview; only server preview
...
This involved replacing PathMapper with the wrapper, PreviewPathMapper,
and MigrationInfo, with the wrapper, PreviewMigrationInfo.
Change-Id: Ie590c298bfa8c64c4765748b42ce3c9dc0dec3d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128107
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-12-12 01:48:23 +00:00
0019bf646b
[migration] handle side casts, assume non-null with const guard.
...
Fixes the only exception package:typed_data!
Change-Id: I130fe63d7e31019ad38a30a681505e88822af443
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126087
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-11-25 21:28:55 +00:00
c3053f0eb2
[nnbd_migration] Restrict downcasts; make all type parameters nullable.
...
This makes trial_migration.dart report two new exceptions:
_EdgeBuilder&GeneralizingAstVisitor&_AssignmentChecker._checkAssignment (package:nnbd_migration/src/edge_builder.dart:2169:14) (x30)
_EdgeBuilder&GeneralizingAstVisitor&_AssignmentChecker._checkDowncast (package:nnbd_migration/src/edge_builder.dart:2351:14) (x7)
30 & 7 is not great but not terrible. These also do not break path, logging, or
charcode.
Failing tests show why we cannot correctly cover remaining cases without
a larger CL.
Change-Id: I6e510db147f60cc8ee047d45e4ce2d95d26cccc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119533
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-10-04 18:31:48 +00:00
40cc975932
Increase the severity of the unused_import hint (to a warning).
...
Change-Id: Ie65eb7e9c0f48c54a1c537e821c88a5ea8451266
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-09-27 02:10:22 +00:00
661816ea06
Use Context.separator in nnbd i13n output; Fixes #38574
...
Change-Id: If125bc6d8bc9ae66d949c712921b6ce7da428f6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118890
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-09-26 17:24:12 +00:00
c49d3c3486
Use a root directory for NNBD i13n output.
...
Change-Id: I4ad9d59136010240d56043609ef37edf44ebc4be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118880
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-26 02:46:22 +00:00
034c529cd1
Ignore failing test on Windows.
...
Change-Id: I39cdef152e58666f90970097826cd089ca37c5b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118903
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Auto-Submit: Samuel Rawlins <srawlins@google.com >
2019-09-25 23:54:12 +00:00
771ee9f9ba
Pass the output directory to dartfix and install a listener when output should be generated
...
Change-Id: Ie73287f212246493a6f95aa39f56bf60c0b23f4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117769
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-18 20:03:00 +00:00
8b2993568e
implement dartfix --pedantic
...
This CL adds a new --pedantic option to dartfix for applying all fixes
marked as pedantic. In addition, this addresses comments in
https://dart-review.googlesource.com/c/sdk/+/111840
Change-Id: Ia2e7a792911f19edb698c126c8fd77cd8f8f77cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-08-05 20:18:05 +00:00
fc5b4e3cef
Rework dartfix lint fixes to remove race condition
...
This refactors the way that dartfix finds lints to fix to be based on
error codes rather than manually running the lints. This prevents
a race condition that occurs between calling setAnalysisRoots and
requesting fixes.
Fix https://github.com/dart-lang/sdk/issues/37558
Change-Id: I35817a9b152a28db9e78662a5ea5096f275f68bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-08-02 02:04:57 +00:00
3f22f1f5df
do not include double-to-int fix by default
...
This changes the default fixes applied by dartfix so that it no longer
converts doubles to ints by default. The fix can still be applied
by specifying '--fix double-to-int' on the command line.
Change-Id: I751a42a9c6ae6589259e0b7ac5c769fd4efc4313
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-07-30 18:05:50 +00:00
8dc24d0919
report dartfix error for unknown fix
...
Change-Id: I0ebc73423d46ad5c07f4755847fe2ec68020428f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-30 18:05:50 +00:00
8027d9cba4
support error code based lint fixes in dartfix
...
Lints that have associated fixes (as opposed to assists)
can now be added relatively easily to dartfix as a new fix.
* rename BasicFixLintTask to BasicFixLintAssistTask
* new BasicFixLintErrorTask class
Change-Id: I73f591e627c10ceeb076622bfc6c3bb9a5a3c022
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-07-10 16:39:22 +00:00
8bb8a29f8b
refactor dartfix lint fixes
...
This replaces several very similar lint fixes with a single BasicFixLintTask
thereby making it easier to add new fixes for existing lints.
In addition, the dartfix test names have been normalized
to match the corresponding DartFix info and additional tests added.
Change-Id: Ia3d1e0ffcb14d34e0af5d49650888eb2c49a9b42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-07-09 21:42:55 +00:00
17f5d2d757
Add assists to inline add and addAll
...
Change-Id: Ie085fd10ffe533fae8a0c5f6325d081a118adc39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99040
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-10 20:40:33 +00:00
cc63d6e647
dart fix support for control_flow_collection fixes
...
Change-Id: I1cd2dccfcc5b5687934e98ea704184c4bb6a50a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98866
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-04-08 21:48:29 +00:00
cf04a16527
dartfix to migrate to spread collections
...
Change-Id: I7764f29e159356cc589f4e66b80eefff6cc998f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98742
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-04-05 22:27:58 +00:00
afe609d2c2
Update NNBD migration to add import as necessary
...
... and simplify apply code edits
Change-Id: I6f205df29ffd42341e2244ff3a5609ba005adcfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98612
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-04 20:31:23 +00:00
0669c2cee5
fix dartfix modification of analysis options
...
... and improve NNBD YamlException error message
Address comments in https://dart-review.googlesource.com/c/sdk/+/98524
Change-Id: I0e44ca8b887b47f1fac247650402032d1e5f5b23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-03 19:34:01 +00:00
ff99692175
dartfix update analysis options to enable NNBD
...
This updates the analysis server edit.dartfix functionality
to enable NNBD by modifying the analysis options file,
creating that file if necessary.
Change-Id: I831182e49e585ef0d851d4eb715885e90954bcad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98429
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-02 15:29:59 +00:00
21b596e1b1
Change NullabilityFixKind from enum to class
...
... so that it can carry additional information
such as an applied message for use by dartfix.
Change-Id: Ic98f4000590c9bf21be45c5a5139946afeeb196c
Reviewed-on: https://dart-review.googlesource.com/c/92302
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-02-07 20:47:37 +00:00
9f0301630f
Update dartfix NNBD to use 2-pass analysis
...
Change-Id: Icc7c1b29c6abeed968372c3a7442fdcecda0e572
Reviewed-on: https://dart-review.googlesource.com/c/92152
Reviewed-by: Paul Berry <paulberry@google.com >
2019-02-07 20:47:37 +00:00
ba9fbda83e
Rework provisional migration API.
...
Instead of returning a list of SourceFileEdit objects, we now return a
list of SingleNullabilityFix objects. Each SingleNullabilityFix can
be queried to determine (a) which source file it applies to, (b) the
exact set of source edits to apply, and (c) the kind of change.
Future CLs will add the ability to query (d) the location of the
change, and (e) the reason for the change.
Change-Id: I5a42958ac70d1e39802efd5915d0856109b4a7db
Reviewed-on: https://dart-review.googlesource.com/c/92151
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-06 23:20:41 +00:00
caa8747a37
Rework dartfix NNBD fix to use new NullabilityMigration engine
...
... add address comment in https://dart-review.googlesource.com/c/sdk/+/92082
Change-Id: Id9b400522e8c9af3d04ca5524174a61a8045d9d7
Reviewed-on: https://dart-review.googlesource.com/c/92141
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-02-06 19:49:35 +00:00
512e2ef292
Extract FixCodeTask/Processor from main dartfix class
...
Change-Id: Ieb8c52c1908521f77c6a5a13809fbe5636ee5b5a
Reviewed-on: https://dart-review.googlesource.com/c/92082
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-02-06 16:45:05 +00:00
5ae156e055
Extract DartFixListener to record source changes and recommendations
...
... and add DartFixRegistrar in preparation for extracting tasks
from the main dartfix class.
Change-Id: I6423a474fc5d94d766d9b219fb31a4263db28d1b
Reviewed-on: https://dart-review.googlesource.com/c/92064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-02-06 16:44:45 +00:00
db9e3f21c9
remove InconsistentAnalysisException guard code from dartfix
...
This updates the dartfix tests to align with how the dartfix API
is implemented and is being used, and removes the now unnecessary
InconsistentAnalysisException guard code.
Change-Id: Id7230ecec4940097fd0f2d3c034f47262ddc94b5
Reviewed-on: https://dart-review.googlesource.com/c/91962
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-02-05 19:01:55 +00:00
1c173c2ce7
Enhance dartfix to allow including and excluding specific fixes
...
This add several options to the dartfix command line
so that only specific fixes can be applied rather than all fixes.
Fix https://github.com/dart-lang/sdk/issues/35539
Change-Id: I8bb89696b0b47a291ed22aa00d4787f3ea5aa4be
Reviewed-on: https://dart-review.googlesource.com/c/91780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-02-01 16:55:17 +00:00
23b5aee978
Update dartfix NNBD to handle more situations
...
This CL updates the dartfix NNBD implementation to skip types
in extends, implements, on, and with clauses
in addition to addressing comments in
https://dart-review.googlesource.com/c/sdk/+/89046
Change-Id: Ifa491ac3ffd2b2ef24b1e649c1355df65adefc13
Reviewed-on: https://dart-review.googlesource.com/c/89403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-01-15 15:52:54 +00:00
3f90e88288
first cut adding simple non-nullable migration to dartfix
...
... and address comments in https://dart-review.googlesource.com/c/sdk/+/88640
Change-Id: I26e0f70f7c112d9ac184e10475e519afd8118a1d
Reviewed-on: https://dart-review.googlesource.com/c/89046
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-01-11 01:59:59 +00:00
a84863253c
Re-apply "Add AnalysisDriver.resetUriResolution() and use it for analysis.reanalyze request."
...
Original change's description:
> Add AnalysisDriver.resetUriResolution() and use it for analysis.reanalyze request.
>
> This CL changes "analysis.reanalyze" API. We decided to repurpose it. It was not
> used for some time now in IntelliJ, and AFAIK has never been used in VS Code.
>
> R=brianwilkerson@google.com , paulberry@google.com
>
> Change-Id: I7510b0189197c9f3f848b0fc59a7b2bd22889ac7
> Reviewed-on: https://dart-review.googlesource.com/c/85523
> Reviewed-by: Paul Berry <paulberry@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Change-Id: I828c9a77f1e28d44c00bfcf39527514e39cccc42
Reviewed-on: https://dart-review.googlesource.com/c/86221
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-12-06 23:14:28 +00:00
bc0df05d07
Update dartfix test on windows
...
... and add unit source null check
Change-Id: Id366a45f73a78486d02b5c8527e1d732a6cf28d4
Reviewed-on: https://dart-review.googlesource.com/c/86360
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-12-06 14:17:48 +00:00
41389f4c5b
Add dartfix part file tests
...
... and address comments in https://dart-review.googlesource.com/c/sdk/+/86261
Change-Id: I3a22fe3a064a83b2dfe57de37a4aab22e6c6d67d
Reviewed-on: https://dart-review.googlesource.com/c/86265
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-12-05 22:55:06 +00:00
Brian Wilkerson