dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

99 Commits

Author SHA1 Message Date
Dan Rubel 824a012d8f do not suggest static methods from superclass - fixes #24258 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1509723004 .
 2015-12-09 14:37:03 -05:00
danrubel 372cb6be58 fix combinator contributor 
gracefully degrade given partially element information
better reporting of exceptions during testing

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1506623002 .
 2015-12-06 15:34:19 -05:00
danrubel 53f777162e (TBR) get completion tests passing 
Review URL: https://codereview.chromium.org/1505443002 .
 2015-12-04 20:55:09 -05:00
danrubel 85334bed8a (TBR) update completion test to expect pass now that this is fixed #23001 
Review URL: https://codereview.chromium.org/1465143003 .
 2015-11-23 11:15:22 -05:00
Dan Rubel d329551747 (TBR) fix completion test - see #24511 
Review URL: https://codereview.chromium.org/1384823005 .
 2015-10-06 14:40:27 -04:00
Brian Wilkerson 42d1d4532d Reformat code to minimize churn 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1310263003 .
 2015-09-09 08:19:18 -07:00
Dan Rubel bd95b13b90 improve keyword suggestions - fixes #24016 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1303233008 .
 2015-08-26 17:34:57 -04:00
danrubel 3bbf03ba7b suggest "in" in for statement 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1285573003 .
 2015-08-10 10:43:27 -04:00
danrubel f79d02ddd0 remove complex keyword suggestions - fixes #23978 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1280313002 .
 2015-08-10 10:09:18 -04:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
danrubel f3a1297576 fix tests 
BUG=

Review URL: https://codereview.chromium.org//1191363003.
 2015-06-20 18:20:46 -04:00
danrubel 0e39092fd0 add enum suggestions 
and update LocalDeclarationVisitor to visit enum declarations

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1157113004
 2015-06-01 12:10:46 -04:00
danrubel@google.com b05fb8ba98 suggest only superclass elements for "super." 
BUG=dartbug.com/23208
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1127643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45535 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-05 19:09:51 +00:00
danrubel@google.com 6368514b6d improve import suggestion 
BUG=dartbug.com/19941
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1113063005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45497 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-04 18:02:23 +00:00
danrubel@google.com 85e1841e35 suggest keywords for switch statement and expressions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1118113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45463 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-01 01:35:35 +00:00
danrubel@google.com 6237c8909f add dart: and package: import uri suggestions 
BUG=dartbug.com/23073
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1100393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45398 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 12:51:52 +00:00
danrubel@google.com 25c6bbaa14 suggest types in var declaration when partial type name supplied 
BUG=dartbug.com/23225
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1097973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45287 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-20 15:29:28 +00:00
danrubel@google.com 9f492ecbe6 fix keyword completion in class body 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1057403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44894 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 22:12:56 +00:00
danrubel@google.com 4e903a637e do not suggest completions for empty dot target 
BUG=dartbug.com/23095
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1056163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44887 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 20:38:50 +00:00
danrubel@google.com 8bf9e95e6e replace request.node with request.target 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1054363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44886 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 20:34:20 +00:00
danrubel@google.com caff47a011 add type completions after "on" in a try block 
BUG=dartbug.com/23028
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1053663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44839 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-01 19:29:57 +00:00
danrubel@google.com 676e027663 remove duplicate completion suggestions 
BUG=dartbug.com/22684
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1001143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44444 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-12 21:40:55 +00:00
danrubel@google.com e867811d28 include constructor arguments in completion suggestions 
BUG=dartbug.com/22364
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1006593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44438 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-12 18:46:06 +00:00
danrubel@google.com 7c9de023c2 include library prefix suggestions when suggesting constructors 
BUG=dartbug.com/22158
R=scheglov@google.com

Review URL: https://codereview.chromium.org//972193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44179 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-03 16:51:18 +00:00
danrubel@google.com 7e9557cb39 add arguments to constructor completions 
BUG=dartbug.com/22158
R=scheglov@google.com

Review URL: https://codereview.chromium.org//972933002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44174 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-03 15:58:50 +00:00
brianwilkerson@google.com cd58e290c4 Reformat 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//969113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-02 22:43:12 +00:00
danrubel@google.com 5194a2b1b4 filter static methods when showing instance completions 
BUG=dartbug.com/22171
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43580 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-07 00:56:15 +00:00
danrubel@google.com dc95fd3689 use propogated type for completions 
BUG=dartbug.com/21457
R=scheglov@google.com

Review URL: https://codereview.chromium.org//902983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43539 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 04:43:15 +00:00
danrubel@google.com b9f3559e03 (TBR) fix failing test 
BUG=

Review URL: https://codereview.chromium.org//881413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43258 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-28 20:39:36 +00:00
paulberry@google.com 6d7155de63 Introduce CompletionTarget to take the place of the Node being completed. 
Instead of locating the node containing the cursor offset using a
NodeLocator, identify the edge in the parse tree which will be
displaced or modified by the completion proposal.  This reduces the
number of cases that need to be handled in the _OpTypeAstVisitor, and
avoids the need for the _OpTypeAstVisitor to consider character
offsets in nearly all cases.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//820773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42543 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-20 15:47:25 +00:00
paulberry@google.com dfb35c0ea6 Add methods to mock SDK that are referenced by completion tests. 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//810063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42512 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-19 17:02:18 +00:00
paulberry@google.com 523dac8d75 Print a count of total tests and expected failures in completion tests. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//806413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42441 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-17 16:52:25 +00:00
paulberry@google.com 879984875b Add filtering to completion tests. 
This allows the negative completion tests to be run.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//798173004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42432 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-17 14:42:29 +00:00
danrubel@google.com ddc3cae8bd refactor duplicate code into single visitor 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//804323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42398 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-16 16:53:24 +00:00
danrubel@google.com 438aa447d4 refine when suggestions are limited to types 
BUG=dartbug.com/18860
R=paulberry@google.com

Review URL: https://codereview.chromium.org//802233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42366 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-15 17:48:00 +00:00
danrubel@google.com cd4ec28541 fix named constructor completion 
BUG=dartbug.com/21799
R=paulberry@google.com

Review URL: https://codereview.chromium.org//803913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42365 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-15 17:16:40 +00:00
danrubel@google.com 5599bc3a5b fix invocation completion test 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//805683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42364 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-15 17:14:36 +00:00
danrubel@google.com 7f1ac9a001 include local functions in completion suggestions 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//802163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42363 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-15 17:11:38 +00:00
paulberry@google.com 0b9ed18603 Allow completions to wait for analysis without requiring a busy wait loop. 
Two new methods are added to the AnalysisContext which return
Futures--the futures complete with the result of analysis once it's
available, avoiding the need for a busy wait loop in the completion engine.

The futures are guaranteed to complete eventually (provided that
analysis reaches quiescence).  If it is determined that the requested
analysis will never become available (e.g. because analysis was
requested for a file or file/library combination that is not subject
to analysis), the future will be completed with an
AnalysisNotScheduledError, so that the client isn't stalled forever
waiting for analysis results.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//800723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42339 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-12 18:22:34 +00:00
danrubel@google.com 6995092b9d code completion for dynamic type elements 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//783383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42261 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-10 19:09:29 +00:00
paulberry@google.com 246112537b Start running new completion tests. 
R=brianwilkerson@google.com, danrubel@google.com

Review URL: https://codereview.chromium.org//781333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42210 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-09 16:44:12 +00:00
brianwilkerson@google.com d05b81598f Ported completion tests 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//785013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42176 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-08 20:00:24 +00:00
danrubel@google.com 4c868034b5 refactor code completion to allow for multiple suggestion computers 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//428313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38787 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-31 16:11:14 +00:00
danrubel@google.com 5a35fd7262 incremental step moving completion into services and adding tests 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//422423003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38728 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-30 12:37:47 +00:00
danrubel@google.com 0ecfa47a94 add FUNCTION_TYPE_ALIAS to CompletionSuggestionKind 
BUG=dartbug/20188
R=paulberry@google.com

Review URL: https://codereview.chromium.org//422133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38670 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-29 12:37:23 +00:00
scheglov@google.com aba0cfa4e6 Remove any 'group' invocations enclosing 'runReflectiveTests'. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//419563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38547 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-24 18:08:45 +00:00
danrubel@google.com 256e11dd57 more progress implementing analysis server code completion 
- add more properties returned by completion suggestion
- move completion suggestion into services
- move property constants into services for use by completion services
- move HasToJson into services for completion
- remove duplicate completion test

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//407833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38418 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-21 02:04:49 +00:00
danrubel@google.com d6497d280c denote completion offset using special character 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//402803004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38349 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-17 21:41:01 +00:00
danrubel@google.com 2bd9f4ec92 first cut simple code completion results 
- not all CompletionSuggestions implemented yet
- results valid in only a few situations
- more to come

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//402723003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38347 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-17 21:11:39 +00:00