dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

62 Commits

Author SHA1 Message Date
Brian Wilkerson 02d50e7ebf Migrate several test classes 
Change-Id: I7477d5c42a8c2f953c51aca7ab6fff8b6fc930f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-19 00:38:19 +00:00
Konstantin Shcheglov a8590a287e Remove WithNonFunctionTypeAliasesMixin from analysis_server tests, enabled by default, update tests. 
https://dart-review.googlesource.com/c/sdk/+/192948 was landed.

Change-Id: If5c175af47c9b324d6ca06597a4ebc3e3541cf85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193962
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-04-03 05:19:42 +00:00
Konstantin Shcheglov e97f1bdbf0 Switch analysis_server to language 2.12, so null safety, but opt-out files. 
This should allow doing partial migration, specifically protocol files,
which are imported by other libraries, but are a small library cycle
that does not import much outside of it.

Change-Id: I904c05d6d5b444ee9a9dbd1f7ada12aabdcc5165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-30 23:39:37 +00:00
Konstantin Shcheglov 92130a010e Tests for DAS services and generic annotations. 
Change-Id: I063c78ae778366e60bb0d4aca55c4e7fd70f3d52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193091
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-25 23:38:24 +00:00
Konstantin Shcheglov 4a5ac9df57 Support for non-function type aliases in convertElement() and test navigation. 
Change-Id: Ic2dcf6ad3faaf6712fdcbbe5197f332b6ba42e78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-26 06:40:00 +00:00
Konstantin Shcheglov fbfc723de7 Use CompoundAssignmentExpression instead of LHS element/type. 
This adds some technical debt in form of using writeOrReadElement in
clients, which can be paid incrementally by migrating these places to
handling assignment like expressions one by one. Doing it all in one
CL was too much. But now the underlaying AST resolution will be
sound.

In the next breaking change we will remove
setAssignmentBackwardCompatibility(), so stop setting elements/types
for assignment targets.

Change-Id: I11626876cfed25653edb0cc18544aba51cef5965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-14 18:45:08 +00:00
Brian Wilkerson ff83b0fec9 Add support for navigating from the URI in import and export configurations to the referenced file 
Change-Id: Ic6234d9a24dcb52228067b20d69277e47ff89a0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-24 22:46:33 +00:00
Brian Wilkerson 9eff98594f Cleanup unnecessary references to experiments that are enabled by default 
There's a good chance that I missed some references, but this should
clean up a significant number of them.

Change-Id: Ib0c93d2505d850903315c93979eca40244ab1585
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147048
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-07 18:42:48 +00:00
Brian Wilkerson 8969b1839c Enable omit_local_variable_types in analysis_server 
Change-Id: I7e5c13d40fd276854601681fc84be321e6031b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-30 03:58:44 +00:00
Brian Wilkerson b03ef5b3fe Convert more doc comments in analysis_server 
Change-Id: I333d0af4444226a8152e840c4d9015fb4c30bd32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-13 19:29:28 +00:00
Brian Wilkerson 8efdee06d6 Begin adding return types in analysis_server 
Change-Id: Id0daa52236bdc90cba6bfd7cf81d1b4cf47603c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133544
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-28 21:18:30 +00:00
Brian Wilkerson 5584c96fde Enable prefer_single_quotes in analysis_server 
All of the changes except in the analysis options file are from dartfix.

Change-Id: Icd9bf02ad07f71d1fc365979c7dfe18a792dc595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132624
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-21 17:52:52 +00:00
Sam Rawlins 327b1eb24f analysis_server: Make private fields final where possible 
Change-Id: Ibdeb7e66f07bf81205d70ac5d1c4cb4aa5a97671
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-01-08 22:08:02 +00:00
Brian Wilkerson 91d6e1a0a7 Enable annotate_overrides in several packages 
Other than analysis_server/test/analysis/notification_overrides_test.dart,
which had a naming conflict, all of the changes were made using dartfix.

Change-Id: I911dd75dcdee00420caa48724125e86d47c8857d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 21:31:40 +00:00
Brian Wilkerson 4043a6fce3 Remove unnecessary uses of new in analysis_server 
Other than analysis_options.yaml, all of the changes were from running
dartfix.

Change-Id: I92411642f12a00fc6bd0bfd24dd60fe67f0fed16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 19:01:51 +00:00
Brian Wilkerson 4f9293962b Add a navigation test 
I wrote the test to debug why navigation wasn't working for me in the
editor, but the test passes. I think it's worth capturing the test.

Change-Id: Ieb4c6380dcd07fbec67d6b508d97087303c428ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113212
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-15 20:23:52 +00:00
Konstantin Shcheglov ca5ac975fe Fix for crash in _DartNavigationComputerVisitor._addUriDirectiveRegion when part has invalid URI. 
R=brianwilkerson@google.com

Change-Id: Ia6c62c344cd195449168e5971165a3d37ffc7f67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-19 14:53:17 +00:00
Brian Wilkerson 47e988b781 Clean up the remaining copyright notices in analysis_server 
Change-Id: Iee3110f92ab0f24312ddd1eff407d2229f895321
Reviewed-on: https://dart-review.googlesource.com/c/89101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-11 15:38:56 +00:00
Konstantin Shcheglov 1f52372bfa Remove CFE integration from analyzer, analysis_server, and analyzer_cli. 
AnalysisDriverResolutionTest is partially updated, about 30 failing
tests added. I will get back to it in a following CL, it is not
directly CFE integration, but updated understanding how we want to
resolve. For example we don't need types for non-expression identifiers.

Change-Id: I3daddbb6c66ffad7a726f3313a1199fd7387aa04
Reviewed-on: https://dart-review.googlesource.com/71883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-08-29 13:46:45 +00:00
Konstantin Shcheglov cb4f5b3a3a Resynthesize nameOffset for properties/parameters. 
R=brianwilkerson@google.com

Change-Id: Ib3213529836df20f580a5d8805006ba13b82bf20
Reviewed-on: https://dart-review.googlesource.com/68761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-07 21:54:55 +00:00
Konstantin Shcheglov c30af508a4 Store import prefix offset into metadata and resynthesize. 
Change-Id: I7ef72c562323f132865c7cb6b3b068623c831043
Reviewed-on: https://dart-review.googlesource.com/68741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-07 18:17:46 +00:00
Brian Wilkerson b83072cf7d Clean up use of callFailingTest 
Change-Id: I00ed46b48c03038825d62e1d9bac355bbe2354a7
Reviewed-on: https://dart-review.googlesource.com/68380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-03 17:29:37 +00:00
Brian Wilkerson f169ebf418 Fork several server tests to run under CFE 
Change-Id: I9ca4184dc5458304f3f1597681fc1c936972d8bd
Reviewed-on: https://dart-review.googlesource.com/67880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-01 20:18:40 +00:00
Danny Tuppeny 40e3f9addc Convert paths for mock SDK libraries to fix tests on Windows 
The other lines on this method are calling `provider.convertPath` around their paths but these ones do not, which is causing almost all analysis server tests to fail on Windows (for me - I can't explain them not
failing builds). This causes the hard-coded paths like `/lib/core/core.dart` to be fixed up to `C:\lib\core\core.dart` which is what the server is looking for (because at the other end the paths *have* been fixed up).

See #32226.

Closes #32230
https://github.com/dart-lang/sdk/pull/32230

GitOrigin-RevId: 1adeee23f8ac8efc8acf61caf5f769e4ec44c030
Change-Id: Id9bf195967db0912c6f4b67bd79d504e627b8aab
Reviewed-on: https://dart-review.googlesource.com/42300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-20 18:55:38 +00:00
Brian Wilkerson 1d8a5d77c1 Convert more tests to use ResourceProviderMixin 
Change-Id: Ia4cce51e33c79c82a989bfda9b8303dfaa72e103
Reviewed-on: https://dart-review.googlesource.com/31880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-01-02 00:47:34 +00:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt. 
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
 2017-07-13 16:28:18 -07:00
Brian Wilkerson 9ddb832e10 Generate constants in server as we do in plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2960073002 .
 2017-06-28 08:21:33 -07:00
Brian Wilkerson 67ff4d4c47 Convert more tests to the new driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2933943002 .
 2017-06-12 14:10:14 -07:00
Brian Wilkerson fb982f5476 Make server use the common protocol classes 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2879273002 .
 2017-05-15 09:35:46 -07:00
Brian Wilkerson 27f9e5e4ce Reverse the sense of the flag to make it easier to find test that need to be converted 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884593003 .
 2017-05-15 08:40:40 -07:00
Brian Wilkerson e55812a3f2 Unify the server and plugin versions of the generators 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2844273003 .
 2017-04-28 07:46:29 -07:00
Brian Wilkerson 61d5c85b48 Allow navigation from var when there is an inferred type (issue 29091) 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2769813005 .
 2017-03-23 10:34:09 -07:00
Konstantin Shcheglov 05a86a7495 Remove 'initializeTestEnvironment' from 'analysis_server'. 
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2402483002 .
 2016-10-06 10:26:17 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'. 
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
 2016-10-06 08:47:15 -07:00
Konstantin Shcheglov 2f0f398c73 Fix lints: unnecessary_brace_in_string_interp 
Also fixes two cases of empty_constructor_bodies.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1521883002 .
 2015-12-13 13:05:00 -08:00
Konstantin Shcheglov 2be2c5e55c Fix for navigation reginos for instance creations with import prefixes. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1498163003 .
 2015-12-04 14:24:09 -08:00
Konstantin Shcheglov c302b65584 Use async/await in all analysis domain tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1478513002 .
 2015-11-24 14:18:37 -08:00
Konstantin Shcheglov 670db50707 Generate separate navigation regions for 'super' and optional 'name'. 
Also support for navigation regions for RedirectingConstructorInvocation.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1465303003 .
 2015-11-23 14:27:03 -08:00
Konstantin Shcheglov 289bd0a056 [Atom] Issue 424. Fix for 'getNavigation' and index expressions. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/424

Review URL: https://codereview.chromium.org/1402353009 .
 2015-10-25 11:29:54 -07:00
Konstantin Shcheglov a30bcd7b97 Issue 24599. Fix for requesting navigation for directives. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24599

Review URL: https://codereview.chromium.org/1405033002 .
 2015-10-15 10:54:06 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
Konstantin Shcheglov 62fd9ac787 Issue 24487. Annotations with constructor resolution should produce navigation reginos to constructors. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24487

Review URL: https://codereview.chromium.org/1378713004 .
 2015-10-02 10:44:58 -07:00
Konstantin Shcheglov 83f94a2114 Add navigation region for 'library' directives. 
Dart Editor uses presence of a navigation region as a sign that there is something that can be renamed, and enables the Rename action.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1373593002 .
 2015-09-25 12:35:51 -07:00
Konstantin Shcheglov 5fd8b38737 Tweak navigation for 'part of' directives. 
This makes it consistent with import/export/part directives, where only URIs are navigation sources.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1365663002 .
 2015-09-23 10:14:49 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
Brian Wilkerson f909ed8adf Add test for references in comments 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1256333008 .
 2015-07-30 11:20:00 -07:00
Konstantin Shcheglov d5d0017e21 Tweak for navigation for URIs. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1246833002 .
 2015-07-20 15:07:00 -07:00
Konstantin Shcheglov d7c2f4550b Issue 23640. Implement 'analysis.getNavigation' request. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23640

Review URL: https://codereview.chromium.org//1232683003 .
 2015-07-10 15:31:25 -07:00
Konstantin Shcheglov 7e194d8fb5 Change navigation regions generation for constructors. 
In IDEA we use navigation regions for resolution.
And so far all navigation regions are for separate identifiers.
This CL splits single regions like "new A.named()" into separate "A" and "named" regions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1218183007.
 2015-07-06 11:27:19 -07:00
scheglov@google.com 9efb25fa50 Use package:test_reflective_loader instead of reflective_tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1101003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45365 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-22 20:54:29 +00:00