dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4618 Commits

Author SHA1 Message Date
Brian Wilkerson 813b0d029a Rename a parse method and make it consistent with newer methods 
Change-Id: I3cde98229649557eb32a291afeab7558943cf140
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171631
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-12 06:20:56 +00:00
pq c84ada0fd4 be aware of cascades when scraping type params for var replacement 
Fixes: https://github.com/dart-lang/sdk/issues/44156

Change-Id: I5ceb69d4a3fa4bbc68cdb7af2f9eb065ac8ae0f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171627
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-11-11 21:08:29 +00:00
Devon Carew e7647f2cf2 Revert "[analysis server] remove the --file-read-mode cli option for the analysis server" 
This reverts commit 1caee4d1fd.

Reason for revert: This breaks google3 - we need to update the linter's use of the analyzer API.

Original change's description:
> [analysis server] remove the --file-read-mode cli option for the analysis server
>
> Change-Id: Id07e3655cb4bcfc462ada0db8257e7cf584272f5
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171101
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Devon Carew <devoncarew@google.com>

TBR=devoncarew@google.com,scheglov@google.com,brianwilkerson@google.com

Change-Id: I68294ad8b565a94aa098e65276b78e9745eec5a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171640
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-11 20:10:41 +00:00
Danny Tuppeny 8687aa6145 [Analyzer] Add an LSP setting for including parameters in completions 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2823.

Change-Id: I477aba5f3563c01a85bb867a1e01f294eed3636e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171585
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-11 19:44:12 +00:00
Devon Carew 1caee4d1fd [analysis server] remove the --file-read-mode cli option for the analysis server 
Change-Id: Id07e3655cb4bcfc462ada0db8257e7cf584272f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-11 19:30:23 +00:00
Brian Wilkerson 23478cb386 Implement a simple transactional model for change builders for use by bulk fixes 
Change-Id: I4e7a3e13345a865a2302dfddbc9aa4eb7b531d15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171340
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-11-11 16:46:42 +00:00
pq d6a8505ba4 remove redundant @required annotations when adding required 
Fixes: https://github.com/dart-lang/sdk/issues/43603

Change-Id: I21ccee4787695b72d5ac25195ade638e918d9550
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-11-10 23:06:07 +00:00
Konstantin Shcheglov b16c6a8292 Issue 44131. Handle .dart_tool/package_config.json file change, re-configure with new Packages. 
Bug: https://github.com/dart-lang/sdk/issues/44131
Change-Id: I4c843da4c6cecea5e334ba6b73cffa42be6d80ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171360
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-10 21:59:06 +00:00
Brian Wilkerson 87cb3ede9e Report conflicting edit exceptions 
Change-Id: I2b76b79a7b741c0d587fd24f8eaa30f1f0f8c657
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171285
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-10 18:22:04 +00:00
Brian Wilkerson f3f053e328 Add preliminary support for simple conditions in data-driven fixes files 
Change-Id: Id65d4cf8daebfa01bf6d59c90f755b9a8827c458
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171043
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-10 18:07:34 +00:00
Danny Tuppeny d4e5a14627 [Analyzer] Use SymbolKind.EnumMember when client supports it 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2945.

Change-Id: Ifdfade387c97c9bf1162e048b2d18930a726806a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171286
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-11-10 17:58:54 +00:00
Brian Wilkerson 0d222cc712 Throw an exception when an attempt is made to produce conflicting edits. 
Change-Id: I826cd1771a61685f76314b3ec0125cfc0364b700
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170800
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-10 15:56:06 +00:00
Danny Tuppeny 4c85f1950b Send LSP unhandled exceptions to instrumentation service 
Change-Id: Id8e876b7144aa98dc7c219b9eec2c140824f9675
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170427
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-11-09 20:06:14 +00:00
Devon Carew 5871cfb23c [analysis server] remove older analysis server flags 
Change-Id: I4384c98a067467def91e2b769d711069ad057a27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170801
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-09 03:54:58 +00:00
Sam Rawlins d8903669be Quick fix: make a parameter nullable 
Closes https://github.com/dart-lang/sdk/issues/44098

Change-Id: Ib3bb0b352f33a027c79746418033497aee1d8a7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170763
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-09 01:19:07 +00:00
Brian Wilkerson 2d4070fa34 Fix a bug when adding a named parameter after removing all existing parameters 
Change-Id: Ib43b154fb781ff50d32f4259ef198857835f9135
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170404
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-04 21:02:37 +00:00
Danny Tuppeny 648debb622 [Analyzer] Prevent NPE in Surround With assist 
Fixes https://github.com/dart-lang/sdk/issues/42556.

Change-Id: I5d38fcbd7932a43da0ca40140cefdef593d6ea8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-11-04 17:52:17 +00:00
Brian Wilkerson a1977edddb Support a rename-parameter change for data-driven fixes 
Change-Id: I9b2d168e3909e7477724a8feb6ae94b69a09950b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170260
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-04 16:18:47 +00:00
Konstantin Shcheglov d484a6f09f Remove support for experiments in Analysis Server options. 
analysis_options.yaml should be used instead.

Change-Id: I02a03667d5de5c9e764e30ff3c77b8df6deaa221
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-30 20:46:02 +00:00
Brian Wilkerson be5446f700 Improve the location of a couple of diagnostics 
Change-Id: I11e935b89d7e2a91a71b2fed162407d6bb2c2367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169942
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-30 20:31:52 +00:00
Brian Wilkerson 26810cdd50 Fix hints in analysis_server 
Change-Id: I4dd078fdca93000e8a8f5251893db1e8f990c7a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169780
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-29 19:41:56 +00:00
Sam Rawlins d38b366eb6 Add quick fix to remove unnecessary null-aware assignments 
Fixes https://github.com/dart-lang/sdk/issues/41514

Change-Id: I29398feae3ad3a83ced722a876c6f6416ef46da8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169581
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-10-29 05:06:53 +00:00
Brian Wilkerson 0128ffa6d1 Add most of the remaining parser diagnostics to the data file parser 
Change-Id: I5e074fb17c27c298a56569a3535779205085d6ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169540
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-28 22:30:10 +00:00
Danny Tuppeny 5851f8bc0c [Analyzer] Add a fix for unnecessary_non_null_assertion 
Change-Id: I90f03426d0f0e823a89dcaf58577561f776398de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169360
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-28 16:27:28 +00:00
Brian Wilkerson e2cc75e847 Fix the offset used when reporting errors inside of string literals 
Also fixes a bug introduced by two incompatible changes were both
committed. Seems like the infrastructure ought to have caught it, but
it appears not to have.

Change-Id: I66a5d9f69740430bd4aedbf5c3c1ee307a92a4de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169250
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-27 23:33:27 +00:00
Brian Wilkerson 29c7474845 Add a test for accessing type arguments 
Change-Id: Idb72eeb468149417c570ceef63116559295caee7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169280
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-10-27 20:59:17 +00:00
Konstantin Shcheglov d9d7324b27 Issue 43777. Update analysis_server/ tests to run when Null Safety is enabled by default in 2.12 
Bug: https://github.com/dart-lang/sdk/issues/43777
Change-Id: Ibd1da16b58b8304d6f1d4260615c7049fc5ffe59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169141
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-10-27 18:19:33 +00:00
Brian Wilkerson c45d52b62a Rework the parser to parse code fragments rather than value generators 
What this means is that data file authors can specify values that are
extracted from the source being updated by writing a single string (in a
format that's a very limited subset of Dart) rather than by writing a
potentially deeply nested map structure.

Change-Id: I06011983310b1c5a4e921c3f762f5b39818ced17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169148
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-27 15:41:52 +00:00
Danny Tuppeny 9307c313ad [Analyzer] Advertise that LSP server can provide Refactor CodeActions 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2885.

Change-Id: I8a3b07d12e7498901fa7d7808aa244a0d71c3feb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169102
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-10-26 16:02:36 +00:00
Danny Tuppeny 1a97f851ef [Analyzer] Remove period from LSP commit characters 
Change-Id: I7eef065f2db39f6b95fcdffbeda40bd4b08aca3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-10-26 14:19:16 +00:00
Brian Wilkerson 4be43f4430 Replace the implementation of an argument value with a more general way of computing a variable's value 
This is backend support to allow the parser to accept a new syntax that
is more general than what is currently supported.

Change-Id: Icb660e7588d67afd403bc6cd1f493cda9accb289
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168992
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-10-24 15:49:23 +00:00
pq a9f17d4f9e fix offset for var replacement in const collection literals 
Fixes: https://github.com/dart-lang/sdk/issues/43895

Change-Id: Iaea95178505859f33ed44d36b8a902cc135e5023
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168880
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-22 20:52:00 +00:00
Konstantin Shcheglov a82c098e4a Issue 43894. Fix for crash in getParameterDocumentation() when the FieldFormalParameter uses unresolved field. 
Bug: https://github.com/dart-lang/sdk/issues/43894
Change-Id: I7834e28fbe6c9ba1f67c3712fef8fcc594dda261
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168779
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-22 20:25:40 +00:00
Sam Rawlins 6103487f9e Remove unused imports with shared prefixes 
Bug: https://github.com/dart-lang/sdk/issues/38784
Change-Id: I2c5477bbb36b17ad9ac4cf5e9584dd66f66afe1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-10-21 19:37:34 +00:00
Danny Tuppeny 96796b9751 [Analyzer] Add commit characters to LSP completion items 
Change-Id: I71b1fa18a0fd9a4051359551803bff975381a835
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168653
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-10-21 18:34:33 +00:00
pq 382dbb6861 handle hashCode fields when creating == 
Fixes: https://github.com/dart-lang/sdk/issues/43867

Change-Id: I6ee0ee4feebce13e576a351bbe9578b705076422
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168582
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-20 22:38:01 +00:00
pq a880c3b180 provide context on producer exceptions 
Change-Id: Iea3028af5de2bdd4712319ea2609d1b14888c1a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168584
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-10-20 22:34:21 +00:00
Brian Wilkerson 691d07575b Add tests for flutter-specific uses of data-driven fixes 
This also adds a fix for a bug found by the tests. There are a couple of
failing tests, but they're failing because the support required for them
hasn't been implemented yet, not because of a bug.

Change-Id: Ia24dffc02aac0c4b61c9c7d8e2d744211f5b4bea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-19 21:44:27 +00:00
Brian Wilkerson c3c6ada631 Support data-driven update of deprecated parameters in methods that are not renamed 
Change-Id: I52039796668225102b9a2d81b4a276556d763324
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168121
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-16 16:49:22 +00:00
Konstantin Shcheglov aad1a677c0 Deprecate GenericTypeAliasElement 
See also https://dart-review.googlesource.com/c/sdk/+/166680

Change-Id: I6018f3bf5796dcc8ab059aab5b29d01e7336581b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-15 16:03:26 +00:00
Brian Wilkerson cb7ac82c32 Fix the computation of valid kinds 
We were previously missing some cases, such as property access nodes,
while accepting too many, such as unknown cases wrapped as an argument
in a method invocation. This fixes both of those cases.

Change-Id: Id489fda9ed23ab19c42f1be451f8747ff8113ca9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167721
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-14 19:29:48 +00:00
Konstantin Shcheglov fbfc723de7 Use CompoundAssignmentExpression instead of LHS element/type. 
This adds some technical debt in form of using writeOrReadElement in
clients, which can be paid incrementally by migrating these places to
handling assignment like expressions one by one. Doing it all in one
CL was too much. But now the underlaying AST resolution will be
sound.

In the next breaking change we will remove
setAssignmentBackwardCompatibility(), so stop setting elements/types
for assignment targets.

Change-Id: I11626876cfed25653edb0cc18544aba51cef5965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-14 18:45:08 +00:00
Danny Tuppeny ece17f73b0 [Analyzer] Ask user whether to proceed with renames that produce errors 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2745.

Change-Id: Ia2770f18ebca410bce93bd2f3042e294083dc435
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167621
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-14 17:46:58 +00:00
Brian Wilkerson a1682401b5 Add flag to transforms indicating whether they should be applied when running in a bulk fix mode 
Change-Id: I9a2add74524bdff4280e84a7d45a207e7321c458
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167421
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-13 17:39:08 +00:00
pq 97ad2d69af re-land pubspec analysis 
Change-Id: I047687f2b64bfdc149bfde2fed6dc8f5d722e7a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-10-12 14:43:52 +00:00
Brian Wilkerson 666dad0086 Use the information we have about the kind of element when computing fixes 
This puts in place support for using the element kind when determining
whether a transform applies. It is not as fully tested as it should be
but I plan to add more tests in future CLs.

Change-Id: Ife89c49384d1ceba9de5b18b7ef197018747ee25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-10-11 16:17:11 +00:00
Konstantin Shcheglov 52370de8fa Enforce prefer_typing_uninitialized_variables in analysis_server 
Change-Id: I09294ac48ab0f86a93cd1dcdcc53cca20546fb31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166720
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-08 20:00:05 +00:00
pq c21b906182 disable pubspec linting 
Disables the fix in https://dart-review.googlesource.com/c/sdk/+/164249 pending a fix to `sort_pub_dependencies` which is producing a false positive that is blocking the Flutter engine roll.

See: https://github.com/dart-lang/sdk/issues/43529
See: https://github.com/dart-lang/linter/issues/2271

Change-Id: Ica6262153b89259ba67b5a43eeeafe2bdd482b44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166703
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Dan Field <dnfield@google.com>
 2020-10-08 19:39:55 +00:00
pq f84bba2897 get libraries to fix from the context collection 
Fixes: https://github.com/dart-lang/sdk/issues/43694

Also implements recursive fix semantics consistent with `dart analyze`.



Change-Id: I349650a0c1704c2e2be84287b46de17ecc132d56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166602
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-08 01:34:08 +00:00
Brian Wilkerson bd6c31ad9a Do not match on parameter names 
One of the bugs I recently found caused the transform for a getter to be
applied against a parameter. This CL fixes that particular issue by
correctly computing the element name to be the name of the enclosing
invocation rather than the parameter.

It also introduces an `ElementMatcher` to hold the data currently being
used to match elements with the intent that more information will be
added in the future to prevent similar sorts of mismatches.

Change-Id: I14abbece334b3dc660d3854b817362c441efa11d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166600
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-10-07 21:37:20 +00:00