8736fec094
Add a fix and assist for omit_local_variable_types and enable it through dartfix
...
Change-Id: If0348d0463e73abbc5c0d20127bc9f22f93e53de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129480
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-23 21:59:00 +00:00
77f645ed71
assist to surround w/ setState
...
Change-Id: Ia441479bc15708fe95343e234bbdf4d91966aa5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129460
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-23 18:56:50 +00:00
71fb1ba3a8
analysis_server: clean up 2 more pedantic lints
...
Change-Id: I8095e69ece227b95522439fae571f152db4e3b25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129337
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-12-23 02:49:07 +00:00
e7f0402ebf
[analyzer] disable crash reporting for the AngularDart analysis plugin
...
Change-Id: I49dddc4901c9cada643c5c024b8580f06c81a0d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129331
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-12-22 23:04:57 +00:00
4a639e8df2
Add support to dartfix for the remaining pedantic lints (for which a fix is already implemented)
...
Change-Id: I6d7b0df1ce4fc7377697d4c66b78f2fb0e95b5c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129362
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-12-21 22:31:49 +00:00
ca202b9582
Remove unnecessary isSubtypeOf() in ExtensionMemberContributor.
...
We either can infer the valid extended type, or we get null.
Change-Id: I6d7912191a432146f6acf97d7d05411724342b16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129334
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-21 21:03:16 +00:00
cfca5ea9f2
Fix NPE when describing a function in the info builder
...
I didn't track it down, but throwing an exception here appears to cause
the migration engine or preview tool to hang. It was preventing the
flutter package from being migrated.
Change-Id: I0c2454fce5622a9768c2e3ff69514f83ffcd8a3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129180
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2019-12-21 17:28:56 +00:00
47c73558ef
Simplify the process of adding support for lint-based fixes in dartfix
...
This removes the need for one of the 2 or 3 changes we needed to make.
If you like this approach we can apply it to other kinds of fixes as
well.
Change-Id: I31dc9412dbd77b19f974cf93ae10fde38da62b24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129261
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-20 23:13:24 +00:00
9555c0a7d8
GenericInferrer gets all information from TypeSystem.
...
Change-Id: I1d3a5626a7ffda33ea7708b6d9f3b9a3b4f1a4f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129308
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-20 20:25:04 +00:00
dd306df959
Fix an NPE when computing a proximateTargetForNode when the node is null
...
I wasn't able to figure out how we got a node info with no AST node, so
I don't know how to write a test for this. Happy to let someone else
follow up.
Change-Id: I4fe745f63641c8f64a611b37d78f86dc50d36f1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129200
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-20 01:16:51 +00:00
21354dccc9
Remove SdkExtUriResolver.
...
Initial: https://dart-review.googlesource.com/c/sdk/+/128770
Reverted: https://dart-review.googlesource.com/c/sdk/+/128820
R=brianwilkerson@google.com
Change-Id: I446d0ddf130712e94aab756e04c91ab4b5e83aeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-20 01:08:49 +00:00
52c6620986
Enable unnecessary_const in analysis_server
...
Change-Id: I44d9902cb23d005ebedd4bc37d57d3751a8ebdc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-19 17:32:52 +00:00
de57ff3b1d
Remove one missed generated use of const in analysis_server
...
Change-Id: I6aac996b1cfe1c5d49d2cb68f7c7340893b79531
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129040
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-19 05:34:28 +00:00
efe76bd5c5
Add support to dartfix for prefer_single_quotes
...
Change-Id: Ifeb2ecdfcd391f22d90ee9ede5660d11ffb61804
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128986
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-19 01:59:49 +00:00
82f1f2f1b0
Remove AnalysisOptionsImpl.strongModeHints
...
Change-Id: I61b8aefb4935160bec20e52fb9c9482079387c74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128848
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-18 20:11:16 +00:00
4043a6fce3
Remove unnecessary uses of new in analysis_server
...
Other than analysis_options.yaml, all of the changes were from running
dartfix.
Change-Id: I92411642f12a00fc6bd0bfd24dd60fe67f0fed16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-18 19:01:51 +00:00
0addcc0c7d
Update LSP spec URI and regenerate from spec
...
Change-Id: I361a7a6e10167e140bf4ba190f29a3c33c584f01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128720
Auto-Submit: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-18 15:08:21 +00:00
c9d89d55a6
Stop generating unnecessary new and const in server generators
...
This doesn't remove other uses of new or const, only those that are
generated. I'll get the rest in other CLs.
Change-Id: I59c296da3d2da0f45789df156a682b9c37398087
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-18 05:15:25 +00:00
becb0c0b85
Revert "Remove SdkExtUriResolver."
...
This reverts commit 7ef8822c2abrianwilkerson@google.com
>
> Change-Id: If0d7bb91e9b1c42e15935b315288fa8e3a000c6d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128770
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com
Change-Id: I0c9a26662a6fe6abac558313c14949886364d28e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-18 01:07:34 +00:00
7ef8822c2a
Remove SdkExtUriResolver.
...
R=brianwilkerson@google.com
Change-Id: If0d7bb91e9b1c42e15935b315288fa8e3a000c6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128770
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-18 00:22:15 +00:00
8c9cbb5ee1
Allow the full path in the URL used to open the preview tool
...
Change-Id: I0bd2d06fa72918d8f12a7b2c78b96ea8bd03ea26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128740
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-17 18:22:36 +00:00
62e5531e36
Add a Flutter Outline Notification to the LSP server
...
Change-Id: Ifbff7d88df7e468cfba383fda89160c7d3d5ee33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128662
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-17 17:46:36 +00:00
2eba06d26f
Stop using preview-dir and preview-port values and always open the preview tool
...
Change-Id: I1ae6aeeb95b1a976c23fe23867a6bec9b453806e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128463
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-16 23:28:35 +00:00
f2ac0784f1
Add a fix and assist to add a return type
...
Change-Id: I7b683953d4b90c1863477b9fcf2e7f34f0955450
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128560
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2019-12-16 18:32:55 +00:00
bae7255c83
Add support to dartfix to fix unnecessary new and const lints
...
Change-Id: I8345ea6afd5aa43bda4855b24d101c04b177ae80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128522
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-16 15:33:11 +00:00
84308858e8
Highlight line that is targeted; fix some linking
...
Change-Id: I4c5758ddd5ffef6e874cbee140bcbfdfd8eb8e81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-12-14 00:25:34 +00:00
affd81b143
Remove preview from dartfix api in favor of opening the preview automatically
...
Change-Id: I7f2dd4c97a99ec9e2d28f2a06778c247150a0632
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128286
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-13 22:42:56 +00:00
11049992d5
Update the server protocol to not require a port number
...
Only spec_input.html was changed, the rest of the files were regenerated.
Change-Id: Ib4644f811d86c46da6d01c601107ede8537e39df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128366
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-13 18:45:41 +00:00
3ab95a114c
NNBD Preview is a single-page application.
...
Navigation links, goto links, and detail links all are handled with
JavaScript, pushing and popping state.
* MigrationInfo moved to migration_info.dart
* All logic for rendering the code and regions of a unit moved to new
UnitRenderer class.
* Navigation links work.
* Goto links work.
* Fresh reload works.
* New scrolling behavior to leave scrolling alone if target is already
in view.
* Removed index page in favor of regular page with blank code.
* Back and forward buttons work.
Change-Id: If2296ee576c45374c18e5ba71426bcbdc894b71f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-12-13 16:14:19 +00:00
f14301b0df
Stop supporting _sdkext, look for _embedder.yaml only in sky_engine package.
...
Change-Id: I20d30ef0e07ec617d5d8b9fb2e5fb97a7fc9930f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128320
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-13 02:15:28 +00:00
3172748cb0
Remove ResolverProvider, and its using for fileResolverProvider / packageResolverProvider.
...
It does not look that these are used anymore.
Change-Id: Ieafecc306dbf2b53e3366b1ffadc34aa7ba416a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128081
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-12 19:54:51 +00:00
7c5d83d170
Add explicit type to generated LSP classes == operators
...
Change-Id: I42f76c8d48329fed93821a17da71963eaa813d4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-12-12 18:42:20 +00:00
3739b80534
Add a publishOutline notification to the LSP server
...
Clients can opt-in by passing "outline: true" in initializationOptions.
Fix outline name
Change-Id: I3a302178c685b49afe50370aef8360105b9676fc
Add test that outline comes through after change
Change-Id: If36344d485ea11c4b25d57e1e1fb43b575e8188f
Initial work on supplying Outline data over LSP
Change-Id: I74670b5c43a41af49195712bcc4be8e120e5b4ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128141
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-12 18:42:20 +00:00
3389b3bd32
Remove Packages from SourceFactory.
...
We have PackageMapUriResolver, this should be the way to resolve
all `package:xyz` URIs. We should not repeat it in SourceFactory.
Change-Id: I52d33dbf7e2d44f2c53521f6a51b0aea70507d3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128106
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-12 17:10:00 +00:00
2c7c3a60e7
NNBD preview: Rip out static preview; only server preview
...
This involved replacing PathMapper with the wrapper, PreviewPathMapper,
and MigrationInfo, with the wrapper, PreviewMigrationInfo.
Change-Id: Ie590c298bfa8c64c4765748b42ce3c9dc0dec3d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128107
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-12-12 01:48:23 +00:00
afde51a608
Start sending urls for preview mode from server to dartfix
...
Change-Id: Ice8463ec9a5d3d21b47e6250f24d093a48b11b7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127988
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-11 14:26:29 +00:00
9ce43015f4
NNBD preview: improve details of where a nullable value is 'assigned'
...
Change-Id: Ifcb37460ef5255e9de58a51860ee47228735abf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127200
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2019-12-11 14:07:09 +00:00
4ce13659b4
Update server API to allow URLs to be returned to dartfix
...
Change-Id: I252ee50b811409aa2eed7d0579c01676160acfca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127940
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-10 19:39:29 +00:00
108a80bd0d
NNBD: Mark some good tests as passing; add FailingTests for some GitHub issues
...
Change-Id: Ia5a55b5c6f1e7d7c7bef32c0afecf689952e17eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127761
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-12-09 22:17:44 +00:00
9605cca5a6
Make a method public that is overridden in a subclass
...
Having the method be private causes the interactive tool to be broken.
Change-Id: I9390de3b9510c38c69039f2df38a116802acdf89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127701
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-09 19:31:13 +00:00
22fef10a59
[nnbd_migration] suppress fewer upstream exact nullable nodes
...
Change-Id: I1acd6b44c098868127e903d96baafa03bcd34b04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127421
Reviewed-by: Janice Collins <jcollins@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-12-09 18:56:29 +00:00
acac2d8d63
NNBD preview: Extract Dart page styles into their own file
...
Change-Id: Iaea12e058c703a198a2ff388a85683cf5cbff8b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127493
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-07 02:06:54 +00:00
310c2eb5c4
Display target file name as link text
...
Change-Id: I1a919db827709210e89ca6e7ecf5a9ed2c5e7d0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127300
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-06 23:22:04 +00:00
b92cd2cb95
Deprecate DartType.displayName, use getDisplayString() instead.
...
We call it with `withNullability: false` almost everywhere.
My attempt to update all places turned out to be a long chain of
changes. So, instead I will make decisions and updates in separate
CLs, starting with ErrorReporter.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I9d72475577ba2934bed1c06a4808ab620e92a20e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127441
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-06 22:43:59 +00:00
70750329af
[nnbd_migration] use animation/delay to make tooltips easier to use
...
Change-Id: I7c32a091952b221037abcdb27b803834678219aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127487
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2019-12-06 22:35:54 +00:00
84cc410c7e
NNBD preview: move navigation; clean up styles
...
View output for logging here:
https://srawlins.users.x20web.corp.google.com/nnbd-i13n/logging-sample/lib/logging.html
* black background
* navigation on the right, colored links, styled
* flex display allows links to be up top if they don't fit horizontally next to source code
* nice font
* removed "suggestions" from text, which I think confused participants into thinking
they were expected to manually enter changes being "suggested."
* nice positioning; consistent margins and padding.
* hyphenated-case CSS classes
Change-Id: I67f373e7c549d9c56cceb082439a77be78e45827
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127467
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-12-06 22:02:04 +00:00
652926bbaf
Deprecate Element.getAncestor, replacing it with methods matching those in AstNode
...
Change-Id: Iebb046791c1fce57a228f997e9c5936809fbc872
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-06 18:29:02 +00:00
723baf767f
[analyzer] fix an npe in fix_internal.dart:2171
...
Bug: https://github.com/dart-lang/sdk/issues/39673
Change-Id: Iad903410ba5fecfa61992c2dfba9289c07234269
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-12-06 00:56:10 +00:00
2bb60763c3
Fix remove_type_annotation fix/assist to work with for loops (issue 39628)
...
Change-Id: Ie212ea369cb2c0d4d8b37b50928d3935fad6a445
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-04 16:15:08 +00:00
28fc03709d
NNBD preview: Improve details for overridden nullable parameter types
...
Change-Id: Id7f85d2030f818f690f904050f0ec54c15b0d819
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127066
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-12-04 14:20:48 +00:00
Brian Wilkerson