dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4618 Commits

Author SHA1 Message Date
Brian Wilkerson 094d98a812 Use the context type for available declarations 
Change-Id: I698becd01145dde94505608f99171789a7f39c62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151428
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-17 15:43:36 +00:00
Danny Tuppeny 728df5d9ab Fix placement of "final" for late fields with types 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2553.

Change-Id: Ief79c8d5e095c17afc39d83eb231604bcf224ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151511
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-17 14:56:04 +00:00
Mike Fairhurst aa3f7dc4e9 [analysis_server] Fix crash reporting bug, casting exception to a string 
Brian noticed this running unit tests. Who knows how many bug reports we
have missed from this -- we can only hope it is very few.

```
type '_TypeError' is not a subtype of type 'String'

package:analysis_server/src/server/error_notifier.dart 26:7        ErrorNotifier.logException
package:analysis_server/src/analysis_server.dart 266:54            AnalysisServer.handleRequest.<fn>
dart:async/zone.dart 1222:13                                       _rootRunBinary
dart:async/zone.dart 1107:19                                       _CustomZone.runBinary
dart:async/zone.dart 1601:18                                       runZonedGuarded.<fn>
dart:async/zone.dart 751:19                                        _ZoneDelegate.handleUncaughtError
...
```
Change-Id: Ib83dc99a88a1566ead5d59a9f71afc80416eb341
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151464
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-17 07:11:30 +00:00
Jaime Wren 651464c909 Implement the rest of the ArgumentList ASTNode logic in the context type visitor in feature_computer.dart, tests added in feature_computer_test.dart 
Change-Id: I35afea21912a785af427afb317cbff532c29d717
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151364
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-16 20:51:21 +00:00
Brian Wilkerson c7d9fa996b Clean up some unnecessary code in completion manager 
Change-Id: Ifdbe46f12b82a521aa079db87fd8c1aba9dd165b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151424
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-16 20:41:01 +00:00
Brian Wilkerson 6d4e7d6830 Fix an exception thrown when a method cannot be resolved because the target type is dynamic 
Change-Id: I0479305057a2f763f68aa61c860ab9785d2ca1b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151420
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-16 17:38:30 +00:00
Danny Tuppeny 25f2f7796a Send LSP outlines for all open files 
Change-Id: Icd785376c54965c53bd4ea0cf89ede74a4287981
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151390
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-16 16:21:50 +00:00
Brian Wilkerson 0d3e77d28e Start converting assists to CorrectionProducer 
Change-Id: Ie2d12ce8c15a75e8db71434d790c32a76a06b13e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151324
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-16 00:11:28 +00:00
Jaime Wren 920ddae937 Re-write of the computation of the context type for code completion.  Instead of passing a parent and child node, a parent node with an offset is passed.  The primary purpose of this change was to fix a bug with argument lists which is close to being fixed. 
I will follow up with some additional fixes and tests for map and list literals.

Change-Id: I1a26e8f900dcf13402385a49e8f3538c5d1b39df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151030
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 18:19:42 +00:00
Danny Tuppeny 25cf204dd2 Prevent duplicate code actions for lines with multiple similar errors 
Change-Id: If1a50f3c651efec9ba68fc7be5e50700cfcdb20b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151234
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 18:09:02 +00:00
Danny Tuppeny 16ef3ee562 Fix LSP equality checks for lists/maps within unions 
Change-Id: I7ec8b591375dfb4d75f802839b89c1288cd4cfef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151236
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 18:09:02 +00:00
Danny Tuppeny 3b243a0c30 Recurse through lists/maps when generating hash codes in LSP types 
Change-Id: I06117fe33c7bfb8553e9930afbf7e3bdc86c6032
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151230
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 18:09:02 +00:00
Konstantin Shcheglov 48f2d10d3e Deprecate ClassElement.hasReferenceToSuper 
Change-Id: Ie94d8e2b0be6ccb30c7ca59c80da2832cfed3689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151168
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-15 17:45:06 +00:00
Brian Wilkerson 8d08bbf40a Add a fix for default_list_constructor 
Change-Id: Ia7b9c88cfe9528ddddd68935009736c494e57130
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151098
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-13 16:29:35 +00:00
Brian Wilkerson c22dc20a93 Use the const-ness of an element when completing in a const context using available declarations 
Change-Id: Ia950ad81ed571cbcf1f0060da0cba26406206ad1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151031
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-12 22:15:55 +00:00
Brian Wilkerson 9be1160700 Do not suggest the keyword const when completing in a constant context 
While it isn't an error to use `const` in those contexts, it also isn't
necessary and we already omit `new` because it's never required. This
makes `const` more consistent with `new`.

Change-Id: Ia577065d53ab57543b86161f5e62e3947ff9a2a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151029
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-12 16:32:40 +00:00
Danny Tuppeny 2f2efeb07a Filter LSP definitions to not include variable names 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2535.

Change-Id: I2e64d0cd53abcde4ac3ecae1682b6b054b16407a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150980
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-12 14:38:44 +00:00
Danny Tuppeny 7b12c8e06d Add fixes for extends_non_class 
Bug: https://github.com/Dart-Code/Dart-Code/issues/2536
Change-Id: I5e4fa5a3625016045d86462b941cee3c73a36a04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150932
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-12 14:12:34 +00:00
Danny Tuppeny 44f869d3a6 Cap the amount of time spent waiting for plugin completions in LSP 
Change-Id: Ic60d9936a252a1322becc233d696dfed41af834a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150927
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-12 14:11:24 +00:00
Konstantin Shcheglov 67da8cf7f5 Fix for NPE when the assigned expression is synthetic at the end of the unit. 
R=brianwilkerson@google.com

Change-Id: I6c221481fa0b8338847f6fb0d605c45c17a55fe3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-11 16:50:51 +00:00
Danny Tuppeny 5c3f9217cb Filter LSP completions (fuzzily) by prefix to reduce payload size 
Bug: https://github.com/dart-lang/sdk/issues/42152.
Bug: https://github.com/dart-lang/sdk/issues/40026.
Change-Id: I4c921ddff3224d736c4236861d0ff156f58be595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150628
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-11 14:11:12 +00:00
Brian Wilkerson 01f284c661 Clean up the return type of the contributors compute method 
All of the contributors now contribute through the builder so the return
value was always an empty list.

Change-Id: I9e5746a7c7e2dc256a00c6091f6bf9d46331b617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150803
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-10 19:37:12 +00:00
Jaime Wren 5900da5418 Refactoring and follow-up on the recent change to local_reference_contributor.dart. 
Change-Id: I40dccf84293d09b85879d75ed84a30e141c8dbda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150764
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-06-10 17:26:17 +00:00
Danny Tuppeny 5f3c799084 Don't return LSP errors when failing to organize imports due to parse errors 
Change-Id: Ia0a6fab160da0a04b4fe81c0968d0f8ad3141c3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150631
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-10 16:07:27 +00:00
Danny Tuppeny 2b917f5b6a Separate server/plugin completion results to make it easier to fuzzy-filter server results 
Change-Id: I249d74627a1eb38ed73a61ea4719aa865c645139
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150627
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-10 15:46:47 +00:00
Jaime Wren abde894da6 Merge the inherited_reference_contributor.dart into the local_reference_contributor.dart contributor. This fixes an outstanding bug in completion inwhich local and inherited methods were recommended in completions instead of local declarations. 
Change-Id: Ie9d2b51b2b25d5537a59f73f23e3f6224190eedf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-06-10 14:59:27 +00:00
Keerti Parthasarathy 85eeee228a Expose some more completion timings. 
Change-Id: Id9cb40fd07c350e7de817025e65d0537e19821e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150467
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-06-08 22:02:59 +00:00
Jaime Wren 0c54bb7563 Finish implementing the shouldSuggest(..) logic in the local_reference_contributor.dart contributor, adding tests for each case. 
The next step is to merge the inherited_reference_contributor.dart into this contributor (local_reference_contributor.dart) to prevent getters, setters and methods from being suggested when they are, in fact, shadowed.

Change-Id: I406cc916d69ee87eaa1b516e6f85996464d62cab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150460
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-08 21:42:22 +00:00
Brian Wilkerson 87300e9081 Rename getClassDeclaration to getClassOrMixingDeclaration 
Change-Id: Ide9ca130a5141d4a970652c0b9893d389a6a7a6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-08 16:25:46 +00:00
Brian Wilkerson e0386cbb92 Convert the remaining fixes to use producers 
This also cleans up FixProcessor by removing some now unused field, etc.

Change-Id: Id4df8b196e3930cdf2f0872c421571edc021041e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150273
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-08 14:05:44 +00:00
Jaime Wren 48b4528a44 Fix completion issue with the shadowing inside of function declarations 
Change-Id: I3bcef03e47400d937b9064a49baa950a3a306f5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150289
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-06-07 00:23:11 +00:00
Jaime Wren 403955cf34 Fix completion issue with the shadowing of enum declarations and enum constants 
Change-Id: I955fb7a0137552299097d8a77a81f6d27a44f354
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-06-05 20:21:26 +00:00
Jaime Wren 1e0611cfac Refactor the LocalConstructorContributor into the LocalReferenceContributor. 
local_declaration_visitor.dart was updated to better implement ConstructorDeclarations

This adds the API of _recordCompletionElement() and _elementAlreadyInCompletionSet() to local_reference_contributor.dart, if this API looks good and lands, I will use it in the rest of the contributor to fix other known shadowing bugs.

local_constructor_contributor_test.dart was removed (a large copied & pasted body of tests not providing value) and tests were added at the beginning of local_reference_contributor_test.dart.  Tests in this file were also updated accordingly.

The change of the testCommentSnippets025 test in completion_test.dart is due to the framework not supporting (in a more robust way) the allowance of both a class and an implicit constructor

The addition of the testCommentSnippets045 test in completion_test.dart is to show that constructor invocations don't need the new keyword.

Change-Id: Ic4a52e3cb94320a92f24b1c743dd61e18c6c7b16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150165
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-06-05 16:15:04 +00:00
Brian Wilkerson 4f0ead16eb Clean up the implementation of DartCompletionRequest.libraryElement 
I believe that the original code was written before ResolvedUnitResult
had a direct pointer to the library element. This is a little cleaner
and might possibly be more performant.

Change-Id: I232aa5747c62986f37601f042ce5a1d659d11d19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150222
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-05 15:14:14 +00:00
Jaime Wren fbfb3a29c5 Small optimization in named_constructor_contributor.dart to not reference the libraryElement until we know that the contributor will be used. 
Change-Id: Ic0624568bd8ae4caec6f49c9ea132fcd17230b95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150167
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-06-05 15:03:54 +00:00
Konstantin Shcheglov 42fd487b08 Fix type cast exception in AddExplicitCast. 
Change-Id: If4b3b2d680bf36b77aa60a96ec70d3bc721d1d8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-04 22:25:19 +00:00
Konstantin Shcheglov e36f8a6645 Fix NPE in RemoveConst when implicit 'const'. 
Change-Id: I563ce8bc9283ef8e393b68be7fd2dca0a653fb0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149890
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-04 17:14:17 +00:00
Konstantin Shcheglov 4b9c8db412 Fix cast exception in RemoveUnusedParameter. 
Change-Id: I2905933f3f2aee68505ee7dba1335a87bc8c84a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149888
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-04 17:13:57 +00:00
Konstantin Shcheglov e5b2cb0b02 Fix for filtering name argument suggestions for Cider. 
R=brianwilkerson@google.com, keertip@google.com

Bug: https://buganizer.corp.google.com/issues/157673517
Change-Id: If7b39b9986963f5936a77556d5ac528b71d365e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-04 01:26:10 +00:00
Paul Berry eba7e8b02f Remove the analysis server's DartFixListener.addDetail. 
It is no longer used, since it was only needed by NNBD migration,
which is now in a separate package unrelated to the analysis server.

Change-Id: Ib9b68a65368e9e53c5be454cddfd1b4c01bcffe2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149864
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-06-03 19:43:49 +00:00
Brian Wilkerson 333873fc05 An initial naive approach to integrating the new relevance computations 
and the available declarations support.

The resulting metrics are lower than I'd like them to be, but I suspect
that this will be a reasonable first step toward the final solution.

Change-Id: Ib5d471a9d3c0dafcb2b3687e25b9af21da97854a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149860
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-03 16:29:00 +00:00
Konstantin Shcheglov 5c0c41cc68 Add CiderCompletionResult.performance 
Change-Id: I5df913afc99fc253282611472dc3ff48b9abb8c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149785
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-03 04:20:04 +00:00
Danny Tuppeny 7de8631a4e Retain original LSP registrations so unregistrations use the same IDs 
Change-Id: Ibfce0105e85da65a7cccbc59b918f4845e11d55b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149594
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-02 19:39:33 +00:00
Paul Berry 930cae0f13 Revert "Remove DartSdk.useSummary." 
This reverts commit a2c3ecabce.

Reason for revert: Breaking change to de facto API

Original change's description:
> Remove DartSdk.useSummary.
> 
> R=​brianwilkerson@google.com
> 
> Change-Id: Ifa851f4af47a973d65c528c6d07fcac0a515134b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149495
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I9998bedb74ea940371f18ac7dce42b2f5dcc3b98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149687
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-06-02 15:20:32 +00:00
Danny Tuppeny 44c7650a10 Enable/disable and register/unregister LSP formatter based on client settings 
Change-Id: Ida81ce80795f79feaaa0e4590c19bc1bc24929a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149591
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-02 14:33:51 +00:00
Danny Tuppeny dd7589e5ce Add LSP support for client-side configuration 
Change-Id: I27aa706fd29da00d21fc4177cd455d8259cf9339
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149590
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-02 14:33:51 +00:00
Danny Tuppeny e9125c17c9 Minor refactor of LSP server capabilities+init test 
Change-Id: I1447bac22e09c94b89e67a26f7b7ea98086bd152
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149589
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-02 14:33:51 +00:00
Danny Tuppeny 7accf5ecfc Improve LSP spec regex to catch didChangeConfiguration method 
Change-Id: I8a377bd79b86b59fce0f16c424c372127ff63433
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149584
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-02 14:33:51 +00:00
Brian Wilkerson 16ecc172ef Clean up some quick fixes 
In later conversions I've been making everything possible private. This
cleans up some of the earlier conversions to do the same.

Change-Id: Ib3347a552d171929a3e5255dba906a7b9cc980a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-01 19:11:18 +00:00
Brian Wilkerson 76d736e27b Convert more quick fixes to use the producer pattern 
Change-Id: I049b2a79b57c96fe016d6046b6d905f7f71c9efd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149600
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-01 14:32:54 +00:00