dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4618 Commits

Author SHA1 Message Date
Konstantin Shcheglov 2b7fc8f134 Update FeatureSet to the new rules. 
Bug: https://github.com/dart-lang/sdk/issues/43032
Change-Id: I6c7d7dc56fd0d4edcc3c6f6cc6fb0422316b8f4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159187
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-08-19 18:27:37 +00:00
Brian Wilkerson 11ba8cb2dd Drop the suffix "Change" from class names 
I don't think it adds value, but if you disagree I'll add it to the
class ModifyParameters for consistency.

Change-Id: Ib823dd482d13a2ae9eb355298d3db813a3791fb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159301
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-19 16:59:16 +00:00
Brian Wilkerson 952e9b3eda Remove an unnecessary type annotation and an unnecessary await 
Change-Id: Idbd451680592e3eb1ac9cc1c13ef2e13e1855057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-19 16:33:03 +00:00
Brian Wilkerson 4af6831020 Add support for modifying parameters in a data-driven fix 
Change-Id: I756df3e665c24cbf5131a0aae1c1526c08a5d172
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158940
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-18 14:56:40 +00:00
pq 6e62a0435d bulk fix for unnecessary_brace_in_string_interps 
Change-Id: I47e846994d727d84564ba8f7daf7a8e6334417c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158143
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-17 18:32:59 +00:00
Devon Carew 528238465f Remove the PerformanceTag class and related code. 
Change-Id: I55b39e8fa6de7a3a946333bc84cc4ba0a09ecba8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158524
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-08-16 23:59:42 +00:00
Brian Wilkerson a904d72a02 Minor cleanup found while working on the next change 
Change-Id: Ibdc2552bf373b080507ef139480343561bc74891
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-14 13:13:34 +00:00
pq 4049442385 bulk fix for prefer_iterable_whereType 
Change-Id: I490bb4cc6e03adb606b45a5aae9dbbc763747124
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158364
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-13 00:40:18 +00:00
pq 0673922e22 bulk fix for use_rethrow_when_possible 
Change-Id: I67b4022109c5b4dccaf3d716f9b4328bf5cdc758
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-12 21:19:08 +00:00
Brian Wilkerson f532f023ff Remove the convert_argument_to_type_argument change 
This functionality will be supported by a combination of
add_type_parameter and remove_parameter.

Change-Id: Ie9970cd87963519f3c7c6fd55f46cd0e89fafc9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158344
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-12 19:53:08 +00:00
pq ab7c1e5904 bulk fix for prefer_generic_function_type_aliases 
Change-Id: Iebe4c3a11a37a0dedb0dbaef5c001e848ae29a3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-12 19:27:48 +00:00
Brian Wilkerson eccd2b6e38 Do not suggest mixins when completing in an extends clause 
Change-Id: I924597184ebecfd19494a95240c3e134cbd6575e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158341
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-12 18:33:46 +00:00
Brian Wilkerson d6a901e64d Add an add_type_parameter change to the data driven fix support 
The intention is for this and another change that allows function
parameters to be removed to replace the change_argument_to_type_argument
change.

Change-Id: I521c20262d5a78d3156c2b53babcf5d610028c67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158205
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-12 18:32:16 +00:00
pq e3d30b8331 bulk fix for prefer_if_null_operators 
Change-Id: I392debf03af58d3f597b5f377eaf65d400a5db35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158164
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-12 16:45:20 +00:00
Paul Berry b7d139a626 External variable support: add a notion of external top level variables to the AST and element model. 
In follow-up CLs I will update error reporting logic.

Change-Id: Iee42088beffee3915a2ef6a4c8cb5c1031535d4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158149
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-08-12 15:59:24 +00:00
Konstantin Shcheglov fab57cfeb7 Switch ImportElementsComputer to the new scope. 
R=brianwilkerson@google.com

Change-Id: Ieb07dd810274401dca1492619b83fcc9a2a8d9f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158107
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-08-11 19:30:12 +00:00
pq b989ccf733 bulk fix for unawaited_futures 
Change-Id: I0d53fe9d31b22a08585ea625a5dfbbf5ed5187e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158104
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-11 15:23:49 +00:00
Jonas Hungershausen 94be2fc1f8 [Analyzer] Keep comments when organizing imports 
This change adjusts the organize imports logic, to keep any comments
written in the line above an import statement attached when
organizing the imports, while being smart about what comments to keep.

Closes https://github.com/dart-lang/sdk/issues/42515
Change-Id: Ibcca4f24411ac16bcdb17f66fb6d2b9c45f7d367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157743
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-11 15:03:59 +00:00
Paul Berry d4e4abdef6 External field support: add a notion of external fields to the AST and element model. 
In follow-up CLs I will update error reporting logic.

Change-Id: Id07b861aa117b93e0c869ad0b52c048085706ee6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157801
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-08-10 21:54:54 +00:00
Konstantin Shcheglov 8405d7c8e3 Remove dart2jsHint option, verifier, and tests. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I95b88940c862d463af03e85fcdf0f4bf81c2fbd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157641
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-08-10 19:19:43 +00:00
pq e2a67723ca bulk fix for prefer_final_fields 
Change-Id: Iabfb6aae5186171f4143d23aeb18a124ceab4a0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-10 15:10:41 +00:00
Brian Wilkerson 570a75be7e Further disable the use of the language model 
Change-Id: Ibd7c8bdd549ca17fbf6d53679973665661906a85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157802
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-08 15:47:12 +00:00
pq b0d007a931 bulk fix for type_init_formals 
Change-Id: I8b79e30f2ea811b97caa8fda1297dda054bbcc05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-08 05:04:50 +00:00
Konstantin Shcheglov 940d7effbd Fix for crash in AddMissingEnumCaseClauses. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I0dc8c3158eb4b46247e415ff36c33991598bce9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157861
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-08 01:22:53 +00:00
pq 06cce87374 bulk fix for unnecessary_this 
Change-Id: I61c0173c8fb1fd02d6119412bf925d08126a7a0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-07 22:58:17 +00:00
pq 768fd39317 bulk fix for unnecessary_overrides 
Change-Id: I9cdd051d7dcde5c9a9495e04cf0e7765aac8e714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-07 15:30:55 +00:00
pq b86f267151 bulk fix for unnecessary_lambdas 
Change-Id: Idbf116b5194c122fae59526c3fc70b8a88f1b8a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157494
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-07 03:56:05 +00:00
Brian Wilkerson eaf94c5897 Add a quick fix to make a return type nullable 
Change-Id: I6e400a5d46f9725586cb5f24601013abf7b3ebb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157603
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-06 23:09:19 +00:00
Brian Wilkerson 3bc6345ad6 Add a new fix to replace null-aware operators with the non-null-aware version when the receiver is non-nullable 
Change-Id: Id51ae969fb7d64ca6d3dd7869bb3886417231f3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157473
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-06 20:17:52 +00:00
Brian Wilkerson 967d219827 Display nullability of types in label for change-type-annotation fix 
I wanted to get your feedback on one change like this before updating
other places where we're excluding the nullability from the display
string. Is it reasonable to always display the nullability? (For
example, could this lead to displaying nullability in legacy code?) Is
there any risk of displaying stars (`int*`)?

Change-Id: I5ac78a4b8559c2fbba6b69b1665f36061432726e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157471
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-06 17:44:19 +00:00
Danny Tuppeny 61e0098c92 Add custom LSP method to force reanalyze 
Change-Id: I7d27654ecb68cf674d6521cd6325256a5fabf86c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-08-06 14:51:19 +00:00
Devon Carew 31335728d1 [analyzer] add a new wrap with widget for SizedBox 
Change-Id: Ib94b254ebdff82309d8761c8bb769e15e19d23ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157423
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-06 04:34:26 +00:00
Paul Berry b5a3292260 Abstract field support: add a notion of abstract fields to the AST and element model. 
In a follow-up CL I will update error reporting logic.

Change-Id: I6fd2916c24a531b1f41bd2872301ffec1fdb8722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157382
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-08-06 02:19:46 +00:00
pq 1bb842869f bulk fix for prefer_spread_collections 
Change-Id: I612d9286e8233fe70da8150cf0ba1fa23c9d039b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-05 22:27:19 +00:00
Brian Wilkerson 5f38d69b5e Fix a bug in ExtensionMemberContributor when the extended type is not an interface type (issue 42945) 
Change-Id: Iaa1e6d5c21ecd8d78db68d49bc624d661f23978b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157345
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-05 20:47:59 +00:00
pq 865495fd6e bulk fix for prefer_single_quotes 
Change-Id: Ida0db0118948115042ebac65b4a8a3438a1b09bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-05 20:17:39 +00:00
pq 207b68d5b4 bulk fix for prefer_if_elements_to_conditional_expressions 
Change-Id: I7b76d437d948680729150e7c5eef99efac3567d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-05 19:11:29 +00:00
Konstantin Shcheglov ebd5b622ba Add DartSdk.languageVersion 
Bug: https://github.com/dart-lang/build/issues/2763#issuecomment-666707445
Change-Id: I8232bd395abc9efea0e5c27716450d6a5442b3bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156489
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-04 21:01:09 +00:00
pq e41b4c1357 bulk fix for prefer_is_not_empty 
Change-Id: I9188d344f03823d4ab2d7eb46f134910d271e527
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-04 18:24:49 +00:00
pq af8767e9c8 bulk fix for prefer_is_empty 
Change-Id: I5c4cdb5b87ccbab8e257a45c33fe78d2d41923e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-04 17:17:19 +00:00
pq bd65d441f5 bulk fix for prefer_conditional_assignment 
Change-Id: I45e979bc00da0d8a5a8a257ce0fbd484137c143d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-04 02:01:13 +00:00
pq 43c68d782d bulk fix for prefer_adjacent_string_concatenation 
Change-Id: I873d3531307a9685dc0950aa2fc2119af5abdd0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 22:40:07 +00:00
pq 2bf777ea6e bulk fix for omit_local_variable_types 
Change-Id: I1cc6eb6c7423ded3c5694728271cec52341ff98a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 20:59:31 +00:00
pq 987c9e347c bulk fix for null_closures 
Change-Id: I20e57da5b95868551216b9b0a095e82116c3585e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 19:14:22 +00:00
Brian Wilkerson ac79402072 remove-duplicate-case should not remove statements if there are cases that fall through to them 
Change-Id: I2094335d06e62eeb184f78b14e6028fdb5341dba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156849
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-03 18:50:21 +00:00
pq d427ab510d bulk fix for no_duplicate_case_values 
Change-Id: I4925113c44d5042062ccaabea680a07eedf7bfdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156848
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 18:11:51 +00:00
Brian Wilkerson 4121cf3cb4 Add a quick fix to add a null check operator 
Change-Id: Ie85ab236015057c2cb0255cc1548605e5b01e908
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156783
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-01 01:17:11 +00:00
Konstantin Shcheglov 28c20c0861 Fix for crash in ReplaceCascadeWithDot, simplify it. 
R=brianwilkerson@google.com

Change-Id: I3243203e42856b6a4e65603aafb708473bdfe3fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156701
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-01 00:32:01 +00:00
pq 5553dcbea7 bulk fix for hash_and_equals 
Change-Id: Ifbca2871bbf90f8c1ea3e3ae6dd6ef9e8b5b00c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 22:28:20 +00:00
Brian Wilkerson dc908e076b Do not suggest an explicit cast when the only difference is the nullability of the type 
Change-Id: Ibb20fd5d3ced4ca13bb604bbe42eced16903de9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156723
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-07-31 19:00:20 +00:00