dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

25 Commits

Author SHA1 Message Date
Brian Wilkerson 30d27c6f61 Migrate all remaining server libraries except the library in bin 
Change-Id: I2041763971a85fb8e9530b64ef30d106091c9739
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196547
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-04-24 04:19:22 +00:00
Konstantin Shcheglov e97f1bdbf0 Switch analysis_server to language 2.12, so null safety, but opt-out files. 
This should allow doing partial migration, specifically protocol files,
which are imported by other libraries, but are a small library cycle
that does not import much outside of it.

Change-Id: I904c05d6d5b444ee9a9dbd1f7ada12aabdcc5165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-30 23:39:37 +00:00
Danny Tuppeny 74d8cc9636 Extend analysis server benchmarks to run for LSP too 
Change-Id: Ib6522b8faaa5be272d8f97043a7aa1c345ea182c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-02 22:09:54 +00:00
Mike Fairhurst 1134a0f17c [analysis_server] Remove unused dart:async imports 
Change-Id: I764ee78cb9e31bdb3abaa36ca4754e1fed180311
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161447
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-09-02 17:29:52 +00:00
Konstantin Shcheglov 58b6f40c73 Issue 42797. Understand in legacy libraries that a function returning Never (in Null Safety library) never returns. (reland) 
Initial: https://dart-review.googlesource.com/c/sdk/+/155500
Reverted: https://dart-review.googlesource.com/c/sdk/+/155540

Bug: https://github.com/dart-lang/sdk/issues/42797

Change-Id: I5f0f1df594ac678718f347ee80b1764f971e42e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-23 00:01:12 +00:00
Brian Wilkerson 8969b1839c Enable omit_local_variable_types in analysis_server 
Change-Id: I7e5c13d40fd276854601681fc84be321e6031b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-30 03:58:44 +00:00
Brian Wilkerson 486467c02d Bulk sort of a subset of the files in analysis_server 
Change-Id: Id811d37ad565c6f3c0ed508ae2b42e22469cbd3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139830
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:13:14 +00:00
Brian Wilkerson 32ce9c7872 Enable prefer_collection_literals in three packages 
Other than the following changes, all of the changes were made by dartfix:
- the analysis options files
- one line to enable the fix through dartfix (missed in an earlier CL)
- three places where a bug in the fix produced invalid code (issue and fix TBD)

Change-Id: If8660700792561805f4d1c96ccecd81abcebfeb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131209
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-11 20:39:02 +00:00
Brian Wilkerson 91d6e1a0a7 Enable annotate_overrides in several packages 
Other than analysis_server/test/analysis/notification_overrides_test.dart,
which had a naming conflict, all of the changes were made using dartfix.

Change-Id: I911dd75dcdee00420caa48724125e86d47c8857d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 21:31:40 +00:00
Brian Wilkerson 4043a6fce3 Remove unnecessary uses of new in analysis_server 
Other than analysis_options.yaml, all of the changes were from running
dartfix.

Change-Id: I92411642f12a00fc6bd0bfd24dd60fe67f0fed16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 19:01:51 +00:00
Devon Carew 81679a2ab4 [analyzer] reduce the default number of times we repeat a benchmark 
Change-Id: Ie9a9b0d58464c6b78e3a707975fda773e043d403
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121804
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-15 22:52:56 +00:00
pq 52abcd3dd2 apply prefer_equal_for_default_values 
Change-Id: I9b6fd3ee18ec834a5db3d0d25455b6db9ea4fbe2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108664
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-07-10 19:31:40 +00:00
Brian Wilkerson 47e988b781 Clean up the remaining copyright notices in analysis_server 
Change-Id: Iee3110f92ab0f24312ddd1eff407d2229f895321
Reviewed-on: https://dart-review.googlesource.com/c/89101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-11 15:38:56 +00:00
Konstantin Shcheglov 1f52372bfa Remove CFE integration from analyzer, analysis_server, and analyzer_cli. 
AnalysisDriverResolutionTest is partially updated, about 30 failing
tests added. I will get back to it in a following CL, it is not
directly CFE integration, but updated understanding how we want to
resolve. For example we don't need types for non-expression identifiers.

Change-Id: I3daddbb6c66ffad7a726f3313a1199fd7387aa04
Reviewed-on: https://dart-review.googlesource.com/71883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-08-29 13:46:45 +00:00
Brian Wilkerson 6a6e7abfc6 Clean up some warnings in the server code base 
Change-Id: I762fcc704fe0fa0547bbbc347eb248853d358121
Reviewed-on: https://dart-review.googlesource.com/67842
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-01 21:09:45 +00:00
Devon Carew 8b1030cc7e Fix a runtime type issue in pkg/analysis_server/benchmark/benchmarks.dart. 
Change-Id: I7d73b4cc7c9d43fa9d58d4e2efd7c534c88fbbc7
Reviewed-on: https://dart-review.googlesource.com/64763
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-12 19:11:44 +00:00
Devon Carew 17b53a2835 Test out no_implicit_casts on the analyzer source base. 
Change-Id: I4eb2414d7d9bbe21883c9e5e8eca10f2eaafb465
Reviewed-on: https://dart-review.googlesource.com/62725
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-06-28 02:20:43 +00:00
Devon Carew 1ab4cee181 Add a benchmark for running flutter analyze --flutter-repo against flutter head. 
Change-Id: I0e4cb66808126b37b43edede43ec7fdd2bbec45a
Reviewed-on: https://dart-review.googlesource.com/51042
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-04-12 21:01:36 +00:00
Brian Wilkerson 602a8c2a7b Clean up usage of deprecated constants 
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-09 01:02:49 +00:00
Jaime Wren cd878bc433 Create the new flag --use-cfe in the analyzer, analysis server and analyzer_cli and migrate the old behavior of --preview-dart-2 to --use-cfe. The --preview-dart-2 flag is now a no-op, with functionality coming soon. 
See https://github.com/dart-lang/sdk/issues/31640

Change-Id: I2db2e7ef6a324cbd5d369b807e331495fed167df
Reviewed-on: https://dart-review.googlesource.com/33121
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2018-01-08 22:37:05 +00:00
Devon Carew c3abeef304 Add a --verbose option to the analysis server benchmarks. 
Bug:
Change-Id: I5cadfacc8f2fcb5b7f0c1c140b2b08b60e65fb6c
Reviewed-on: https://dart-review.googlesource.com/25221
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-01 16:20:31 +00:00
Devon Carew ee1404e91a Allow analysis server benchmarks to run with --preview-dart-2. 
Bug:
Change-Id: Ifb9a5c596d3ad63012177cfb4e0bd7b107e78aff
Reviewed-on: https://dart-review.googlesource.com/20941
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2017-11-15 07:37:51 +00:00
Devon Carew a714187898 Tweaks to the analysis server benchmarks. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2998813002 .
 2017-08-10 12:35:06 -07:00
Devon Carew e164b2a820 ignore errors deleting the analysis driver cache. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2992203002 .
 2017-08-02 10:33:00 -07:00
Devon Carew f383c17bc2 Redo our benchmarks; add a benchmark/benchmarks.dart tool. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2986293002 .
 2017-08-02 08:07:38 -07:00