Commit Graph

1453 Commits

Author SHA1 Message Date
Alexander Thomas 95f55ab22b [co19] Roll co19 to bbba568b780a48c69a1de8ad1a8527a37cf71fad
2020-07-07 sgrekhov@unipro.ru Fixes 786. LibTest\async\Zone migrated to null safety
2020-07-07 sgrekhov@unipro.ru More leftFutureOr tests added and also generator migrated to null safety
2020-07-06 sgrekhov@unipro.ru Debug output removed and issue number added
2020-07-06 sgrekhov@unipro.ru Language/Statements tests fixed after tryjob run
2020-07-06 sgrekhov@unipro.ru Fixes 784. LibTest\async\Timer migrated to null safety
2020-07-06 sgrekhov@unipro.ru Fixes 783. LibTest\async\StreamTransformer migrated to null safety
2020-07-06 sgrekhov@unipro.ru Fixes 782. LibTest\async\StreamIterator migrated to null safety
2020-07-03 sgrekhov@unipro.ru Fixes 780. StreamConsumer, StreamController and StreamSink tests migrated to null safety
2020-07-03 sgrekhov@unipro.ru Make getter and setter to have the same type
2020-07-02 sgrekhov@unipro.ru Return an expected type from the test

Change-Id: I746333ddb8505f62041da8ec4a80ba223cfe5594
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153353
Reviewed-by: William Hesse <whesse@google.com>
2020-07-07 11:06:20 +00:00
Alexander Thomas 2c98bd5bbf [benchmarks] Update benchmark_harness to null safe version
2020-06-25 athom@google.com Merge pull request 49 from athomas/opt-in
2020-06-23 athom@google.com Migrate result emitter test
2020-06-23 athom@google.com Add dependency overrides for dev dependencies
2020-06-23 athom@google.com Update travis config to test with non-nullable enabled
2020-06-23 athom@google.com Enable non-nullable experiment in analysis options
2020-06-25 athom@google.com Opt-out examples/
2020-06-23 athom@google.com Update SDK dependency to 2.9.0-1
2019-12-26 kevmoo@users.noreply.github.com Fix latest pedantic lints – and a few more (47)
2019-11-08 pq@users.noreply.github.com tidy example (46)

Change-Id: Iabb37217518f437eba63d605735286661f45abc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153356
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2020-07-07 10:54:04 +00:00
Jonas Termansen 749d55da18 Roll benchmarks-internal 88af52754f27..d3eff2adacd3
d3eff2adacd3b0378bf3027ceb6caff0df669280 https://dart-internal-review.googlesource.com/c/benchmarks-internal/+/1882

R=athom@google.com

Change-Id: I4694fef4a689a2637565192628b352775b23b32a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153354
Auto-Submit: Jonas Termansen <sortie@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2020-07-07 10:48:29 +00:00
Tess Strickland 06cb010247 Revert "Add unawaited to package:meta"
This reverts commit 0d44449aaa.

Reason for revert: Breaks Flutter HHH and the Dart->Flutter roll.

Original change's description:
> Add unawaited to package:meta
> 
> Change-Id: I09df4989591327bd4d148e73a5887b900902576c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152680
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Jake Macdonald <jakemac@google.com>

TBR=brianwilkerson@google.com,jakemac@google.com

Change-Id: I71f491bccc37508a24b7f6f9d051ed914bafeccd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153351
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
2020-07-07 08:14:51 +00:00
Clement Skau 0ce83987d6 Reland "[SDK] Adds an SDK hash to kernels and the VM."
Note: This is a reland of https://dart-review.googlesource.com/c/sdk/+/150343

Adds a new SDK hash to kernels and the VM which is optionally checked
to verify kernels are built for the same SDK as the VM.
This helps catch incompatibilities that are currently causing
subtle bugs and (not so subtle) crashes.

The SDK hash is encoded in kernels as a new field in components.
The hash is derived from the 10 byte git short hash.

This new check can be disabled via:
  tools/gn.py ... --no-verify-sdk-hash

This CL bumps the min. (and max.) supported kernel format version,
making the VM backwards incompatible from this point back.

This also bumps the min. and current ABI version.

Bug: https://github.com/dart-lang/sdk/issues/41802
Change-Id: I2f85945045a603eb9dcfd1f2c0d0d024bd84a956
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152802
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2020-07-07 06:08:20 +00:00
Regis Crelier 315ecf2606 Roll benchmarks-internal to 88af52754f272e7a4c5737b7e003c2ed9e8a754f
88af527 Fix typo in previously migrated NBody and NBodySIMD benchmarks
e86edcd Migrate TypedDataCopy benchmark to NNBD
dd8be12 Clean lints in BinarySize benchmark.
ab00e7f Don't duplicate DeltaBlue and Meteor for compilation benchmarking.
05c73ea Migrate Meteor benchmark to NNBD
52ba4cc Migrate NBody and NBodySIMD benchmarks to NNBD
4253c9f Migrate MD5, SHA1, and SHA256 to NNBD
e49b588 Migrate the WordSolver and WordSolverIdentity benchmarks.
ff27bee Migrate the MicroClosure benchmark.

Change-Id: I87b8263c8b150a8f3bdce8cc62a76f956d096473
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153390
Commit-Queue: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-07-07 00:41:50 +00:00
Brian Wilkerson 0d44449aaa Add unawaited to package:meta
Change-Id: I09df4989591327bd4d148e73a5887b900902576c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152680
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2020-07-06 21:57:52 +00:00
Jacob MacDonald 1b1fcc0618 update package:test in the sdk
- Fixes an upcoming name conflict with package:meta.

Change-Id: Ia9520a794086a652f2d7e1e32e04899cdf330910
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153380
Commit-Queue: Jake Macdonald <jakemac@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Jake Macdonald <jakemac@google.com>
2020-07-06 16:41:51 +00:00
Jonas Termansen b3c9e89028 Roll benchmarks-internal ee36753c0b4b..e6a5aa28c884
e6a5aa28c884a4124977a37eb8a2e7822ee88ccc https://dart-internal-review.googlesource.com/c/benchmarks-internal/+/1703

R=zichangguo@google.com

Change-Id: If73e4f976a32844151cce0335c44cb998d579d09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153210
Auto-Submit: Jonas Termansen <sortie@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
Reviewed-by: Zichang Guo <zichangguo@google.com>
2020-07-06 03:15:30 +00:00
Jonas Termansen 0ec020cd86 Roll benchmarks-internal 2d9d76e04ce0..ee36753c0b4b
3206349ce765900dff3f4b349d62758f69f5372c https://dart-internal-review.googlesource.com/c/benchmarks-internal/+/1780
b15e9f92787fb8c173c6fcb9ac3f132ac79759a1 https://dart-internal-review.googlesource.com/c/benchmarks-internal/+/1760
dbf67bb5ded52be36c47a4431903b4f652090299 https://dart-internal-review.googlesource.com/c/benchmarks-internal/+/1801
e49ce2441927d3ed608b3cc1b272d27cd5d388d6 https://dart-internal-review.googlesource.com/c/benchmarks-internal/+/1804
ee36753c0b4b9689c3c15763ed4a78d42cd940f3 https://dart-internal-review.googlesource.com/c/benchmarks-internal/+/1803

R=askesc@google.com, regis@google.com, rmacnak@google.com

Change-Id: I08d7ce0472f1b72384c4babc5861190f1f01dd87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153201
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Jonas Termansen <sortie@google.com>
2020-07-03 15:16:27 +00:00
Alexander Thomas c190fc3a31 [co19] Roll co19 to 4035c66f0cacb70064395473cb54d810c046c225
2020-07-02 irina.arkhipets@gmail.com Merge remote-tracking branch 'origin/master'
2020-07-02 irina.arkhipets@gmail.com Fixed issue 779: Utils/tests/Expect tests adopted for nnbd.
2020-07-02 sgrekhov@unipro.ru Fixes 777. LibTest\async\Stream migrated to null safety
2020-07-02 sgrekhov@unipro.ru Relative import removed from multitests
2020-07-02 irina.arkhipets@gmail.com Fixed issue 778: Error checks for Future flattening corrected.
2020-06-30 sgrekhov@unipro.ru Fixes 776. LibTest\async\Future migrated to null safety
2020-06-29 irina.arkhipets@gmail.com Fixed issue 390: LanguageFeatures/regression tests updated and adopted for nnbd, missing Issue tests added, new tests added.
2020-06-29 sgrekhov@unipro.ru Fixes 775. LibTest\async\EventSink migrated to null safety
2020-06-29 sgrekhov@unipro.ru Fixes 774. LibTest\async\Completer migrated to null safety
2020-06-29 sgrekhov@unipro.ru Fixes 773. LibTest\math\Rectangle migrated to null safety
2020-06-29 sgrekhov@unipro.ru Fixes 772. LibTest\math\Point migrated to null safety
2020-06-29 sgrekhov@unipro.ru Minor codestyle changes
2020-06-29 sgrekhov@unipro.ru Fixes 771. LibTest\math\MutableRectangle migrated to null safety
2020-06-29 irina.arkhipets@gmail.com Fixed issue 770: LanguageFeatures/Super-bounded-types tests adopted for nnbd.
2020-06-29 sgrekhov@unipro.ru After tryjob run Mixin and Overview tests fixed
2020-06-28 irina.arkhipets@gmail.com Fixed issue 607: New new Instantiate-to-bounds/typedef tests with null safety checks added.
2020-06-28 irina.arkhipets@gmail.com Merge remote-tracking branch 'origin/master'
2020-06-28 irina.arkhipets@gmail.com Fixed issue 607: New checks added to static i-2-b tests.
2020-06-26 sgrekhov@unipro.ru Fixes 769. LibTest\math migrated to null safety
2020-06-26 irina.arkhipets@gmail.com Fixed issue 763: Language/Varuables tests adopted to null-safety.
2020-06-26 irina.arkhipets@gmail.com Issue 607: Tests corrected according to the Dart SDK Issue 42470 evaluation
2020-06-26 sgrekhov@unipro.ru Fixes 768. Language\Types\Type_Aliases migrated to null safety
2020-06-25 irina.arkhipets@gmail.com Fixed issue 607: instantiate-2-bounds tests updated, more checks added for nun-functional typedefs
2020-06-25 irina.arkhipets@gmail.com Fixed issue 607: LanguageFeatures/Instantiate-to-bounds/nonfunction_typedef tests updated, new tests added.

Failures will be triaged on:
https://github.com/dart-lang/co19/issues/781

Change-Id: I3295e6e707ab20f04bf76406d47d89ac37d6c6ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153143
Reviewed-by: William Hesse <whesse@google.com>
2020-07-02 14:38:47 +00:00
Nate Bosch 800b24a336 Update to latest package:yaml
Change-Id: I23f170e78116b66634da74a486d08816c240b983
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152905
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2020-07-01 21:33:34 +00:00
Nate Bosch adb08da0da Update to latest async and bazel_worker
Rename from `_tag` to `_rev` since they are now pinned by SHA.

Change-Id: I1a325be0a48b12624281bc0e8b5b783e92e54585
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152984
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2020-07-01 21:12:14 +00:00
Jacob MacDonald 18d5c1afa8 update typed_data to the nnbd version
Change-Id: Ic2483271fd97c31cd7758b4e0f0877c964b359a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152902
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-07-01 20:53:31 +00:00
Jacob MacDonald 51ac86c753 update collection dep, and add flutter-engine patch
Change-Id: I5e8b0eb2b161b71734feebb6e13d039082ad6bc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152860
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
2020-07-01 20:50:38 +00:00
Nate Bosch 25d6c349b9 Update to latest package:stack_trace
Fixes a bug parsing `data:` URIs from VM style stack frames.

Change-Id: I16ef95f0b7f0a7c97b9d30bf38ae766f3702f4c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152981
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2020-06-30 19:01:44 +00:00
Regis Crelier 892f38259f Roll benchmarks-internal to 2d9d76e04ce0a997ad3eb4e5e320e89e727af8a5
Change-Id: I1b017ee2e61e9c58ed57de0e9a38d82874d65637
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152924
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2020-06-30 00:26:44 +00:00
Michael Thomsen ff114a9828 Roll stagehand package
This is to pick up new versions, and https://github.com/dart-lang/stagehand/pull/659

Change-Id: If7aca9d2eff9d4567de9fbf75c6853be094be2f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152480
Auto-Submit: Michael Thomsen <mit@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
2020-06-29 11:49:22 +00:00
Regis Crelier 871f0ee31e Roll benchmarks-internal to a7f7c387fa877a5ea060a13c5c3aa1ca6aed2461
Change-Id: I81c7042cdc2aacd0db535d5ebe72a28beef8edfe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152724
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2020-06-27 01:04:48 +00:00
asiva bb8d145616 Revert "[SDK] Adds an SDK hash to kernels and the VM."
This reverts commit edde575dcd.

Reason for revert: Breaks the Dart to Flutter roll and golem

Original change's description:
> [SDK] Adds an SDK hash to kernels and the VM.
>
> Adds a new SDK hash to kernels and the VM which is optionally checked
> to verify kernels are built for the same SDK as the VM.
> This helps catch incompatibilities that are currently causing
> subtle bugs and (not so subtle) crashes.
>
> The SDK hash is encoded in kernels as a new field in components.
> The hash is derived from the 10 byte git short hash.
>
> This new check can be disabled via:
>   tools/gn.py ... --no-verify-sdk-hash
>
> This CL bumps the min. (and max.) supported kernel format version,
> making the VM backwards incompatible from this point back.
>
> Bug: https://github.com/dart-lang/sdk/issues/41802
> Change-Id: I3cbb2d481239ee64dafdaa0e4aac36c80281931b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150343
> Commit-Queue: Clement Skau <cskau@google.com>
> Reviewed-by: Jens Johansen <jensj@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,jensj@google.com,cskau@google.com

Change-Id: I34cc7d378e2babdaaca4d932d19c19d0f35422fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/41802
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152703
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2020-06-26 18:54:17 +00:00
Jacob MacDonald 04dd5edc6a update fixnum to nnbd version
Bug:https://github.com/dart-lang/sdk/issues/42274
Change-Id: I18df7926fc8b767ab6ff6d3505f160147217a00f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152605
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
2020-06-26 17:39:10 +00:00
Clement Skau edde575dcd [SDK] Adds an SDK hash to kernels and the VM.
Adds a new SDK hash to kernels and the VM which is optionally checked
to verify kernels are built for the same SDK as the VM.
This helps catch incompatibilities that are currently causing
subtle bugs and (not so subtle) crashes.

The SDK hash is encoded in kernels as a new field in components.
The hash is derived from the 10 byte git short hash.

This new check can be disabled via:
  tools/gn.py ... --no-verify-sdk-hash

This CL bumps the min. (and max.) supported kernel format version,
making the VM backwards incompatible from this point back.

Bug: https://github.com/dart-lang/sdk/issues/41802
Change-Id: I3cbb2d481239ee64dafdaa0e4aac36c80281931b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150343
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2020-06-26 13:35:42 +00:00
William Hesse 98324c95d5 Roll benchmarks-internal to 15a6634bd60ed0b937ed5dbc874cba2da9865514
Change-Id: Ice1ed6cd9f4038d34061e62e177adb8ce6e0c668
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152643
Reviewed-by: Karl Klose <karlklose@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2020-06-26 10:59:02 +00:00
Alexander Thomas bcd2708843 [co19] Roll co19 to e674d8ccb29250fa5d7ac886fa98c5962543fffc
2020-06-25 sgrekhov@unipro.ru Fix test to not to fail on dart2js
2020-06-25 sgrekhov@unipro.ru Language/Libraries_and_Scripts tests fixed and issue numbers added
2020-06-25 sgrekhov@unipro.ru Fixes 767. Language\Types\Type_dynamic migrated to null safety
2020-06-25 sgrekhov@unipro.ru Fixes 766. Language\Types\Type_Void migrated to null safety
2020-06-25 sgrekhov@unipro.ru Fixes 765. Language\Types\Static_Types migrated to null safety
2020-06-25 sgrekhov@unipro.ru Fixes 764. Language\Types\Parameterized_Types migrated to null safety
2020-06-24 sgrekhov@unipro.ru Fixes 759. Language\Types\Interface_Types migrated to null safety
2020-06-24 irina.arkhipets@gmail.com Fixed issue 763: Language\Variables\Evaluation_of_Implicit_Variable_Getters tests migrated to null-safety
2020-06-24 irina.arkhipets@gmail.com Fixed issue 762: Language\Statements\Yield_and_Yield_Each\Yield_Each tests updated for nnbd
2020-06-24 irina.arkhipets@gmail.com Fixed issue 762: Language\Statements\Yield_and_Yield_Each\Yield tests adopted for nnbd
2020-06-24 irina.arkhipets@gmail.com Fixed issue 761: Language\Statements\While tests adopted for nnbd
2020-06-24 irina.arkhipets@gmail.com Fixed issue 760: Language\Statements\Try tests adopted for nnbd
2020-06-24 irina.arkhipets@gmail.com Fixed issue 758: Language\Statements\Switch tests adopted for nnbd

Change-Id: I1488f026bab1d061af5a3aa91d5aa7c4df8f0662
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152522
Reviewed-by: William Hesse <whesse@google.com>
2020-06-26 09:09:32 +00:00
Regis Crelier 63cf56d925 Roll benchmarks-internal to 02695da98bcf006b95630d3c386f4169d7ec4ecf
Ignore invariant_booleans lint rule when analyzing benchmarks.

Change-Id: I6071d3c1407e9c67689204e4ceb50cc1c0c8e109
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152598
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2020-06-26 01:56:03 +00:00
Alexander Aprelev d33e51df3c [build] Support --clang when building dart sdk on Windows.
It relies on flutter copy of clang distribution, same one that is used to build flutter/engine.

It addressed several deprecated warnings from clang compiler for functions like strdup, unlink, etc.

It allows few warnings still since they are triggered in third_party sources.

Change-Id: Ieb13792c011438d46dbbc0fa030e1b5e4ea14315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142704
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2020-06-25 03:36:41 +00:00
Alexander Markov c1df6c391d Roll benchmarks-internal to e18a31671508f878c7a04b22415de22dfea29f6c
Change-Id: I514034c526a41d701016c78131f614128da20b9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152425
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2020-06-24 22:38:28 +00:00
Alexander Thomas d8eb844e5d [infra] Add browsers to the DEPS
The browser used by the test infrastructure are currently pulled in from
the recipes rather than via gclient. This is the first step to remove
that duplicated functionality and will enable all builders to that need
browser to get them.

The browsers aren't downloaded by default and not available on all
platforms. It is not recommend to use these browsers for local testing,
because they may interfere with a user's installation.

https://github.com/dart-lang/sdk/issues/42417

Change-Id: I5df72c3b43f7b49cf90200d47a089714c91b5b3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152340
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2020-06-24 14:02:40 +00:00
Alexander Thomas 3f1aa79bfc [co19] Roll co19 to bfa5ab1e3a0be81899760af9c24ab734348114a5
2020-06-24 irina.arkhipets@gmail.com Fixed issue 757: Language\Statements\Return tests adopted to nnbd
2020-06-24 irina.arkhipets@gmail.com Fixed issue 756: Language\Statements\Rethrow tests migrated to null safety
2020-06-24 irina.arkhipets@gmail.com Fixed issue 755: Language\Statements\Local_Function_Declaration adopted for null-safety
2020-06-24 irina.arkhipets@gmail.com Fixed issue 754: Language\Statements\Local_Function_Declaration tests adopted for nnbd
2020-06-24 irina.arkhipets@gmail.com Fixed issue 607: New tests with null-safety cjecks added in i-2-b.
2020-06-24 irina.arkhipets@gmail.com Fixed issue 0: Tests improved
2020-06-24 irina.arkhipets@gmail.com Fixed issue 607: Additional null-safety checks added to Simple-bounds tests
2020-06-24 irina.arkhipets@gmail.com Fixed issue 607: New Simple-bounds tests with null safety checks added
2020-06-23 irina.arkhipets@gmail.com Issue tags for SDK Issue 42446 added
2020-06-23 irina.arkhipets@gmail.com Fixed issue 388: New simple-bounds tests with nnbd checks adde, tests updated
2020-06-23 sgrekhov@unipro.ru Fixes 753. Language\Types\Function_Types migrated to null safety
2020-06-23 sgrekhov@unipro.ru Fixes752.  Language\Types\Dynamic_Type_System migrated to null safety
2020-06-23 irina.arkhipets@gmail.com Fixed issue 388: new LanguageFeatures/Simple-bounds tests which checks null-dafety added.
2020-06-23 sgrekhov@unipro.ru Generics tests fixed

Change-Id: Ib36dc449287780e44895adb3357b2bfef284ec3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152146
Reviewed-by: William Hesse <whesse@google.com>
2020-06-24 10:26:09 +00:00
Regis Crelier f4047fc96f Roll benchmarks-internal to cb9ae13486f5dc0ec8d80694dc6b8a50dc4ac7d1
Change-Id: I3834afd340d66cfea472f4de3b3cb7204d8e1431
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152207
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2020-06-24 00:37:56 +00:00
Tess Strickland 6d1f8f2465 Roll benchmarks-internal to 8a7ce78ada809beb62fcfdf2f8e7a400a7bc5ed3
Change-Id: I08d9f9a37c13a983f5396204e0392d5b97b45b56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152010
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2020-06-23 15:24:11 +00:00
Alexander Thomas f28fcfea2b [co19] Roll co19 to 443e4b3cd3953e9d8feef85bb712a93f6dac0858
2020-06-22 irina.arkhipets@gmail.com Fixed issue 646: typo corrected
2020-06-22 irina.arkhipets@gmail.com Fixed issue 646: Language/Generics tests updated, missing Issue tags added.
2020-06-22 sgrekhov@unipro.ru Fixes 733. Check only the end of the pingInterval.toString()
2020-06-22 sgrekhov@unipro.ru Fixes 741.Language\Reference\Lexical_Rules\Reserved_Words tests migrated to null safety
2020-06-22 irina.arkhipets@gmail.com Fixed issue 646: Lanhuage/Generics/Superbounded_types tests updated, nissing Issue tags added.
2020-06-22 sgrekhov@unipro.ru Fixes 733. Expect two digits for hours in to String()

Change-Id: Id15731a4d75826ab621d66009653df03cec025da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151850
Reviewed-by: William Hesse <whesse@google.com>
2020-06-23 10:30:50 +00:00
Regis Crelier 03af7314cc Roll benchmarks-internal to dff8b1878dcb8bb861937bd5bea07d03dcf08251
Change-Id: Ia64f88fca697864539ed490fa69a08b438e53713
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151984
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2020-06-22 21:24:37 +00:00
Alexander Thomas 752278b550 [infra] Update checked-in SDKs to 2.9.0-18.0.dev
Change-Id: I218efac80364fa178779eb27d837d7a829301755
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152000
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2020-06-22 18:49:26 +00:00
Jake Macdonald 5f0a94bc12 Revert "Update fixnum to the migrated version and add it to the allowed experiments file"
This reverts commit cb1105af48.

Reason for revert: Broke flutter-engine-linux bot https://ci.chromium.org/p/dart/builders/ci.sandbox/flutter-engine-linux/11048?

Original change's description:
> Update fixnum to the migrated version and add it to the allowed experiments file
> 
> This package is used in benchmarking and we need a migrated version in order
> to run benchmarks with null safety enabled.
> 
> Change-Id: I916331a03006d6b5d3f0d0bb590012376e410c24
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150170
> Commit-Queue: Jake Macdonald <jakemac@google.com>
> Reviewed-by: Stephen Adams <sra@google.com>

TBR=sortie@google.com,jakemac@google.com,sra@google.com

Change-Id: I4536f395a877c245140d53f7a9463f2ed156d012
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151926
Reviewed-by: Jake Macdonald <jakemac@google.com>
Auto-Submit: Jake Macdonald <jakemac@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
2020-06-22 18:21:58 +00:00
Jacob MacDonald cb1105af48 Update fixnum to the migrated version and add it to the allowed experiments file
This package is used in benchmarking and we need a migrated version in order
to run benchmarks with null safety enabled.

Change-Id: I916331a03006d6b5d3f0d0bb590012376e410c24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150170
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2020-06-22 15:50:25 +00:00
David Morgan 50fbe74ac3 Upgrade stack_trace from 1.9.3 to 07569831f17844ef90214a179db211954a7f7324 (1.9.5-dev in pubspec.yaml).
Change-Id: Ica27386447b9d19b31bcd0eafb1e00f213ca3c2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151841
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
2020-06-19 18:13:23 +00:00
Regis Crelier 7e72c9ae7e Roll benchmarks-internal to 29176ec025667ab7acb9dbb93b3e7d429c6c2c6f
Change-Id: I6958edb197ebb2a0390fe9883dddb93d9446f1ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151860
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2020-06-19 18:05:23 +00:00
Alexander Thomas 2716c73110 [co19] Roll co19 to f3466a4fc3d201e2ca4da7214560718344aea87c
2020-06-19 sgrekhov@unipro.ru Generics and Functions test fixed after tryjobs run
2020-06-19 irina.arkhipets@gmail.com Needless reviewer tags removed.
2020-06-19 irina.arkhipets@gmail.com Fixed issue 750: Language\Statements\If tests adopted for nnbd
2020-06-18 irina.arkhipets@gmail.com Fixed issue 749: Language\Statements\For tests adopted for null-safety.
2020-06-18 irina.arkhipets@gmail.com Fixed issue 748: Language\Statements\For\For_Loop tests adopted for null-safety.
2020-06-18 irina.arkhipets@gmail.com Fixed issue 747: Language\Statements\For\For_in tests adopted for null-safety.
2020-06-18 irina.arkhipets@gmail.com Fixed issue 746: Language\Statements\Expression_Statements tests adopted for null-safety.
2020-06-18 irina.arkhipets@gmail.com Fixed issue 735: typo in compile tag corrected
2020-06-18 irina.arkhipets@gmail.com Fixed issue 745: Language\Libraries_and_Scripts tests adopted for null-safety.
2020-06-18 irina.arkhipets@gmail.com Fixed issue 744: Language\Statements\Continue tests adopted for null-safety.
2020-06-18 irina.arkhipets@gmail.com Fixed issue 743: Language\Statements\Break tests adopted for null-safety.
2020-06-18 irina.arkhipets@gmail.com Fixed issue 742 Language\Statements\Assert tests adopted for null-safety.
2020-06-18 irina.arkhipets@gmail.com Test library corrected according to the Dart SDK Issue 42393.
2020-06-18 irina.arkhipets@gmail.com Fixed issue 740: Language\Libraries_and_Scripts tests adopted for null-safety.
2020-06-18 irina.arkhipets@gmail.com Fixed issue 739: Language\Libraries_and_Scripts\URIs tests adopted for null-safety.
2020-06-18 irina.arkhipets@gmail.com Fixed issue 738: Language\Libraries_and_Scripts\Scripts tests adopted for null-safety.
2020-06-18 irina.arkhipets@gmail.com Fixed issue 724: Language\Libraries_and_Scripts\Parts tests adopted for null-safety.
2020-06-18 sgrekhov@unipro.ru Fixes 737. Language\Reference\Lexical_Rules\Comments migrated to null safety
2020-06-18 irina.arkhipets@gmail.com Fixed issue 735: Compile error tags corrected for cycle error.
2020-06-18 sgrekhov@unipro.ru Change Language tests according to the issues resolution
2020-06-17 sgrekhov@unipro.ru Fixes 736. Language\Reference\Operator_Precedence migrated to null safety
2020-06-17 sgrekhov@unipro.ru Fix Language tests after tryjobs run.
2020-06-16 sgrekhov@unipro.ru Fixes 734. Language\Reference\Lexical_Rules migrated to null safety
2020-06-16 sgrekhov@unipro.ru Fixes 732. Language\Overview\Scoping migrated to null safety
2020-06-16 sgrekhov@unipro.ru Classes/Constructors tests fixed to not to fail on NNBD
2020-06-15 sgrekhov@unipro.ru Fixes 731. Language\Overview\Privacy tests migrated to null-safety
2020-06-15 sgrekhov@unipro.ru 730. Fix mixin super invocation test
2020-06-11 sgrekhov@unipro.ru Fixes 730. LanguageFeatures/Super-mixins migrated to null safety

Change-Id: Id33ff14a06e2c3037cfb64385aec2aaaabe779fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151823
Reviewed-by: William Hesse <whesse@google.com>
2020-06-19 14:26:46 +00:00
Regis Crelier bcb3a71601 Roll benchmarks-internal to 4fa1b8ae571aaf1762346a3e0e893aca643af030
Change-Id: Ib2e696bacbc87575a9737f45644d824b7e1144a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151804
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2020-06-19 11:22:25 +00:00
Regis Crelier a92a7ec8fc Roll benchmarks-internal to 478f5a8be0bad2b1bc3c1c9cf150486ec77516e1
Change-Id: Ia020965d0fbae6f7a26bc6d43678182a6e76fb49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151801
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2020-06-18 20:44:02 +00:00
Martin Kustermann 2ab8dbd689 Roll third_party/icu to @bbf7f88a24b1
This pulls in two changes which fixes fuchsia build [0] and windows
chromium build [1].

[0] https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2248560
[1] https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2250687

Closes https://github.com/dart-lang/sdk/issues/42230

Change-Id: Ia0be5454e8884cf0753e8cdc7f7cb7ae03c7681d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151530
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2020-06-18 15:41:30 +00:00
Liam Appelbe 764e72800f Reland "Revert "Add an --os=fuchsia option to build.py:""
This reverts commit d39d4d0d55.

Reason for revert: Relanding with fix

Change-Id: I6d6911b6cdc578a3b576b237db94c7f1db9824b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151600
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
2020-06-18 00:24:31 +00:00
Alexander Thomas b2d41ab0a2 [infra] Update checked-in SDKs to 2.9.0-16.0.dev
https://github.com/dart-lang/sdk/issues/42274

Change-Id: I3a566f14482de29e9aa499d8a8e7c4281c30fbd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151391
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2020-06-16 16:51:20 +00:00
George Wright d39d4d0d55 Revert "Add an --os=fuchsia option to build.py:"
This reverts commit 4ce18ab931.

Reason for revert: bad merge, caused build breakages in flutter/engine

Original change's description:
> Add an --os=fuchsia option to build.py:
> 
> tools/build.py --os=fuchsia runtime create_sdk
> 
> This is analogous to --os=android. It cross compiles from Linux x64 to
> Fuchsia.
> 
> A lot of the build rules are just slightly different between the existing
> Fuchsia build rules used by Flutter, and the ones added by GN SDK. For
> example "$fuchsia_sdk_root/pkg:fdio" is now "$fuchsia_sdk_root/pkg/fdio".
> So to support this I had to add a new variable, using_fuchsia_gn_sdk,
> analogous to using_fuchsia_sdk. Flutter will need to set this to false.
> 
> Change-Id: Ief275d65f30a42a801607de93cf2d27a1fe825dd
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150689
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,asiva@google.com,liama@google.com,kaushikiska@google.com,matthewcarroll@google.com

Change-Id: If01ee34eba906c55f2d56ba650748a86e81e701c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151321
Auto-Submit: George Wright <wrightgeorge@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
2020-06-15 23:01:53 +00:00
Liam Appelbe 4ce18ab931 Add an --os=fuchsia option to build.py:
tools/build.py --os=fuchsia runtime create_sdk

This is analogous to --os=android. It cross compiles from Linux x64 to
Fuchsia.

A lot of the build rules are just slightly different between the existing
Fuchsia build rules used by Flutter, and the ones added by GN SDK. For
example "$fuchsia_sdk_root/pkg:fdio" is now "$fuchsia_sdk_root/pkg/fdio".
So to support this I had to add a new variable, using_fuchsia_gn_sdk,
analogous to using_fuchsia_sdk. Flutter will need to set this to false.

Change-Id: Ief275d65f30a42a801607de93cf2d27a1fe825dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150689
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
2020-06-15 20:05:16 +00:00
Daco Harkes d87046342f [benchmarks/ffi] Add FfiCall benchmark with Handles
On x64 desktop in JIT the trampolines with Handles are a bit slower
than trampolines passing integers or Pointers.

FfiCall.Uint64x01(RunTime): 200.8482627033541 us.
FfiCall.PointerUint8x01(RunTime): 261.3910088865656 us.
FfiCall.Handlex01(RunTime): 355.4978670458585 us.
FfiCall.Handlex02(RunTime): 384.86376755820663 us.
FfiCall.Handlex04(RunTime): 492.896007885658 us.
FfiCall.Handlex10(RunTime): 846.1214043993232 us.
FfiCall.Handlex20(RunTime): 1193.412291169451 us.

Issue: https://github.com/dart-lang/sdk/issues/36858
Issue: https://github.com/dart-lang/sdk/issues/41319

New issue for optimizing multiple handles:
https://github.com/dart-lang/sdk/issues/42341

Also cleans up dart2/native which was erroneously left over from the
benchmark duplication for NNBD.

Change-Id: I81223fefc47129d00984492efb9502d5449f0d4a
Cq-Include-Trybots: luci.dart.try:benchmark-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145593
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2020-06-15 13:27:16 +00:00
Daco Harkes 8d4d3a33ad [vm] fix build CIPD package issue
Change-Id: I6f3e7cb005233f4625d60f1f2a18b2e4914e01ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151224
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2020-06-15 10:51:59 +00:00
Martin Kustermann 68ede604ce [vm] Roll third_party/icu@ to 8d29692df64066
Issue https://github.com/dart-lang/sdk/issues/42230

Change-Id: Id0537f982759b20854d72db21937aac4a2866a07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151220
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2020-06-15 08:45:11 +00:00
Martin Kustermann b35f03471f [vm] Roll third_party/boringssl@ to 429ccb1877f798
Issue https://github.com/dart-lang/sdk/issues/42230

Change-Id: Id0483369a6668a1c2aac67191554d6075e5f8caf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151221
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2020-06-15 08:36:29 +00:00