Roll in versions of third_party packages which have been updated to
use StreamTransformerBase and forward compatible method signatures
on classes implementing Stream.
Change-Id: Ie366174bf09f9268a7f1476387c124cb3ea474f6
Reviewed-on: https://dart-review.googlesource.com/38680
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
This is a branch of co19 tests where the tests have been
made strong mode compliant. A co19_2_analyzer.status file
has been added with the current statuses of the tests when
run on dartanalyzer --strong. We expect more Dart 2 configurations
to start running these tests and adding status files.
Change-Id: I22077272707620b92dd1092c38bbb4f3d5964493
Reviewed-on: https://dart-review.googlesource.com/37743
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This brings package:http_io into third_party/pkg_tested so that its
migrated tests will run on sdk commits.
Change-Id: I516152747cdaeb1e874a900cb8ad57d84594ed6c
Reviewed-on: https://dart-review.googlesource.com/36842
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
* added support for external constructors in `avoid_unused_constructor_parameters`
* added code reference resolution docs for `comment_references`
Bug:
Change-Id: I844d7a50de557afe35cf9580ad06f31308359e0a
Reviewed-on: https://dart-review.googlesource.com/34220
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This required some changes to analysis_server, since analysis_server
used to have its own version of pumpEventQueue(). Since
pumpEventQueue() is now provided by the test package, I've removed
analysis_server's version, and I've updated some of the call sites to
pass in "times: 5000" to replicate the old analysis_server behavior.
This also required some changes to analyzer, since the fail() method
is now marked as @alwaysThrows, so no code may follow it without
producing a dead code hint.
Change-Id: Ie5ef3a5cc685c18da02de699e59f63f3bb8865f7
Reviewed-on: https://dart-review.googlesource.com/32683
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This removes scheduled_test which is important for rolling other
packages. In return, it brings in two new packages, test_descriptor and
test_process.
There are no changes in the formatter's actual output. All of the
differences are in tests or internal dependencies, so I don't think we
need to worry about coordinating this with the PRESUBMIT version of
dartfmt as in https://github.com/dart-lang/sdk/issues/30164.
Change-Id: I1c81e157c32326801985615abc353f2239fe2470
Reviewed-on: https://dart-review.googlesource.com/32664
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
This reverts commit 8b8d9b08e1.
Reason for revert: Github mirrors need to be created *before* landing.
Original change's description:
> Update dart_style to 1.0.9 and bring in its new dependencies.
>
> This removes the dependency on scheduled_test which is important for
> rolling other packages. In return, it brings in two new packages,
> test_descriptor and test_process.
>
> There are no changes in the formatter's actual output. All of the
> differences are in tests or internal dependencies, so I don't think we
> need to worry about coordinating this with the PRESUBMIT version of
> dartfmt as in https://github.com/dart-lang/sdk/issues/30164.
>
> Change-Id: I1d6426303055a4400a0ca3d16965a3e05ab39cf7
> Reviewed-on: https://dart-review.googlesource.com/32445
> Reviewed-by: Kevin Moore <kevmoo@google.com>
> Commit-Queue: Bob Nystrom <rnystrom@google.com>
TBR=kevmoo@google.com,rnystrom@google.com
Change-Id: I3af883a6f41339e3cc79096e0f61639c11af1e20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/32640
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
This removes the dependency on scheduled_test which is important for
rolling other packages. In return, it brings in two new packages,
test_descriptor and test_process.
There are no changes in the formatter's actual output. All of the
differences are in tests or internal dependencies, so I don't think we
need to worry about coordinating this with the PRESUBMIT version of
dartfmt as in https://github.com/dart-lang/sdk/issues/30164.
Change-Id: I1d6426303055a4400a0ca3d16965a3e05ab39cf7
Reviewed-on: https://dart-review.googlesource.com/32445
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
This bump is primarily to remove the dependency on scheduled_test. (The
dependents only include barback, shelf_static, and watcher.)
Change-Id: I1e40da2798a539d596b99688150d74934a0626e4
Reviewed-on: https://dart-review.googlesource.com/30980
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This CL switches the ia32 and arm64 builds to use clang by default.
The arm build can't be switched at least until we roll clang to
pick up the fix for https://reviews.llvm.org/D34691.
This CL also changes to use the sysroots from wheezy (and jessie
for arm64) by default so that we can be building/testing locally with
the same setup as we are shipping in the SDK.
Change-Id: I09a1907ee7f78c3f4bb8d56ffdbbd6107ed054d9
Reviewed-on: https://dart-review.googlesource.com/25160
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
* `prefer_interpolation_to_compose_strings` update to allow concatenation of two non-literal strings
* `prefer_interpolation_to_compose_strings` updated to allow `+=`
* lots of rule documentation fixes and enhancements
* fix for `prefer_const_constructors_in_immutables` false positive with redirecting factory constructors
Bug:
Change-Id: I6c095567ef92ad47fc57cbcbfb6745d0173043c4
Reviewed-on: https://dart-review.googlesource.com/18380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Janice Collins