e3797b1bb7
[dartdevc] Apply more lints from pedantic v1.9.0 and cleanup violations
...
- avoid_null_checks_in_equality_operators
- camel_case_extensions
- prefer_adjacent_string_concatenation
- prefer_collection_literals
- prefer_for_elements_to_map_fromIterable
- prefer_if_null_operators
- prefer_spread_collections
Change-Id: Iab816e71274a57cbca9b4006dc8dbc55604fcb2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133500
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2020-01-29 22:14:00 +00:00
2d82fb42ce
Enforce and fix lint prefer_single_quotes
...
Change-Id: I7e7b18d90ae8518c700607ec383c73a0eda5a299
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130726
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Auto-Submit: Nate Bosch <nbosch@google.com >
2020-01-08 22:07:21 +00:00
b368a6de1c
[dartdevc] copying over sourcemap file from build_web_compilers
...
Change-Id: Id5e4554c775becc9b1313c5cd85bd02920ea52f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121440
Commit-Queue: Mark Zhou <markzipan@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2019-10-15 20:03:34 +00:00
7972c61aab
fix detection of dart sdk lines in stack traces to recognize the ddk sdk
...
Change-Id: Ic94460833e9358b631bf1485a495ae386ff3e863
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118780
Reviewed-by: Vijay Menon <vsm@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
2019-09-25 15:45:09 +00:00
1ef4399df0
Run dartfmt --fix for dart2 on pkg/dev_compiler
...
This uses optional new/const and `=` in named argument defaults.
All changes are automated, except for:
- utils/dartdevc/BUILD.gn: run DDC build scripts with --preview-dart-2
- pkg/dev_compiler/tool/patch_sdk.dart: add a TODO that Analyzer doesn't
supporting implicit const in libraries.dart
- pkg/dev_compiler/tool/input_sdk/libraries.dart: was not formatted due
to the aforementioned Analyzer bug
- tools/bots/test_matrix.json: run DDC sourcemap suite in Dart 2 mode
- pkg/pkg.status: skip pkg/dev_compiler if running in Dart 1 mode
Change-Id: I9b80ccba0c2cc7b66efc662a0b16562e3660aee3
Reviewed-on: https://dart-review.googlesource.com/60402
Commit-Queue: Jenny Messerly <jmesserly@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2018-06-15 00:28:13 +00:00
34f8c356a3
Fix sdk stack trace mapping so tools recognize it
...
This should fix #32389
Change-Id: I1e6f1a7aea852abb9b2b4a9bf851941a8e0c91e7
Reviewed-on: https://dart-review.googlesource.com/44840
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Vijay Menon <vsm@google.com >
2018-03-02 19:46:49 +00:00
ea7c7988e3
Don't inline source maps into the SDK
...
Change-Id: Ia4e8673cf0c023353b27a3c0a947b09e04ec09c0
Reviewed-on: https://dart-review.googlesource.com/44320
Reviewed-by: Jenny Messerly <jmesserly@google.com >
Commit-Queue: Vijay Menon <vsm@google.com >
2018-03-01 03:21:37 +00:00
0bda5c9015
get source_map_stack_trace working for the external world
...
Bug:
Change-Id: I7385f2f1f11742ce5f90cce67b863ba066074679
Reviewed-on: https://dart-review.googlesource.com/41921
Reviewed-by: Vijay Menon <vsm@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2018-02-15 22:45:26 +00:00
f95daf6168
Fix DDC stack trace mapping
...
This supersedes https://dart-review.googlesource.com/c/sdk/+/4614 .
Patch 1 is the unmodified source_map_stack_trace.dart. Patch 2 is my fixes for DDC.
Change-Id: I30c6fad4bdc75061edbacc5fc75482af98e29bbb
Reviewed-on: https://dart-review.googlesource.com/4960
Reviewed-by: Jacob Richman <jacobr@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Vijay Menon <vsm@google.com >
2017-09-11 21:52:41 +00:00
Nicholas Shahan