Previously, approve_results.dart only looked at flaky.json from the
baseline build to determine whether to ignore a flake. But, if the flake
occurs in the try build and is detected as such by deflaking, flaky.json
might not contain data about the flake. Therefore, approve_results.dart
needs to also inspect the results data for the flaky bit.
Change-Id: I51f4c44a80684414c2c50d2460aed3f90eadaf12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116341
Reviewed-by: Jonas Termansen <sortie@google.com>
Copy the signed SDK directory to release first (if it exists). Then copy
only those unsigned files that have no signed counterparts.
* Add --version alias and remove SVN reference from --revision help.
* Fix --dry-run.
* Add new base_directory to GCS namer.
b/139027087
Change-Id: I4163eb56494bfa92ab1e5686cf089136d63881fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115860
Reviewed-by: William Hesse <whesse@google.com>
VM no longer relies on distinct ICData entries in constant pool, and
it no longer creates actual ICData objects.
This change introduces new DynamicCall constant pool entry which is
* de-duplicated;
* stores arguments descriptor inline instead of allocating a separate
constant pool entry and referencing it by index;
* reserves extra slot in constant pool (like other call constants), so
we can eventually remove creation of extra UnlinkedCall objects.
Change-Id: I8d21954803ca5be5b6fc8335b700e8a9086245cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116120
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
The original change is in Patchset 1.
The dependency contains the fix for the non-bare-instructions bot.
Change-Id: Iab02ab0736a2ee9144b667d2777ca526341b2a36
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-android-release-arm-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-bare-linux-release-x64-try,vm-kernel-precomp-mac-debug-simarm_x64-try,vm-kernel-precomp-win-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115241
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
The modular tests run on d8 - no need to run on both chrome and ff bots.
Old DDC is only used internally on Linux today, so removing Mac tests.
(Could also split out Win testing.)
Change-Id: If2ab50fae89d25d95f2e45d80de4834033e43b9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114621
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
This mode is no longer relevant and doesn't need to be benchmarked.
I didn't remove the legacy entry points in
* pkg/front_end/tool/fasta_perf.dart
* pkg/front_end/tool/incremental_perf.dart
as that would allow a cascade of simplifications that's probably better done
by the front end team.
Change-Id: Iffd977cfdf322aa181025920423083f4ab9de75f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113688
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
This adds a temporary hack causing make_version.py to report 2.5.0 if
the VERSION file's major.minor.patch = 2.5.0 and the channel is be and
--custom_for_pub = flutter. As soon as the VERSION file is bumped on
master, the hack will become a no-op and can be removed.
Fixes https://github.com/dart-lang/sdk/issues/37838
Change-Id: Icaff27e35686dfe4c69c17f7edbcf57b6fdf6ae2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113187
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
This ensures JS calls in the SDK are statically typed (or, at least, don't
inadvertently trigger dynamic calls).
Analyzer has a hack where `JS('String', ...)` is typed as `String`. Kernel
doesn't, but we get the same effect (in DDK) via `JS<String>('String', ...)`.
This should not affect dart2js which specially interprets the type string
itself.
Change-Id: I63c5f199e2c51da2beca72659261acf1faff66e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112937
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
This CL makes several adjustments to the spec_parser grammar Dart.g,
such that the spec_parser can parse the proposed NNBD constructs,
cf. language PR #293.
Change-Id: Ieec00259d73b6037d6a87d5c97cfac40186baef0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101500
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
We would like to run our main test suites with DDK on firefox.
* co19_2
* language_2
* corelib_2
* lib_2
* dartdevc_native
* ddc kernel modular tests
Change-Id: I05919b3fe4f3f34a38542f0edb064d2d6fbe0e10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107340
Reviewed-by: Alexander Thomas <athom@google.com>
vm-dartkb-linux-release-x64-abi is not a real configuration, it's just
the name of the bot. So if the configuration field needs to be a real
configuration name this won't work.
Change-Id: I703b13f15324eda4540d78707168a91ca00a6222
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111861
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: William Hesse <whesse@google.com>
- Add `.style.yapf` with configuration to use Google style.
- Run `yapf` on all `.py` files in this repo.
- Manually fix one trailing space in a doc string.
- Run `git cl format runtime` to satisfy presubmit.
Change-Id: I7e6bd11e91f07926b9188362599af398551eed79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111600
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
William Hesse