Commit Graph

19577 Commits

Author SHA1 Message Date
Mayank Patke a554c8be6b Fix language_2/flatten_test.
Change-Id: I1cba1d84737d5b42d3d8670568e249de9790cfba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117064
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-13 01:05:24 +00:00
Aart Bik 95d7749f48 [vm/compiler] OSR on non-empty stack integrity
Rationale:
Leaving a push argument on the stack in slightly more
complex flow graphs (try-catch, loop back, conditinals)
required a bit more bookkeeping. This CL also introduces
more integrity checks to make sure the stack is as
expected at each block and instruction.

Note:
Fuzzer is regression test for new feature.

https://github.com/dart-lang/sdk/issues/38231

Change-Id: I8f7e605937d76c1a429df601e69380111737dd94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116545
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2019-09-13 00:58:24 +00:00
Mayank Patke 9f778d69f4 Fix language_2/external_test.
Change-Id: Ie54433c28619a4786ae0d67b1358cdbc91f8ffab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116890
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-12 23:51:57 +00:00
Mayank Patke c858519064 Delete lib_2/async/timer_not_available_test.
Change-Id: If24b2652f3b8fa22e844b20fab8034d13e3003ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117066
Commit-Queue: Mayank Patke <fishythefish@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2019-09-12 22:58:07 +00:00
Mayank Patke 81c9fb8e63 Fix corelib_2/nsm_invocation_generic_test.
Change-Id: I0906988498ad6a8d9acabc103d759bed9c01ee83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116891
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2019-09-12 18:17:46 +00:00
Kallen Tu 83930fdc75 Reformatted extension method tests.
Removed unnecessary semicolon.

Change-Id: Ic5b2ff93b2a8904f377e14b19439a046d8fc2a1d

Reformat tests using dart_style.

Change-Id: I4d50f441fb7fa9d5d934ba6c9f3691ddd87a5cc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116551
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
2019-09-12 17:39:46 +00:00
Kallen Tu 4331e7e5fa Fix bad tests setter_no_getter_test and syntax_test.
Changed void test expectation to ok. Using void as such is now valid.

Change-Id: I2ea0208a182eb0f20eb9e1b79c938df899f96319

Change setter_no_getter_test to a static error test - compile-time error.

Change-Id: I232e4460397f88e4f9806adf73622903fd76d000
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116825
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
2019-09-12 17:16:08 +00:00
Mayank Patke 531cb02331 Fix language_2/mixin_constructor_forwarding/* tests.
Change-Id: I9d6cf8236d3549a799ee2b499cafd4ad40f445a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116720
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-12 00:43:19 +00:00
Mayank Patke 24f45d64c7 Delete language_2/generic_no_such_method_dispatcher_simple_test.
language_2/generic_no_such_method_dispatcher_test works after
https://dart-review.googlesource.com/c/sdk/+/115901, so we can delete this test
now.

Change-Id: Ifb0b32f9afb0d93de3db75f2293f60a1ce485c13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116751
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-12 00:41:39 +00:00
Alexander Aprelev 0c481a196c Revert Reland '[vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs).' as it breaks flutter profile execution on ios 32-bit platform.
Fixes https://github.com/flutter/flutter/issues/40114

Change-Id: If8d71e9c19c2e794d29f7ecbacb87457890a2fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116883
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2019-09-12 00:10:09 +00:00
Mayank Patke d18bfb409f Fix language_2/super_call4_test.
Change-Id: I1173d7121e7f557f93ec1f61341b627f141e6802
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116800
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-11 22:26:29 +00:00
Konstantin Shcheglov 3d1712c822 Remove tests for unqualified identifiers from static_extension_getter_setter_conflicts_test
R=brianwilkerson@google.com

Change-Id: I98f11b85ca480b6012e1286a707010ced4305571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-09-11 19:37:36 +00:00
Lasse R.H. Nielsen 4d5e15abde Fix broken static_extension_getter_setter_test.
Change-Id: Ie8cfc07df8507862c1d534421a1bd9a60fac580c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116500
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2019-09-11 07:44:56 +00:00
Ryan Macnak 9a9c0f3374 [test] Update status for some mirrors tests under reload stress testing.
Change-Id: Ia1b9adf1b83fe5cb5be8a853d1561fd1519f1df3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116550
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2019-09-10 23:07:38 +00:00
Aart Bik 2305d9f3a6 [vm/compiler] Better be ready for OSR in field init
Rationale:
OSR was happening in a field initializer, but the kernel
binary flow graph builder assumed this never happened.
With regression test.

https://github.com/dart-lang/sdk/issues/38248

Change-Id: I91243b4422cac76ec7ee2460d466bd0e1cf608ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116558
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
2019-09-10 22:17:22 +00:00
Mayank Patke d93d70a89a [dart2js] Add test for issue #38005.
Change-Id: Ie13483d9ad0f8eb9a1582f7d8378ae859184b654
Bug: https://github.com/dart-lang/sdk/issues/38005
Fixes: https://github.com/dart-lang/sdk/issues/38005
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116365
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-10 22:07:42 +00:00
Mayank Patke 81dc269a71 Status file cleanup.
Change-Id: Ifeb56e7ec7319ec9834b1888f09f0726c1b5a6e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116486
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2019-09-10 21:26:46 +00:00
Mayank Patke 13fc090e85 Fix language_2/map_literal3_test/03.
Change-Id: I2d3dd6857ce3c2a4594f53de71d03b42668731c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116487
Commit-Queue: Mayank Patke <fishythefish@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2019-09-10 20:17:27 +00:00
Konstantin Shcheglov fa099eb717 Look for both getter and setter in the hierarchy before looking for extension.
Change-Id: I7080f5ffb307b9deb9bba453e1d1c1aa253b7cc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116489
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-09-10 16:39:09 +00:00
Dmitry Stefantsov ccb6ba948b [cfe] Gather constraints from both possibilities for FutureOr
Closes #37778.

Bug: http://dartbug.com/37778.
Change-Id: Ia8828c27ccc912831a0fea8a473c547184c99229
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115243
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
2019-09-10 09:50:30 +00:00
Mayank Patke 78bf8f08b9 Fix language_2/deferred_load_library_wrong_args_test.
Change-Id: I83f31b84a2128f01056bca21c2dce1b1dde57567
Bug: https://github.com/dart-lang/sdk/issues/38281
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116480
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2019-09-10 02:10:38 +00:00
Mayank Patke b4724c1d78 Fix language_2/regress_23408_test.
Change-Id: I9ab03ffd07738d6c936052d104e8d68716835815
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116440
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-10 00:58:49 +00:00
Alexander Aprelev 95db62d6a2 [vm/io] Return data right away if it's ready.
This fixes problem with directory watching on Windows where data might be accumulated before dart stream is setup.

Bug: https://github.com/dart-lang/sdk/issues/37909

Change-Id: I601842522e76e4a6a4e6a22d6b376a49af200e6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115801
Reviewed-by: Zichang Guo <zichangguo@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2019-09-09 23:16:52 +00:00
Mayank Patke 601d8934f4 Fix issue31596 tests
Change-Id: I02d56402aa09c1c9563929ab3792743b8fe7e97d
Bug: https://github.com/dart-lang/sdk/issues/31596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116085
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
2019-09-09 23:16:03 +00:00
Mayank Patke 4e7b77e428 Fix language_2/super_bound_closure_test
Change-Id: Ib297bfb5350d97a30c3a2f737d9c2dad75ef88ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116087
Commit-Queue: Mayank Patke <fishythefish@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2019-09-09 19:54:41 +00:00
Mayank Patke a2c8b69af0 Status file cleanup
Change-Id: If5fbfe605dd27c02f664c0017a84a4a7594bf4e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116181
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2019-09-09 19:54:31 +00:00
Mayank Patke 909e2515af Fix regress_29025_test
This test doesn't do what it once did since callable classes are no
longer function subtypes. Still, we can preserve some of the behavior.

Change-Id: I92f503bfbbe81685cf79a3bb9b6d85b6859d3c52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116141
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-09 19:46:26 +00:00
Mayank Patke ecb9a113d1 Fix language_2/regress_22976_test
Change-Id: I0ea4a1861d37e5eefa2e05b0aafcde95fe95f484
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115902
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
2019-09-09 19:25:56 +00:00
Mayank Patke 4310d157a1 Fix language_2/type_promotion_more_specific_test/04
Change-Id: Idb6dc5341e8b45f5dff22f6e6545ca154dcb05a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116180
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
2019-09-09 18:59:26 +00:00
Mayank Patke 438c595950 Fix language_2/regress_30339_test
Change-Id: Ic0aa807c53b0334096633b0c0952efb68d0231f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116086
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Mayank Patke <fishythefish@google.com>
2019-09-09 18:57:36 +00:00
Mayank Patke 9497b7b0a4 Delete language_2/regress_29405_test
Callable classes aren't functions anymore, so this test no longer makes sense.

Change-Id: I9c93273c378c707c5cd05d6619dd8114e283c3d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116143
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2019-09-09 18:34:21 +00:00
Paul Berry bc24702149 Add missing parens to static_extension_getter_setter_conflicts_test.dart
Change-Id: I12642c789c082c1e083d821b9d01473ca70c1bcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116300
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-09-09 15:44:37 +00:00
Ryan Macnak 84db16381d [vm] Remove dead --load_deferred_eagerly and dependent code tracking for library prefixes.
Since Dart 2, library prefixes are always loaded eagerly on the VM.

Also remove reload check for deferred prefixes. This check was added to avoid behavior of library prefixes giving spurious "not loaded" errors after a reload, but now this error can never occur. Resolves a difference in reload between AST and bytecode modes, since bytecode mode isn't surfacing the deferred property.

Change-Id: Ide5fb6cac2efc90ca1b108a35bc09d342cbd60de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116051
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
2019-09-06 23:37:33 +00:00
Mayank Patke fd7676e0bc Fix language_2/config_import_corelib_test
Change-Id: Idc45ec34d12957f2ea097e27ba606344aec32ee5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116057
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-06 23:20:16 +00:00
Mayank Patke 40454f0918 Fix language_2/f_bounded_quantification2_test
Change-Id: Ibb182e2ea89f3dd4790be659a69d6c58e333efb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115779
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-06 21:35:36 +00:00
Mayank Patke 836f6de0f4 Fix language_2/f_bounded_quantification4_test
This isn't quite what the test was doing before, but the test was completely broken before so /shrug.

Change-Id: Idc3b6e1eab3b0c444f7100f01eecc5f27991df9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115900
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-06 21:35:35 +00:00
Mayank Patke a689f8df06 corelib_2/unsigned_shift_test fixes
Just doing some test cleanup on massively failing tests. This test still won't pass until we support `>>>` but we can fix some of the issues.

Change-Id: I1a111455c969f21644ab2713f81f4ee00e7383f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115881
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-06 19:49:57 +00:00
Mayank Patke add83ad185 Fix language_2/generic_no_such_method_dispatcher_test
Change-Id: I5d048d47bb10e66caef483f47a9b8245fc45d3d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115901
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2019-09-06 18:15:49 +00:00
Mayank Patke f5b53276ce Fix language_2/compile_time_constant_static5_test
Change-Id: Ice89ef6c38f93a94be41cece77804f6b04569534
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115778
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2019-09-06 18:15:19 +00:00
Konstantin Shcheglov 35f45f0ee4 Do null-aware shorting for IndexExpression.
R=brianwilkerson@google.com

Change-Id: I72e6aabb4fd2f79201ee1146e6ea83aa54ceb7a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115763
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-09-05 23:52:39 +00:00
Leaf Petersen 90aca0b8d5 Add test for incomparable on type resolution and fix expectations.
Change-Id: I8c1ead430a866461d802e86a36c892899645faf4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115620
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2019-09-05 22:39:21 +00:00
Aart Bik d9a9346c3f [vm/compiler] Fix truncating logic
Rationale:
The representation mask should not be used to
do the truncation, which is more subtle around
the sign bit. With regression test.

https://github.com/dart-lang/sdk/issues/38147

Change-Id: I9745f6d73f4761eb6210e0b60b2b0504994f5cbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115607
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
2019-09-05 21:13:43 +00:00
Samir Jindel c219a76652 Reland "[vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs)."
The original change is in Patchset 1.
The dependency contains the fix for the non-bare-instructions bot.

Change-Id: Iab02ab0736a2ee9144b667d2777ca526341b2a36
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-android-release-arm-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-bare-linux-release-x64-try,vm-kernel-precomp-mac-debug-simarm_x64-try,vm-kernel-precomp-win-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115241
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2019-09-05 20:19:22 +00:00
Robert Nystrom 89ad636b58 Remove the old "preview Dart 2" flags from the test runner.
Dart 2 shipped a year ago, so we're pretty well past a "preview". :)

Change-Id: I6c5d21ae4181e4228cc1fc49b6344cdb8fc43794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115544
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
2019-09-05 16:59:43 +00:00
Zichang Guo 92ed74e5f1 Reland "[vm] support zoneID for http"
This is a reland of c3db2e3ee0

Original change's description:
> [vm] support zoneID for http
> 
> Coming from https://dart-review.googlesource.com/c/sdk/+/103544.
> 
> Fixes: https://github.com/dart-lang/sdk/issues/37570
> Change-Id: I0f81cb5d8009dc929fca24e03a343a7b0c1597bc
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110121
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Commit-Queue: Zichang Guo <zichangguo@google.com>

Change-Id: I3692bf02fd29bc3bc8b9b54de1466075fecec1f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115605
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
2019-09-05 14:54:48 +00:00
Johnni Winther 34004f7f6b [cfe] Support modular compilation of extensions
Includes serialization/deserialization of Extension and
ExtensionMemberDescriptor.

Change-Id: I04df581355b0d6f9e6bfa638241c8b7f210d3ce5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115369
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-09-05 11:19:53 +00:00
Lasse R.H. Nielsen dfcc31baf3 Add test for getter/setter conflicts with extension members.
Change-Id: I9332e29d021d126d6678f6866d484185e2f1da73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115211
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2019-09-05 09:15:43 +00:00
Konstantin Shcheglov 6eed35b60d Analyze null-aware index expression reads.
R=brianwilkerson@google.com

Change-Id: Idcd787434eae070e87adf267a016bda2a4e5703e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-09-05 00:58:46 +00:00
Zichang Guo 05b7c55e8f Revert "[vm] support zoneID for http"
This reverts commit c3db2e3ee0.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [vm] support zoneID for http
> 
> Coming from https://dart-review.googlesource.com/c/sdk/+/103544.
> 
> Fixes: https://github.com/dart-lang/sdk/issues/37570
> Change-Id: I0f81cb5d8009dc929fca24e03a343a7b0c1597bc
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110121
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Commit-Queue: Zichang Guo <zichangguo@google.com>

TBR=lrn@google.com,zra@google.com,asiva@google.com,zichangguo@google.com

Change-Id: I41e52b905b112a0e6f2a6c2c8c135a9ec6ef6869
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115604
Reviewed-by: Zichang Guo <zichangguo@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
2019-09-04 22:17:48 +00:00
Zichang Guo c3db2e3ee0 [vm] support zoneID for http
Coming from https://dart-review.googlesource.com/c/sdk/+/103544.

Fixes: https://github.com/dart-lang/sdk/issues/37570
Change-Id: I0f81cb5d8009dc929fca24e03a343a7b0c1597bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110121
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
2019-09-04 15:42:01 +00:00