dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
66,572 Commits 2 Branches 0 Tags
a554c8be6ba94cc2c7312dbde5eb85537a35f607
Commit Graph

8104 Commits

Author SHA1 Message Date
Konstantin Shcheglov c138b505be Update TypeSystem tests to reuse AbstractTypeSystemTest. 
R=brianwilkerson@google.com

Change-Id: Ic6e446cf124a52c8663140a995d4a58c3e4c92a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117015
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-12 23:18:07 +00:00
Mike Fairhurst 5beca80bc7 [analyzer] add isNullAware to IndexExpression 
Change-Id: I3c3b1b0a38ea81fd573ec005e810eb2b000b3430
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-09-12 21:31:57 +00:00
Mike Fairhurst 2bc48ad1b6 [analyzer] add isNullAware to propertyAccess 
Change-Id: Ia785a308e7281d6d17d05b38d52337f611708206
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116685
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-12 21:29:27 +00:00
Mike Fairhurst 68bcc00d10 [analyzer] implement isNullAware for method invocations 
Change-Id: I630f94311a55b7a7fce5e47143e333abffe19c9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116681
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-12 21:21:22 +00:00
Konstantin Shcheglov c72a8589d9 Don't use DartType.instantiate() in TypeProviderImpl. 
R=brianwilkerson@google.com

Change-Id: I4f5b0edb618d49fa20c5102d896d09b94aeb0653
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117003
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-12 19:43:02 +00:00
Konstantin Shcheglov fc2f744d9e Deprecate 'Source.encoding'. 
R=brianwilkerson@google.com

Change-Id: I1a97c9b5a1401a16044df4e37117b2ec7e4e5db2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-12 16:48:16 +00:00
Brian Wilkerson c74e68e501 Add documentation for more diagnostics 
Change-Id: Id2aeb13db0ceb81fc18d67e6ef2778304b36d02b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-09-12 16:35:46 +00:00
danrubel 3b1d3de988 update parser to report out of order "?.." operator 
Change-Id: I2d90e458d5721d16142752e8ac6a522cc41c2051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-09-12 14:38:31 +00:00
David Morgan 60ca2b840d Revert "Enable visibleForTesting on unnamed constructors" 
This reverts commit de7ad46797.

Reason for revert: breaking for google3; need to discuss how to land this kind of change.

Original change's description:
> Enable visibleForTesting on unnamed constructors
> 
> Fixes #37936
> 
> Change-Id: I99023b66d7d53922edecfbab7be41d4c4145ec15
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114591
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=brianwilkerson@google.com,srawlins@google.com

Change-Id: I9d3688b4dcdff92f94b83e1e557a488abfd963cb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116782
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
 2019-09-12 07:34:49 +00:00
Konstantin Shcheglov c6b0ae1fda Fix for indexing FieldFormalParameterMember with unresolved field. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38071
Change-Id: Ifa2f9218357f0f7bb3236f66aee34c8940c8b206
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116865
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 22:45:59 +00:00
Konstantin Shcheglov c99cd5b82e Add more dart:html, enough for angular_analyzer_plugin. 
R=brianwilkerson@google.com

Change-Id: Ib45e5464e18839c65878e52f6a3c281416a9c952
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116861
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 22:04:09 +00:00
Konstantin Shcheglov 3e63f06afd Remove CancelableFuture. 
We don't use it anymore, and none of our clients does.

R=brianwilkerson@google.com

Change-Id: Iac840c182b47d85595ca80762fa8a207d8545585
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116752
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 22:03:19 +00:00
Konstantin Shcheglov e8836f5086 Fix sample for UNDEFINED_SETTER. 
R=brianwilkerson@google.com

Change-Id: I9c897ee5890d4b951cf157a5da6c21a5505248d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116823
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 21:20:57 +00:00
Konstantin Shcheglov d39b67dbfe Remove more unused classes from engine.dart 
R=brianwilkerson@google.com

Change-Id: I8d660025e201ef8a79d377c1923fe9a87bbc80ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116750
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 20:12:49 +00:00
Brian Wilkerson d36f5ed181 Fix diagnostic documentation tests and add support for documenting parser codes 
Change-Id: Ie2e360e6e4a344888bb409d20f21c969280bbdf9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116742
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 19:45:47 +00:00
Brian Wilkerson be93b04a7c Introduce a better diagnostic message for unqualified references to static members within extensions 
Change-Id: Ie505bf86e510161bf5dece489292388039902f83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116748
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 19:02:56 +00:00
Sam Rawlins de7ad46797 Enable visibleForTesting on unnamed constructors 
Fixes #37936

Change-Id: I99023b66d7d53922edecfbab7be41d4c4145ec15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114591
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 18:20:46 +00:00
Sam Rawlins 80040e5cfe Remove errors for raw types in is or as expressions. 
This brings the errors in line with the exceptions described in the spec:

https://github.com/dart-lang/language/blob/master/resources/type-system/strict-raw-types.md#conditions-for-a-raw-type-hint

Change-Id: I045237d937579d4390d3e676dc5e12346b90b480
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-11 18:13:46 +00:00
Konstantin Shcheglov dd3d6547de Rewrite property resolution, fix reporting errors when compound assignment without a getter. 
Change-Id: Id737ea776866c3d9a52033181759f27e26dc34b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116559
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 17:28:53 +00:00
Konstantin Shcheglov 76e6325ae0 Remove unused methods of AnalysisContext. 
Change-Id: Ie7f81ac09b51f7a4e70a32f962e6e15c81245820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 17:09:47 +00:00
danrubel 16c7ac92bf move const method error reporting into parser 
Change-Id: Ibae4aeb0362138e742f80186ed98a20eb3469ba1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-09-11 14:48:47 +00:00
Brian Wilkerson 9113fb3ce0 Move the remaining StaticWarningCode tests to their own files 
Change-Id: I764c9cbd961bc377d1b158aa0e16b2fb0e77b8cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116722
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 13:34:57 +00:00
Konstantin Shcheglov 6e01ad4d22 Fix for codeOffset/codeLength for enum constants. 
R=brianwilkerson@google.com

Change-Id: I5694f96fc0e7863f18c208005ec9984eaf58bacb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116682
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-10 22:52:29 +00:00
Brian Wilkerson 90866d3ecc Remove unused import 
Change-Id: I011f6591a760d7d82ffc8b9462c5749107e5012f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116552
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-09-10 20:42:20 +00:00
danrubel 30ea777c65 fix parsing of "?.." cascade operator 
Fix https://github.com/dart-lang/sdk/issues/37859

Change-Id: Ie29f4fd000199f0099137308603335e36af6ae26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116089
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-10 20:36:04 +00:00
Brian Wilkerson 7ffb9de00f Update the version in the extension methods version hint 
Change-Id: I465413e0d1252573112bff2e518fc933308e093b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-10 19:48:17 +00:00
Konstantin Shcheglov c11ca7d439 Check for CompileTimeErrorCode.CONST_WITH_TYPE_PARAMETERS in LinterContext.canBeConst(). 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/linter/issues/1712
Change-Id: I8e6ec22999baf2af95f05af13fdaf596cba7676a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-10 17:57:11 +00:00
Konstantin Shcheglov fa099eb717 Look for both getter and setter in the hierarchy before looking for extension. 
Change-Id: I7080f5ffb307b9deb9bba453e1d1c1aa253b7cc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116489
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-10 16:39:09 +00:00
Konstantin Shcheglov 331271d405 Set id(s) for GenericFunctionType(s) in constructor initializers and default values. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38282
Change-Id: I05d5b5c003fa51cc5061ed2dd6883809b6f82cae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116490
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-10 16:26:39 +00:00
Mike Fairhurst 7413879026 [analyzer] Add getter isNullAware to SpreadElement 
Change-Id: I89d644da2277b4527f32e176f9355cf16734dc64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116380
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-10 03:20:19 +00:00
Konstantin Shcheglov 0851b9ae4c Consider both getter and setter when deciding whether an extension reference is ambiguous. 
Change-Id: I8acbabda7f748e7415bd38a957e96f906afd7f6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116250
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-09 19:13:06 +00:00
Konstantin Shcheglov 6f38a73618 Remove most of the task model. 
I run presubmit, and it does not look to me that any failin tests
are caused by this CL.
https://test.corp.google.com/ui#id=OCL:267824456:BASE:267824473:1567923135217:2380181a

R=brianwilkerson@google.com

Change-Id: I838f2174460e0d06c85bbb83de9037113c0b6393
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116252
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-09 18:26:50 +00:00
Konstantin Shcheglov fbd21a0d1f Guard against null in exportedDeclarations. 
I was not able to find the root reason of the problem :-(

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38261
Change-Id: Ib9a78366548688eab231fc941b29f608bdb6b15e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-09 18:24:16 +00:00
Sam Rawlins e9dcb9f45d fix typo in factory; add mixin text for protected 
Change-Id: Idab2890de1f128105a02d94a7512e4a22eba7023
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116050
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-09 14:11:47 +00:00
danrubel 41bf7443d4 update parser to report static constructor 
Change-Id: I95b07f5e85600a05c59b3107922ae663f242b0dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116246
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-09 05:26:16 +00:00
danrubel cb1efb8d27 update parser to allow "late var" in NNBD 
Fix https://github.com/dart-lang/sdk/issues/38022
Fix https://github.com/dart-lang/sdk/issues/37857

Change-Id: I9ddfeddd424312e584b67bb1f42c73957ed7b05c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-09 05:26:16 +00:00
danrubel fb73cb19e6 update parser to report MixinDeclaresConstructor error 
Change-Id: I4750ff522046cbcc6bab561d189f578a8e8fd8d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-09 05:26:16 +00:00
danrubel 355df2a354 split AstBuilder endClassConstructor out of endClassMethod event 
This CL moves the logic determining whether a declaration is a method
or constructor into the parser and splits the AstBuilder endClassMethod
event handler into simplified endClassConstructor and endClassMethod event handlers

Change-Id: I2d2124a2456f70d5511163cead25f6c586ea9c71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-09 05:26:16 +00:00
danrubel b6f6240013 fix extension factory declaration in AST 
Constructor declarations within extensions are invalid and the parser
reports an error. This modifies AstBuilder to add the declaration
as a method declaration in order to get navigation, search, etc.

Fix https://github.com/dart-lang/sdk/issues/38202

Change-Id: I6071a8d5a742d6598f18a831688ddc97e411f76f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-09 05:26:16 +00:00
danrubel 618b56d24d fix conditional expression parsing with NNBD enabled 
Fix https://github.com/dart-lang/sdk/issues/38113

Change-Id: I06ebb5ee6260dfa97969a7d11b8c66c48d2ae766
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116054
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-09 05:26:16 +00:00
Konstantin Shcheglov 23d28932f0 Remove asserts in TypeProviderImpl. 
R=brianwilkerson@google.com

Change-Id: I4a82fc390d202ba316af4f36932349993952df98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116183
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-07 15:10:38 +00:00
Konstantin Shcheglov 3d3bbc2dbf Remove 'strongMode' flag in StaticTypeAnalyzerTest. 
R=brianwilkerson@google.com

Change-Id: I85c0a0a5fd9ea2f0814906f44ce922c70f0c842e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116088
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-07 15:01:23 +00:00
Konstantin Shcheglov 7f8398e484 Changes to MockSdk to make it usable in linter. 
The goal is to switch linter to analyzer's MockSdk.

R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I3bf735ddf82efaaa24ccc07fa8fe7e752dc6d19f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-07 14:53:28 +00:00
Konstantin Shcheglov 116cfbaa2d Issue 38198. Fix for isMoreSpecific() extension. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38198
Change-Id: I734d2353b9064a1a0e007495a1df546873e15c8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-07 14:53:20 +00:00
Konstantin Shcheglov 2c219ddb07 Replace AnalysisContextFactory with TestAnalysisContext. 
R=brianwilkerson@google.com

Change-Id: I45ac78530061478e4835bd78355ab9f089f80879
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116047
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-06 22:47:36 +00:00
Sam Rawlins cf94c3a2fa Additional tests verifying interaction between mixins, static 
extensions, and visiblity annotations (protected, visibleForTemplate,
visibleForTesting).

Change-Id: I7dc09aa0d12ea917c4c8c8235efc4554b8287379
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116048
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-06 22:20:57 +00:00
Konstantin Shcheglov ffd50c0dc5 Report EXTENSION_AS_EXPRESSION, set type fo dynamic. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38203
Change-Id: Iee270b7b3fecbeaba202c304f21ef703a8567674
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116055
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-06 22:14:34 +00:00
danrubel 152aa5a6ed fix calls following null-assertion operator 
Fix https://github.com/dart-lang/sdk/issues/37708

Change-Id: I46ed01cef1eb426e7e28c481d98cb04ac0eed44c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116046
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-06 20:48:17 +00:00
danrubel 4e4047a52f fix extension abstract method error 
This changes EXTENSION_DECLARES_ABSTRACT_MEMBER to be a parse error
and moves it into the parser so that it is generated for all of CFE.

Fix https://github.com/dart-lang/sdk/issues/37945

Change-Id: Iba2876eb2db83e96ec49adc49a7b6a0e7aff200b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116002
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-06 19:50:17 +00:00
Konstantin Shcheglov 0d63ce1d0c Clean up MockSdkElements. 
R=brianwilkerson@google.com

Change-Id: I378bc57d08119d4a82315f1e181b934e3d7e17e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116045
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-06 19:14:39 +00:00