dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
66,572 Commits 2 Branches 0 Tags
a554c8be6ba94cc2c7312dbde5eb85537a35f607
Commit Graph

3022 Commits

Author SHA1 Message Date
Brian Wilkerson 7badd807b1 Add a fix to replace an override with the extension name if accessing a static member 
Change-Id: I5c7557aaff6af4eeaad196513c3315679fab26f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117011
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-12 19:54:52 +00:00
Brian Wilkerson 49de78b708 Convert tests so that they will continue to pass when extension methods are enabled by default 
Change-Id: I58722f78c19d00842d98ebb238622e88c06468e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117009
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-12 19:12:12 +00:00
pq 9d3de982c6 fix for REMOVE_UNUSED_LABEL 
see:  https://github.com/dart-lang/sdk/issues/38361

Change-Id: I45fdba9f12d9fdfd7d431149da97632df97a4653
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117008
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-12 18:59:18 +00:00
pq 1d01d91c33 fix for sort_child_properties_last 
Change-Id: Ife3f05077fcd48e8f821314b55ba481918ba05c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-12 00:07:40 +00:00
Konstantin Shcheglov eac977bef0 Issue 38273. Fix for inlining methods ending with a return statement without an expression. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38273
Change-Id: Ib399379f8aecb1e7737f2efdeb9dbf53f27d4abb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 23:27:40 +00:00
Brian Wilkerson 25edeb7ae1 Support completing the extension name locally 
Change-Id: I49174918ca84f2aaafe4b47200e9396f2191a727
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116802
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 21:42:26 +00:00
Konstantin Shcheglov 4f8f592b51 Remove adding prefixes for auto imports. 
Adding import prefixes often has false positives.
At this point I think that this feature does more harm than benefit.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38326
Change-Id: I99e3400aebc062d9de3c298d7ed58520534d061c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116746
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 19:04:47 +00:00
Brian Wilkerson be93b04a7c Introduce a better diagnostic message for unqualified references to static members within extensions 
Change-Id: Ie505bf86e510161bf5dece489292388039902f83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116748
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 19:02:56 +00:00
Konstantin Shcheglov 76e6325ae0 Remove unused methods of AnalysisContext. 
Change-Id: Ie7f81ac09b51f7a4e70a32f962e6e15c81245820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 17:09:47 +00:00
pq 27918cdb29 fix for prefer_inlined_adds 
Change-Id: Icd307a2bc7fdb1d3e63fd5144af79dcc430b5ba8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-11 16:54:07 +00:00
Brian Wilkerson 1b67cc79da Suggest completions for extensions in parts 
Change-Id: I3aceaf24680ee7599a0beccd79dde1f790ec5ad1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116686
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 13:34:07 +00:00
Brian Wilkerson f3911dffb5 Update included element kinds to include extensions 
Change-Id: I1eada569734810707df085b8b66e02f1458aabf7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-10 21:37:26 +00:00
pq 24857b773a fix for prefer_spread_collections 
Change-Id: I5509b4a0dc7a9d404c484915794ff22ee51d502e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-10 16:42:40 +00:00
pq 8329968192 fix for prefer_single_quotes 
Change-Id: I844c6847fb3318cca34fb18b5fb89e1f4196f357
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-10 13:54:56 +00:00
pq 9a2e2801d9 fix for avoid_relative_lib_imports 
Change-Id: Ib7ffd8cab3d1f0b22ebb9ad2d284c65d3194de15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116484
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-10 12:28:26 +00:00
pq 27f803db76 fix for convert_to_null_aware_operators 
Change-Id: I3d256ab5d474b91796226aba08058250dc2451c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-09 19:17:08 +00:00
pq 9fd672b1b7 fix for prefer_expression_bodies 
Change-Id: Ie1a76db4450f1b2447e8988e84f758d623810264
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-09 18:06:06 +00:00
pq ab5e36bcfb fix for prefer_int_literals 
Change-Id: I4743fdce6e638e20e641d764b7e1dd607419dcd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-09 13:39:47 +00:00
pq 5247036142 fix for convert_to_if_element 
Change-Id: I311b503313ad88121098bc13fc2909ff964907d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116058
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-06 23:14:16 +00:00
Brian Wilkerson 67cdae394f Add import fix in missed case 
Change-Id: Iee046e2cfcbb6ca51c7d6315f492099ab1128a03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116056
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-06 22:27:35 +00:00
Brian Wilkerson eb60f0531e Support a fix to add a setter, both in extensions and elsewhere 
Change-Id: I94d7ec13a2bcf73b120be18facf473a4710a6e28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116053
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-06 21:59:14 +00:00
pq 1354ec93db fix for prefer_for_elements_to_map_fromIterable 
Change-Id: I2d9df7fc7f4fd5bf24a63a62c8e167175e6fbfb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116043
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-06 20:57:39 +00:00
Brian Wilkerson f48a5a9f64 Support create method fix for extensions 
Change-Id: Iafb40a8b1cfb5a284fda4ec2ff85e5b36d7dc9bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115765
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-09-06 16:04:20 +00:00
Brian Wilkerson d8f16611ed Support replacing similar names in extensions 
Change-Id: I1a3dd56dba6ac245ea7176488ea50f629ed8d174
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115774
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-06 13:41:50 +00:00
pq 4d0fa1e402 fix for slash_for_doc_comments 
Change-Id: I05ed8f878736f3afeb545940e047ac03dfcbc1f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115771
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-06 13:24:09 +00:00
pq 698d120328 base processor migration; fix to add type annotations 
Change-Id: Ia35084f29ac54e666b98f1400eeef598512b4f20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-09-05 21:27:41 +00:00
Brian Wilkerson cf5e9ca423 Additional tests and fixes for creating getters 
Change-Id: Ia162cc49987d48c71052cba85c2d5da159c2c8f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115722
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-05 18:25:14 +00:00
Brian Wilkerson ec48af600f Support fix to import a library defining an extention 
Change-Id: Ife2f48eb5de0311aacd0d811973b7c160fc311da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115721
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-09-05 18:00:45 +00:00
pq c7bb9cf5c4 refactor to share common fix/assist processor code 
Also, introduces a fix for curly braces (and makes the assist conditional).
This is the proposed pattern for the remaining fix/assist correspondences.

See: https://github.com/dart-lang/sdk/issues/37508


(Note: in a follow-up I'll pull more shared functionality into the new
BaseProcessor; the goal here is to have just enough shared to allow for
conditionally adding assists where there are already fixes.)


Change-Id: I5b725c58b15afa76db66d15f34c90338704689c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115720
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-09-05 17:43:06 +00:00
Brian Wilkerson 57314a7e2f Add fixes to create getters in extensions 
Change-Id: I9a78cdeac0fddfc23f919956723a884456c4e429
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-09-04 21:13:45 +00:00
pq ec62b1a242 new fix: MAKE_VARIABLE_NOT_FINAL 
Fixes: https://github.com/dart-lang/sdk/issues/33290

Change-Id: Ice1c11907ed696d9d209145a4cacf2ca250c17c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115273
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-04 13:14:22 +00:00
Konstantin Shcheglov 946e7e3913 Issue 37005. Use FunctionType to get parameters. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/37005
Change-Id: Ic149578a98414a8670cbbdf70a5762656fbb66a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115270
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-03 20:03:16 +00:00
Brian Wilkerson 233b4a71ca Deprecate some unnecessarily duplicated error codes 
Originally the spec made a distinction between when some of these
conditions were errors and when they were warnings. That distinction has
been removed, so this just cleans up our code to reflect that fact.

Change-Id: I3a6fdae2896eb93c6b9cacfea790cd9b553feec5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115261
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-03 16:01:25 +00:00
Konstantin Shcheglov 6705a135e5 Clean up 'Extract Local' refactoring. 
We don't support expression fragments anymore, also don't need to
re-tokenize code.

R=brianwilkerson@google.com

Change-Id: Ic8bf930a2d7b81862ce08925405bdd479db8eaba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-02 20:07:47 +00:00
pq 041a0e4bff fixes for prefer_const_constructors 
Fixes: https://github.com/dart-lang/sdk/issues/38143

Change-Id: I7e50072fa8362311a8c47a0cbd4218f3ed949363
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115073
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-30 23:58:38 +00:00
Konstantin Shcheglov 5190274ed2 Extract LintNames into services/linter/lint_names.dart 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I903f8b7eff521a9c218b42311db5e618d4a7a4f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115072
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-30 22:03:38 +00:00
Konstantin Shcheglov b1edcc4de9 Take 'prefer_final_locals' lint into account in 'Extract Local' refactoring. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: If562cea70ff816bdcd59df50a6c4f86c006f8857
Bug: https://github.com/dart-lang/sdk/issues/38081
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115065
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-30 20:36:18 +00:00
Konstantin Shcheglov a2e9af92d2 Protocol for 'server.log' notification. 
R=brianwilkerson@google.com

Change-Id: Ifed9a0f04ee961b217643b7236fce7a0067664cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114607
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-29 22:33:33 +00:00
Brian Wilkerson a90abd6cf7 Support completions of extensions imported with a prefix 
Change-Id: I82a1fe85fef30f5e9e18cf0459ec0d70500c8d68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115002
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-29 21:54:33 +00:00
Brian Wilkerson aa0af27497 Support completion of static members defined in extensions 
Change-Id: I4093a000b84e1f56d53f93201250d287662c7af3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114968
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-29 20:33:30 +00:00
Konstantin Shcheglov c07b1fea98 Add relevanceBoost for initializers of variable initializers. 
R=brianwilkerson@google.com

Bug: https://github.com/JetBrains/intellij-plugins/pull/665#issuecomment-525052795
Change-Id: I254639a1582ca5691e96e15612bd2078c65e0b41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114969
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-29 20:25:26 +00:00
pq ea09fbe45d switch case statement completions 
follow-up from: https://dart-review.googlesource.com/c/sdk/+/114748

Change-Id: If92ac6e67298e8950d7da57c0d1892cb29ae8c7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114756
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-08-28 23:26:45 +00:00
pq 851701d2a4 add BREAK suggestions to switch cases 
fixes: https://github.com/dart-lang/sdk/issues/36605

Change-Id: I29e3b6a46c542895995b5eedcc64262352bb49a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114748
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-08-28 20:27:51 +00:00
Brian Wilkerson 91400d6422 Guard against an NPE when computing completions (issue 38006) 
Change-Id: Ica0a9cf3eecd765db8e9ebaab560f59275f3c345
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114622
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-27 21:21:53 +00:00
abykov2 e5b0ff494b Adding an offset field to TokenDetails to return token offset as part of listTokenDetails 
Closes #38013
https://github.com/dart-lang/sdk/pull/38013

GitOrigin-RevId: f384b20a96950238a50a95420b264100de5bbbe4
Change-Id: Iabca2d4ac89f07424439ab5bba2156860aab2c81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114587
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Alex Bykov <abykov@google.com>
 2019-08-27 17:52:38 +00:00
Konstantin Shcheglov 605709ac31 Fix _isDynamicExpression() in DartUnitHighlightsComputer2. 
The staticType of an "expression" can be `null` if it is not really
an expression, e.g. an import prefix, or a name of an extension.

R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I9eb328453e77fa51ff0f2d289972ad1274a9a5e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114558
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-26 21:54:52 +00:00
Konstantin Shcheglov e18ebb610b Set relevance tags for constructors. 
R=brianwilkerson@google.com

Bug: https://github.com/JetBrains/intellij-plugins/pull/665#issuecomment-523843326
Change-Id: I347822b84311ed2b94171231597aeceebd900015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-26 20:36:01 +00:00
Konstantin Shcheglov 67d8bb4c24 Add 'Rename Extension Member' refactoring. 
R=brianwilkerson@google.com

Change-Id: Ifba22e28e27ee1d29959db27da1fa1cc7a47e4db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114546
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-26 19:44:35 +00:00
Konstantin Shcheglov da66bf6f77 Issue 37951. Identify widgets in IfElement and ForElement. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/37951
Change-Id: I67efef667227c43749b63e4b4c53f6f517edf43d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-26 16:34:15 +00:00
Jens Johansen 74e09abc6e [CFE] Remove/move file that wasn't needed by frontend; cleanup pubspec.yaml a bit 
Change-Id: I204b844e7f1cb892a529bca3a13017ed836275f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114074
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-08-23 07:42:03 +00:00