dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
53,966 Commits 2 Branches 0 Tags
a412f24e4151dfd9b1ecfe996bfdd6772c7675cd
Commit Graph

405 Commits

Author SHA1 Message Date
Alexander Thomas 7702816194 [infra] Add builder tag for vm-kernel-optcounter-threshold builder 
#31838

Change-Id: I46e681518b569905a8b2b30f7add53e69aeef446
Reviewed-on: https://dart-review.googlesource.com/40742
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-02-13 12:32:11 +00:00
Alexander Thomas 6f58ab48e9 [infra] Re-enable sharding on vm-kernel/vm-kernel-precomp builders 
* Send fewer files to shards by not including co19_2 in the file set.

Change-Id: I317a8fc44cf60e0489e23514cf9bf119afa827ee
Reviewed-on: https://dart-review.googlesource.com/39941
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-08 21:48:52 +00:00
Alexander Thomas f2af628b8a [infra] Disable sharding on vm-kernel and vm-kernel-precomp builders 
TBR=whesse@google.com

Change-Id: I0277aa21b7aef6118e639d01a26ed7c98e5cdf6e
Reviewed-on: https://dart-review.googlesource.com/39762
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-02-07 16:42:52 +00:00
Alexander Thomas 222ad40af3 [infra] Add missing package to vm-kernel file set 
TBR=whesse@google.com

Change-Id: I58a25a274dca173b8e025e44972226d9a196d5b7
Reviewed-on: https://dart-review.googlesource.com/39760
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-02-07 16:27:49 +00:00
Alexander Thomas a5992af988 [infra] --use-blobs on vm-kernel-precomp-win 
Change-Id: I47d0e40dcece7d81356a44f4ddb071059fb8b149
Reviewed-on: https://dart-review.googlesource.com/39740
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-02-07 16:19:49 +00:00
Alexander Thomas ea683b93a8 [infra] Update VM builders in test matrix to match CQ 
Change-Id: I85d8a51fa6639c5d20704da749ea6b2b72c224bb
Reviewed-on: https://dart-review.googlesource.com/39701
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-07 14:37:37 +00:00
Alexander Thomas 71910f0656 [infra] Shard vm-kernel builders on Luci 
Change-Id: I9ff39eae6cf6bcd9aad59a8320d6a665e480182a
Reviewed-on: https://dart-review.googlesource.com/38580
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-07 14:20:11 +00:00
Alexander Thomas 4256f10f99 [infra] Increase timeout for front end tests on vm-kernel in test matrix 
Change-Id: I0155868d1311d3ab21660881ef36f8f6ceafe24e
Reviewed-on: https://dart-review.googlesource.com/37980
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-02-05 11:12:47 +00:00
Alexander Thomas 1c9d9234bf [infra] Remove unfinished trigger configuration 
Change-Id: I5af8518c41c12f37b7b9c602512fa3f4693f53f2
Reviewed-on: https://dart-review.googlesource.com/37661
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-05 11:12:47 +00:00
Siva Chandra 71dba8a0e5 Link the platform kernel with the command line dart executable. 
Change-Id: Ib376a259e2e9ff9b487820c041d6795f8f7192d1
Reviewed-on: https://dart-review.googlesource.com/37420
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Chandra <sivachandra@google.com>
 2018-02-01 15:11:29 +00:00
Alexander Thomas 338685e9b6 [infra] Increase timeout for front_end tests in test matrix 
Change-Id: I4b6b321fbf6522f81844018c787228e05141a9a4
Reviewed-on: https://dart-review.googlesource.com/35200
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-01-17 15:44:19 +00:00
Alexander Thomas 27ebef64d4 [infra] Add VM Kernel Windows x64 builders 
Bug: https://github.com/dart-lang/sdk/issues/31707
Change-Id: Ie56f4c6f78c9b7c27fc4f587857e412db3e8f358
Reviewed-on: https://dart-review.googlesource.com/33960
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-01-16 15:39:03 +00:00
Jenny Messerly 2a8d1c023b enable corelib_2 and lib_2 tests for DDK on the bots 
Change-Id: I72d5b9d34bc93f888c9da5da169e3a1cab003913
Reviewed-on: https://dart-review.googlesource.com/34505
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-01-13 01:21:10 +00:00
Jenny Messerly 1ace9bfe00 enable corelib_2 tests for DDK on the bots 
Change-Id: I97fb3f606545db64313a1c3e8d1b687d536ac589
Reviewed-on: https://dart-review.googlesource.com/34503
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-01-13 00:39:33 +00:00
Alexander Thomas 89bd41d19a [infra] Simplify vm-kernel configurations in test matrix 
This also adds the missing vm-kernel opt-counter builder.

Bug: https://github.com/dart-lang/sdk/issues/31753
Change-Id: I0199218f83d227cfc52505c213d7b689acd9c43e
Reviewed-on: https://dart-review.googlesource.com/31984
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-01-09 20:59:49 +00:00
Alexander Thomas c4e89ecaf4 [Infra] Correct step name in test matrix 
Change-Id: I6f27037103feb4bdd037cdc0a78fa0a254c95930
Reviewed-on: https://dart-review.googlesource.com/32080
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-01-03 13:52:24 +00:00
Alexander Thomas 97e2994818 [Infra] Remove asan ia32 builder from test matrix 
Bug: 31749
Change-Id: I3e9354a9f914788bbe2d08841e2212bddf033d12
Reviewed-on: https://dart-review.googlesource.com/31943
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-01-03 13:19:44 +00:00
Sigmund Cherem 414bad86df Directly create dart2js platform files using its patch files 
Change-Id: I1c7d59968bfafeeb5a8b5252fa2d47e3c05b893e
Reviewed-on: https://dart-review.googlesource.com/27404
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-12-19 20:31:57 +00:00
Alexander Thomas 61bc4e07e9 [Infra] Add VM Kernel simarm/simdbc builders to test matrix 
Change-Id: I37a0961382ca0da5ed549c76c18f3ac5b15ab29e
Reviewed-on: https://dart-review.googlesource.com/27580
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2017-12-14 12:30:35 +00:00
Bob Nystrom 650c9dcc8e Support extractTypeArguments() in 1.0 mode on the VM and dart2js. 
Without strong mode, a "good enough" implementation is to simply call
the generic method with "dynamic" for the type arguments, which is what
this does. That should be enough to unblock our internal users.

We also need to not report a compile error when
dart_internal/extract_type_arguments.dart imports the hidden
"dart:_internal" library.

This patch does both of those for the VM and dart2js (using its old
front end).

Note that the test still fails because the test is more particular than
most actual user code would be -- it validates that the instantiated
type arguments are *exactly* correct, and not that the returned object
is merely subtype compatible.

Bug:
Change-Id: I0343beace4991861b29712b3fd7067ec8dc8f8ba
Reviewed-on: https://dart-review.googlesource.com/28020
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-12-12 19:04:18 +00:00
Vyacheslav Egorov efca9c69ab [vm/testing] Make --strong -c dartk configuration a Dart 2.0 configuration. 
Switch it to use pkg/vm/tool/dart2 which is the source of truth for what
Dart 2 VM configuration means. Don't pass any additional flags from
tools/test.py itself.

Align pkg/vm/tool/dart2 with what tools/test.py was passing to VM on _2 suites.

Make default invocation `tools/test.py -c dartk --strong -m release,debug`
green by updating status files and skipping suites that are not Dart 2.0
compliant. I have filed issues #31588 for isolate suite and #31587 for
service suite.

Reland of https://dart-review.googlesource.com/27820

Change-Id: I49400fae716f75425e70bf1e561b3375ba39157e
Reviewed-on: https://dart-review.googlesource.com/28565
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2017-12-12 12:19:10 +00:00
Alexander Thomas 68bbe83132 [Infra] Add -rnone to ensure DDC kernel custom scripts don't use xvfb 
TBR=whesse@google.com

Change-Id: I0e670e5b48fb0c4abe23c789344f2e2ea22ae667
Reviewed-on: https://dart-review.googlesource.com/28564
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2017-12-12 10:45:12 +00:00
Alexander Thomas 6538cb9004 [Infra] Fix broken DDC buildernames in test matrix caused by bad merge 
TBR=whesse@google.com

Change-Id: I59f298aef3f280b10a6eb4f495c73adab76128ff
Reviewed-on: https://dart-review.googlesource.com/28561
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-12-12 08:59:01 +00:00
Alexander Thomas bdd88891b9 [Infra] Move runtime into DDC builder names 
This makes it easier to add other runtimes later.

Change-Id: I90dfd9c404167eff880eed00933ffea212ccdef2
Reviewed-on: https://dart-review.googlesource.com/27942
Reviewed-by: William Hesse <whesse@google.com>
 2017-12-12 08:11:12 +00:00
Bob Nystrom a53e4dd504 Finish migrating stuff out of lib_strong. 
Some of these are data files that weren't picked up by the migration
script. Some are files that slipped between blocks of tests.

Change-Id: I184dc4701758b280444d54ec55c225ade30f3276
Reviewed-on: https://dart-review.googlesource.com/26423
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2017-12-11 23:45:23 +00:00
Vyacheslav Egorov e84fa65696 Revert "[vm/testing] Make --strong -c dartk configuration a Dart 2.0 configuration." 
This reverts commit 50865e9387.

CQ on Mac is broken.

TBR=kustermann@google.com

Bug:
Change-Id: I41a7cab59c076dba4f25f5904725cca5bb4619c9
Reviewed-on: https://dart-review.googlesource.com/28420
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-12-11 21:07:43 +00:00
Vyacheslav Egorov 50865e9387 [vm/testing] Make --strong -c dartk configuration a Dart 2.0 configuration. 
Switch it to use pkg/vm/tool/dart2 which is the source of truth for what
Dart 2 VM configuration means. Don't pass any additional flags from
tools/test.py itself.

Align pkg/vm/tool/dart2 with what tools/test.py was passing to VM on _2 suites.

Make default invocation `tools/test.py -c dartk --strong -m release,debug`
green by updating status files and skipping suites that are not Dart 2.0
compliant. I have filed issues #31588 for isolate suite and #31587 for
service suite.

Change-Id: I882b28f6a011eabf69c349ff0792b275434e39ff
Reviewed-on: https://dart-review.googlesource.com/27820
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2017-12-11 12:49:22 +00:00
Jens Johansen a6f66714ec [DDC] Enable sourcemap unit tests 
Bug:
Change-Id: I10240c27eb06e8b0eddeac6a051ef00790970b11
Reviewed-on: https://dart-review.googlesource.com/27560
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2017-12-11 09:25:10 +00:00
Morten Krogh-Jespersen 309a0d5abd Improve selecting platform for try test. 
The bot names are picked from the platform selected. The tool now also ask for xvfb if on linux.

Bug:
Change-Id: I47dd28a0240f34607535808326a182bf663ead04
Reviewed-on: https://dart-review.googlesource.com/24821
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-12-05 07:27:09 +00:00
Alexander Thomas 352c34a07f Remove DDK with runtime 'none' tests from DDC builder 
Change-Id: I7bd76b3b52cafb435b88ba71b99858f23a5e6f2f
Reviewed-on: https://dart-review.googlesource.com/25920
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2017-12-04 18:15:35 +00:00
Vyacheslav Egorov 4f17dea27d Add pkg/kernel/test/binary_bench.dart to try_benchmarks.sh 
Change-Id: I6c6a54dbb10aac9e55f4f90e908432a162295dd3
Reviewed-on: https://dart-review.googlesource.com/23677
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2017-11-30 11:39:31 +00:00
Morten Krogh-Jespersen 1d1b29f469 Utility program to send arguments to try tests. 
This small utility program makes it easier to invoke custom steps on try
builders.

Bug:
Change-Id: I63d3d77365f47d79f489a70fef5431a93a6663e5
Reviewed-on: https://dart-review.googlesource.com/24440
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-11-30 09:56:58 +00:00
Alexander Thomas 0bf5ca8e47 Fix invalid JSON in test matrix 
Change-Id: Ie551fbc739922138ad026b510a9e871eb20d4af1
Reviewed-on: https://dart-review.googlesource.com/24423
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-11-29 12:09:25 +00:00
Alexander Thomas 4f68da06ef Add DDC kernel tests to test matrix 
Change-Id: Ie04c6a0308cf19b7e051f97aafa06d81b9979d7b
Reviewed-on: https://dart-review.googlesource.com/23662
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-11-29 11:19:34 +00:00
Sigmund Cherem 2cf4dd41e9 Update try_benchmarks.sh to use correct platform file 
Change-Id: Idf85e0a2f0ce3bafc6257ae8d5d1a8735f795835
Reviewed-on: https://dart-review.googlesource.com/23961
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-11-28 16:38:25 +00:00
Alexander Thomas 8588854548 Add VM debug canary builder to test matrix and commit queue 
Change-Id: I7386e3e6f9f786c98a134095f1a4e772f8fa7143
Reviewed-on: https://dart-review.googlesource.com/23666
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-11-27 16:17:21 +00:00
Morten Krogh-Jespersen d7e687fecb Revert "Add triggering of dart2js bots on sdk-builders." 
This reverts commit 645acdbd0e.

TBR: athom@google.com

Bug:
Change-Id: Ia47a15e000dddfe1bb040ce148ac3d9cc2ceac8f
Reviewed-on: https://dart-review.googlesource.com/23669
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-11-27 12:06:07 +00:00
Morten Krogh-Jespersen 645acdbd0e Add triggering of dart2js bots on sdk-builders. 
DO NOT LAND until we have more machines.

Bug:
Change-Id: I0ad43356f3b429c807568d44a53988a30172bfe2
Reviewed-on: https://dart-review.googlesource.com/20980
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-11-27 11:07:28 +00:00
Alexander Thomas 9698df457c Merge SDK build steps in test matrix 
Change-Id: Icc9b03e33c7375c5cc1460f1d7116efed2157d44
Reviewed-on: https://dart-review.googlesource.com/22804
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2017-11-23 09:10:16 +00:00
Harry Terkelsen f5bb30ff73 Try building "Hello World" with the v2 dart2js 
Change-Id: I7ffbbd0f0dc545dac0b1e7211d9848a5757d0151
Reviewed-on: https://dart-review.googlesource.com/20910
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2017-11-20 18:08:06 +00:00
Sigmund Cherem 3b73de2060 Rename 'driver' to 'default' in incremental_perf.dart 
This just makes the name more appropriate since now that the default incremental
generator is not using kernel-driver altogether.

Change-Id: Ic7357dbb4eaad482f20249dd13ba3a49a39322d3
Reviewed-on: https://dart-review.googlesource.com/22160
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2017-11-20 18:03:56 +00:00
Sigmund Cherem 2a199ae689 Add flags to configure incremental_perf 
This lets us benchmark separately:
- IKG implementations (the default based on kernel-driver or the minimal implementation)
- strong and non-strong mode

This also adds commands to try_benchmarks that highlight how these options will be used.

Change-Id: I5ce2c4563b7e79c33d78df7fd87be76f5d47e3f4
Reviewed-on: https://dart-review.googlesource.com/21320
Reviewed-by: Jonas Termansen <sortie@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-11-16 03:42:23 +00:00
Morten Krogh-Jespersen 8618c947ec Add dart2js-csp-minified to the test matrix. 
Bug:
Change-Id: I877f67ea4ef9023cc1d4d767dab15c544db46b05
Reviewed-on: https://dart-review.googlesource.com/21241
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-11-15 22:40:12 +00:00
Morten Krogh-Jespersen 88aef0a65d Add --strong to vm-precomp builders to the test matrix. 
This CL adds --strong arguments to precomp builders, based on the input in
https://dart-review.googlesource.com/c/sdk/+/20860
Bug:
Change-Id: I18f64c4a82a0cf4f5f37f19d794705b3ae69f651
Reviewed-on: https://dart-review.googlesource.com/21300
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-15 22:37:20 +00:00
Morten Krogh-Jespersen fe112c5357 Add jsshell to dart2js test matrix configuration. 
Bug:
Change-Id: Ic488034a9f7364036690f01881bb90f43828a7a6
Reviewed-on: https://dart-review.googlesource.com/21240
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-11-15 22:36:50 +00:00
Morten Krogh-Jespersen 6cdd14f8da Add d8-minified to the test matrix. 
Bug:
Change-Id: I2709cae4ed9eefe4297de5a60ebcc0955637e024
Reviewed-on: https://dart-review.googlesource.com/21242
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-11-15 22:34:06 +00:00
Sigmund Cherem 3fa203ba1f Update try_benchmarks.sh to let fasta find the VM patch files 
Change-Id: I200b8fd266e866f05e4353a383f89c235c29c80a
Reviewed-on: https://dart-review.googlesource.com/21002
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-11-15 20:23:23 +00:00
Vyacheslav Egorov 3e59066738 [golem] Update try_benchmarks.sh for dart-v2 and dart-aot-v2 
* Ensure that strong platform and outline exist.
* Ensure that pkg/vm/tool scripts work.

Bug:
Change-Id: Ief8211b85f31767341f022d1389ceb06c4f90cd9
Reviewed-on: https://dart-review.googlesource.com/20722
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2017-11-15 07:06:51 +00:00
Morten Krogh-Jespersen 22403530f0 Adding dart2js builders to the test matrix. 
WIP

Bug:
Change-Id: I36c790884f4b31c60a7b9a5475f9c45847d9f94d
Reviewed-on: https://dart-review.googlesource.com/20840
Reviewed-by: William Hesse <whesse@google.com>
 2017-11-15 02:09:16 +00:00
Morten Krogh-Jespersen 7590424b02 Enable triggering of analyzer linux builders in the test matrix. 
Bug:
Change-Id: I4e50ac00d143ee16e34cf7491b7f149ad01a81e5
Reviewed-on: https://dart-review.googlesource.com/20203
Reviewed-by: William Hesse <whesse@google.com>
 2017-11-15 01:49:17 +00:00