dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
53,966 Commits 2 Branches 0 Tags
a412f24e4151dfd9b1ecfe996bfdd6772c7675cd
Commit Graph

5083 Commits

Author SHA1 Message Date
Zach Anderson 0d5cf900b0 [infra,flutter] Adds semantically meaningful custom version strings 
See https://github.com/flutter/flutter/issues/14751

Change-Id: I3b35c2a32c0dd1301e92abe23b1c6fe2c2e04a6c
Reviewed-on: https://dart-review.googlesource.com/42026
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-02-16 20:44:48 +00:00
Alexander Thomas 7488718131 Revert "[infra] Temporarily mark CQ Windows SDK builder as experimental" 
This reverts commit 3493aae512.

Reason for revert: The Windows bots have access to the VS toolchain again.
https://bugs.chromium.org/p/chromium/issues/detail?id=812927

Original change's description:
> [infra] Temporarily mark CQ Windows SDK builder as experimental
> 
> TBR=whesse@google.com
> 
> Change-Id: I95042b0ec8cb056ef2a825ba81c5258c0789df7c
> Reviewed-on: https://dart-review.googlesource.com/41821
> Reviewed-by: Alexander Thomas <athom@google.com>

TBR=whesse@google.com,athom@google.com

Change-Id: I2f064b40536fd771d0b87aa4756f9596ccaace76
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/41980
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-02-16 07:57:41 +00:00
Alexander Thomas 3493aae512 [infra] Temporarily mark CQ Windows SDK builder as experimental 
TBR=whesse@google.com

Change-Id: I95042b0ec8cb056ef2a825ba81c5258c0789df7c
Reviewed-on: https://dart-review.googlesource.com/41821
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-02-15 16:13:05 +00:00
Peter von der Ahé 01e95adcc6 Implement default runtime and mode for Fasta and other compilers 
Fixes https://github.com/dart-lang/sdk/issues/32169

Change-Id: I574aab13acedc8afe63cd5c7c055183643452013
Reviewed-on: https://dart-review.googlesource.com/41661
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-02-15 11:19:12 +00:00
Zach Anderson 98a42402cc Revert "[infra] Use wheezy sysroot for local builds on linux." 
This reverts commit 4678cdaa24.

Reason for revert: This broke gcc arm builds.

Original change's description:
> [infra] Use wheezy sysroot for local builds on linux.
> 
> I had though that this is how things already worked, but it wasn't.
> 
> Change-Id: Iaa6b4e7d9e791f3fad29431c5715fcb19df8a76b
> Reviewed-on: https://dart-review.googlesource.com/40840
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Commit-Queue: Zach Anderson <zra@google.com>

TBR=rmacnak@google.com,zra@google.com,asiva@google.com

Change-Id: I013fe2d3736acdcb8ce7d1ec959419f20aa0aa54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/41340
Reviewed-by: Zach Anderson <zra@google.com>
 2018-02-14 16:41:45 +00:00
Zach Anderson 3b2e4076d3 Revert "[infra] Fix asan build" 
This reverts commit 41eef1cbb5.

Reason for revert: Backing out to revert:
[infra] Use wheezy sysroot for local builds on linux.

Original change's description:
> [infra] Fix asan build
> 
> Change-Id: Ib5b1efbf12bdf7455e2c9d32c37ce5a06ed3195b
> Reviewed-on: https://dart-review.googlesource.com/41000
> Reviewed-by: Zach Anderson <zra@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Commit-Queue: Zach Anderson <zra@google.com>

TBR=rmacnak@google.com,zra@google.com

Change-Id: Ica54f78a98784aa7e1b40f8c7e113298606255c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/41341
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-02-14 16:41:29 +00:00
Siva Annamalai 4925ed38ac Revert "Create isolate from the platform kernel when running VM tests under dartk." 
This reverts commit 3e967d3d76.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Create isolate from the platform kernel when running VM tests under dartk.
> 
> Status of tests which now start failing has been updated.
> 
> Ability to run the vm tests in strong mode has also been added. The
> status of tests which fail in strong mode will be updated when the vm
> tests are moved under the strong mode tests on the bots.
> 
> Change-Id: I95f94c09dd0ebbf1fe661ee1f6e0c3e7b07509bd
> Reviewed-on: https://dart-review.googlesource.com/40642
> Commit-Queue: Siva Chandra <sivachandra@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=sivachandra@google.com,asiva@google.com

Change-Id: I6144bbe882cdf56ee6be3132c6f9dec2cbafcb47
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/41026
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2018-02-13 23:33:12 +00:00
Zach Anderson 41eef1cbb5 [infra] Fix asan build 
Change-Id: Ib5b1efbf12bdf7455e2c9d32c37ce5a06ed3195b
Reviewed-on: https://dart-review.googlesource.com/41000
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-02-13 21:10:24 +00:00
Siva Chandra 3e967d3d76 Create isolate from the platform kernel when running VM tests under dartk. 
Status of tests which now start failing has been updated.

Ability to run the vm tests in strong mode has also been added. The
status of tests which fail in strong mode will be updated when the vm
tests are moved under the strong mode tests on the bots.

Change-Id: I95f94c09dd0ebbf1fe661ee1f6e0c3e7b07509bd
Reviewed-on: https://dart-review.googlesource.com/40642
Commit-Queue: Siva Chandra <sivachandra@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-02-13 20:34:24 +00:00
Zach Anderson 4678cdaa24 [infra] Use wheezy sysroot for local builds on linux. 
I had though that this is how things already worked, but it wasn't.

Change-Id: Iaa6b4e7d9e791f3fad29431c5715fcb19df8a76b
Reviewed-on: https://dart-review.googlesource.com/40840
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-02-13 19:11:24 +00:00
Alexander Thomas 7702816194 [infra] Add builder tag for vm-kernel-optcounter-threshold builder 
#31838

Change-Id: I46e681518b569905a8b2b30f7add53e69aeef446
Reviewed-on: https://dart-review.googlesource.com/40742
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-02-13 12:32:11 +00:00
Peter von der Ahé f6f849e3b9 Pass --strong-mode when testing fasta in strong mode. 
Change-Id: I534d283d7f604d0f0e686dc23606e81f665ec5e4
Reviewed-on: https://dart-review.googlesource.com/40527
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-02-13 11:08:46 +00:00
Peter von der Ahé 5882a0d13d Address comments from previous CL 
Change-Id: If98db1948e21c43eed60c7e1ee18c9fff61be88c
Reviewed-on: https://dart-review.googlesource.com/40540
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-12 18:25:11 +00:00
Peter von der Ahé bc7d1137fc Implement Fasta compiler configuration 
Change-Id: Id17c35592838fd5ccc203b9e4ea0a86a29fe527e
Reviewed-on: https://dart-review.googlesource.com/36643
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2018-02-12 11:39:18 +00:00
William Hesse c9ec45638b Drop unused local variable in test.dart 
Fixes analyzer hint

TBR=athom@google.com

Change-Id: I5af6e9a0f11cc40a10ac710e1fcfd7e6bc3279d2
Reviewed-on: https://dart-review.googlesource.com/40382
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-10 13:01:51 +00:00
Alexander Thomas 6f58ab48e9 [infra] Re-enable sharding on vm-kernel/vm-kernel-precomp builders 
* Send fewer files to shards by not including co19_2 in the file set.

Change-Id: I317a8fc44cf60e0489e23514cf9bf119afa827ee
Reviewed-on: https://dart-review.googlesource.com/39941
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-08 21:48:52 +00:00
Siva Chandra 6ff0951bdf Remove the use of redundant flags --dfe and --kernel-binaries. 
This change helps in confining flag manipulation to just the embedder.
When we are ready to turn all dart 2 flags to true by default, the
change can be confined to just the VM.

Change-Id: I4ac550c331b1f236a2bd9d0453b7c567eb0c05d3
Reviewed-on: https://dart-review.googlesource.com/38881
Commit-Queue: Siva Chandra <sivachandra@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-02-08 20:56:22 +00:00
Alexander Thomas f2af628b8a [infra] Disable sharding on vm-kernel and vm-kernel-precomp builders 
TBR=whesse@google.com

Change-Id: I0277aa21b7aef6118e639d01a26ed7c98e5cdf6e
Reviewed-on: https://dart-review.googlesource.com/39762
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-02-07 16:42:52 +00:00
Alexander Thomas 222ad40af3 [infra] Add missing package to vm-kernel file set 
TBR=whesse@google.com

Change-Id: I58a25a274dca173b8e025e44972226d9a196d5b7
Reviewed-on: https://dart-review.googlesource.com/39760
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-02-07 16:27:49 +00:00
Alexander Thomas a5992af988 [infra] --use-blobs on vm-kernel-precomp-win 
Change-Id: I47d0e40dcece7d81356a44f4ddb071059fb8b149
Reviewed-on: https://dart-review.googlesource.com/39740
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-02-07 16:19:49 +00:00
Alexander Thomas ea683b93a8 [infra] Update VM builders in test matrix to match CQ 
Change-Id: I85d8a51fa6639c5d20704da749ea6b2b72c224bb
Reviewed-on: https://dart-review.googlesource.com/39701
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-07 14:37:37 +00:00
Alexander Thomas 71910f0656 [infra] Shard vm-kernel builders on Luci 
Change-Id: I9ff39eae6cf6bcd9aad59a8320d6a665e480182a
Reviewed-on: https://dart-review.googlesource.com/38580
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-07 14:20:11 +00:00
Lasse R.H. Nielsen 6f78471687 New methods on Iterable, List, Set, Queue, Map. 
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.

Change-Id: I7a12fea533d42b0fc8357086649df38ad01f3cdd
Reviewed-on: https://dart-review.googlesource.com/39140
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-02-07 06:12:53 +00:00
Zachary Anderson e842c9b0b5 [infra] Use dart_action() instead of python scripts 
This change shifts logic for invoking Dart scripts during the build
from a couple of python scripts to a new template called dart_action().

Change-Id: Ic0818122cd7317cbd22a7255d880fe8f87271b7e
Reviewed-on: https://dart-review.googlesource.com/39260
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-02-06 21:51:13 +00:00
Peter von der Ahé f8f312c787 Prepare for fasta compiler configuration in test.dart 
Change-Id: I4c7f7c7b39e07eee42b4dd5375fb855d3348ac49
Reviewed-on: https://dart-review.googlesource.com/39121
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-06 15:11:52 +00:00
William Hesse 9c35cff5cd Revert "New methods on Iterable, List, Set, Queue, Map." 
This reverts commit 0b59f24f97.

Reason for revert: Creates crashes in dart2js with kernel, see
https://luci-milo.appspot.com/buildbot/client.dart/dart2js-linux-d8-minified-1-5-be/9751

Original change's description:
> New methods on Iterable, List, Set, Queue, Map.
> Changes signature of Iterable.singleWhere.
> Makes LinkedHashMap no longer be a HashMap.
> 
> Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
> Reviewed-on: https://dart-review.googlesource.com/32541
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Leaf Petersen <leafp@google.com>

TBR=lrn@google.com,leafp@google.com

Change-Id: Iab904f5885a5213ae2e16ef496eed0b6843185f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39060
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-06 13:32:19 +00:00
William Hesse ffc478f6fa Improve status file update tool "fix similar tests" option 
R=athom@google.com

Change-Id: I0a26e929b06b7c737b0f233839aca4551ec1d0dc
Reviewed-on: https://dart-review.googlesource.com/39020
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-02-06 12:51:07 +00:00
Alexander Thomas 59f272827e [infra] Remove unnecessary prefix 't' from section toggle option 
Change-Id: Iacfea3435c813c1d74a64f09df1802610636ef4e
Reviewed-on: https://dart-review.googlesource.com/37460
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-06 11:35:52 +00:00
Alexander Thomas bc0156ee44 [infra] Only add custom sections once 
* Prevent autofixing tests across suites.
* Handle invalid input when selecting files.
* Only display sections in files that apply to the failing test.

Change-Id: Ia7f22bdf29901af05742e461ca009f2e3a4a3e37
Reviewed-on: https://dart-review.googlesource.com/37400
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-06 11:35:52 +00:00
Lasse R.H. Nielsen 0b59f24f97 New methods on Iterable, List, Set, Queue, Map. 
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.

Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
Reviewed-on: https://dart-review.googlesource.com/32541
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-02-06 11:17:46 +00:00
Paul Berry be8748997d Remove configurations that aren't useful to test anymore 
Change-Id: I555ce0b54fec59d8c21b7574055ef7f444a3d423
Reviewed-on: https://dart-review.googlesource.com/38600
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-06 08:28:37 +00:00
Bob Nystrom f92d1a6a7e Optimize ExpectationSet. 
With the old implementation, looking up the expectations for a single
test was O(n) in the number of status file entries in all status files
(!). That means getting the status of m tests was O(n * m). :(

This parses entry paths into a tree and only traverses the branches of
that the test patch matches. On my script that determines the
expectation of every test on every configuration, it changes the runtime
from ~30s to ~1.5.

On my laptop, this change also takes this:

  time ./tools/test.py -m release --list -c dartdevc language_2

From about ~4.5s to ~3.5.

Storing the expectations in a more structured way also opens the door
to some other changes we could do:

- Separate out the configuration from ExpectationSet so that you can
  use a single ExpectationSet for multiple configurations.

- Determining which status entries are pointless because they are
  covered by a similar expectation higher up the file system tree.

- Determining which status entries collide and hit the same test.

Change-Id: I121bca34b68e1e6bb45edb59bd3cfe95d37e6bef
Reviewed-on: https://dart-review.googlesource.com/38382
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-06 02:47:15 +00:00
Terry Lucas d7a8aa155f Fixed a number of File API methods in DDC. 
R=vsm@google.com

Change-Id: I77881201f1e89f731476655476eb865e10d581a1
Reviewed-on: https://dart-review.googlesource.com/38164
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-02-05 22:29:00 +00:00
William Hesse 45e1b8884b Update checked-in SDK to version 2.0.0-dev.20.0 
Change-Id: I1494b20fb5a5ae14599286e65824fdd7f759a28f
Reviewed-on: https://dart-review.googlesource.com/38802
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-02-05 17:47:41 +00:00
Alexander Thomas 4256f10f99 [infra] Increase timeout for front end tests on vm-kernel in test matrix 
Change-Id: I0155868d1311d3ab21660881ef36f8f6ceafe24e
Reviewed-on: https://dart-review.googlesource.com/37980
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-02-05 11:12:47 +00:00
Alexander Thomas 1c9d9234bf [infra] Remove unfinished trigger configuration 
Change-Id: I5af8518c41c12f37b7b9c602512fa3f4693f53f2
Reviewed-on: https://dart-review.googlesource.com/37661
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-05 11:12:47 +00:00
Florian Loitsch 3b8e4d41a7 Reapply "Run async functions immediately." 
Which was reverted in commit 032be73dbe.
Originally commited in commit 67bac0bce6.
Original review URL: https://dart-review.googlesource.com/5263

Change-Id: Ic7333c29e502a3924dc6aade8ffa46fc8aa5b04a
Reviewed-on: https://dart-review.googlesource.com/38120
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-02 15:50:16 +00:00
William Hesse 8e7174b210 Fix gardening status update tool to fix all similar tests in one step 
Change-Id: Ie93900b32e86d67c2928b38030434509ab2fc5ec
Reviewed-on: https://dart-review.googlesource.com/38121
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2018-02-02 12:12:47 +00:00
Siva Chandra 71dba8a0e5 Link the platform kernel with the command line dart executable. 
Change-Id: Ib376a259e2e9ff9b487820c041d6795f8f7192d1
Reviewed-on: https://dart-review.googlesource.com/37420
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Chandra <sivachandra@google.com>
 2018-02-01 15:11:29 +00:00
Florian Loitsch 032be73dbe Revert "Run async functions immediately." 
This reverts commit 67bac0bce6.

Reason for revert: broke the bot.

Original change's description:
> Run async functions immediately.
> 
> Migrated from https://codereview.chromium.org/2478703003/
> 
> Change-Id: I1d678c01ba5876490b12c676c500171328361d31
> Reviewed-on: https://dart-review.googlesource.com/5263
> Commit-Queue: Florian Loitsch <floitsch@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>
> Reviewed-by: William Hesse <whesse@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Régis Crelier <regis@google.com>

TBR=whesse@google.com,rnystrom@google.com,vegorov@google.com,kustermann@google.com,zra@google.com,floitsch@google.com,jmesserly@google.com,vsm@google.com,regis@google.com,sigmund@google.com

Change-Id: I20c948057423c3fa5aa8c72843f8f2a17e086ad5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/37981
Reviewed-by: Florian Loitsch <floitsch@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-01 15:01:21 +00:00
William Hesse 25af9c2495 Add co19_2 suite to SDK source checkout 
This is a branch of co19 tests where the tests have been
made strong mode compliant. A co19_2_analyzer.status file
has been added with the current statuses of the tests when
run on dartanalyzer --strong. We expect more Dart 2 configurations
to start running these tests and adding status files.

Change-Id: I22077272707620b92dd1092c38bbb4f3d5964493
Reviewed-on: https://dart-review.googlesource.com/37743
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-02-01 14:11:37 +00:00
Florian Loitsch 67bac0bce6 Run async functions immediately. 
Migrated from https://codereview.chromium.org/2478703003/

Change-Id: I1d678c01ba5876490b12c676c500171328361d31
Reviewed-on: https://dart-review.googlesource.com/5263
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-02-01 14:08:57 +00:00
Bob Nystrom 85faacc23c Fix the const assertion test. 
Dart 2 has no notion of "checked mode", so a failed assertion in a
const constructor should always be a compile error.

Change-Id: I02227c03613346918de1e3a7f7c70d209a940b90
Reviewed-on: https://dart-review.googlesource.com/37647
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-01-30 23:26:01 +00:00
William Hesse 0f67c89474 Update status for Chrome 64 and Firefox 59 on all operating systems 
This reverts commit c5306595f4, which updated
the status for linux only, and updates it for all operating systems instead.
It also fixes a minor error in the status update tools.

Change-Id: I556dff775f221b872c5cea27b7ed5a0088d378a5
Reviewed-on: https://dart-review.googlesource.com/37261
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-01-29 18:11:06 +00:00
Alexander Thomas 0546d85ef3 [infra] Skip selection step when there is only one possible outcome 
Change-Id: I5fc5677cbc52d998c24a6e2cefef519ec0178c2a
Reviewed-on: https://dart-review.googlesource.com/37200
Reviewed-by: William Hesse <whesse@google.com>
 2018-01-29 16:12:51 +00:00
Alexander Thomas eff50ffc43 [infra] Ensure that <Enter> doesn't auto-fix 
Change-Id: I6134eb2abc1b23d5aada43cf4666def67a580900
Reviewed-on: https://dart-review.googlesource.com/37180
Reviewed-by: William Hesse <whesse@google.com>
 2018-01-29 16:12:51 +00:00
Alexander Thomas 2d84ed2297 [infra] Allow passing status command inputs to the tool directly 
Change-Id: I20ee77aa8fe2102ddaed785d085d9e0c1806471d
Reviewed-on: https://dart-review.googlesource.com/37000
Reviewed-by: William Hesse <whesse@google.com>
 2018-01-26 20:31:16 +00:00
Alexander Thomas c508eb6f29 [infra] Add support for to status.dart results 
Change-Id: I17294da087152d7c9d5bc04c9146d05bfac1e6a9
Reviewed-on: https://dart-review.googlesource.com/36843
Reviewed-by: William Hesse <whesse@google.com>
 2018-01-26 00:15:11 +00:00
Ryan Macnak a369b88497 Teach package:kernel and patch_sdk.dart about dart_runner. 
Change-Id: Ie39e278031b8d484086f3b4ad0c2eb323a152fc3
Reviewed-on: https://dart-review.googlesource.com/36489
Reviewed-by: Zach Anderson <zra@google.com>
 2018-01-26 00:05:08 +00:00
Sigmund Cherem 444f65315e Pass --strong to dart2js when running in strong mode 
Change-Id: I6ddf9e51547e2c7163c82e4433ce3f0fb527173a
Reviewed-on: https://dart-review.googlesource.com/36382
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-01-23 08:23:26 +00:00