Commit Graph

4927 Commits

Author SHA1 Message Date
Dmitry Stefantsov 43ddb1cd99 Update more status files after landing ec9c927b18
Change-Id: I978cc28895c515ba6c6d5db9a08606b8c01993e9
Reviewed-on: https://dart-review.googlesource.com/41860
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-02-15 17:30:08 +00:00
Brian Wilkerson 386f8b2f5f Skip remaining Dart 1.0 tests
Change-Id: I8014cdb5d5cd154f52043593e577b29a01d71e2b
Reviewed-on: https://dart-review.googlesource.com/41601
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-15 14:14:07 +00:00
Dmitry Stefantsov 28887cc851 Update more dart2js status after landing ec9c927b18
Change-Id: If2e302e0e840f6cb1aa9076c8d854e55d36cba90
Reviewed-on: https://dart-review.googlesource.com/41266
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-02-15 00:15:10 +00:00
Johnni Winther f2b8cafb44 Handle assert in initializers of constant constructors.
Change-Id: Ibb4053af00392b3c43177c60c8551cc6ffe937eb
Reviewed-on: https://dart-review.googlesource.com/38320
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-02-13 14:00:01 +00:00
Johnni Winther 62f0120bb9 Update status for d8-minified
Change-Id: I4a382baa4b84e975c445bc2512b55e4bfcdd1b30
Reviewed-on: https://dart-review.googlesource.com/40525
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-02-12 14:40:07 +00:00
Johnni Winther 41118c438e Reimplement runtime type checks computation
Change-Id: Ic1baa96e60db30cf9afe3414e605f0200361583b
Reviewed-on: https://dart-review.googlesource.com/37560
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-02-12 13:29:30 +00:00
William Hesse e4f5497d0e Update status for dart2js-with-kernel
Change-Id: I233dbf8d5cbc8c93e3dcd3369f067345e6f04a56
Reviewed-on: https://dart-review.googlesource.com/40282
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-02-09 12:53:19 +00:00
Mike Fairhurst ef421661dc Fix status files and ref #32100 for staticwarning/compiletimeerror weirdness
Change-Id: I991ffffa37b21cffc5f14528a303e86b14a393ba
Reviewed-on: https://dart-review.googlesource.com/40106
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-09 00:04:52 +00:00
Dan Rubel 11ed56d0c1 Update status files
Change-Id: I3402d16544aabc6f0df8c738615ea6e9929f5ece
Reviewed-on: https://dart-review.googlesource.com/40160
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
2018-02-08 22:24:02 +00:00
Mike Fairhurst 56d59dd967 Reland https://dart-review.googlesource.com/c/sdk/+/37441 with fixes
Change-Id: If8e2ec2ca1ac4f533dcb56b0c95d55e4a13e0598
Reviewed-on: https://dart-review.googlesource.com/39881
Reviewed-by: Paul Berry <paulberry@google.com>
2018-02-08 20:46:19 +00:00
Régis Crelier e64f37614e [VM runtime] Fix TypeArguments::IsUninstantiatedIdentity() not to return true
for a still unfinalized type argument vector (fixes #31944).
Update status files.

Change-Id: Ib603cd702891dc93775a5fbd09c341bb36922ab3
Reviewed-on: https://dart-review.googlesource.com/39855
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2018-02-08 02:03:24 +00:00
William Hesse 2f9caa23c7 Update status for dart2js-with-kernel
Bug: https://github.com/dart-lang/sdk/issues/32078
Change-Id: If167667e16db1dd200aed649ac43071404d4feb9
TBR=johnniwinther@google.com
Reviewed-on: https://dart-review.googlesource.com/39780
Reviewed-by: William Hesse <whesse@google.com>
2018-02-07 16:03:35 +00:00
Peter von der Ahé 8815bbe90e Update status files for $compiler == fasta
Change-Id: I09761d12b98864d9a9abcc7abe6f046e45951715
Reviewed-on: https://dart-review.googlesource.com/36642
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-02-07 15:38:09 +00:00
Paul Berry cca7b4419d Replace $builder_tag == strong with $strong in status files
The `$builder_tag == strong` annotations were added before test.py
supported `$strong`.  Now that `$strong` is supported, it's better to
use it directly to avoid confusion.

Change-Id: I715edecaee1e36ab8a26dbc96a6aa056e1be018f
Reviewed-on: https://dart-review.googlesource.com/39600
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-02-07 11:50:10 +00:00
Dan Rubel b2c5415db9 Rework parseClassMember to remove findMemberName
This CL finishes the process of removing findMemberName from parsing
class members and sets the stage for improved recovery.
In addition, this CL:

* Revises the `endMethod` event to include a beforeParam token
    so that the parser can revise the token stream before the parameters
    during recovery.

* Reworks insertSyntheticIdentifer for use in more places

Change-Id: If5bcd6f554053f72429e938b5cd5e7021e03d5b3
Reviewed-on: https://dart-review.googlesource.com/39320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-02-06 21:01:53 +00:00
pq e1f4a9a533 Analyzer status updates (in quest for greenness) [TBR].
This should get us at least part of the way back to green.

(nosuchmethod_forwarding_test next)


Change-Id: I21e98dd6739b6d9f4d94373a647451d05e637840
Reviewed-on: https://dart-review.googlesource.com/38860
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2018-02-05 21:25:34 +00:00
Aske Simon Christensen 89e1fa5df3 Status for bad_constructor_test/06
Missing status updates for https://github.com/dart-lang/sdk/commit/cff6f514eddaf50318518905742195e152319e37

Change-Id: Ief7131ae3557adc305b44e4eb422ddf7447929c5
Reviewed-on: https://dart-review.googlesource.com/38761
Reviewed-by: Aske Simon Christensen <askesc@google.com>
2018-02-05 16:50:38 +00:00
Sigmund Cherem f541f060ee [fe] deferred access checks for several access patterns of classes.
This adds checks for allocations and type values, and provides a compile
time error for type declarations, is-checks, and as-casts.

Change-Id: I3bfed41b0dd45abeb02158f0537102c779511998
Reviewed-on: https://dart-review.googlesource.com/36383
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-02-02 20:44:16 +00:00
Sigmund Cherem 5428a12b84 Ensure that env includes the actual mixin application fields and procedures.
From the docs of mixedInClass and mixin: the former is the direct thing that is
mixed in, but if it is a named mixin application it may not contain the actual
fields and procedures, instead the `.mixin` class does.

Change-Id: I049ced771925431d613b0b661154c1761fbe0a51
Reviewed-on: https://dart-review.googlesource.com/38161
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
2018-02-02 07:10:30 +00:00
Brian Wilkerson 4cad8c202d Attempt to fix bot status
Change-Id: Ib934765771306d57b218d3691c3bba249f1d90ef
Reviewed-on: https://dart-review.googlesource.com/37863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-01-31 19:51:55 +00:00
Régis Crelier ed1d8bd475 [VM parser] Complete support for generalized void (fixes #30516).
'void' is now allowed as type annotation for locals, fields, and formal
parameters, in addition to being previously allowed as type argument.
Update status files.

Change-Id: I6459f56824dc0a695615d8dc87c9a8a1f9be29ef
Reviewed-on: https://dart-review.googlesource.com/37651
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2018-01-31 00:56:41 +00:00
Brian Wilkerson 1d6b2de09c Another status file update to fix the bots
Change-Id: I4cd60ab7c74573f136db44c2c4075d20abcd6688
Reviewed-on: https://dart-review.googlesource.com/37643
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-01-30 19:47:59 +00:00
Brian Wilkerson f8596607bb Update status files to fix bots
Change-Id: I1659bc7e8ef8452daf44ae6ca30064f01f338272
Reviewed-on: https://dart-review.googlesource.com/37580
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-01-30 17:33:09 +00:00
Johnni Winther 09bb73427e Compute implicit is-tests more precisely.
Closes #21969

Change-Id: If446df1e1ae4cdfb4d32580abb7f12fb213d678c
Reviewed-on: https://dart-review.googlesource.com/35865
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-26 22:26:17 +00:00
Siva Annamalai 8d9d68751a More status file updates
Change-Id: I2a767ba0ce7ab0a8e65add40933a19f969f401cc
Reviewed-on: https://dart-review.googlesource.com/36161
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-01-21 06:36:02 +00:00
Sigmund Cherem 7e78f0a952 Update more dart2js .status files
This covers legacy mode,  but using fasta.

Change-Id: I7af9518d8a69512012400f6215d0195fb6069e51
Reviewed-on: https://dart-review.googlesource.com/36060
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-19 20:41:47 +00:00
Erik Corry 25f08d3c5c Disable cyclic_type_test/03 which is failing
R=ahe@google.com

Bug: 31944
Change-Id: I7474f4356c3569a95a28110b69f274c785356203
Reviewed-on: https://dart-review.googlesource.com/35961
Commit-Queue: Erik Corry <erikcorry@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-01-19 15:33:25 +00:00
Vyacheslav Egorov 01658c8491 [gardening] Fix error in language.status file.
TBR=ahe@google.com

Change-Id: Ia9033eefd271d36d9945e7d0d812f925eec653be
Reviewed-on: https://dart-review.googlesource.com/35980
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-01-19 14:32:53 +00:00
Lasse R.H. Nielsen 08edf99bde Mark language/cyclic_type_test/03 as crashing on one platform.
Change-Id: Ifc612e692cedeb105e9bebdbddacaeb48f66a2cc
Reviewed-on: https://dart-review.googlesource.com/35963
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-01-19 14:06:32 +00:00
William Hesse 17bc2b78c4 Update status for a language test with a fasta compile-time error
Bug: https://github.com/dart-lang/sdk/issues/31935
Change-Id: Ifc25e8d4684879184418cb9e3d2f71cc71a88c30
R: ahe@google.com
Reviewed-on: https://dart-review.googlesource.com/35880
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-01-19 09:03:29 +00:00
Jens Johansen 55f4a6e56c [kernel] Update status after fix of #31817 (take 2)
Change-Id: I2e9576042d8476fc2b7f7c1857f0c6210038a81b
Reviewed-on: https://dart-review.googlesource.com/35861
Reviewed-by: Jens Johansen <jensj@google.com>
2018-01-19 07:53:22 +00:00
Sigmund Cherem a4df86676f Adjust .status files
CL https://dart.googlesource.com/sdk/+/3fcede3c7f57a9b3457cae83d928694b864f01bd
changed the behavior. A similar change was included for language_2, this is the
same kind of changes for the old language/ suite.

TBR=ahe@google.com

Change-Id: I4ea256442481d92bbb7eaa4d4d47294f5222e8d0
Reviewed-on: https://dart-review.googlesource.com/35808
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-18 22:11:14 +00:00
Sigmund Cherem e2ad2db805 Generate checks for library-is-loaded to fasta and dart2js.
Change-Id: Ibf453ca7390b81da7231dcb1be43e426c00d6eeb
Reviewed-on: https://dart-review.googlesource.com/35100
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-01-18 20:17:14 +00:00
Erik Corry 5ed2f25f40 There is no longer a safarimobilesim test runtime.
And so there is no need to maintain status files for this platform.

R=whesse@google.com

Change-Id: Ie70e4b7308cfd9b1b179b2d1eeeb8f36dd1a62dc
Reviewed-on: https://dart-review.googlesource.com/34824
Commit-Queue: Erik Corry <erikcorry@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-01-17 13:13:17 +00:00
Johnni Winther 897114ff79 Update dart2js_with_kernel status
Change-Id: Icf935c78ba915b487c1213d59b328ab884324e5d
Reviewed-on: https://dart-review.googlesource.com/35140
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-01-17 08:00:40 +00:00
Sigmund Cherem 9cdf04e8ee Mark conditional_import_tests as passing in dart2js
TBR=sjindel@google.com

Change-Id: I6310ce0f1dae916d4075453ed6fcdad2fcb1f38e
Reviewed-on: https://dart-review.googlesource.com/35061
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-17 00:58:26 +00:00
Sigmund Cherem 0e1a407823 Produce a static error when using kernel and mirrors
Just noticed that the 'supportsRelection' flag was not checked when running with
'--use-kernel'.

Change-Id: I9f4bd540ad963c33c8b9013860ac63b1c6707299
Reviewed-on: https://dart-review.googlesource.com/35006
Reviewed-by: Harry Terkelsen <het@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-01-17 00:56:12 +00:00
Sigmund Cherem 96f915faa1 Update status for dart2js-with-kernel after disabling int64 in dart2js
TBR=sra@google.com

Change-Id: I3e13493ba619fb16ed9731fc85fc14938022ef59
Reviewed-on: https://dart-review.googlesource.com/35000
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-01-16 22:30:04 +00:00
Sigmund Cherem 0c04eb53c7 Disable int64 when running dart2js
The goal is to renable it as soon as we migrate our constant-evaluator and
constant folding to use Bigint.

Change-Id: I3bba1bbe07517e9cb496896b3417f58173878d62
Reviewed-on: https://dart-review.googlesource.com/34302
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2018-01-16 19:52:22 +00:00
Sigmund Cherem f1390f7660 Add missing return in loadLibrary tearoff
The code to represent a tearoff of loadLibrary looked like this:

  Future __loadLibrary__lib1 () {
    lib1.loadLibrary();
  }

but should have been like:

  Future __loadLibrary__lib1 () {
    return lib1.loadLibrary();
  }

Change-Id: I31efb5bee9f7e376660602c1b842a90a0a2659a4
Reviewed-on: https://dart-review.googlesource.com/34510
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-01-16 19:35:32 +00:00
William Hesse 63511838dd Update status for failing local function test on dart2js
Bug: https://github.com/dart-lang/sdk/issues/31879
Change-Id: I141e2ef9c4cc40796d3b3198e4183a1c05f0b063
TBR=johnniwinther@google.com
Reviewed-on: https://dart-review.googlesource.com/34382
Reviewed-by: William Hesse <whesse@google.com>
2018-01-12 14:01:01 +00:00
Johnni Winther 8e8915f538 Support generic closures in rti analysis
Change-Id: I1d393cff5b83f8db69e7bddb8ecfcd4a5205854f
Reviewed-on: https://dart-review.googlesource.com/32700
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-08 11:36:40 +00:00
Martin Kustermann 3c5211fd93 [Gardening] Remove passing test from status file
Change-Id: Ie465eb85631e875a295e14f10231bda94f86a6ea
Reviewed-on: https://dart-review.googlesource.com/32764
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2018-01-08 11:18:22 +00:00
Harry Terkelsen 11d1b6f0db update status files after switch case fixes
Change-Id: If0127431e9237478ce12ff495d32eff144781bcd
Reviewed-on: https://dart-review.googlesource.com/32670
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
2018-01-05 23:29:29 +00:00
Alexander Markov c051a0b905 [VM, Tests] Turn Dart 2.0 fixed-size integers ON by default, v2
Dart 2.0 fixed-size integers are enabled in Dart VM in all modes.
Status of legacy tests is updated.

This CL includes ff9fc413a7 with fixes.

Change-Id: I632d8177e9d07cd82ecea75ab6c325681b3a25c9
Reviewed-on: https://dart-review.googlesource.com/32443
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-05 01:44:56 +00:00
Alexander Markov 90551f6aa5 Revert "[VM, Tests] Turn Dart 2.0 fixed-size integers ON by default"
This reverts commit ff9fc413a7.

Reason: buildbot failures.
Change-Id: I68ffde271c8ba3b212e3bf015e2e550c8c891441
Reviewed-on: https://dart-review.googlesource.com/32442
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-01-04 19:04:44 +00:00
Alexander Markov ff9fc413a7 [VM, Tests] Turn Dart 2.0 fixed-size integers ON by default
Dart 2.0 fixed-size integers are enabled in Dart VM in all modes.
Status of legacy tests is updated.

Change-Id: I967a413c0b81eb92cf6be78ad3ee324798288bd2
Reviewed-on: https://dart-review.googlesource.com/31406
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-01-04 18:02:57 +00:00
Sigmund Cherem d85651846f Update .status files
One language test "passes" when we no longer complain about the mixin issue.

Bug:
Change-Id: I5aeb4ead7d3faf6ec756eeb11fecc20bcfb4c16e
Reviewed-on: https://dart-review.googlesource.com/31260
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-12-21 22:49:02 +00:00
Brian Wilkerson 439dfe0c29 Revert "Produce an error if there would be an exception thrown by an assert in an initializer list"
Change-Id: I21553a5a3bf12b7636d9ef507092d0e19f9c0d57
Reviewed-on: https://dart-review.googlesource.com/30041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2017-12-16 01:44:13 +00:00
Brian Wilkerson 71dd8acda1 Produce an error if there would be an exception thrown by an assert in an initializer list
Change-Id: Ia95b2e09c64846d319d940e29c422355ab972da6
Reviewed-on: https://dart-review.googlesource.com/29700
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2017-12-15 23:03:15 +00:00