Sigmund Cherem
4436877ab2
More changes to make bots happy
...
R=efortuna@google.com
Change-Id: If0407436d204d9668a0ed13bf5fe2d36a0e041a9
Reviewed-on: https://dart-review.googlesource.com/41563
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Emily Fortuna <efortuna@google.com >
2018-02-14 23:09:34 +00:00
Sigmund Cherem
50db95f69b
Fixes for CSP: status lines and some test fixes.
...
These failures started showing up when we switched to use chrome instead of DRT
for CSP tests.
Change-Id: I53b70ce18eaef73e720e10fdac05245953131f7c
Reviewed-on: https://dart-review.googlesource.com/41480
Reviewed-by: Emily Fortuna <efortuna@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-02-14 21:54:53 +00:00
Peter von der Ahé
8815bbe90e
Update status files for $compiler == fasta
...
Change-Id: I09761d12b98864d9a9abcc7abe6f046e45951715
Reviewed-on: https://dart-review.googlesource.com/36642
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-07 15:38:09 +00:00
Paul Berry
cca7b4419d
Replace $builder_tag == strong with $strong in status files
...
The `$builder_tag == strong` annotations were added before test.py
supported `$strong`. Now that `$strong` is supported, it's better to
use it directly to avoid confusion.
Change-Id: I715edecaee1e36ab8a26dbc96a6aa056e1be018f
Reviewed-on: https://dart-review.googlesource.com/39600
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-02-07 11:50:10 +00:00
Erik Corry
3c2f9ea88d
More SkipByDesign for tests that were moved
...
R=vegorov@google.com
Change-Id: I9d89ce90428d70ceb48e7eb2b16eb63f0aff8734
Reviewed-on: https://dart-review.googlesource.com/35721
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Erik Corry <erikcorry@google.com >
2018-01-19 09:11:45 +00:00
Erik Corry
5ed2f25f40
There is no longer a safarimobilesim test runtime.
...
And so there is no need to maintain status files for this platform.
R=whesse@google.com
Change-Id: Ie70e4b7308cfd9b1b179b2d1eeeb8f36dd1a62dc
Reviewed-on: https://dart-review.googlesource.com/34824
Commit-Queue: Erik Corry <erikcorry@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-01-17 13:13:17 +00:00
Terry Lucas
476b1e02a9
Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test.
...
Also, updated status files to correctly fix failures in FF, IE and removed other spurious status entries.
R=alanknight@google.com ,vsm@google.com
Change-Id: Ic965103d892ff4d5d119712e3187e829f57cd022
Reviewed-on: https://dart-review.googlesource.com/31800
Reviewed-by: Terry Lucas <terry@google.com >
2017-12-29 23:51:02 +00:00
Terry Lucas
0af98266ab
Revert "Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test."
...
This reverts commit 0c8294e4a0 .
Bug:
Change-Id: Idb35c64fd5365f2669e8aff45765fed74e0f0766
Reviewed-on: https://dart-review.googlesource.com/31440
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
2017-12-23 01:59:38 +00:00
Terry Lucas
0c8294e4a0
Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test.
...
R=alanknight@google.com ,vsm@google.com
Change-Id: I80e82f5aaa3c9748740031d8da139f79e2c0ab70
Reviewed-on: https://dart-review.googlesource.com/31080
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Alan Knight <alanknight@google.com >
2017-12-22 22:57:34 +00:00
Terry Lucas
642b768e87
Fixed default parameter messagePorts for MessageEvent factory.
...
R=vsm@google.com
Change-Id: Ic94ccbe4c29302e44c58791658ce75dff86d9ac2
Reviewed-on: https://dart-review.googlesource.com/29544
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2017-12-14 18:21:25 +00:00
Morten Krogh-Jespersen
3db4b1070b
Normalize all status files and enable presubmit hook.
...
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.
To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.
Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2017-12-07 08:38:30 +00:00
Emily Fortuna
31cb880614
Add parameter type checks in constructor body methods.
...
Bug:
Change-Id: Ic62886aa9db8dbe1f16f85ea528faffdeb299dac
Reviewed-on: https://dart-review.googlesource.com/26044
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Emily Fortuna <efortuna@google.com >
2017-12-05 00:28:04 +00:00
Emily Fortuna
dc1b5525bf
Create temporary Method type in kernel world for compatibility with Dart 1
...
Bug:
Change-Id: I9efa163ce1a9a76df405f32d35850743e7f090cc
Reviewed-on: https://dart-review.googlesource.com/25723
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2017-12-04 19:37:54 +00:00
Emily Fortuna
b7ef9072f1
Set "type" for FutureOr to dynamic (temporarily).
...
Bug:
Change-Id: Ie4a376316c0fa444642c2535c0a97f3245c92fda
Reviewed-on: https://dart-review.googlesource.com/24621
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Emily Fortuna <efortuna@google.com >
2017-11-30 18:18:04 +00:00
Morten Krogh-Jespersen
39907272f6
Remove comments from status files.
...
This will allow for having automatic tools to alphabetize sections and entries.
Bug:
Change-Id: Ia7b7a100ca33197c4f3b1c50c11f24873dfbc09b
Reviewed-on: https://dart-review.googlesource.com/23675
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-11-28 07:56:20 +00:00
Emily Fortuna
d3eef66367
Add function parameter type checks in checked mode with constructors and loop variables.
...
Bug:
Change-Id: Ib3245eb59c9f23b31e4a0b1c65a25f1c2ad3188f
Reviewed-on: https://dart-review.googlesource.com/23143
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Emily Fortuna <efortuna@google.com >
2017-11-22 19:57:04 +00:00
Emily Fortuna
9e5ad7af1a
Populate field setter method body for checked mode.
...
Bug:
Change-Id: I802fc425b998ce1ff1110a7e48215b557035d442
Reviewed-on: https://dart-review.googlesource.com/22300
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Emily Fortuna <efortuna@google.com >
2017-11-21 01:11:07 +00:00
William Hesse
50eb1eccec
Update status files for Firefox Quantum (57.0)
...
Bug:
Change-Id: I1d7a017409e8ff10791f897eea9295a89f8ac8ca
R=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/21542
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com >
2017-11-17 00:00:09 +00:00
Emily Fortuna
c7dadec876
Capture this and type variables in closures in checked mode when needed.
...
Bug:
Change-Id: I9e3bbc658590bcb6ec04cff4323cc2a97c20fc6b
Reviewed-on: https://dart-review.googlesource.com/21321
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Emily Fortuna <efortuna@google.com >
2017-11-16 21:22:41 +00:00
Emily Fortuna
bf94e73568
Fix up type inference to run in checked mode and enable checked mode tests running with kernel script.
...
Bug:
Change-Id: If720b6868fbdf010f4aac614ceea1ddea533c277
Reviewed-on: https://dart-review.googlesource.com/21222
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2017-11-15 22:34:51 +00:00
Lasse R.H. Nielsen
0b58c4bd10
Change some constant declarations to lowerCase.
...
Retain the old values.
Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.
Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen
e61fc07b58
Revert "Change some constant declarations to lowerCase."
...
This reverts commit c048cfb178 .
Reason for revert: VM code fingerprints needs update.
Original change's description:
> Change some constant declarations to lowerCase.
>
> Retain the old values.
>
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
> Reviewed-by: Florian Loitsch <floitsch@google.com >
TBR=lrn@google.com ,floitsch@google.com
Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen
c048cfb178
Change some constant declarations to lowerCase.
...
Retain the old values.
Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Florian Loitsch <floitsch@google.com >
2017-11-14 11:13:04 +00:00
Emily Fortuna
035c85580b
Make fast-startup work with kernel!
...
Bug:
Change-Id: I88bf7fd7609bc816cc6d50daaa7e3a0ec5dc1934
Reviewed-on: https://dart-review.googlesource.com/19403
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-11-09 01:37:25 +00:00
Emily Fortuna
ef68e359a2
Deal with JS-interop default argument values.
...
Bug:
Change-Id: I9f0c26f8716473b445922aac43248b717ce45bb3
Reviewed-on: https://dart-review.googlesource.com/19120
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2017-11-08 23:24:01 +00:00
Harry Terkelsen
c9aa3a688b
Add custom element support to the kernel ssa builder
...
Change-Id: I06ec8bc2f53dd88116abb11655c83783de1d48cd
Reviewed-on: https://dart-review.googlesource.com/16328
Commit-Queue: Harry Terkelsen <het@google.com >
Reviewed-by: Emily Fortuna <efortuna@google.com >
2017-10-25 16:36:29 +00:00
Emily Fortuna
ba3cc12592
Entity-ify trustType in type_builder.
...
Bug:
Change-Id: Ie58b98f5a23268e97d2730f4f694d125ae9baf93
Reviewed-on: https://dart-review.googlesource.com/15060
Reviewed-by: Stephen Adams <sra@google.com >
2017-10-19 17:15:20 +00:00
Harry Terkelsen
f36b1f49d6
Only set model.scopeInfo for the outer member, not nested closures
...
Change-Id: I848e18e1000158b4a198782227bfb2524104e805
Reviewed-on: https://dart-review.googlesource.com/14700
Reviewed-by: Emily Fortuna <efortuna@google.com >
2017-10-18 21:00:06 +00:00
Emily Fortuna
2b33f79dd1
Update localsMap when inlining or looking at super constructors.
...
Bug:
Change-Id: I60b2d0d87d84901817d7d03b685a068c9d2f6100
Reviewed-on: https://dart-review.googlesource.com/14621
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2017-10-18 17:58:32 +00:00
William Hesse
601e822ce9
Update status for Chrome 62 stable
...
Bug:
Change-Id: I3c554583dbd9fabc01664e21d86248768db551a4
R=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/14765
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com >
2017-10-18 12:02:56 +00:00
Emily Fortuna
e3d0a7093c
Test TypeVariables in isTest correctly (and non-type variables) in Kernel.
...
Bug:
Change-Id: I624e7a111841bcab77d370163ac21d2c5cc3010a
Reviewed-on: https://dart-review.googlesource.com/13681
Reviewed-by: Stephen Adams <sra@google.com >
2017-10-14 00:20:44 +00:00
Harry Terkelsen
d62eb05435
Search for members in superclasses when searching for a class member
...
This changes 'hasConcreteMatch' to search the superclass chain in the
kernel implementation. This matches what the Element model does.
Change-Id: I6a0ab69bc7e6fe705139d6fa69fffc2346582702
Reviewed-on: https://dart-review.googlesource.com/12843
Commit-Queue: Harry Terkelsen <het@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2017-10-11 22:07:11 +00:00
Emily Fortuna
a40fd8b507
Fixed up JS Interop, correct "native" detection, and made HN angular app run!
...
Bug:
Change-Id: Iea339d62d891661d6d1415424b12ac3f914b046e
Reviewed-on: https://dart-review.googlesource.com/12460
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2017-10-10 18:26:54 +00:00
Emily Fortuna
b364883108
More changes to get angular app compiling.
...
The html status updates are unrelated, but the result of running our status update script.
Bug:
Change-Id: Ibeafda58f0bf750ebc7434c85bcf8fb08b14f590
Reviewed-on: https://dart-review.googlesource.com/8736
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2017-09-28 19:37:25 +00:00
Emily Fortuna
8bd22ffd28
Fix log parsing script to handle group names with spaces in them.
...
Bug:
Change-Id: If538d7e18af850e973ce0236e6949b7dbe36ba09
Reviewed-on: https://dart-review.googlesource.com/8733
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-09-27 18:13:54 +00:00
Emily Fortuna
fe9d02855b
Add html tests for dart2js kernel testing.
...
Bug:
Change-Id: I4d28af58a655f76ea639c8f048e86738afb2e108
Reviewed-on: https://dart-review.googlesource.com/8720
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-09-26 21:19:57 +00:00
Emily Fortuna
bc8229f3c9
Small update to status files after Chrome update to 61.
...
TBR
Bug:
Change-Id: I6ea24c360359a59a388f33a02c83396bcf201097
Reviewed-on: https://dart-review.googlesource.com/3683
Reviewed-by: Emily Fortuna <efortuna@google.com >
2017-09-06 17:41:27 +00:00
Terry Lucas
0585e74b63
Fixed analyzer test to use dart2js not dartium
...
R=paulberry@google.com
Committed: https://github.com/dart-lang/sdk/commit/704de3bb3e27313c0eb6eb5ebc03173a5396dd1e
Review-Url: https://codereview.chromium.org/3004153002 .
2017-09-01 09:03:16 -07:00
William Hesse
a8cab7a205
Revert "Removed Dartium SDK libs"
...
This reverts commit 4a58918382 .
That commit seems to have broken docgen on the html libraries.
BUG=
TBR=terry@google.com
Review-Url: https://codereview.chromium.org/3004173002 .
2017-09-01 00:47:57 +02:00
Terry Lucas
4a58918382
Removed Dartium SDK libs
...
First stage remove the libraries that are no longer part of 1.25 and beyond.
R=alanknight@google.com , sigmund@google.com
Committed: https://github.com/dart-lang/sdk/commit/a18908461adc431af2ee0114ed5ea9ef781bfb67
Committed: https://github.com/dart-lang/sdk/commit/d96561af083777ac9529c75ae05b6e89f8f06a6c
Review-Url: https://codereview.chromium.org/3008563002 .
2017-08-31 07:17:23 -07:00
Terry Lucas
f1269525a8
Revert: Removed Dartium SDK libs
...
Review-Url: https://codereview.chromium.org/3005913003 .
2017-08-30 20:47:07 -07:00
Terry Lucas
d96561af08
Removed Dartium SDK libs
...
First stage remove the libraries that are no longer part of 1.25 and beyond.
R=alanknight@google.com , sigmund@google.com
Committed: https://github.com/dart-lang/sdk/commit/a18908461adc431af2ee0114ed5ea9ef781bfb67
Review-Url: https://codereview.chromium.org/3008563002 .
2017-08-30 20:07:15 -07:00
Alan Knight
d5d867235d
More status fixes
...
BUG=
Review-Url: https://codereview.chromium.org/2987083002 .
2017-07-28 17:54:33 -07:00
Alan Knight
4c9b6c8437
Fix some test suppressions for Chrome 60
...
BUG=
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2986153002 .
2017-07-28 12:39:04 -07:00
Sigmund Cherem
64adc3c87b
update status files: fixes roll of chrome 60
...
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2988903002 .
2017-07-26 15:11:58 -07:00
Terry Lucas
d0d5d6cc25
Revert "Revert "Removed Dartium test exceptions""
...
This reverts commit b85f66253c .
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2984613002 .
2017-07-19 05:51:54 -07:00
Johnni Winther
b85f66253c
Revert "Removed Dartium test exceptions"
...
This reverts commit 84f079f24c .
Review-Url: https://codereview.chromium.org/2983073002 .
2017-07-19 13:31:32 +02:00
Terry Lucas
84f079f24c
Removed Dartium test exceptions
...
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2983033002 .
2017-07-18 13:18:14 -07:00
Kevin Moore
500f5cb324
2nd try: SDK dep cleanup
...
Retry https://github.com/dart-lang/sdk/commit/7a9cc03c09
Which was reverted at https://github.com/dart-lang/sdk/commit/b6d15d87bc
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2978233002 .
2017-07-18 13:13:50 -07:00
Kevin Moore
b6d15d87bc
Revert "Remove several packages from DEPS"
...
Looks like we have tests that require these
This reverts commit 7a9cc03c09 .
Review-Url: https://codereview.chromium.org/2980303002 .
2017-07-18 07:36:37 -07:00