dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
53,966 Commits 2 Branches 0 Tags
a412f24e4151dfd9b1ecfe996bfdd6772c7675cd
Commit Graph

3556 Commits

Author SHA1 Message Date
Sigmund Cherem 50db95f69b Fixes for CSP: status lines and some test fixes. 
These failures started showing up when we switched to use chrome instead of DRT
for CSP tests.

Change-Id: I53b70ce18eaef73e720e10fdac05245953131f7c
Reviewed-on: https://dart-review.googlesource.com/41480
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-02-14 21:54:53 +00:00
Lasse R.H. Nielsen fed7120b07 Make UnmodifiableMapView not lose unmodifiability on cast/retype. 
Change-Id: I44c084353b35e16cd2fd5481d86a7be6c0b62ef3
Reviewed-on: https://dart-review.googlesource.com/41160
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-02-14 12:49:23 +00:00
Johnni Winther f2b8cafb44 Handle assert in initializers of constant constructors. 
Change-Id: Ibb4053af00392b3c43177c60c8551cc6ffe937eb
Reviewed-on: https://dart-review.googlesource.com/38320
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-02-13 14:00:01 +00:00
Johnni Winther d30aaaa4b8 Ensure no type parameters on constructors. 
Change-Id: I6a40e2f74b8a89e5873d94d406a56f82db0d0b48
Reviewed-on: https://dart-review.googlesource.com/40526
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-02-13 11:11:05 +00:00
Johnni Winther 41118c438e Reimplement runtime type checks computation 
Change-Id: Ic1baa96e60db30cf9afe3414e605f0200361583b
Reviewed-on: https://dart-review.googlesource.com/37560
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-02-12 13:29:30 +00:00
Johnni Winther ca8aacc981 Add rti_emission_test.dart 
Closes #32055

Change-Id: Ic33be29a70b88dee2271d121958c25716dc4e6db
Reviewed-on: https://dart-review.googlesource.com/38540
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-02-12 10:35:20 +00:00
Sigmund Cherem 521188f838 Fix deferred loading in the presence of type parameters too 
(and get rid of a TODO(redemption) that I should have fixed eons ago...)

Change-Id: I218a7bddcc8256ff84b4ec03b54a858e8f5d8687
Reviewed-on: https://dart-review.googlesource.com/40180
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-02-09 00:25:26 +00:00
Dan Rubel d4f2f9cef2 Update fasta parser to report constructor initializer errors 
This CL updates the fasta parser to report three additional
errors in constructor initializers:

* ExpectedAnInitializer
* MissingAssignmentInInitializer
* RedirectingConstructorWithBody

I also added a comment from a discussion about
https://dart-review.googlesource.com/c/sdk/+/39320

Change-Id: Iecb6fe97e3612a11ccc89864a4fc9f353846504c
Reviewed-on: https://dart-review.googlesource.com/40040
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-08 18:08:40 +00:00
Johnni Winther b7ef215604 Ensure no function type variables on constructors 
Closes #32069

Change-Id: I9e8e35aad7844863717d19d6335da87b9c823375
Reviewed-on: https://dart-review.googlesource.com/39700
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-02-08 09:09:09 +00:00
Emily Fortuna ef3c271542 Generate signature function in strong mode (previously was behind a flag). 
Change-Id: Ia99623beb4f5cbba719833af2d710702d2caaa6d
Reviewed-on: https://dart-review.googlesource.com/38902
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-02-07 23:02:40 +00:00
Johnni Winther a3964bd479 Only add type argument count to generic invocations. 
Change-Id: Iee137f74002fea74189d23bff9f27515b4daf224
Reviewed-on: https://dart-review.googlesource.com/35926
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-02-07 12:18:31 +00:00
Paul Berry cca7b4419d Replace $builder_tag == strong with $strong in status files 
The `$builder_tag == strong` annotations were added before test.py
supported `$strong`.  Now that `$strong` is supported, it's better to
use it directly to avoid confusion.

Change-Id: I715edecaee1e36ab8a26dbc96a6aa056e1be018f
Reviewed-on: https://dart-review.googlesource.com/39600
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-07 11:50:10 +00:00
Lasse R.H. Nielsen 6f78471687 New methods on Iterable, List, Set, Queue, Map. 
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.

Change-Id: I7a12fea533d42b0fc8357086649df38ad01f3cdd
Reviewed-on: https://dart-review.googlesource.com/39140
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-02-07 06:12:53 +00:00
Sigmund Cherem 2847a8b3af Retain type arguments in closures if needed for .runtimeType 
Change-Id: I07781ffaf19d1a2099c5a45509ec93545514e61a
Reviewed-on: https://dart-review.googlesource.com/39300
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-02-06 21:54:58 +00:00
Dan Rubel e1e7ab1c3d Fasta parser cleanup 
This separates and cleans up externally called fasta parser methods
such as parseTopLevelMember and parseMember from internal callers.

* Split external and internal calls to parseTopLevelMember
    so that external callers use parseTopLevelMember
    and internal callers use parseTopLevelMemberImpl.

* Rename the externally called parseMember --> parseClassMember
    and the internally called parseClassMember --> parseClassMemberImpl

* Revise the insertSyntheticIdentifier method and cleanup some
    exiting recovery code to use it.

Change-Id: Ic66ddcbbe761937bb917c679590fc7de2fdd0396
Reviewed-on: https://dart-review.googlesource.com/39080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-02-06 16:34:43 +00:00
William Hesse 9c35cff5cd Revert "New methods on Iterable, List, Set, Queue, Map." 
This reverts commit 0b59f24f97.

Reason for revert: Creates crashes in dart2js with kernel, see
https://luci-milo.appspot.com/buildbot/client.dart/dart2js-linux-d8-minified-1-5-be/9751

Original change's description:
> New methods on Iterable, List, Set, Queue, Map.
> Changes signature of Iterable.singleWhere.
> Makes LinkedHashMap no longer be a HashMap.
> 
> Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
> Reviewed-on: https://dart-review.googlesource.com/32541
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Leaf Petersen <leafp@google.com>

TBR=lrn@google.com,leafp@google.com

Change-Id: Iab904f5885a5213ae2e16ef496eed0b6843185f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39060
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-06 13:32:19 +00:00
Lasse R.H. Nielsen 0b59f24f97 New methods on Iterable, List, Set, Queue, Map. 
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.

Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
Reviewed-on: https://dart-review.googlesource.com/32541
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-02-06 11:17:46 +00:00
Dan Rubel 64374c1a83 Update status files 
Change-Id: I1ab483c50bec5d373f31a7e2f946b0fd2433ee44
Reviewed-on: https://dart-review.googlesource.com/38660
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-02-05 13:52:18 +00:00
Harry Terkelsen 1fcbe23b8f Fix issue in resolving annotations that refer to annotated types 
Change-Id: Ifcef137ec51e26d3e1a2505fd4845fe63f670318
Reviewed-on: https://dart-review.googlesource.com/38181
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2018-02-02 18:14:37 +00:00
Sigmund Cherem 3b6d39cc2c Correctly defer typedef references 
Change-Id: I61fb5ebb399dcfca5193b7ae870badc10add23e5
Reviewed-on: https://dart-review.googlesource.com/37880
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-01-31 21:10:29 +00:00
Dan Rubel ec7435945d Remove findMemberName from parseTopLevelMember 
This CL refactors parseTopLevelMember so that it does not scan ahead
using findMemberName. This is the next step in removing findMemberName
to improve top level declaration recovery.

Change-Id: I4d949f72cba5618541448c08e1756bf45a4d1762
Reviewed-on: https://dart-review.googlesource.com/37680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-01-31 12:04:56 +00:00
Johnni Winther abaabd4773 Remove unneeded RuntimeTypeChecks object 
Change-Id: Ia0d7e842edff4694a74a6d3e43c3c912093c3e9b
Reviewed-on: https://dart-review.googlesource.com/37520
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-01-31 08:00:31 +00:00
Leaf Petersen 991753313f Remove deep future flattening from analyzer and DDC 
Change-Id: Ic48f29adec3a46744b259ba5b2b8ad7d97caa6c2
Reviewed-on: https://dart-review.googlesource.com/37424
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-01-30 18:11:11 +00:00
Johnni Winther 9b0d9a2882 Track type variable tests through generic method invocations. 
Change-Id: Ibb4fdf92ca1085034db5d10c3f10b46f60c70c16
Reviewed-on: https://dart-review.googlesource.com/36941
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-29 09:20:02 +00:00
Johnni Winther f0b5e3466a Refactor collection and printing features for annotations. 
Change-Id: Ib1c1790d883acd51c690237fd4d3374d6e0b92e5
Reviewed-on: https://dart-review.googlesource.com/36740
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-29 08:30:11 +00:00
Johnni Winther 20e363f4b9 Ensure signature functions for --disable-rti-optimization 
- and cleanup/refactor RuntimeTypesChecks(Builder).

Closes #28894

Change-Id: I8d4cd808411532cce6b28c2f233cc4086de6b100
Reviewed-on: https://dart-review.googlesource.com/35982
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-29 08:06:51 +00:00
Johnni Winther 09bb73427e Compute implicit is-tests more precisely. 
Closes #21969

Change-Id: If446df1e1ae4cdfb4d32580abb7f12fb213d678c
Reviewed-on: https://dart-review.googlesource.com/35865
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-26 22:26:17 +00:00
Johnni Winther 588a60f15b Add test for needed runtime checks 
This is added as a precursor to
https://dart-review.googlesource.com/c/sdk/+/35865 to detect to an error
in dart2js_extra/inline_generic_test/04 otherwise introduced.

Change-Id: I25e475709ee821d01694904ef0cade8100b7548b
Reviewed-on: https://dart-review.googlesource.com/36640
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-26 21:51:41 +00:00
Lasse R.H. Nielsen 87e7861ec8 Make Expect.throws not accept an expectation error as a throw. 
Some small clean-up, and fixing one test that relies on the changed behavior.

Change-Id: Ibfed0c41c3121f2dc13a0d67b7534693165eb5e2
Reviewed-on: https://dart-review.googlesource.com/36620
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-25 13:24:03 +00:00
Siva Annamalai 5f5bba2a74 Normalize status files. 
Allow void as a type.
Change-Id: Ia94c50bcc2e4023008da1dad60cdbfc3465d936b

Change-Id: Ibe7d394cf92e6bb45e06770329da857bcb2c84b0
Reviewed-on: https://dart-review.googlesource.com/36127
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2018-01-20 23:02:08 +00:00
Johnni Winther 08cac02761 Mark dummy_compiler_test, recursive_import_test as slow on any runtime 
Change-Id: I04fd0452e9873026050af94e966148ed793b0b70
Reviewed-on: https://dart-review.googlesource.com/36100
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-01-19 23:32:37 +00:00
Harry Terkelsen 2305d7aea1 Fix bug in resolution caused by unresolved fields in annotations 
Fixes #31803

Change-Id: Id50713281934bf51f8684c3acf5936edd48e33e4
Reviewed-on: https://dart-review.googlesource.com/35464
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2018-01-19 23:24:47 +00:00
Johnni Winther 2c405fe8fc Fix testing strong mode only equivalence tests. 
Change-Id: I982472056fc79dac27b2638bd006ad4e1dbc1920
Reviewed-on: https://dart-review.googlesource.com/35640
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-19 22:44:21 +00:00
Johnni Winther ffd18a37ef Track type arguments of static and dynamic calls 
- and use these to optimize for type argument need on instance
methods and closurized static methods.

Change-Id: Id41d8f8aa7639da15fbd24844e397a4524b6ed20
Reviewed-on: https://dart-review.googlesource.com/35261
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-19 22:31:37 +00:00
Johnni Winther 4a82a4fbf5 Ensure type variables in initializers. 
Closes #31715

Change-Id: I45b28b8e42d5246eab0e354506630b7109db0ca1
Reviewed-on: https://dart-review.googlesource.com/36002
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-19 22:23:57 +00:00
Sigmund Cherem 7e78f0a952 Update more dart2js .status files 
This covers legacy mode,  but using fasta.

Change-Id: I7af9518d8a69512012400f6215d0195fb6069e51
Reviewed-on: https://dart-review.googlesource.com/36060
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-19 20:41:47 +00:00
Sigmund Cherem bc22c3e050 Fix custom-loader test: use JS instead of native. 
This makes it possible to run the test with --use-kernel.

Change-Id: Ie992ae0fe557169d44d0873e3d44b89c2aca5292
Reviewed-on: https://dart-review.googlesource.com/35812
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-01-18 23:50:54 +00:00
Johnni Winther 73e35eb035 Update RTI optimization to handle type literal uses 
... for generic methods and local function. Also update capture
conversion to recognize the new kinds of type variables.

Change-Id: I9b8771b0ebe6c9e926712fa31b0bdea966cc6a25
Reviewed-on: https://dart-review.googlesource.com/34600
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-01-17 15:12:55 +00:00
Erik Corry 5ed2f25f40 There is no longer a safarimobilesim test runtime. 
And so there is no need to maintain status files for this platform.

R=whesse@google.com

Change-Id: Ie70e4b7308cfd9b1b179b2d1eeeb8f36dd1a62dc
Reviewed-on: https://dart-review.googlesource.com/34824
Commit-Queue: Erik Corry <erikcorry@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-01-17 13:13:17 +00:00
Johnni Winther 99feac38cc Move unittests 
Change-Id: I23972b65cd839b9e535e4c483312c0e66b43d374
Reviewed-on: https://dart-review.googlesource.com/34820
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-17 10:29:16 +00:00
Johnni Winther 94fc11388a Port inference tests, #5 of 5 
Change-Id: I384056289dfa99991aa42fbe0baadedc6c208b6f
Reviewed-on: https://dart-review.googlesource.com/34586
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-17 10:19:53 +00:00
Sigmund Cherem 0e1a407823 Produce a static error when using kernel and mirrors 
Just noticed that the 'supportsRelection' flag was not checked when running with
'--use-kernel'.

Change-Id: I9f4bd540ad963c33c8b9013860ac63b1c6707299
Reviewed-on: https://dart-review.googlesource.com/35006
Reviewed-by: Harry Terkelsen <het@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-01-17 00:56:12 +00:00
Sigmund Cherem 96f915faa1 Update status for dart2js-with-kernel after disabling int64 in dart2js 
TBR=sra@google.com

Change-Id: I3e13493ba619fb16ed9731fc85fc14938022ef59
Reviewed-on: https://dart-review.googlesource.com/35000
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-01-16 22:30:04 +00:00
Sigmund Cherem 0c04eb53c7 Disable int64 when running dart2js 
The goal is to renable it as soon as we migrate our constant-evaluator and
constant folding to use Bigint.

Change-Id: I3bba1bbe07517e9cb496896b3417f58173878d62
Reviewed-on: https://dart-review.googlesource.com/34302
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-01-16 19:52:22 +00:00
Johnni Winther e01081ef03 Split inference tests to avoid timeout 
Change-Id: I94253b787e9d3356b988fe08115394165823bf52
Reviewed-on: https://dart-review.googlesource.com/34580
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-01-15 08:22:13 +00:00
Sigmund Cherem 72c3c8ea61 Several deferred loading improvements: 
- fix some discrepancies between old and new deferred loading.
  * Kernel is now using the correct world impact
  * For the old FE, I'm more careful about avoiding metadata nodes when mirros
    are disabled as well.
  * Better approximate when a constant is deferred in the kernel codegen

- make 'dump()' independent of the IR, so we can easily compare them side by
  side.

- exclude primitives in kernel since we don't need to track them. I
  didn't change the old front end because it is not as easy to do. I did this
  change because kernel was processing many more constants than the old frontend
  (the old frontend skipped constants that were never evaluated, we have no way
  to do it selectively like that in the new front end).

Change-Id: I337d3fd818753125476b7390da5d900ebdc02709
Reviewed-on: https://dart-review.googlesource.com/34509
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-01-13 01:42:32 +00:00
Harry Terkelsen 93abeeb47e new test fails in minified because runtimeType is minified 
Change-Id: Iedb7bf5d022d313ce24e7a630bb74c05e8d65853
Reviewed-on: https://dart-review.googlesource.com/34502
Reviewed-by: Harry Terkelsen <het@google.com>
 2018-01-12 22:39:59 +00:00
Johnni Winther d539c78af1 Add source information to parameter stubs. 
Change-Id: If942cc13203752361c3104c89190d75979073498
Reviewed-on: https://dart-review.googlesource.com/34440
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-12 21:23:40 +00:00
Harry Terkelsen 33952ad8f6 Add a small repro for dart2js runtime type issue 
Change-Id: Ibe8720565814dd9f7b7c4ea4370548a64a880f21
Reviewed-on: https://dart-review.googlesource.com/34028
Commit-Queue: Harry Terkelsen <het@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-01-12 21:13:40 +00:00
Stephen Adams 87e5a57b9a Fix dart2js_extra/string_interpolation tests 
Old dart2js behaviour is incorrect.
Fasta behaviour is correct as recently specified.

See https://github.com/dart-lang/sdk/issues/30909 for details

Bug:
Change-Id: Ie9b24d19cab81be764cec02baa327283f4a3b3ce
Reviewed-on: https://dart-review.googlesource.com/34225
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-12 19:21:19 +00:00