dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
53,966 Commits 2 Branches 0 Tags
a412f24e4151dfd9b1ecfe996bfdd6772c7675cd
Commit Graph

80 Commits

Author SHA1 Message Date
Jaime Wren cd878bc433 Create the new flag --use-cfe in the analyzer, analysis server and analyzer_cli and migrate the old behavior of --preview-dart-2 to --use-cfe. The --preview-dart-2 flag is now a no-op, with functionality coming soon. 
See https://github.com/dart-lang/sdk/issues/31640

Change-Id: I2db2e7ef6a324cbd5d369b807e331495fed167df
Reviewed-on: https://dart-review.googlesource.com/33121
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2018-01-08 22:37:05 +00:00
Paul Berry 105b170ddb Roll package test to 0.12.29+1 and stack_trace to 1.9.0 
This required some changes to analysis_server, since analysis_server
used to have its own version of pumpEventQueue().  Since
pumpEventQueue() is now provided by the test package, I've removed
analysis_server's version, and I've updated some of the call sites to
pass in "times: 5000" to replicate the old analysis_server behavior.

This also required some changes to analyzer, since the fail() method
is now marked as @alwaysThrows, so no code may follow it without
producing a dead code hint.

Change-Id: Ie5ef3a5cc685c18da02de699e59f63f3bb8865f7
Reviewed-on: https://dart-review.googlesource.com/32683
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-01-07 14:22:23 +00:00
Devon Carew 0a289c8341 Add analysis server analysis domain preview dart 2 tests. 
Bug:
Change-Id: Id1ea8cbd214ec5f117c83f7df31b53456254ff78
Reviewed-on: https://dart-review.googlesource.com/28802
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-12 21:43:29 +00:00
Devon Carew 98f716a8b2 Disable the manage imports on paste feature. 
Bug: https://github.com/dart-lang/sdk/issues/31456
Change-Id: I4045c4a72a0ad3fe66c019cce2499b79c4c2086d
Reviewed-on: https://dart-review.googlesource.com/23960
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-27 20:23:11 +00:00
Devon Carew ee1404e91a Allow analysis server benchmarks to run with --preview-dart-2. 
Bug:
Change-Id: Ifb9a5c596d3ad63012177cfb4e0bd7b107e78aff
Reviewed-on: https://dart-review.googlesource.com/20941
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2017-11-15 07:37:51 +00:00
Brian Wilkerson 35f6d5da1b Correctly handle adding imports when pasting into part files 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/3001733002 .
 2017-08-16 07:43:36 -07:00
Brian Wilkerson ae69313731 Initial implementation of the import-aware copy support 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2988183002 .
 2017-08-01 08:32:12 -07:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt. 
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
 2017-07-13 16:28:18 -07:00
Brian Wilkerson d9754a58e9 Initial implementation of copy/paste support 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2972833002 .
 2017-07-05 14:02:07 -07:00
Brian Wilkerson 7d26ff6d4f Remove some more library directives 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884233004 .
 2017-05-17 08:02:08 -07:00
Brian Wilkerson fb982f5476 Make server use the common protocol classes 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2879273002 .
 2017-05-15 09:35:46 -07:00
Brian Wilkerson e55812a3f2 Unify the server and plugin versions of the generators 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2844273003 .
 2017-04-28 07:46:29 -07:00
Devon Carew d02519aec4 Make the analysis server integration tests driver only. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2820893002 .
 2017-04-17 11:23:38 -07:00
Devon Carew eb1839b8fd Minor changes to the generated spec, and display deprecated methods better. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2800283002 .
 2017-04-15 13:43:36 -07:00
Devon Carew e572bf93ec Add 4 integration tests for the analysis domain. 
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2808623002 .
 2017-04-08 20:56:00 -07:00
Jacob Richman a993294503 Format all analyzer packages 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2753923003 .
 2017-03-16 16:11:43 -07:00
Devon Carew 0f7fc43df5 Remove the --no-error-notification flag. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2713053002 .
 2017-02-23 16:55:46 -08:00
Devon Carew fbb613a3fe Update the statuses of various analysis server integration tests. 
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2717523003 .
 2017-02-23 14:23:55 -08:00
Devon Carew 5e0710617d Tests for analysis.navigation. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2696323004 .
 2017-02-16 14:35:20 -08:00
Brian Wilkerson 06b3f47434 [Gardening] Remove an invalid (and flaky) test 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2681493002 .
 2017-02-06 10:09:03 -08:00
Brian Wilkerson 2f81decdd7 Add a test that server does not send errors when errors have been disabled 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2674863004 .
 2017-02-04 09:46:55 -08:00
Paul Berry c6206ea1de Split "_Driver" tests to separate test files. 
This avoids timeouts on my machine.  Also it makes it easier to disable these tests when necessary.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2627293002 .
 2017-01-12 08:19:19 -08:00
Brian Wilkerson 5ad638c9d3 Add a failing integration test 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2574843002 .
 2016-12-13 11:44:37 -08:00
Konstantin Shcheglov d564b0aaab Send errors notification without delay. 
Update 'analysis.updateContent' integration test.

This might be OK from performance POV - errors are cheaper to send than
for example navigation. And this satisfies the goal of 'analyzing'
notification - that new errors are to be expected.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2567113003 .
 2016-12-12 11:39:47 -08:00
Konstantin Shcheglov f43db9ccfa Update the integration test to make the file with subscription a priority one. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2566243002 .
 2016-12-12 10:51:13 -08:00
Konstantin Shcheglov 2a7612f103 Implement 'analysis.occurrences' for the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2566223002 .
 2016-12-12 10:07:19 -08:00
Konstantin Shcheglov a7222ac09d Implement 'analysis.outline' for the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2571513002 .
 2016-12-12 09:09:45 -08:00
Konstantin Shcheglov 0728e4ee70 Implement 'analysis.getErrors' for the new driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2566013002 .
 2016-12-11 15:27:57 -08:00
Brian Wilkerson 7f36a0d403 Get all integration tests running with the new driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2564863003 .
 2016-12-09 16:12:52 -08:00
Devon Carew f16a0a2a4d Use an import prefix in the analysis server tests; this fixes some issues conflicting with the 
'equals' symbol in the 1.4.0 version of package:path.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2518873002 .
 2016-11-20 10:26:27 -08:00
Mohamed Hayibor 5595b9698d Fix typos 'overriden' to 'overridden' and '@mustCall super' to '@mustCallSuper' (#27853) 
* fix overriden typos to overridden
* Fix @mustCall super to @mustCallSuper
 2016-11-18 09:36:25 -08:00
Brian Wilkerson 99ce88f8bc (TBR) Fix more failing tests 
Review URL: https://codereview.chromium.org/2426723002 .
 2016-10-17 12:57:56 -07:00
Konstantin Shcheglov 05a86a7495 Remove 'initializeTestEnvironment' from 'analysis_server'. 
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2402483002 .
 2016-10-06 10:26:17 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'. 
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
 2016-10-06 08:47:15 -07:00
Konstantin Shcheglov 0223b08a34 Issue 27300. Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE. (Land again) 
The pkg/analysis_server/test/integration/analysis/error_test was fixed.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/27300

Review URL: https://codereview.chromium.org/2366963002 .
 2016-09-23 10:21:21 -07:00
Brian Wilkerson 6ccbef94fc Convert analysis server over to use ContextBuilder 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2286923002 .
 2016-08-29 08:11:53 -07:00
Brian Wilkerson 40a310748a Correctly use sdk passed on command-line 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2276033003 .
 2016-08-24 12:38:21 -07:00
Konstantin Shcheglov 34ae48a6b0 Don't run Analysis Server performance tests in checked mode. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2153163002 .
 2016-07-15 09:05:09 -07:00
Brian Wilkerson f3dc748db5 Add two memory usage benchmarks 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2111743002 .
 2016-06-30 07:44:41 -07:00
Brian Wilkerson 44836f8538 Support the name analysis_options.yaml for analysis options files 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1975963002 .
 2016-05-13 07:33:06 -07:00
Brian Wilkerson 8c22a5f807 Format code in analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1838933003 .
 2016-03-29 08:27:14 -07:00
Konstantin Shcheglov c0d40223bf Issue 25945. Include static/propagateInvokeType for MethodInvocation names into hover. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25945

Review URL: https://codereview.chromium.org/1814893002 .
 2016-03-17 10:29:10 -07:00
Konstantin Shcheglov 168556a3e4 Tweaks for hover. 
1. Include full signature of classes - extends, with and implements clauses.

2. Provide statis type only for variables - for all other elements the static type is always the same as in the signature.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1513943005 .
 2015-12-11 14:25:46 -08:00
pq c4ccdb462a LineInfo line-end detection fixes. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1413783005 .
 2015-10-27 09:39:30 -07:00
pq 808f32d61d Fix to give LineInfo to options error spans. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1417363007 .
 2015-10-26 21:09:48 -07:00
pq 6bce9b2373 One extension manager (to bind them all). 
TL;DR Moves all plugin registration to AE's extension manager.

The rub is that plugin registration wasn't happening right which cropped up in integration testing.  Included is a test that verifies that options are getting properly threaded through to the linter.  (This test failed when we had two Extension Managers.)

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398033004 .
 2015-10-13 16:37:42 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
Paul Berry 03a156c891 Plumb "enableSuperMixins" option through analysis server (implements DEP 34). 
Partially addresses #23772.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1301533003 .
 2015-08-20 09:47:26 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
Konstantin Shcheglov d5d0017e21 Tweak for navigation for URIs. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1246833002 .
 2015-07-20 15:07:00 -07:00