dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
53,966 Commits 2 Branches 0 Tags
a412f24e4151dfd9b1ecfe996bfdd6772c7675cd
Commit Graph

180 Commits

Author SHA1 Message Date
Mike Fairhurst 85973b9a54 Simplify analysis server's excluded file handling 
Change-Id: I30bc19e7c185cb3dffbe5b84d0bd3f7b5b6f585b
Reviewed-on: https://dart-review.googlesource.com/41562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-02-14 22:25:54 +00:00
Brian Wilkerson 4ecd8f7213 Enable the analysis of pubspec.yaml files in server 
Change-Id: I97c66b357d624cdcd6259c099b6421eb87c317c5
Reviewed-on: https://dart-review.googlesource.com/31404
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-24 17:20:42 +00:00
Konstantin Shcheglov 223a78d7bf Listen for watch events and notify AnalysisServer. 
So, AnalysisServer can serve a broadcast Stream and let EditDomain
reset a pending refactoring.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1465
Change-Id: I9462ad623ef261a658655a7445ee0ad9b0029a18
Reviewed-on: https://dart-review.googlesource.com/18426
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-03 15:59:45 +00:00
Brian Wilkerson a715f60d51 Guard against race condition 
Change-Id: Ie689e8e47559760c5955987005def7aef67e8e09
Reviewed-on: https://dart-review.googlesource.com/6262
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-15 21:27:40 +00:00
Brian Wilkerson bd8f5ad79f Guard against getting a watch event before the driver is created 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/3001023002 .
 2017-08-16 14:08:44 -07:00
Brian Wilkerson a420a1fbb5 Remove more dead code from analysis server 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2949103003 .
 2017-06-22 08:21:03 -07:00
Brian Wilkerson e28064f405 Restore partial analysis of analysis options files 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2946313003 .
 2017-06-22 08:00:50 -07:00
Brian Wilkerson 24996fbfe7 Add support to pass the location of the analysis options file to plugins 
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2947743002 .
 2017-06-20 07:41:03 -07:00
Brian Wilkerson e0216fef7f Remove ability to disable new analysis driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2937323003 .
 2017-06-19 08:13:14 -07:00
Devon Carew 0b79e4d20d update the analyzer and analysis server perf tags 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2917183003 .
 2017-06-03 19:51:27 -07:00
Devon Carew 6c1625743c Relax a null check in context_manager.dart. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2915673002 .
 2017-06-01 09:50:00 -07:00
Devon Carew 24b0d1489f Fix an npe in context_manager.dart. 
BUG=

Review-Url: https://codereview.chromium.org/2917453002 .
 2017-05-30 14:29:53 -07:00
Devon Carew 1e7ff6bccf Add the analysis options path to the diagnostics page. 
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2913493002 .
 2017-05-30 13:29:25 -07:00
Brian Wilkerson a6214b3129 Remove more libraries directives from server 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2894883002 .
 2017-05-19 08:42:30 -07:00
Brian Wilkerson 65f492a043 Add support for watch events and error notifications 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842013003 .
 2017-04-26 09:36:26 -07:00
Brian Wilkerson dd49e79f74 Add context information to driver and add hooks for plugin management 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2795743002 .
 2017-04-03 10:13:45 -07:00
Mike Fairhurst 985160c08d Replace making getInnermostContext public with making a getFolder method 
This way SingleContextManager can fulfill the interface too (it can't
provide a ContextInfo, and the concept of `innermost` doesn't really
exist).

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2754473004 .
 2017-03-14 16:13:16 -07:00
Mike Fairhurst ebab20824a Formalizing the hacks letting the angular analyzer plugin run for now. 
Mostly just making private methods public. But also add in some hooks
(via streams and callbacks) that allow the angular analyzer to wrap
analysis drivers in new angular drivers.

This code will likely all be reverted at some point when a much much
better plugin API is available.

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2742343006 .
 2017-03-14 12:09:24 -07:00
Brian Wilkerson 7993dac4f1 Check the type of a map entry before using it (issue 28756) 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2697603005 .
 2017-02-14 12:58:43 -08:00
Konstantin Shcheglov e9794e37b5 Call processOptionsForDriver() before creating the driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2615903002 .
 2017-01-05 11:10:01 -08:00
Konstantin Shcheglov d9930d86cd processOptionsForDriver() is never called with 'optionsRemoved'. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2612783004 .
 2017-01-05 08:47:52 -08:00
Brian Wilkerson a8e9a1f108 Fix updating source factory in driver (issue 28086) 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2571353002 .
 2016-12-14 13:08:23 -08:00
Brian Wilkerson 223513c81a Fix bug when packages file changes in new driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2570623002 .
 2016-12-12 14:03:00 -08:00
Konstantin Shcheglov c4ed99acc9 Support for overlay only files in Analysis Server with the new driver. 
Do we need this at all?

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2571593002 .
 2016-12-12 13:16:04 -08:00
Konstantin Shcheglov 4fa3413596 Renames and comment tweaks for files. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2569623002 .
 2016-12-11 10:11:07 -08:00
Brian Wilkerson c99adefae7 Get some tests running using the analysis driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2562083002 .
 2016-12-09 08:32:39 -08:00
Brian Wilkerson 0ea654a068 Remove the AnalysisOptionsProcessor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559523005 .
 2016-12-07 10:51:33 -08:00
Brian Wilkerson 20baedc660 Reapply "Move the linter core to the analyzer package" 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559773002 .
 2016-12-07 09:57:17 -08:00
Paul Berry 1a172e935b Revert "Move the linter core to the analyzer package" 
This reverts commit 6d9d5f53a1, which
was causing analysis server unit tests to fail.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2561573003 .
 2016-12-07 05:36:46 -08:00
Brian Wilkerson 6d9d5f53a1 Move the linter core to the analyzer package 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2553203002 .
 2016-12-06 09:42:26 -08:00
Konstantin Shcheglov a86fe28658 Send 'analysis.flushResults' on file removal. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2552023002 .
 2016-12-05 13:38:21 -08:00
Brian Wilkerson b81564b623 Add support for generating lints when using the new driver 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2545553007 .
 2016-12-03 07:25:42 -08:00
Brian Wilkerson 37387de83a Exclude files from analysis when using AnalysisDriver 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2536303002 .
 2016-11-29 13:30:22 -08:00
Dan Rubel 74d713ece9 remove support for analyzer configuration in pubspec 
This removes support for having directives like this in your pubspec:

analyzer:
  configuration: test_pack/config

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2511963002 .
 2016-11-20 20:44:04 -05:00
Dan Rubel 9ec7547323 update ContextManager to support analysis option include directive 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2514533002 .
 2016-11-17 15:36:33 -05:00
Konstantin Shcheglov d0ee9613d4 Fix disposing context with the new driver. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2489523008 .
 2016-11-10 13:13:06 -08:00
Konstantin Shcheglov b6c02291b8 Notify all drivers about all changed files. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2489063002 .
 2016-11-09 11:32:02 -08:00
Konstantin Shcheglov 0257eeb4f5 Simplify handling of watch events for the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2463903002 .
 2016-10-31 11:00:22 -07:00
Konstantin Shcheglov 6826e267b9 Integration of the new analysis driver, behind a flag. 
The flag is --enable-new-analysis-driver, disabled by default.

WIP, only error notifications for now.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2465923002 .
 2016-10-31 09:54:31 -07:00
Brian Wilkerson 685e4ff9e1 Revert "Remove unused option in server API" 
Review URL: https://codereview.chromium.org/2382033003 .
 2016-09-30 10:14:12 -07:00
Brian Wilkerson 2972bd0d6b Remove unused option in server API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2382053002 .
 2016-09-30 09:04:38 -07:00
Konstantin Shcheglov 09b0bba932 Issue 27358. Reset AnalysisContext 'sourceFactory' and 'typeSystem' on analysis options change. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27358

Review URL: https://codereview.chromium.org/2361203004 .
 2016-09-23 09:44:47 -07:00
Brian Wilkerson c369a8449e More clean-up in server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2350143004 .
 2016-09-20 08:39:43 -07:00
Brian Wilkerson 6c448b6938 Move exception support to its own library 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2328043002 .
 2016-09-10 11:04:19 -07:00
Brian Wilkerson 5bd4de469e Clean up warnings and hints 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2324463006 .
 2016-09-09 09:09:59 -07:00
Paul Berry 94309733cd Revert "Remove unnecessary hide clauses" 
The `Resource` class wasn't removed from the SDK until version
1.20.0-dev.0.0, which was only recently published.  Reverting this
change to allow people using older SDK releases a little more time to
upgrade.

This reverts commit 2cdafd82c2.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2299243002 .
 2016-09-01 16:08:43 -07:00
Brian Wilkerson 2cdafd82c2 Remove unnecessary hide clauses 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2305453002 .
 2016-08-31 16:44:52 -07:00
Brian Wilkerson 6ccbef94fc Convert analysis server over to use ContextBuilder 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2286923002 .
 2016-08-29 08:11:53 -07:00
Konstantin Shcheglov af6bd2ef88 Use SdkExtensionFinder in the old Analysis Server implementation. 
To be replaced with ContextBuilder of course.
But we need this for the time being.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2272093003 .
 2016-08-24 13:58:16 -07:00
Brian Wilkerson 5b26441dbf Convert server and cli and deprecate the old implementation 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2214613003 .
 2016-08-04 11:28:16 -07:00