Commit Graph

838 Commits

Author SHA1 Message Date
scheglov@google.com a3dcd4e8f8 Issue 7469. Report error if type appears in for extends and implements clauses
http://code.google.com/p/dart/issues/detail?id=7469

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11612027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16282 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 19:49:12 +00:00
scheglov@google.com 0abc92dae5 Tweak to support 'dart.core' as core library name.
Needed to commit again https://codereview.chromium.org/11419032/

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11615031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16278 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 19:11:20 +00:00
devoncarew@google.com 9743106bba Fix for a file encoding isuse in DartAnnotation.java.
https://code.google.com/p/dart/issues/detail?id=7431
Review URL: https://codereview.chromium.org//11606018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16264 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 17:30:58 +00:00
scheglov@google.com 2c93012cc4 Issue 6971. Don't report error for using built-in identifier as part of parameterized type.
http://code.google.com/p/dart/issues/detail?id=6971

It seems that this is official position of Gilad, so I just do what is he thinks is right.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11571029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16180 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 21:24:38 +00:00
scheglov@google.com 47346c8fa4 Issue 7093. Support for inlining function references.
http://code.google.com/p/dart/issues/detail?id=7093

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11577022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16170 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 17:54:26 +00:00
scheglov@google.com 7ed0ec0e3d Issue 7373. Fix for marking abstract methods as overriding themselves.
http://code.google.com/p/dart/issues/detail?id=7373

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11569021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16143 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 22:25:49 +00:00
scheglov@google.com 4d1840ce18 Issue 6974. Report warning when arguments are given for 'dynamic' or type variable.
http://code.google.com/p/dart/issues/detail?id=6974

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11569014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16135 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 19:12:39 +00:00
scheglov@google.com 694b17e439 Issue 6971. Fixes for using built-in identifier as import prefix.
http://code.google.com/p/dart/issues/detail?id=6971

Only first part of issue.
I don't agree that code like this is valid:
   abstract<dynamic> v;

I think "abstract" here is still type annotation, so error should be reported.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11549028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16086 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 01:16:41 +00:00
scheglov@google.com 3d808f8e63 Issue 7271. If class has method call() with type F, class should be considered as subtype of function type F
http://code.google.com/p/dart/issues/detail?id=7271

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11442061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16058 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 20:02:51 +00:00
scheglov@google.com 2069cc083d Issue 2862. Report warning when 'default' of switch has fall-through.
http://code.google.com/p/dart/issues/detail?id=2862

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11555015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16052 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 17:15:11 +00:00
scheglov@google.com a691a8955c Issue 6836. Reference to prefixed undeclared identifier in static context is also warning
http://code.google.com/p/dart/issues/detail?id=6836

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11548014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16050 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 16:56:30 +00:00
scheglov@google.com 2a7af69179 Issue 7278. Report static warnings for redirecting factory constructors
http://code.google.com/p/dart/issues/detail?id=7278

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11549014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16046 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 16:32:37 +00:00
scheglov@google.com 67eca2faa2 Issue 6710. Report error for function libteral with return type and name.
http://code.google.com/p/dart/issues/detail?id=6710

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11533010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16019 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 06:23:35 +00:00
scheglov@google.com 1f37d21d41 Issue 7282. Report error for deprecated === and !==
http://code.google.com/p/dart/issues/detail?id=7282

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11534013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15989 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 18:26:02 +00:00
keertip@google.com ab854d4573 fix for dartbug.com/7234 - URI exception for web_audio
Review URL: https://codereview.chromium.org//11515006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15931 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-10 20:52:01 +00:00
scheglov@google.com b7cbab1a19 Enabled reporting problems in some libraries.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11464004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15802 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 19:14:50 +00:00
scheglov@google.com 3e298ec9ed Ignore not all, but only some problems in dart:core
http://code.google.com/p/dart/issues/detail?id=7128

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11447018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15760 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-05 23:06:28 +00:00
scheglov@google.com 0aa59c4802 Issue 7128. Don't show problems in dart:core
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11415291

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15701 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-04 19:43:13 +00:00
scheglov@google.com 4769c45988 More co19 clean up.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11421216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15700 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-04 18:58:24 +00:00
scheglov@google.com 5679566f2d More co19 triage.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11428131

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15644 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 17:49:07 +00:00
scheglov@google.com 17d16e41d7 Triage and fixes for co19 library tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11416307

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15643 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 17:30:21 +00:00
scheglov@google.com 47d52ca683 Triage some co19 tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11414264

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15597 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 20:19:43 +00:00
scheglov@google.com 9d80840238 Analyze Dart scripts in HTML files.
Right now only for adding markers.

R=devoncarew@google.com,danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//11348291

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15533 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 18:54:50 +00:00
scheglov@google.com 04e18f28de Triage some co19 tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11418233

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15527 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 17:39:02 +00:00
keertip@google.com ee9aba4f8e yet another fix for dart: with "_"
Review URL: https://codereview.chromium.org//11415186

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15513 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 12:32:41 +00:00
scheglov@google.com c6d61ca3d0 Add Analyzer commment line option '--type-checks-for-inferred-types'.
So, users can get same warnings was in Editor, if they want to.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11308256

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15484 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:39:52 +00:00
scheglov@google.com 05fbfbbbb6 Don't warn if inferred type is too generic - such as Object or Collection.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11411236

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15471 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 20:51:57 +00:00
scheglov@google.com fb341a13c0 Issue 6964. Optionally don't warn in Editor when class with noSuchMethod() has unimplemented members.
http://code.google.com/p/dart/issues/detail?id=6964

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11428055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15470 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 20:41:07 +00:00
scheglov@google.com 23d612de8a Native method is not abstract.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11412225

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15467 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 19:41:55 +00:00
keertip@google.com 52d2be32af fix for resolving dart core library names with "_"
Review URL: https://codereview.chromium.org//11416246

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15465 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 19:35:40 +00:00
scheglov@google.com f90ff506ad Issue 6859. Report wrong URI at correct location.
http://code.google.com/p/dart/issues/detail?id=6859

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11280196

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15425 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 23:31:46 +00:00
scheglov@google.com 34aca3a353 Issue 6969. Fix for reporting machine format for EOS error.
http://code.google.com/p/dart/issues/detail?id=6969

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11418190

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15416 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 21:41:18 +00:00
scheglov@google.com c262e9a7bb Issue 5359. Highlight 'on' in try-catch statement.
http://code.google.com/p/dart/issues/detail?id=5359

R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//11418186

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15414 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 21:19:04 +00:00
scheglov@google.com 4f5cbe2eff Allow not only 'Iterator iterator()' but also 'Iterator iterator' (field).
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11419186

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15411 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 19:50:22 +00:00
scheglov@google.com 61776ab7e5 Issue 6881. Import and part URIs can be adjacent strings
http://code.google.com/p/dart/issues/detail?id=6881

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11414175

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15351 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 23:11:26 +00:00
scheglov@google.com a780383353 Issue 6908. Fix parsing look for receiver.() in switch.
http://code.google.com/p/dart/issues/detail?id=6908

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11280155

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15336 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 18:56:12 +00:00
scheglov@google.com 1661792570 Issue 6866. Report not-implemented-in-concrete class warnings if there are members without body.
http://code.google.com/p/dart/issues/detail?id=6866

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11411146

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15335 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 18:45:06 +00:00
scheglov@google.com b67a63c232 Issue 6825. Parse @meta annotations before 'export' directive.
http://code.google.com/p/dart/issues/detail?id=6825

co19 failure should be fixed completely after http://code.google.com/p/dart/issues/detail?id=6836

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11414137

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15331 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 18:31:51 +00:00
scheglov@google.com c19d914af9 Fix for ClassCastException when [name] in comment uses import conflict name.
Was in feedback logs.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11412156

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15327 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 18:05:23 +00:00
scheglov@google.com 1806149f58 Issue 6824. Re-export of conflicting elements is error.
http://code.google.com/p/dart/issues/detail?id=6824

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11308173

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15320 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 17:48:48 +00:00
scheglov@google.com 7b6e1b5a99 Issue 6823. Type variable bounds are type annotations, so there should be warning, not error.
http://code.google.com/p/dart/issues/detail?id=6823

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11414128

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15318 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 17:36:31 +00:00
scheglov@google.com a69c8b98fc Issue 6822. Report error only if import prefix is hidden by top-level element.
http://code.google.com/p/dart/issues/detail?id=6822

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11417135

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15314 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 16:49:05 +00:00
scheglov@google.com 5d7261d837 Issue 6790. Support for '--name=value' options style.
http://code.google.com/p/dart/issues/detail?id=6790

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11411136

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15312 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 16:32:30 +00:00
scheglov@google.com 1277895b47 Issue 6836. Using undeclared identifier in static context is now warning.
http://code.google.com/p/dart/issues/detail?id=6836

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11280135

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15311 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 16:18:35 +00:00
scheglov@google.com 62f9fea6ab Issue 6283. Support type literals as expressions.
http://code.google.com/p/dart/issues/detail?id=6283

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11316096

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15173 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 18:59:53 +00:00
scheglov@google.com d1a6c7a68b Don't allow 'abstract' and 'interface' in dart2js anymore
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11308116

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15170 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 18:41:22 +00:00
scheglov@google.com 83a0ccafa7 Issue 6770. Support for @deprecated on library directive.
http://code.google.com/p/dart/issues/detail?id=6770

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11415065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15169 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 18:39:17 +00:00
scheglov@google.com ae23395701 Issue 6771. Show @deprecated warning for fields.
http://code.google.com/p/dart/issues/detail?id=6771

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11316088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15127 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 02:03:20 +00:00
scheglov@google.com 90bd553412 Issue 6776. Infer sub-type member only if there is only one candidate.
http://code.google.com/p/dart/issues/detail?id=6776

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11348139

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15123 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 23:52:02 +00:00
scheglov@google.com 56e20681ea Issue 6779. Report error for missing getter/setter in unqualified field access
http://code.google.com/p/dart/issues/detail?id=6779

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11280065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15105 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 20:00:39 +00:00