Commit Graph

54 Commits

Author SHA1 Message Date
Brian Wilkerson a3697af085 Update PluginWatcher to be more efficient
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2830063002 .
2017-04-20 09:25:37 -07:00
Brian Wilkerson ba3ed4ba37 Initial support for getting fixes from plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2830863002 .
2017-04-19 15:00:00 -07:00
Brian Wilkerson dd49e79f74 Add context information to driver and add hooks for plugin management
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2795743002 .
2017-04-03 10:13:45 -07:00
Brian Wilkerson 550443f147 Improve performance of PluginLocator by caching results
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2754473005 .
2017-03-16 07:28:34 -07:00
Brian Wilkerson 8afab37d55 Add PluginWatcher to watch for new plugins that need to be run
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2750483006 .
2017-03-15 11:26:14 -07:00
Brian Wilkerson 72323291fe Add an object that can manage which plugins are associated with each context / driver
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2746293004 .
2017-03-14 12:09:53 -07:00
Brian Wilkerson 37c585e842 Make it safe to initialize the notificationManager in server
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2708353008 .
2017-02-23 12:31:15 -08:00
Brian Wilkerson 2e64ccbf84 Add the notification manager
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2692373002 .
2017-02-15 08:04:31 -08:00
Brian Wilkerson a56cee72e5 Extract object creation methods for use by a future test class
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2696853002 .
2017-02-14 12:37:09 -08:00
Brian Wilkerson 92550811ac Add conversion routines from the plugin API to the server API
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2689903002 .
2017-02-12 08:19:13 -08:00
Brian Wilkerson 5d0fa7dc21 Finish file rename operation (TBR)
Review-Url: https://codereview.chromium.org/2685783005 .
2017-02-08 13:56:56 -08:00
Brian Wilkerson 407985cbce Support merging with priority information
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2683673003 .
2017-02-07 10:05:20 -08:00
Brian Wilkerson 37720f012f Use toList to copy lists and clean up errors and warnings
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2685613002 .
2017-02-07 09:00:09 -08:00
Brian Wilkerson ccdf574d49 Add support for merging results from plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2678673002 .
2017-02-07 08:06:59 -08:00
Brian Wilkerson 9c9de9e48c Add code to locate a plugin within a package
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2671773007 .
2017-02-05 11:58:05 -08:00
Brian Wilkerson a8f65e61a9 Initial support for managing partial results from plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2676593006 .
2017-02-04 09:46:08 -08:00
Brian Wilkerson a01afcd1d1 Remove the options plugin
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2569603002 .
2016-12-11 08:38:29 -08:00
Brian Wilkerson 44836f8538 Support the name analysis_options.yaml for analysis options files
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1975963002 .
2016-05-13 07:33:06 -07:00
Brian Wilkerson d87f9c09de Update to use the latest version of the plugin package
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1965083002 .
2016-05-11 09:54:29 -07:00
Konstantin Shcheglov bd76934452 Remove old index and search implementations.
Also rename the new implementation files and classes to remove the
'2' suffix.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1801883002 .
2016-03-14 12:19:40 -07:00
danrubel ac63bc8fe4 update completion extension point to use CompletionContributorFactory
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1495933002 .
2015-12-03 10:02:04 -05:00
danrubel 6fb4f45d6b - move completion contributor extension into new DartCompletionPlugin
- change DartCompletionContributorFactor to return single contributor rather than list of contributors
- remove server field from completion request
- update comments per prior review

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1484853002 .
2015-11-30 13:53:22 -05:00
danrubel 0168336439 create new Dart specific completion contributor extension point
and modify DartCompletionManager to use it

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1470373002 .
2015-11-24 16:12:55 -05:00
Konstantin Shcheglov 0ae251793f Make index provisional API.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1471073002 .
2015-11-23 12:54:55 -08:00
pq 6d9cb5e48a Move diagnostics to diagnostics domain (#24931).
Still flagged `experimental` so no docs created.

See: https://github.com/dart-lang/sdk/issues/24931

BUG=24931
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1453433002 .
2015-11-16 14:10:10 -08:00
Konstantin Shcheglov 508b70bdab Replace Glob implementation.
This makes MDL analysis another 5% faster.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1452473002 .
2015-11-15 12:17:17 -08:00
Brian Wilkerson aaaf7c2de8 Fix glob patterns to work on Windows
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1426353002 .
2015-11-03 15:35:26 -08:00
Brian Wilkerson 879cf82b6b Rework analyzed files support to use globs
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1413643006 .
2015-11-03 07:11:29 -08:00
pq 52fb3b3bab Introducing a lint server plugin.
Avoids introducing an unwanted dependency on the options plugin to server (efects discovered: https://codereview.chromium.org/1411313005/). Also soon to be future home for fixes and completions.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1410553005 .
2015-10-26 12:11:38 -07:00
pq 15c9636924 Backed out validator registration.
Net-net: this bakes in an (unsafe in tests) assumption that the options plugin has been contributed and registered.

Backing out pending a revisit.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1411313005 .
2015-10-26 09:46:09 -07:00
pq 68dc36a3e7 OptionsValidator plugin extension and linter service.
* Adds a new extension point to allow for contributing OptionsValidators.
* Adds a new linter 'service' to server that contributes a lint-aware validator.

You'll notice that the warning code I added is NOT in `errors.dart`.  I did that in anticipation of plugin-specifc warnings living elsewhere.  If that's not the right angle, happy to un-do!

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1418333002 .
2015-10-26 08:50:55 -07:00
pq 140a4f5891 Register .analysis_options files for analysis.
Some oportunistic constant cleanup as well (follow-up from: https://codereview.chromium.org/1399893004/).

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1412213003 .
2015-10-19 09:46:54 -07:00
Brian Wilkerson 3825cf0cd4 Add an experimental domain
R=paulberry@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org/1412683002 .
2015-10-16 12:56:13 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
Brian Wilkerson 8f4c63c92b Restructure the public API for server
R=danrubel@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1392253002 .
2015-10-09 07:57:00 -07:00
Brian Wilkerson 7bbd8c66a5 Move completion APIs to private location
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1383313002 .
2015-10-05 11:57:35 -07:00
Konstantin Shcheglov 4aa6466ccb Use IndexContributor(s) in LocalIndex.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1359113002 .
2015-09-23 08:17:33 -07:00
Konstantin Shcheglov ef2fc0d778 Add OCCURRENCES_CONTRIBUTOR_EXTENSION_POINT_ID.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1337143002 .
2015-09-11 13:59:28 -07:00
Konstantin Shcheglov dfd09f3f66 Extension point for AnalysisResultListener(s).
The plan is that plugins will listen for computed results. For example the Angular
plugin will listen for DART_TEMPLATES and once it sees one, it will schedule
sending the navigation notification, because now the other extension - NavigationContributor
can produce its navigation regions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1303343008 .
2015-09-04 09:56:27 -07:00
Konstantin Shcheglov b15a031276 Navigation extension point.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1303033010 .
2015-09-01 13:06:25 -07:00
Brian Wilkerson 089038b085 Move index closer to the plugin API
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1156493004
2015-06-01 08:25:40 -07:00
Brian Wilkerson ad52c9eab9 Add support for specifying files needing analysis
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1152013002
2015-05-21 14:34:04 -07:00
brianwilkerson@google.com ac3613e2bb Re-apply change to move to plugin package
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1094083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45408 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 18:54:24 +00:00
brianwilkerson@google.com 3d536efcfe Revert breaking change
Review URL: https://codereview.chromium.org//1101213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45384 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 22:12:20 +00:00
brianwilkerson@google.com 24c853446a Convert analyzer and analysis_server to use the plugin package
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1063153004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45382 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 20:32:35 +00:00
brianwilkerson@google.com b63a2e1d78 Add API for contributing to the index
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1060063008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45358 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:11:20 +00:00
brianwilkerson@google.com 1fa696f64d Initial version of completion plugin API
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1095143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45293 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 17:44:41 +00:00
brianwilkerson@google.com dbfb8bf97d Create a public API for contributing assists and make assists pluggable
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1073383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45109 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 16:03:50 +00:00
brianwilkerson@google.com 46064e8f2f Create a public API for contributing fixes and make fixes pluggable
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1080653003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45079 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 21:01:10 +00:00
brianwilkerson@google.com b36c00f15f Temporarily move plugin support
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1027433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44586 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 19:06:22 +00:00