c5fd1308ac
Fix a bug in barback's static package handling.
...
This releases barback 0.15.2+2.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//597343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40645 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-24 20:16:45 +00:00
bc3209656a
Properly handle barback logs after a transformer's been canceled.
...
R=jmesserly@google.com
BUG=20180
Review URL: https://codereview.chromium.org//560293004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40185 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 21:51:49 +00:00
8b4b2aba89
Fix an analyzer error in barback.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//556423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40128 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 22:59:27 +00:00
e934f33074
Add the ability for a PackageProvider to declare static packages.
...
Once pub gets rid of RewriteTransformer, this will allow it to avoid
passing in assets to Barback unnecessarily.
R=rnystrom@google.com
BUG=20859
Review URL: https://codereview.chromium.org//554783003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40118 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 21:13:28 +00:00
6559d6ee37
Adding a lazy transformer example.
...
BUG=
R=nweiz@google.com
Review URL: https://codereview.chromium.org//552843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40008 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 00:43:12 +00:00
8626a6ee40
Add a note to barback indicating that version 0.15.1 should be skipped.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//489603007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39565 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-26 19:58:13 +00:00
c78cb46423
Clean up after r39484 and r39486.
...
In particular, this adds CHANGELOG entries for packages that have been
modified and fixes pub's barback dependency so it doesn't declare
compatibility on an uncut release.
This releases args, barback, http_parser, and shelf.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//506973003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39563 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-26 19:49:44 +00:00
8016f40500
Update dart:collection to version 1.0.0
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//463333004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39484 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-22 08:52:09 +00:00
7e8801fd6b
Only support the new source_span spans in barback.
...
This releases barback 0.15.0, code_transformers 0.2.0+1, observe 0.11.0+2,
polymer 0.12.0+3, and smoke 0.2.0+3.
BUG=19930
R=blois@google.com , rnystrom@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//430973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38762 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-30 23:38:25 +00:00
c59f368e6d
Adding an aggregate transformer example to barback. Also updating the previous examples.
...
BUG=
Review URL: https://codereview.chromium.org//429943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38736 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-30 15:39:29 +00:00
a41478d6e5
Support source_span spans in barback.
...
This releases barback 0.14.2, which supports both SourceSpan and Span.
It will be followed up with barback 0.15.0, which will remove support
for Span.
barback 0.14.1 will be added to third_party/pkg in a follow-up CL.
R=rnystrom@google.com
BUG=19930
Review URL: https://codereview.chromium.org//423823010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38712 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 23:05:22 +00:00
ce4dee2beb
Move pub/barback's Pool class into its own package.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//399963004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38525 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 23:32:06 +00:00
4ac8e0563a
Roll forward revision 37912.
...
Both polymer and code_transformers test flakes should now be fixed.
R=rnystrom@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//367023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37965 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 23:53:57 +00:00
b6d877c05f
Revert revision 37912 - it seems to be causing errors and flake on the pub builders
...
Review URL: https://codereview.chromium.org//366863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37929 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 05:48:40 +00:00
9d2b492764
Automatically log how long each transform runs.
...
These logs are fine, so they won't appear unless the user runs pub in
verbose mode. They also won't appear for transformers that take less
than a second to run.
R=rnystrom@google.com
BUG=16946
Review URL: https://codereview.chromium.org//368463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37912 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 21:57:45 +00:00
e0464f5bf5
Add implicit constraints from pub onto stack_trace and source_maps.
...
These packages are used in pub's plugin isolate, so pub needs to have
a dependency on them to ensure their APIs don't change out from under
it.
R=rnystrom@google.com
BUG=19574
Review URL: https://codereview.chromium.org//356523003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37751 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 20:04:05 +00:00
e833411604
Fix a barback bug where a closed stream could get an event.
...
R=rnystrom@google.com
BUG=19540
Review URL: https://codereview.chromium.org//343963003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37519 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 21:10:15 +00:00
8485b3c12d
Release barback 0.14.1.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//324163003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37206 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 22:12:49 +00:00
aa1f532d1a
Release stack_trace 1.0.0.
...
R=kevmoo@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org//308763003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36891 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 18:40:25 +00:00
ed667e542c
Fix a bug where barback transformers would produce stale output.
...
For the gory details, see the new test in
pkg/barback/test/package_graph/transform/concurrency_test.dart.
R=rnystrom@google.com
BUG=19038
Review URL: https://codereview.chromium.org//306773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36780 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 23:57:27 +00:00
9e82daf42d
Expose aggregate transformers in barback.
...
R=rnystrom@google.com
BUG=18567
Review URL: https://codereview.chromium.org//299833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36777 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 23:33:32 +00:00
b5eabedd8f
Add a "message" field to wrapped barback exceptions.
...
This makes it possible for calling code to get the error message
without the stack trace, if it so desires.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//307543006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36724 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 00:43:11 +00:00
d165520d5d
Handle synchronous asset load errors in barback.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//298133006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36723 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 00:36:45 +00:00
287b119b7a
Fix a bug that caused the fix in r36391 not to work.
...
The first phase in a group considered itself idle even if the previous
phase was running, since it had no contents.
R=jmesserly@google.com
BUG=18872
Review URL: https://codereview.chromium.org//296743004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36398 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 22:43:45 +00:00
3fafeaaa78
Fix a bug when loading secondary assets in barback.
...
If a transformer group was followed by another transformer group, the
second group would sometimes be unable to load secondary assets that
were emitted by the first group.
Also get barback ready to release 0.14.0+1.
R=jmesserly@google.com
BUG=18872
Review URL: https://codereview.chromium.org//281383004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36391 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 22:05:01 +00:00
2a1d545967
Bump the version of barback for release.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//235883013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36382 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 21:06:35 +00:00
dc97d31bc8
Transition barback's infrastructure to an aggregate-based model.
...
Aggregate transformers still aren't exposed publicly, but the normal
transformers are now all wrapped in aggregate transformers.
R=rnystrom@google.com
BUG=18567
Review URL: https://codereview.chromium.org//267393009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36325 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-19 21:11:23 +00:00
951e535c61
Add aggregate transformer types to barback.
...
This doesn't make the types public yet. However, it does run non-aggregate
transformers using AggregateTransform.
R=rnystrom@google.com
BUG=18567
Review URL: https://codereview.chromium.org//262173009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35864 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-07 20:08:56 +00:00
b92c90ad4a
Reorganize barback's source files.
...
This creates four directories beneath barback/lib/src:
* asset/ contains the Asset and AssetNode classes, as well as various
classes for dealing with them.
* graph/ contains the classes that make up the barback asset graph, as
well as utility classes that are specific to these (such as
NodeStreams).
* transformer/ contains Transformer and similar classes (such as
TransformerGroup), as well as the classes (such as Transform) that
are passed to Transformer methods.
* utils/ contains utility classes that aren't barback-specific (such
as CancelableFuture).
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//261823008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35777 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-05 22:58:41 +00:00
5faf3eaaa1
Remove PhaseInput and add TransformerSorter to barback.
...
Aggregate transformers aren't yet supported, but this introduces the
large-scale structure necessary to support them.
R=rnystrom@google.com
BUG=18567
Review URL: https://codereview.chromium.org//260833006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35676 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-02 01:24:54 +00:00
e6026d9236
Don't assume that a transform node is consistently deferred or not.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//255283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35606 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 00:48:38 +00:00
602dbd59c6
Expand barback's notion of dirtiness to understand declaredness.
...
Barback is now able to distinguish between a section of the
transformer graph that could produce arbitrary new assets and one for
which all the transforms have declared their outputs, and so can only
produce a subset of those outputs. This allows requests for assets
that we know won't be generated to be short-circuited, and will
eventually allow us to finish providing inputs to aggregate primary
transformers without waiting for the entire previous phase to complete.
R=rnystrom@google.com
BUG=18226
Review URL: https://codereview.chromium.org//255483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35546 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 21:32:40 +00:00
138d51829f
Move common streams in barback to their own class.
...
This cleans up some duplication and will make it easier to change or
add common streams in the future.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//249183005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35341 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 22:58:50 +00:00
4476df500e
Fix barback test failures.
...
The timing changes caused by allowing transformers to return
non-Futures tickled a race condition in the tests for running
declaring transformers eagerly. This avoids that race condition by
ensuring that the transformers are fully declared before any assets
are requested.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//247813004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35283 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 20:44:47 +00:00
e1ebd97e7c
Don't require Transformer methods to return Futures.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//243793005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35280 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 19:59:26 +00:00
d30621796b
Run declaring transformers eagerly if possible, even if their inputs are deferred.
...
R=rnystrom@google.com
BUG=18270
Review URL: https://codereview.chromium.org//243103003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35279 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 19:49:41 +00:00
7edf663a9d
Fix a deadlock bug with lazy transformer pipelining.
...
A deadlock would occur when a lazy primary input to a lazy transformer
became dirty while the transformer's apply method was running.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//241223005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35181 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-18 20:03:14 +00:00
31c7c483a6
Don't warn if a transformer declares outputs that it doesn't emit.
...
R=rnystrom@google.com
BUG=18285
Review URL: https://codereview.chromium.org//241493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35150 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-17 20:18:13 +00:00
9f15614e94
Lazy transformers followed by non-lazy ones shouldn't always be forced.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//238513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35099 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-15 23:56:11 +00:00
5aa9ef2c40
Make [Barback.getAllAssets] work when called synchronously.
...
This was broken because InputNode didn't take its input being dirty
into account when calculating whether it was dirty, so the synchronous
period between providing Barback with assets and getting those assets'
values had the graph marked as clean but none of its outputs yet
available.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//238503003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35098 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-15 23:54:32 +00:00
b896337e9e
Don't make lazy transformers eager when an asset is requested.
...
Instead, they'll only be active long enough to finish applying, then become lazy
again.
R=rnystrom@google.com
BUG=17903
Review URL: https://codereview.chromium.org//233843002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35055 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-15 01:08:32 +00:00
ff12f81d44
Preserve laziness in declaring transformers.
...
R=rnystrom@google.com
BUG=16442
Review URL: https://codereview.chromium.org//231603005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34945 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 20:57:50 +00:00
c8f7d9ee15
Stop working around issue 14971 in barback.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//230723004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34943 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 20:43:07 +00:00
6e601e5159
Don't treat the primary input as a secondary input in barback.
...
Some transformers use [Transform.readInputAsString] to read their
primary input, which puts it into a weird state of being considered
both a primary and a secondary input. This ensures that it always goes
through the normal [primaryInput] path.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//229833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34905 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 23:51:09 +00:00
5da715ba5a
Only run [declareOutputs] once for each asset/transformer pair.
...
BUG=16442
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//227123007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34892 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 20:23:12 +00:00
a402dfd459
Renaming "examples" to "example".
...
BUG=
Review URL: https://codereview.chromium.org//230143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34859 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 04:13:33 +00:00
7c5db3616b
Only run [Transformer.isPrimary] once for each asset/transformer pair.
...
BUG=16442
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//224933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34857 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 23:59:24 +00:00
da4d59c05e
Only pass an AssetId to isPrimary and declareOutputs.
...
BUG=16442
R=blois@google.com , efortuna@google.com , rnystrom@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//223553008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34853 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 23:46:23 +00:00
31eee5bc11
Adding barback examples.
...
BUG=
R=nweiz@google.com
Review URL: https://codereview.chromium.org//197533004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34851 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 23:19:58 +00:00
135783d3ec
Release barback 0.12.0.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//213593002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34458 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 23:21:54 +00:00
nweiz@google.com