ec5cdd5c26
Fix sort order in engine.dart.
...
TBR=scheglov@google.com
Review URL: https://codereview.chromium.org//792093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42256 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 18:22:42 +00:00
8baaaf9aa1
fix logic for detecting when in an auto-binding element
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//783393005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42254 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 18:05:54 +00:00
8e7dd100f1
Code clean-up
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//792053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42252 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 17:06:19 +00:00
bdb6a6a61f
Instrument communications
...
R=danrubel@google.com , lukechurch@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//790063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42250 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 16:48:08 +00:00
c82b826af1
New getter: FieldElement.isEnumConstant (Dart version of source)
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//790103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42249 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 16:20:49 +00:00
79ae635658
dart2js: don't pass the supername to visitFields.
...
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//761483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42247 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 16:09:15 +00:00
29356bf94a
Incremental compilation of new lazy statics.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//764023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42243 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 14:15:56 +00:00
a4eaf84c1d
Generate typedef node from the element.
...
BUG=
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//764023005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42238 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 09:17:40 +00:00
82e12821d0
Fix crash in typechecker
...
BUG=http://dartbug.com/21793
R=floitsch@google.com
Review URL: https://codereview.chromium.org//787753005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42236 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 08:29:32 +00:00
5a35c6fd0e
Incremental compiler: support optional arguments.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//740273003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42235 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 08:08:12 +00:00
583b9447f5
Rollback r42232.
...
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//785393003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42233 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 01:18:57 +00:00
bd65677ec2
Comment out the function causing CPU burn up.
...
TBR
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//793433004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42232 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 00:46:26 +00:00
8e89586d5d
Fix scheduled_test's constraint on unittest.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//793493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42231 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 00:43:55 +00:00
e24f040b46
skip completion if client closed stream
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//774033003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42229 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 23:57:12 +00:00
4247fe2550
bound the time waiting for analysis to complete
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//790743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42228 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 23:54:06 +00:00
897a446835
Sort Quick Fixes. Make lower priorities more relavant than higher.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//788983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42227 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 22:23:27 +00:00
0871ea96ba
Restrict the version constraints on exported dependencies.
...
This avoids a versioning issue where an exported dependency adds a
feature and the exporting package's users' version constraints become
invalidated.
For example, suppose unittest 1.0.0 and matcher 1.0.0 exist. unittest
has the constraint "matcher: '>=1.0.0 <2.0.0'" and exports matcher.
Then matcher 1.1.0 is released with a new feature, and a user writes a
new package, mypkg, which uses that feature. As per common practice,
this package has the version constraint "unittest: '>=1.0.0 <2.0.0'"
and no constraint on matcher. This constraint allows matcher 1.0.0,
which doesn't support the new feature; this is a problem.
Under the new scheme, unittest would have the constraint "matcher:
'>=1.0.0 <1.1.0'". Then when matcher 1.1.0 is released, unittest 1.1.0
would be released as well with the constraint "marcher: '>=1.1.0
<1.2.0'".
The tight lower bound ensures that the constraint "unittest: '>=1.1.0
<2.0.0'" properly selects only versions of matcher that have features
available in the version the user is testing against. The tight upper
bound ensures that new features in a new version of matcher won't
become available in unittest without a version upgrade.
R=jmesserly@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org//775413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42223 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 21:35:23 +00:00
c2db2b8c0e
Fix the build
...
Review URL: https://codereview.chromium.org//792433005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42221 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 21:24:46 +00:00
0a8dc970d2
Hooks for instrumentation
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//787763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42218 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 20:14:42 +00:00
bd852d8d3e
Make completion tests handle exceptions during getSuggestions().
...
Previously, if an exception occurred during getSuggestions(), or the
future returned by it completed with an error, the completion test
would exit without calling tearDown().
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//787863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42217 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 19:34:48 +00:00
c0d348575c
Disable completion_test on debug builds (it times out).
...
TBR=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//792463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42211 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 17:18:33 +00:00
246112537b
Start running new completion tests.
...
R=brianwilkerson@google.com , danrubel@google.com
Review URL: https://codereview.chromium.org//781333003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42210 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 16:44:12 +00:00
a5f3c39b21
Isolates: allow sending of arbitrary objects in dart2js.
...
BUG= http://dartbug.com/12628
BUG= http://dartbug.com/9245
R=lrn@google.com , sigurdm@google.com , sra@google.com
Committed: https://code.google.com/p/dart/source/detail?r=42161
Reverted: https://code.google.com/p/dart/source/detail?r=42206
Review URL: https://codereview.chromium.org//742873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42209 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 16:41:58 +00:00
67dff7ca30
Revert "Isolates: allow sending of arbitrary objects in dart2js."
...
This reverts commit r42161.
Revert "Update status file."
This reverts commit r42163.
Revert "Update test."
This reverts commit r42165.
Revert "Update status file."
This reverts commit r42166.
Review URL: https://codereview.chromium.org//791543004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42206 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 13:25:23 +00:00
57285d2105
Incremental compilation handles indirectly instantiated classes.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//763083004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42205 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 13:06:58 +00:00
8abca9eb46
Bump pkg/fixnum version so we can pull r38680
...
R=kevmoo@google.com
Review URL: https://codereview.chromium.org//774463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42203 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 04:03:58 +00:00
495cb6d5bf
Issue 21801. Index redirecting constructor invocations.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21801
Review URL: https://codereview.chromium.org//783223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42202 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 02:21:07 +00:00
e30b2b313d
Ignore ButtonType when computing an extracted method return type.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//789543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42201 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 02:19:54 +00:00
f95a58d882
Revert disabled test (r42196).
...
Review URL: https://codereview.chromium.org//786893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42200 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 00:48:29 +00:00
e718ae0eab
Disable failing 'with_test_environment_test' until investigated.
...
Review URL: https://codereview.chromium.org//790573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42196 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 23:03:22 +00:00
600bf9f771
pkg/unittest: fix test after last change
...
TBR
Review URL: https://codereview.chromium.org//750543004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42195 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 22:50:21 +00:00
3b73b01511
Issue 21740. Allow inlining local variables declared in SwitchCase.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21740
Review URL: https://codereview.chromium.org//780653005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42191 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 22:33:07 +00:00
f0bc442ea4
cache suggestions on change in priority sources
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//787663004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42189 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 22:00:16 +00:00
dc9f446021
update computeFast/Full now that completion manager is long lived
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//758953003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42188 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:56:56 +00:00
7a2e37d5ce
Instead of Throwing an error when setting the unittest config if it has already been set we'll just display a warning.
...
https://codereview.chromium.org/772463003/
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42187 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:46:29 +00:00
7cd5226565
Annotate remaining analyzer/analysis server tests with "@ReflectiveTestCase()"
...
In r42181, I failed to notice the need to annotate these tests because
they aren't currently being run under dart2js (most likely due to
slowness). I've modified runReflectiveTests() to check for the
presence of the annotation before running the tests, in order to
ensure that all the classes are properly annotated now, and so that we
won't forget to add annotations in the future.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//742273005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42185 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:35:52 +00:00
e73e5faaad
Getters should not have parameters.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//787603004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42183 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:04:44 +00:00
280657737f
Annotate analyzer tests with @ReflectiveTestCase().
...
Fixes analyzer tests when run under dart2js.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//780763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42181 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:00:51 +00:00
a97ad9a625
Handle "fail_" style tests in reflective tests.
...
There is one corner case we don't handle--we don't catch the case
where the test is expected to fail, but the failure comes from an
asynchronous callback invoked via expectAsync(). Fortunately
expectAsync() is rare enough that this doesn't cause a problem with
any of our existing "fail_" style tests.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//790553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42180 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 20:33:18 +00:00
8bfeac0ca5
Instrumentation support
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//751063005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42179 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 20:30:19 +00:00
75d0e5f3db
Revert "Improve receiver narrowing in type propagation."
...
This reverts revision 42162.
BUG=
TBR=sra@google.com
Review URL: https://codereview.chromium.org//786843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42177 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 20:03:16 +00:00
d05b81598f
Ported completion tests
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//785013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42176 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 20:00:24 +00:00
3f91cbb15e
null check for pub result in PubPackageMapProvider
...
BUG=dartbug.com/21814
R=paulberry@google.com
Review URL: https://codereview.chromium.org//750113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42173 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 18:58:31 +00:00
8ef4de75cd
include lower relevance suggestions only if they are already cached
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//784853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42172 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 18:56:43 +00:00
d675fa46a9
Delete pop-pop-win from the repo
...
Code now lives at: https://github.com/dart-lang/sample-pop_pop_win
Test coverage available at:
http://build.chromium.org/p/client.dart.packages/console
In particular:
http://build.chromium.org/p/client.dart.packages/console?builder=packages-windows-sample-sample-pop_pop_win&builder=packages-linux-sample-sample-pop_pop_win&builder=packages-mac-sample-sample-pop_pop_win&reload=none
R=kevmoo@google.com
Review URL: https://codereview.chromium.org//786443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42171 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 18:52:12 +00:00
cbbcadc423
remove unused cache arguments
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//787653002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42167 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 16:59:02 +00:00
cc4d2af55d
Refactored treatment of closure variables in dart2js CPS.
...
Closure variables are now represented by a ClosureVariable object.
Previously they were identified by a LocalElement.
Parameters to a FunctionDefinition are now a mix of Parameter and
ClosureVariable. FunctionDefinitions also have a list of all the closure
variables they declare.
This change is a step toward supporting field initializers that modify or
capture function parameters.
BUG=
R=johnniwinther@google.com , sigurdm@google.com
Review URL: https://codereview.chromium.org//756383004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42164 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 14:06:23 +00:00
714da403d5
Improve receiver narrowing in type propagation.
...
BUG=
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//771613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42162 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 13:41:05 +00:00
c115b77640
Isolates: allow sending of arbitrary objects in dart2js.
...
BUG= http://dartbug.com/12628
BUG= http://dartbug.com/9245
R=lrn@google.com , sigurdm@google.com , sra@google.com
Review URL: https://codereview.chromium.org//742873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42161 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 13:28:29 +00:00
c3a22ba02d
invoke computeCache when priority sources change
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//787553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42160 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 12:04:32 +00:00
paulberry@google.com