a22d5b98fd
Reapply "[build] Track glob dependencies via depfiles, instead of always re-executing scripts at GN time."
...
Use a relative path for the depfile's target to match Ninja's expectation; otherwise it thinks the target is always dirty.
TEST=build twice
Bug: https://github.com/flutter/flutter/issues/81074
Change-Id: I4cae7ab55f79b5206521c7090502c0769d2b5277
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198443
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2021-05-12 00:27:28 +00:00
5c0ff97acf
Revert "[build] Track glob dependencies via depfiles, instead of always re-executing scripts at GN time."
...
This reverts commit 8d436a2011https://github.com/flutter/flutter/issues/81074
> Change-Id: I3fba7743f89b970dfd8d4d47b21f7d51be7a9cdb
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196981
> Commit-Queue: Ryan Macnak <rmacnak@google.com >
> Reviewed-by: Chinmay Garde <chinmaygarde@google.com >
> Reviewed-by: Ben Konyi <bkonyi@google.com >
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: https://github.com/flutter/flutter/issues/81074
Change-Id: I74c9ce055ad49107ae0d21f2f3b9b74991fc81d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198441
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2021-05-05 23:26:14 +00:00
8d436a2011
[build] Track glob dependencies via depfiles, instead of always re-executing scripts at GN time.
...
Bug: https://github.com/flutter/flutter/issues/81074
Change-Id: I3fba7743f89b970dfd8d4d47b21f7d51be7a9cdb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196981
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Chinmay Garde <chinmaygarde@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2021-04-28 23:10:34 +00:00
e33d023fa0
[BUILD] - Format gn files, this is being done to ensure the unfork CL
...
doesn't show these formatting changes as diffs.
Change-Id: I69ccbf4adabc66d88371cece785a2c1bce60f133
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138962
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2020-03-10 21:56:11 +00:00
ccfafee023
Make list_files.py and list_dart_files.py return absolute paths for GN
...
This makes doing an SDK build in the Fuchsia tree easier.
The previous attempt at this change failed in gyp builds targeting xcode.
They failed because input lists for actions of the same target (e.g. the
actions for dartanalyzer) are merged and de-duped when the lists contain
relative paths, but merged and *not* de-duped when the lists contain
absolute paths. gyp rejects xcode files that it generated itself
when they contain duplicate entries.
This CL works around that bug, by using absolute paths in the GN build
and keeping relative paths in the gyp build.
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2567213002 .
2016-12-13 10:01:28 -08:00
b873e2b8e3
Revert "Make list_files.py and list_dart_files.py return absolute paths"
...
This reverts commit a858542c89https://codereview.chromium.org/2574523002 .
2016-12-12 13:14:53 -08:00
a858542c89
Make list_files.py and list_dart_files.py return absolute paths
...
This makes doing an SDK build in the Fuchsia tree easier
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2564413004 .
2016-12-12 13:09:26 -08:00
8169499ef8
GN: Format more gn files
...
Missed these on the first pass.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2454703004 .
2016-10-27 04:25:34 -07:00
ee21a2261d
Use list_dart_files.py instead of list_files.py in GN build.
...
To track https://codereview.chromium.org/2391863002/ on the
gyp side, and use it in more places.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2392253002 .
2016-10-05 07:50:40 -07:00
7c784cea9f
Linux create_sdk GN build for host
...
This CL enables GN builds of all targets from dart.gyp
on Linux for the host (i.e. ia32, x64).
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2379803002 .
2016-09-29 13:23:00 -07:00
Ryan Macnak