75d15bbfa3
[analysis_server] Support formatter page width from analysis_options in legacy protocol
...
This adds the same support previously added to LSP to the legacy protocol.
As with LSP, the value in analysis_options overrides the explicit argument (since the expectation is that the user has not specifically chosen this value for this file, but rather as a default for the project/globally).
See https://github.com/dart-lang/sdk/issues/56864
[analyzer] Add support for "formatter" in analysis_options + use page_width in LSP
This adds support for validation + completion for `formatter/page_width` in analysis_options, and uses this value in preference to the client-supplied value in the LSP server.
It does not yet add support for the legacy protocol, and there are a few questions in https://github.com/dart-lang/sdk/issues/56864#issuecomment-2399289974 .
See https://github.com/dart-lang/sdk/issues/56864
Change-Id: Ic2be00087f78eb62c409dbc8f558d2f24b521f78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-10-08 17:31:46 +00:00
5d84439f5d
[analyzer] Add support for "formatter" in analysis_options + use page_width in LSP
...
This adds support for validation + completion for `formatter/page_width` in analysis_options, and uses this value in preference to the client-supplied value in the LSP server.
It does not yet add support for the legacy protocol, and there are a few questions in https://github.com/dart-lang/sdk/issues/56864#issuecomment-2399289974 .
See https://github.com/dart-lang/sdk/issues/56864
Change-Id: I7844e3abd1191beb9cc24197bbc8aa7c9e9ad4fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388822
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-10-08 16:37:54 +00:00
d4aa30a3ba
Revert "analyzer: Write out qualified extension names in error messages"
...
This reverts commit 10c1d883dfhttps://github.com/dart-lang/sdk/issues/56269
>
> Change-Id: I025966fd4aa3d7c5b71175321f21f95e8c41f086
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388580
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Commit-Queue: Samuel Rawlins <srawlins@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Change-Id: I613695e90c96e5ffdb4dc56e729dc34be385f5fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388823
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Alexander Thomas <athom@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2024-10-08 15:07:38 +00:00
b2e74ab9da
[Element model] Migrate edit_import_elements.dart
...
Change-Id: If81e7081207960b3a55bc6d6dc0b5488b50e35a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2024-10-07 22:12:39 +00:00
164777e2cd
Part. Deprecate LibraryElement.scope
...
Change-Id: I85a24d0f1d0b4251415644fe1438503e41710436
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388682
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-10-07 20:43:10 +00:00
10c1d883df
analyzer: Write out qualified extension names in error messages
...
Fixes https://github.com/dart-lang/sdk/issues/56269
Change-Id: I025966fd4aa3d7c5b71175321f21f95e8c41f086
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388580
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-10-07 18:01:54 +00:00
3dc879f166
[DAS] Fix go to type definition for formal parameter
...
R=paulberry@google.com
Fixes https://github.com/dart-lang/sdk/issues/56844
Change-Id: Idb5c9420ecd9fda1d961c7211758721c4c4c7522
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388660
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-10-07 17:38:19 +00:00
0bd1bffa84
[analysis_server] Show analysis driver scheduler timings in the diagnostic pages
...
The `AnalysisDriverScheduler` already keeps timings of all of its operations (in `accumulatedPerformance`), but they're not easily accessible to users and might help track down some kinds of performance issues.
This adds a new page to the diagnostics server that shows the timings, as well as a reset button to clear them so they can collect numbers just for a specific operation(s).
It involves some tweaks to the server to handle `POST` (because we shouldn't really use `GET` to mutate anything).
Change-Id: Ia49d471aaa1637a0c978f75569556b26982367d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388561
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-10-07 17:10:16 +00:00
1fbeaa0d19
DAS: offer to import extension on null-aware access and unary op
...
Fixes https://github.com/dart-lang/sdk/issues/56328
Change-Id: I144d9ca92a93bcc72c2cdd2016fcb2784f2858ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388067
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-10-04 21:45:29 +00:00
79c0c75053
[DAS] Fix add type annotation assist for parameter types
...
R=srawlins@google.com
Fixes https://github.com/dart-lang/sdk/issues/37918
Change-Id: Iecf667e48cc42b06ea62c052c136b6f717657396
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388281
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2024-10-04 20:55:48 +00:00
8015967aba
Elements. Update analysis_server/ migration status file.
...
Change-Id: Iddd961600ea73e81b95387159656daf5acd3aa9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388443
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-10-04 20:20:39 +00:00
450c1962d0
Make members a subtype of element rather than fragment
...
Change-Id: I4fce1d1a3a63b79dcfc1b61903e5dcabd7771bfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388066
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-10-04 18:42:33 +00:00
13a052e0e7
Parts. Deprecate LibraryElement.libraryImports
...
Change-Id: I9e3455fda9943123cc0aa0d95617f532bcec670f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-10-04 18:41:14 +00:00
9a23a0cad6
[DAS] Fixing swap with single Widget on children
...
R=pquitslund@google.com
Fixes https://github.com/dart-lang/sdk/issues/55940
Change-Id: I5cad91a97dcd9fe7b550b3661e8a46a301cbb558
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387862
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-10-04 18:10:35 +00:00
f58e0ed8aa
Don't suggest references to private enum fields
...
Some Dart code defines enums with private fields. This is useful to
indicate that the represented values might change in the future, and
should not considered to be exhaustive. Take this enum as an example:
```dart
enum ProtocolVersion {
v1,
v2,
_upcoming,
}
```
When code in a different library is switching over that enum, it can't
use the private member:
```dart
import 'protocol_version.dart';
ProtocolImplementation findImplementation(ProtocolVersion version) {
return switch (version) {
ProtocolVersion.v1 => LegacyProtocol(),
ProtocolVersion.v2 => NewProtocol(),
// Missing default case
};
}
```
At the moment, the analysis server would suggest adding a reference to
`ProtocolVersion._upcoming` to fix the switch expression, which is
invalid. The only way to fix the switch is to add a default expression,
which this change introduces instead.
Change-Id: Id38dbf206a25c11dcc53af50e19ac5dd1287637e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388005
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-10-03 23:45:06 +00:00
a4124616c9
Parts. Deprecate LibraryElement.importedLibraries
...
Change-Id: I3407e7fe0aa92218346d8376854a6e4a639e8013
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-10-03 21:54:07 +00:00
a409a1c07d
[analyzer/linter] Use shared enumeration for lint names
...
This helps to avoid any accidental mispellings, enables find usages, and potentially makes future renames easier.
The primary goal is to make future work in https://github.com/dart-lang/sdk/issues/56835 easier.
Change-Id: I684630a4d6cb145031de0dabc221f247246ea00c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Parker Lougheed <parlough@gmail.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-10-03 21:36:49 +00:00
ffa9cbcc9a
CHANGELOG: add analyzer notes for 3.5 and 3.6
...
Change-Id: I5299d81279baccfabb7f040a2b07e5c2f0894525
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2024-10-03 20:12:48 +00:00
6970405b9a
[analysis_server] Record timing of reading from FileByteStore and show in diagnostic pages
...
This can help track down when performance issues may be caused by slow disk access (such as that described in https://github.com/dart-lang/sdk/issues/56755 caused by Windows Defender scanning files as they are read).
Change-Id: I4aee0d3aa12f3c6d52bd8e95470915eb1b920829
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388006
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-10-03 20:11:38 +00:00
5f7e2b1b60
Parts. Deprecate LibraryElement.exportedLibraries
...
Change-Id: Ieb542d5c7241f31ebae389badb9fd99c560cfd48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388144
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-10-03 19:49:51 +00:00
331ca05414
Elements. Implement PrefixElement2 and PrefixFragment.
...
Change-Id: I547049096efa1ecf56f7b4adb77d21908d2da4db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-10-03 19:18:48 +00:00
2fd313b62a
fix renaming prefix
...
Fixes https://github.com/dart-lang/sdk/issues/56809
R=srawlins@google.com
Change-Id: I3df1f42923e7cb6382f7d6ad9875af6bb91a62a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-10-02 20:58:13 +00:00
4fe2944776
Parts. Consider 'part' of 'part of lib.name' as an error.
...
Maybe? https://github.com/dart-lang/co19/issues/2907
Change-Id: If64ba74bf8d3ad3f5e1b926f19705ae469c76a5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387820
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-10-02 18:16:14 +00:00
4b65ff2e17
[DAS] Updating the priority for the fix "Use library with prefix"
...
This CL is updating the priority for the `IMPORT_LIBRARY_PREFIX` to be the same as `IMPORT_LIBRARY_SHOW`. They should both appear first in the list to avoid unnecessary duplication of imports and possibly avoiding the creation of `ambiguous_import` since aliasing imports is usually done for this reason.
R=srawlins@google.com
Fixes https://github.com/dart-lang/sdk/issues/56799
Change-Id: I785b1dbabb1229d1233420430768b8fe0e4a25bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387827
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-10-02 16:10:32 +00:00
927f2b7eb2
[analysis_server] Return empty document highlights instead of null when no matches
...
This partly fixes https://github.com/Dart-Code/Dart-Code/issues/5294 , in that it prevents VS Code falling back to a text search which gives confusing results.
However, because we don't produce any occurrences for record field names (because they are built on `Element`s which don't exist here), it also doesn't highlight the complete symbol name under the cursor like it would for other symbols (not does it highlight other references to the same record field in surrounding code). I'll follow up on the issue about this because it would also be nice to handle them.
Change-Id: I11f89d222d727cf73adf4a067ac00ca0cb5b1ebb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-10-02 16:02:38 +00:00
0560410593
[Code completion] Introduce a mxin for ease of access to selection offset and displayText
...
Change-Id: I03a3552620ab7188f527f3345e92559d31bedc1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387740
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-10-01 19:08:11 +00:00
4ac6c5cdf3
Elements. Make Fragmented public, migrate ExecutableParameters.
...
Change-Id: I1d9dbe7d1a74e82e4e4b5486399d4478674b6f50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387610
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-10-01 16:49:17 +00:00
4366f822b6
Issue 56558. Fixed encapsulate_field to work with dynamic and prefixed types.
...
Bug: https://github.com/dart-lang/sdk/issues/56558
Change-Id: I59cce649a2f7989804e4dfd580cf2041c89fbe3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/385322
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-10-01 16:43:49 +00:00
19eab32e9e
[Code completion] Make a few more suggestions ExecutableSuggestion.
...
Change-Id: I0f44a22c998a9d08891666e845b55ea7664ed607
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387760
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-10-01 16:41:13 +00:00
480756dad3
[DAS] Test for aliased import add show
...
Fixes https://github.com/dart-lang/sdk/issues/45993
Since the recent change in this class the behaviour is working as intended. Simply added a test to make sure future changes don't break this by mistake.
R=srawlins@google.com
Change-Id: Ie978690ecad0731ace001d74c6ab2dd623681aa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387529
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com >
2024-10-01 00:34:43 +00:00
52b1b9d6e6
Elements. Migrate AddMissingParameter.
...
Change-Id: If292e7155f7f13e3208759325801197736d84ad9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387623
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-09-30 21:48:18 +00:00
1f8aea0c81
Bump lints to a97011b4b031b1df94765dbacd7d92b0b765c8b9
...
Changes:
```
> git log --format="%C(auto) %h %s" af68bf0..a97011b
https://dart.googlesource.com/lints.git/+/a97011b add unintended_html_in_doc_comment; rev to 5.1.0 (211)
```
Diff: https://dart.googlesource.com/lints.git/+/af68bf0cbad88002a2ae19ee8db37b64eb120c32..a97011b4b031b1df94765dbacd7d92b0b765c8b9/
Change-Id: I998d73f5f72e94d5f2922b0751d31620a837555e
Tested: analysis only change
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387601
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2024-09-30 21:48:03 +00:00
34f44647d7
Elements. Migrate ImportOrganizer.
...
Change-Id: Ifb0bad8b4a5953ba03fca03aa67cbfcb772ebc39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387525
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-09-30 21:10:10 +00:00
a11815d5b1
Elements. Migrate MoveTypeArgumentsToClass.
...
Change-Id: I49e1a6f69e84eea75861cbf396660962066eedf4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387408
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-09-30 20:37:40 +00:00
7b502b1e63
Fix extension type import library
...
Closes https://github.com/dart-lang/sdk/pull/56781
Fixes https://github.com/dart-lang/sdk/issues/55443
GitOrigin-RevId: b6d7b3dab49964bb0fc6e2a3abdc643df5023d97
Change-Id: I708da5d01ccae45cc7d143e4fac365fb2c84e31e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386701
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-09-30 19:44:57 +00:00
6298d95a51
Invert conditional expression assist
...
Closes https://github.com/dart-lang/sdk/pull/56714
Fixes https://github.com/dart-lang/sdk/issues/45853
GitOrigin-RevId: 7afb370aee8cabaac337ffaaa08248df6d2e1570
Change-Id: I86730c45f2025653bca013f4a81d6ebab06bad3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384960
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2024-09-30 19:36:55 +00:00
065d3fbea3
Elements. Migrate MoveDocCommentToLibraryDirective.
...
Change-Id: I94daa794293bd33efae95f0f2fe4d7ab623b3eff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387357
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-09-30 19:33:34 +00:00
83c26333a2
[DAS] Consider two lint rules when offering "add import" refactorings
...
Taking into consideration `prefer_relative_imports` and `always_use_package_imports` for adding import options to the assists list.
When neither is set, both will appear always showing package imports first. If both are set we will treat this as if only `always_use_package_imports` is and show only package imports.
Fixes https://github.com/dart-lang/sdk/issues/56800
R=scheglov@google.com
Change-Id: If2353479de91f50c6c44eb7a17487fb6d0d6f681
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387500
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-09-30 19:17:36 +00:00
01c82f84a1
Elements. Migrate MoveAnnotationToLibraryDirective.
...
Change-Id: Ibd2ec3a5ed8651d4de2f5b146b68e58a7d2f894c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387407
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-09-30 18:31:30 +00:00
2eb6582c42
Elements. Migrate RemoveAbstract.
...
Change-Id: Id3e5b543103835420c6f372cb0505b44a76c86bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387409
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-09-30 18:02:17 +00:00
103c85dac4
Elements. Migrate ColorComputer.
...
Change-Id: I14314b9d5b5e6a8b9f28d0dc4957b9e1da05cdf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-09-30 17:38:59 +00:00
6fdb0fb887
Elements. Migrate SurroundWith.
...
Change-Id: Ia603ebff824012b8992bdcc5e93bf5a98f1daa05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387424
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-09-30 17:37:07 +00:00
2008dd6474
Elements. Migrate MakeVariableNullable.
...
Change-Id: I478238743d655841203a753681815004d50c6db6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387406
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-09-30 17:22:21 +00:00
48d4a15fcd
Elements. Migrate DestructureLocalVariableAssignment.
...
Change-Id: Ic6551bd2884585945698d9e319bbe0c5a1b8311d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387353
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-09-30 17:15:03 +00:00
45546b6427
Elements. Migrate FlutterConvertToChildren.
...
Change-Id: I62e9df0a1b1729f139a1ac7da2da6ac761607185
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387403
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-09-30 17:14:18 +00:00
3c5bdb63cf
Elements. Migrate CreateMethod.
...
Change-Id: I7e631dd63baf74060a94bd413f5ccdd527fd21f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387352
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-09-30 16:56:50 +00:00
1488e4d66c
Elements. Migrate ElementDescriptor.
...
Change-Id: I7b5d42c4302835ec35a5ab1e607e7b4b836e5a3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387461
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-09-30 16:35:41 +00:00
b8ab6861d8
Elements. Migrate WrapInText.
...
Change-Id: Ib447267be94ec637017bae24cf9c3a9b37d8ddf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387425
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-09-30 16:33:30 +00:00
48af10e005
Elements. Migrate SplitVariableDeclaration.
...
Change-Id: I3b9a94632da878150b95980c5db7bb73c6a66a46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387422
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-09-30 16:27:38 +00:00
9b6c7e63a5
Elements. Migrate ShadowField.
...
Change-Id: Id073dbba830e0f3b0acd0ac8630910a478443c26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387415
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-09-30 16:19:35 +00:00
Danny Tuppeny