Devon Carew
1f8aea0c81
Bump lints to a97011b4b031b1df94765dbacd7d92b0b765c8b9
...
Changes:
```
> git log --format="%C(auto) %h %s" af68bf0..a97011b
https://dart.googlesource.com/lints.git/+/a97011b add unintended_html_in_doc_comment; rev to 5.1.0 (211)
```
Diff: https://dart.googlesource.com/lints.git/+/af68bf0cbad88002a2ae19ee8db37b64eb120c32..a97011b4b031b1df94765dbacd7d92b0b765c8b9/
Change-Id: I998d73f5f72e94d5f2922b0751d31620a837555e
Tested: analysis only change
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387601
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2024-09-30 21:48:03 +00:00
Jake Macdonald
5285faad67
add ParameterStyle enum and style getter to FormalParameter, closes https://github.com/dart-lang/sdk/issues/56593
...
add isConst to constructors, add const and factory keywords to augmentations, part of https://github.com/dart-lang/sdk/issues/56516
Change-Id: I424031e22636678da5c9c428099100bfac748daf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382662
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2024-09-04 20:16:11 +00:00
Erik Ernst
410e9a852a
Remove unused type parameter
...
This CL removes an unused type parameter from a test in _macros.
The type parameter gave rise to a warning from the lint
`avoid_types_as_parameter_names` because it had the same name as a
type in scope (`Declaration`).
The type variable could also have been renamed, but it seems very unlikely that any other part of the system will break because the type parameter has been removed: The function is declared in a test, and nothing in the test depends on that type parameter in any way.
See also https://github.com/dart-lang/linter/issues/5066 for details.
Change-Id: Ibc42c4a758f70564c9fe12f3bf2bfbb72e63e97d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383600
Reviewed-by: Jake Macdonald <jakemac@google.com >
2024-09-04 19:34:36 +00:00
Erik Ernst
624835988a
Adjust cast.dart to avoid type variable shadowing type
...
This is a non-functional change to _macros, it only renames two type
variables whose scope is enclosed in a single function body, such that
said shadowing doesn't occur.
Change-Id: Ia196e5cb50a5d9864d002e3aa9f60eb442ebea25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383244
Reviewed-by: Jake Macdonald <jakemac@google.com >
2024-09-03 16:08:48 +00:00
Devon Carew
89532d54ed
[deps] rev package:lints to capture the unnecessary_library_name addition
...
Change-Id: I6ca4b0cef189248eac4d0898e8549424f2d889bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380180
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2024-08-13 17:04:13 +00:00
Jake Macdonald
51939f1454
add type parameters when creating augmentations
...
Bug: https://github.com/dart-lang/language/issues/3922
Change-Id: I9d9f6ce898e16e2ed393ae77f0dbcbf9c75fb56d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372580
Auto-Submit: Jake Macdonald <jakemac@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2024-06-21 07:57:33 +00:00
Jake Macdonald
f4899aa62e
skip failing macro test
...
Bug: https://github.com/dart-lang/sdk/issues/55992
Change-Id: Ib2bfaf980d0edc7ac8a0e2a891983a3294ee1588
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371220
Auto-Submit: Jake Macdonald <jakemac@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2024-06-12 20:59:34 +00:00
Jake Macdonald
fac11694b4
Track async microtasks scheduled by macros, and ensure they have all completed before a macro returns.
...
Does not track certain events such as async I/O, but will refuse to execute the scheduled callbacks when those do complete.
Bug: https://github.com/dart-lang/sdk/issues/55426
Change-Id: Ie81100e9e4dbe49d050bad875cc9b6a65969863d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370120
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Morgan :) <davidmorgan@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2024-06-11 21:02:29 +00:00
Sam Rawlins
82a3006220
macros: replace unsupported [this] comment references with this.
...
Work towards https://github.com/dart-lang/dartdoc/issues/3761
Sibling CL to https://dart-review.googlesource.com/c/sdk/+/365204
The analyzer has never recognized `[this]` as a valid doc comment
reference (and the `comment_references` lint rule has similarly
reported such reference attempts). dartdoc has its own algorithms
for resolving comment references, which we are dismantling in favor
of a single resolution, provided by the analyzer.
We've also decided against adding support in the analyzer (see
https://github.com/dart-lang/linter/issues/2079 ), so these
reference attempts should be re-written.
Change-Id: I872c215a574dc3d04f0708387408d22fdfd14c14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366882
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2024-06-05 18:37:46 +00:00
Simon Binder
ff6e1df848
[macros]: Remove type argument from StaticTypeImpl
...
This is a follow-up to the previous CL adding support for named static
types and instantiations to macros
(https://dart-review.googlesource.com/c/sdk/+/348920 ).
The type argument on `StaticTypeImpl` was not necessary so this CL
removes it.
Change-Id: I1e309c819be86f7f81ba4b7a418ed1f22ba7ac8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368424
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2024-05-30 07:51:32 +00:00
Jake Macdonald
77490aacc7
update macros and _macros versions to reflect breaking change for implementations
...
Change-Id: Ia60631c494de0e5f8a286275c056ce0c3026410a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
2024-05-28 14:40:29 +00:00
Simon Binder
78f2e16cc9
Add asInstanceOf to StaticType introspection capabilities
...
This adds `asInstanceOf` to `StaticType`, which tries to find the
instantiation of a given class so that a `StaticType` becomes a subtype
of it.
To actually make use of that data, the definition of `NamedStaticType`
is expanded to contain information about the resolved type identifier
and the type arguments instantiating the class.
Change-Id: I4f7b05d9e44f5228863ef875545286b5cd7f9a41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/348920
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Morgan :) <davidmorgan@google.com >
2024-05-28 10:56:55 +00:00
Konstantin Shcheglov
f42b019f43
Macro. Support for 'extendsType'.
...
Change-Id: Ic913d26b630f2d2f22fd6c4dec25ed27814d9f8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368201
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-05-24 21:38:51 +00:00
Jake Macdonald
0ee590e954
stop importing util.dart, it isn't supported (imports dart:mirrors)
...
Change-Id: I1dd4d650ace0866e3ef88655582c7edfcf946d01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368222
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-05-24 21:27:04 +00:00
Jake Macdonald
ba9af345c2
fix failing pkg/_macro/test/executor/executor_test
...
Change-Id: I15040720ae47f28b90064db94b1c08cd9db1484f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368220
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-05-24 21:01:54 +00:00
Jake Macdonald
0d2b01bab3
add extendsType API which adds an extends clause to an existing type
...
refactors builder implementations to fix some bugs, nested builders go through a separate constructor now which has all required params so we can ensure the parent maps are passed down.
update pubspecs/changelogs for release
Bug: https://github.com/dart-lang/sdk/issues/55425
Change-Id: I5bfe3bea3b7574de83d8b3774e92fd9101325b8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368080
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2024-05-24 18:16:22 +00:00
Jake Macdonald
3cd3efd29c
Handle diagnostics from nested builders, as well as ParallelWaitErrors with diagnostic exceptions and AsyncErrors.
...
This fixes diagnostic reporting in the updated JSON macro which uses Future.wait and Record.wait, as well as nested builders.
Change-Id: I0f80ae7f93b1ecaf24ed98512cd8a4f86e6b125a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365840
Commit-Queue: Leaf Petersen <leafp@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2024-05-08 17:57:23 +00:00
Jake Macdonald
aa87aa4018
improve formatting of initializer lists and the toJson body
...
Change-Id: I9363415a32e57a75cc93f2ee3657acfe7103c042
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365720
Commit-Queue: Jake Macdonald <jakemac@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-05-08 14:55:01 +00:00
Konstantin Shcheglov
b08dae5674
Macro. Check for valid parts in Code.fromParts(), not just assert().
...
Bug: https://github.com/dart-lang/sdk/issues/55441
Change-Id: I27fd2cbdd750317a40583788690447d54df6a037
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362440
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-04-16 04:37:20 +00:00
Konstantin Shcheglov
a847a535fd
Macro. Put Future into _typeDeclarationCache.
...
Change-Id: I33f2dc65f12e57b65fed27345a9fb8f1f79da455
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361982
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-04-10 21:07:19 +00:00
Michael Thomsen
090fc9293a
Create README.md for _macros
...
Closes https://github.com/dart-lang/sdk/pull/55420
GitOrigin-RevId: d55a7081e8e763ca53e8f337e82d3cd404e3079c
Change-Id: Ia4f5fe3e2df15110b7c6d3a520c895e2027bceb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361986
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2024-04-10 15:03:17 +00:00
Jake Macdonald
5733a98f4e
update changelogs for _macros and macros packages
...
Change-Id: I91c7513c02013bc2f65e732b83b06d7e954a4ebc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2024-04-09 15:40:17 +00:00
Konstantin Shcheglov
60230e016f
Macro. Cache typeDeclarationOf(IdentifierImpl) results.
...
This makes https://dart-review.googlesource.com/c/sdk/+/361160/1
about 10% faster.
Before:
[time: 6871 ms]
(name: <scheduler>, count: 0, elapsed: 0:00:00.000000, elapsedSelf: -0:00:06.742687)
(name: analyzeFile, count: 104, elapsed: 0:00:06.742687, elapsedSelf: 0:00:01.014164)
(name: libraryContext, count: 104, elapsed: 0:00:05.728523, elapsedSelf: 0:00:00.195590)(bytesPut: 5378632, cycleCount: 9, libraryCount: 115)
(name: link, count: 9, elapsed: 0:00:05.316310, elapsedSelf: 0:00:00.278338)
(name: computeLibraryScopes, count: 9, elapsed: 0:00:00.128982, elapsedSelf: 0:00:00.056258)
(name: buildMacroApplier, count: 9, elapsed: 0:00:00.072625, elapsedSelf: 0:00:00.072625)
(name: executeMacroTypesPhase, count: 9, elapsed: 0:00:00.000099, elapsedSelf: 0:00:00.000099)
(name: executeMacroDeclarationsPhase, count: 9, elapsed: 0:00:00.223973, elapsedSelf: 0:00:00.223973)(constructorsOf: 100, methodsOf: 100)
(name: executeMacroDefinitionsPhase, count: 9, elapsed: 0:00:04.264144, elapsedSelf: 0:00:00.001345)
(name: executeDefinitionsPhase, count: 315, elapsed: 0:00:03.622893, elapsedSelf: 0:00:03.622893)(constructorsOf: 300, methodsOf: 300, resolve: 42000, typeDeclarationOf: 41200)
(name: addMacroResults, count: 200, elapsed: 0:00:00.639906, elapsedSelf: 0:00:00.639906)
(name: mergeMacroAugmentations, count: 9, elapsed: 0:00:00.420873, elapsedSelf: 0:00:00.420873)
(name: macroCompileKernel, count: 1, elapsed: 0:00:00.216623, elapsedSelf: 0:00:00.216623)
After:
[time: 6121 ms]
(name: <scheduler>, count: 0, elapsed: 0:00:00.000000, elapsedSelf: -0:00:06.006443)
(name: analyzeFile, count: 104, elapsed: 0:00:06.006443, elapsedSelf: 0:00:00.879439)
(name: libraryContext, count: 104, elapsed: 0:00:05.127004, elapsedSelf: 0:00:00.177845)(bytesPut: 5378632, cycleCount: 9, libraryCount: 115)
(name: link, count: 9, elapsed: 0:00:04.744696, elapsedSelf: 0:00:00.238642)
(name: computeLibraryScopes, count: 9, elapsed: 0:00:00.134995, elapsedSelf: 0:00:00.054646)
(name: buildMacroApplier, count: 9, elapsed: 0:00:00.080271, elapsedSelf: 0:00:00.080271)
(name: executeMacroTypesPhase, count: 9, elapsed: 0:00:00.000078, elapsedSelf: 0:00:00.000078)
(name: executeMacroDeclarationsPhase, count: 9, elapsed: 0:00:00.228962, elapsedSelf: 0:00:00.228962)(constructorsOf: 100, methodsOf: 100)
(name: executeMacroDefinitionsPhase, count: 9, elapsed: 0:00:03.739473, elapsedSelf: 0:00:00.001227)
(name: executeDefinitionsPhase, count: 315, elapsed: 0:00:03.108632, elapsedSelf: 0:00:03.108632)(constructorsOf: 300, methodsOf: 300, resolve: 42000, typeDeclarationOf: 1200)
(name: addMacroResults, count: 200, elapsed: 0:00:00.629614, elapsedSelf: 0:00:00.629614)
(name: mergeMacroAugmentations, count: 9, elapsed: 0:00:00.402624, elapsedSelf: 0:00:00.402624)
(name: macroCompileKernel, count: 1, elapsed: 0:00:00.204463, elapsedSelf: 0:00:00.204463)
Change-Id: I4cd899fe321a7a6da202da0375c60c383c510940
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361623
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2024-04-09 02:39:03 +00:00
Konstantin Shcheglov
d0e4ef7e6c
Parse 'augment library' instead of 'library augment'.
...
Bug: https://github.com/dart-lang/sdk/issues/55374
Change-Id: I856c21f4b102fa589f5a14c3d28daf64e4112099
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361286
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2024-04-08 20:34:30 +00:00
Konstantin Shcheglov
dbc1facd40
Macro. Cache TypeDeclaration introspection results.
...
This makes https://dart-review.googlesource.com/c/sdk/+/361160/1
about 30% faster.
Before:
[time: 9800 ms]
(name: <scheduler>, count: 0, elapsed: 0:00:00.000000, elapsedSelf: -0:00:09.676162)
(name: analyzeFile, count: 104, elapsed: 0:00:09.676162, elapsedSelf: 0:00:01.122336)
(name: libraryContext, count: 104, elapsed: 0:00:08.553826, elapsedSelf: 0:00:00.370620)(bytesPut: 5378632, cycleCount: 9, libraryCount: 115)
(name: link, count: 9, elapsed: 0:00:08.183206, elapsedSelf: 0:00:00.273932)
(name: computeLibraryScopes, count: 9, elapsed: 0:00:00.137679, elapsedSelf: 0:00:00.073448)
(name: buildMacroApplier, count: 9, elapsed: 0:00:00.064103, elapsedSelf: 0:00:00.064103)
(name: executeMacroTypesPhase, count: 9, elapsed: 0:00:00.000128, elapsedSelf: 0:00:00.000128)
(name: executeMacroDeclarationsPhase, count: 9, elapsed: 0:00:00.211514, elapsedSelf: 0:00:00.211514)(constructorsOf: 100, methodsOf: 100)
(name: executeMacroDefinitionsPhase, count: 9, elapsed: 0:00:07.163251, elapsedSelf: 0:00:00.001486)
(name: macroApplier.executeDefinitionsPhase, count: 315, elapsed: 0:00:06.532745, elapsedSelf: 0:00:00.008799)(constructorsOf: 20300, methodsOf: 20300, resolve: 42000, typeDeclarationOf: 41200)
(name: macroExecutor.executeDefinitionsPhase, count: 200, elapsed: 0:00:06.523946, elapsedSelf: 0:00:06.523946)
(name: addMacroResults, count: 200, elapsed: 0:00:00.629020, elapsedSelf: 0:00:00.629020)
(name: mergeMacroAugmentations, count: 9, elapsed: 0:00:00.396830, elapsedSelf: 0:00:00.396830)
After:
[time: 6871 ms]
(name: <scheduler>, count: 0, elapsed: 0:00:00.000000, elapsedSelf: -0:00:06.742687)
(name: analyzeFile, count: 104, elapsed: 0:00:06.742687, elapsedSelf: 0:00:01.014164)
(name: libraryContext, count: 104, elapsed: 0:00:05.728523, elapsedSelf: 0:00:00.195590)(bytesPut: 5378632, cycleCount: 9, libraryCount: 115)
(name: link, count: 9, elapsed: 0:00:05.316310, elapsedSelf: 0:00:00.278338)
(name: computeLibraryScopes, count: 9, elapsed: 0:00:00.128982, elapsedSelf: 0:00:00.056258)
(name: buildMacroApplier, count: 9, elapsed: 0:00:00.072625, elapsedSelf: 0:00:00.072625)
(name: executeMacroTypesPhase, count: 9, elapsed: 0:00:00.000099, elapsedSelf: 0:00:00.000099)
(name: executeMacroDeclarationsPhase, count: 9, elapsed: 0:00:00.223973, elapsedSelf: 0:00:00.223973)(constructorsOf: 100, methodsOf: 100)
(name: executeMacroDefinitionsPhase, count: 9, elapsed: 0:00:04.264144, elapsedSelf: 0:00:00.001345)
(name: executeDefinitionsPhase, count: 315, elapsed: 0:00:03.622893, elapsedSelf: 0:00:03.622893)(constructorsOf: 300, methodsOf: 300, resolve: 42000, typeDeclarationOf: 41200)
(name: addMacroResults, count: 200, elapsed: 0:00:00.639906, elapsedSelf: 0:00:00.639906)
(name: mergeMacroAugmentations, count: 9, elapsed: 0:00:00.420873, elapsedSelf: 0:00:00.420873)
(name: macroCompileKernel, count: 1, elapsed: 0:00:00.216623, elapsedSelf: 0:00:00.216623)
Change-Id: Ica435904e9a0f686c91e7703262687c110600983
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361622
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2024-04-08 19:34:22 +00:00
Jake Macdonald
631939e109
Prep to release package:macros
...
- update SDK dependency to ensure it supports SDK vendored packages
- sync pubspec/changelog versions
Change-Id: Ib79244bec43fc94bf12340241f6eab4001e4b21c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359920
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
2024-03-26 19:51:01 +00:00
Konstantin Shcheglov
36c0788137
add package:_macros (SDK vendored) and package:macros (pub published)
...
add sdk_packages.yaml file (describes SDK vendored package locations)
delete old macro code in _fe_analyzer_shared, move tests/benchmarks
adds a top level `pkg` directory to the Dart SDK, which is where vendored packages live
BUG: https://github.com/dart-lang/sdk/issues/54976
Change-Id: Ib3503a27fb5644fa8a39ab5a3e5b568df330cfd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359040
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2024-03-26 18:40:00 +00:00
Jake Macdonald
8df8de82b3
Ensure that the pubspecs of both _macros and macros packages are updated whenever the lib/ dir of _macros is edited.
...
Related to https://dart-review.googlesource.com/c/sdk/+/359040
Change-Id: Iab3cfa89e0492282c348c6a72f3032191fa4998f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359580
Auto-Submit: Jake Macdonald <jakemac@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2024-03-26 16:49:16 +00:00
Jake Macdonald
5a8bc19faf
add skeleton for _macros package
...
Change-Id: I9a4a84e4292b7fef1de76222a540c341ed041e51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359041
Commit-Queue: Jake Macdonald <jakemac@google.com >
Commit-Queue: Ilya Yanok <yanok@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Ilya Yanok <yanok@google.com >
2024-03-21 21:22:12 +00:00