dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
21,407 Commits 2 Branches 0 Tags
9ceaef9d732eb2d962ef8a759d080bc0ecec886d
Commit Graph

5592 Commits

Author SHA1 Message Date
hausner@google.com a65c571f18 Get rid of dynamic call debug stub 
This leaves only one debugger stub function. Yay.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//140743010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31932 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-17 21:32:58 +00:00
johnmccutchan@google.com d41a2106c2 Change Code object serialization format to use 50% less space. 
Update observatory to support new format
Cache code objects inside observatory isolate
Profiler updates cache of code objects
Profiler can display annotated disassembly objects
Code objects now display sample ticks
Fix error viewer
Start using the logging package.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//135843006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31931 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-17 21:16:44 +00:00
hausner@google.com 06da68b5aa Eliminate another debugger stub 
This change replaces https://codereview.chromium.org/135213002/

The specialized debugger stub call for static method calls is
no longer needed. It was introduced because once upon a time, the
static method call stub used to patch the call site when the target
was compiled. The VM stopped patching unoptimized static calls a
long time ago. Thus we can treat a static call like a regular runtime
call when patching it to set a breakpoint.

Bonus fix: single step runtime callback on mips was broken. The
enter/leave stub frame were missing.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//140793010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31928 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-17 19:09:46 +00:00
johnmccutchan@google.com 79d1f9537b Ensure Sample instance_size is always set. 
BUG=

Review URL: https://codereview.chromium.org//136293004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31927 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-17 17:14:08 +00:00
johnmccutchan@google.com 79d3555394 Add flag to control number of stack frames collected by profiler 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//131853007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31924 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-17 16:32:51 +00:00
ajohnsen@google.com cb47100b7c Speed up typed *List:fromList constructor, by calling setRange. 
BUG=
R=lrn@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//136473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31909 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-17 08:15:38 +00:00
regis@google.com 17196f6467 Make a type malbounded if one of its type arguments is malbounded, even if 
independently of the declared bounds for the type (fix issue 16149).

R=srdjan@google.com

Review URL: https://codereview.chromium.org//140913005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31901 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 22:56:35 +00:00
hausner@google.com 812467f0f6 Fix several little buglets with stepping 
No need to halt on single step if there is a breakpoint on the
same location. While looking at the resulting test failures, I
discovered that the step_in_equals test was not at all testing
what it was meant to test. It happened to pass because of a
related bug in the parser. Decided to abandon that test and
instead check that we can break at == even if one of the operands
is null.

Added ability to match line numbers in the debugger tests.

R=regis@google.com

Review URL: https://codereview.chromium.org//135843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31898 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 21:15:17 +00:00
fschneider@google.com fb5e6077bd Undo workaround for a bug with compile-type of the context value. 
I think this was fixed already with https://codereview.chromium.org/102053010/.

BUG=dartbug.com/15652
R=srdjan@google.com

Review URL: https://codereview.chromium.org//133853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31885 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 14:13:24 +00:00
lrn@google.com 3b3e87cabc Revert "Rename internal library dart:_collection-dev to dart:_internal." 
Dartium needs updating too.

Committed: https://code.google.com/p/dart/source/detail?r=31827

R=floitsch@google.com

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31877 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 12:06:38 +00:00
lrn@google.com 9357caa547 Revert "Make VM TypedList not implement ByteBuffer." 
Html transferable test fails to send buffer as buffer.

Review URL: https://codereview.chromium.org//137783019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31875 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 11:48:07 +00:00
lrn@google.com c2f6609181 Make VM TypedList not implement ByteBuffer. 
BUG= http://dartbug.com/10136
R=asiva@google.com, sra@google.com

Review URL: https://codereview.chromium.org//138033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31873 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 10:18:41 +00:00
iposva@google.com 781f737c6a First round of http://dartbug.com/15922: 
- Address warnings about 64-bit to 32-bit conversions.
- Remove heap profiler.

R=asiva@google.com

Review URL: https://codereview.chromium.org//139043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31867 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 05:05:35 +00:00
srdjan@google.com 27934ab40b Similar fix to merging trunc-div/mod: only one merge for now. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//131333004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31862 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 00:15:02 +00:00
iposva@google.com aeb751f670 - Large constants need to be marked as such. 
Review URL: https://codereview.chromium.org//140213003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31861 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 00:09:15 +00:00
iposva@google.com 8db30180b4 Fix http://dartbug.com/16111 
- Use all bits from the seed value even if passed a Bigint.
- Fix out of bounds access in BigintOperations.
- Remove obsolete implementation note.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//136453012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31859 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 00:01:55 +00:00
srdjan@google.com 76b526875c Fix issue 16103: incorrect merging of sin/cos. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//140233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31858 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 23:12:41 +00:00
regis@google.com 8fd260da32 Unfriend RawType (missed in cl 133273015). 
Review URL: https://codereview.chromium.org//136453010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31857 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 22:48:42 +00:00
regis@google.com 79a3315396 Replace debugging code with asserts in snapshotter. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//133273015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31854 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 21:54:15 +00:00
turnidge@google.com 12f8555b19 Allow root level requests in the vm service. 
Move /cpu to the root level.

Move PostReply to the command handlers.  This will allow command
handlers to reply asynchronously (by delegating elsewhere) if they
need to.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//131973007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31849 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 20:45:39 +00:00
srdjan@google.com e16402e56e Fix 16099: Invocation's positionalArguments contains an immutable array. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//139663003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31845 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 19:14:45 +00:00
srdjan@google.com bcb8549677 Fix issue 16103: Prevent recursive triggering of optimizer by resetting the optimization counter threshold before calling the compiler. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//139263005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31844 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 19:09:02 +00:00
regis@google.com 5fdae0d636 Leave uninitialized type arguments of a type being finalized as null instead of 
temporarily setting them to dynamic for improved code robustness, since dealing
with a null type is less forgiving than dealing with dynamic.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//137983006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31843 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 18:56:10 +00:00
lrn@google.com ead87f47e9 Revert "Rename internal library dart:_collection-dev to dart:_internal." 
Dartium needs updating too.

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31827 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 12:27:44 +00:00
lrn@google.com 0098710559 Rename internal library dart:_collection-dev to dart:_internal. 
BUG= http://dartbug.com/14140
R=floitsch@google.com

Review URL: https://codereview.chromium.org//133893007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31823 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 09:24:46 +00:00
asiva@google.com ab3b253830 remove resource.h from bin.gypi file (should fix windows build break) 
R=iposva@google.com

Review URL: https://codereview.chromium.org//137783007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31816 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-15 00:16:45 +00:00
hausner@google.com b4f0bf5998 Fix debugger stub patching on x64 architecture 
Instead of patching the entry in the object pool, patch the offset
into the pool at the call site.

SIMARM and SIMMIPS will have to be fixed the same way in a later change.

R=iposva@google.com

Review URL: https://codereview.chromium.org//131853006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31812 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 23:27:13 +00:00
johnmccutchan@google.com 8205cbf364 Fix mac build breakage in dart_api_impl.cc 
BUG=

Review URL: https://codereview.chromium.org//137443008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31811 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 23:05:57 +00:00
johnmccutchan@google.com c76b6eb1c2 Split service into VM and embedder specific bits. 
Move most service sources into the VM.

R=asiva@google.com

Review URL: https://codereview.chromium.org//125103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31809 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 22:34:43 +00:00
rmacnak@google.com 2b77f8b1d4 dart2js: Implement instanceMembers and staticMembers. 
BUG=http://dartbug.com/14633

Review URL: https://codereview.chromium.org//137123005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31808 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 22:31:20 +00:00
regis@google.com b48d1455c2 Share mixin type with interface type in mixin application classes. 
R=hausner@google.com

Review URL: https://codereview.chromium.org//138273005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31807 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 22:30:59 +00:00
asiva@google.com 9fb8b89682 1. Delete prolog weak persistent handles when shutting down an isolate 
2. Remove the peer_ field from RawExternalTypedData as it is not used anywhere

R=iposva@google.com

Review URL: https://codereview.chromium.org//136853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31797 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 19:55:46 +00:00
regis@google.com c2f0dec5ec Support bounded mixins in the VM (fix issue 14453). 
Add tests.

R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//137543004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31794 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 18:41:27 +00:00
johnmccutchan@google.com fc0cbbe801 Use a shared profile buffer 
May need to follow this up with a bump in the buffer size.

R=iposva@google.com

Review URL: https://codereview.chromium.org//134463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31786 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 15:18:47 +00:00
iposva@google.com 52c465d1a4 - Properly detag the pointer before using it. 
Review URL: https://codereview.chromium.org//136193004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31771 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-14 00:52:58 +00:00
iposva@google.com e627af8674 Fix dartbug.com/15963: 
- Properly serialize and deserialize RawInstance which represent the Object class.
- Initialize the last word to null even for AllocateUnitialized to ensure the
  properly formed objects even for misaligned objects.

R=asiva@google.com

Review URL: https://codereview.chromium.org//130563005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31765 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-13 22:46:19 +00:00
rmacnak@google.com 39f69b6045 Revert "dart2js: Implement instanceMembers and staticMembers." 
Review URL: https://codereview.chromium.org//137533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31763 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-13 22:40:36 +00:00
rmacnak@google.com 3886174aa1 dart2js: Implement instanceMembers and staticMembers. 
BUG=http://dartbug.com/14633
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//94093011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31757 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-13 21:09:49 +00:00
vegorov@google.com 18892b278b Ensure that MaterializeObject has relaxed RequiredInputRepresentation. 
Instruction itself is essentially a part of a deoptimization enviroment and thus can deal with any representation.

Default RequiredInputRepresentation is too strict and require tagged representation for all inputs which leads to ineffecient code: SelectRepresentations pass which is run while materializations are still in the graph will insert redundant boxing.

R=srdjan@google.com
BUG=dart:16063

Review URL: https://codereview.chromium.org//136923004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31753 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-13 19:33:05 +00:00
johnmccutchan@google.com 057e483d51 Support unboxed SIMD types in AllocationSinking 
BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//25509007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31752 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-13 18:41:08 +00:00
johnmccutchan@google.com 959cd6b191 Fix profile sample buffer leak 
BUG=

Review URL: https://codereview.chromium.org//132903004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31696 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-10 17:24:11 +00:00
hausner@google.com 31db06a905 Delete obsolete debug stub 
Remove the debug stub that became obsolete with the recent rewrite
of how we handle breakpoints at return statements.

R=regis@google.com

Review URL: https://codereview.chromium.org//132793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31685 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-09 23:56:08 +00:00
hausner@google.com ab26604b54 Debugger no longer causes top level variable initialization 
When a top-level variable has not been initialized yet, the
debugger reports a value of ‘null’ rather than causing a side
effect of running the initializer code.

R=jacobr@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//126653003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31678 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-09 21:50:20 +00:00
rmacnak@google.com 615715ccaa Extend the immutable collections test to the new API. Make *Members return immutable collections. Add missing metadata property for SyntheticSetterParameter. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//132133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31675 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-09 20:38:32 +00:00
ajohnsen@google.com daa4a59dbc Really fix Windows build. 
BUG=

Review URL: https://codereview.chromium.org//130973005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31654 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-09 11:23:01 +00:00
ajohnsen@google.com d04f006cdd Fix Windows impl. 
BUG=

Review URL: https://codereview.chromium.org//131403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31653 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-09 10:38:11 +00:00
ajohnsen@google.com 754c1d2b2a Fix listing of '' and '/'. 
BUG=https://code.google.com/p/dart/issues/detail?id=15966
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//131373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31652 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-09 10:33:56 +00:00
rmacnak@google.com 7dfcd0f4a1 Add ClassMirror.isAbstract to the API and VM implementation. 
BUG=http://dartbug.com/12826
R=gbracha@google.com

Review URL: https://codereview.chromium.org//129883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31643 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-09 01:27:51 +00:00
johnmccutchan@google.com 4506470336 Disable profiler for Dartium bots 
BUG=

Review URL: https://codereview.chromium.org//129983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31639 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-09 00:33:54 +00:00
rmacnak@google.com 8313c51650 Ensure a class is finalized before attempting any reflective invocation on it. 
Avoids mysterious error that results when finalization that is triggered by the reflective invocation fails to propogate a compile-time error.

BUG=http://dartbug.com/15886
R=regis@google.com, zra@google.com

Review URL: https://codereview.chromium.org//129513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31638 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-09 00:18:09 +00:00