Commit Graph

1263 Commits

Author SHA1 Message Date
Ryan Macnak d7d2dc10ef [infra] Add vm-aot-mac-release-x64 and vm-aot-mac-product-arm64.
Change-Id: I9b8b3384cfe783f1943d0598e5f2e76de36253c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300020
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-05-01 22:33:34 +00:00
Ryan Macnak 5493bc035d [infra] Remove arm32 from gcc builder.
Bug: https://github.com/dart-lang/sdk/issues/52080
Change-Id: I8332638ebb758507403b098f463291fd19f231e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/299240
Reviewed-by: Alexander Thomas <athom@google.com>
2023-04-28 05:33:00 +00:00
Ryan Macnak 4c2ec2ef45 [infra] Remove configurations for legacy QEMU.
Change-Id: Iec8bff7573c2b9d7544511916c8e1c0fc3859398
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296063
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2023-04-27 09:39:51 +00:00
Ryan Macnak 07326f7762 [infra] Add configurations for NNBD QEMU.
Change-Id: Id3bb6d1b09ccbfe445d2f5132e1f3b07b4edd852
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296060
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2023-04-27 09:39:51 +00:00
William Hesse 60fec9c720 [infra] Adjust sharding for VM JIT builders
Cutting the shards from 10 to 4 makes the shards time out after 90
minutes on the slowest builders. Even the fastest builders have shard
runtimes of 30 minutes.

Changing the sharding of JIT builder tests from 4 to 8 for both VM tests
and co19 tests.

Fixup after https://dart-review.googlesource.com/c/sdk/+/294140

Change-Id: I813aa40b6aac0fc5083a9606b71d00e78ce71ffc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297480
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2023-04-24 10:18:05 +00:00
Ryan Macnak 4d8fa9729e [infra] Remove configurations for legacy obfuscate and stripped modes.
Change-Id: I7192ba0fe31f2059c722559c4acaec4bdf0b01f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296022
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2023-04-20 19:11:06 +00:00
Jonas Termansen 6585fcf1d2 Delete promote script.
The promote script has been replaced by the promote recipe.

Remove unused code from bot_utils.

Bug: b/277727317
Change-Id: I6a087c11d6e98480d346017c97be82bf23438aed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296260
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
2023-04-20 15:41:11 +00:00
Ryan Macnak 1aed900be7 [infra] Migrate Android JIT FFI builders to sound NNBD.
Change-Id: Ifa93f7329bf988a73e406e7978488a0abbc06ae4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296020
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2023-04-20 15:37:20 +00:00
Alexander Thomas 9814aaf662 [infra] Mark new vm-dwarf/obfuscate configs as sound null safe
Without this, they will run _2 suites by default.

Change-Id: Ica435675c467875a7f3dbab6cf05994835dd0ab5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296583
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2023-04-20 14:19:51 +00:00
Ryan Macnak 8a5c3d9e3d [infra] Add configurations to migrate obfuscate and stripped modes.
Change-Id: I62581c6874b211c57da61639f460685790acb40d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296021
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2023-04-19 16:26:59 +00:00
Ryan Macnak 30518b205d [infra] Copy llvm to shards, which is the target of the llvm-strip symlink.
Bug: https://github.com/dart-lang/sdk/issues/52010
Change-Id: I44d81ebb2f9e3db5ed86e560f7b043bd26804bf1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295747
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2023-04-18 18:33:10 +00:00
Daco Harkes f9f1030959 [infra] DEPS and test dart-lang/native packages
This CL pulls in dart-lang/native packages and runs them on the
pkg bots.

Bug: https://github.com/dart-lang/sdk/issues/50565
Change-Id: Ifcd8ba25f8bdfeca8f4c161adfc3c20e0ce500d1
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295280
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2023-04-18 08:04:49 +00:00
Ryan Macnak badd96032d [infra] Test gcc cross builds instead of simulators.
Skipping arm64 for lack of toolchain on the bots.

Disable tcmalloc on arm, where it fails to compile.

The builds are split into separate steps instead of using a shorter invocation like `--mode=debug,release --arch=ia32,x64,arm,riscv64` to avoid per-step timeouts.

Change-Id: Iccf5e6e8d91584147138ac37487560a7cc608b6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283121
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-04-13 18:02:37 +00:00
Nicholas Shahan 178063c7f4 [dart2js] Fix fileset used by dill_loader_test
Add `tests/corelib/` to the fileset that contains all the "_2" test
suites so it can be read by
`pkg/compiler/test/end_to_end/dill_loader_test.dart`.

The `dart2js-unit-linux-x64-release` bot configuration uses
the `js_platform_2` fileset because many of the tests under `pkg/compiler/test/` are running or referencing unsound test
files. As the tests migrate to use sound null safety, they will
need to update their hard coded paths to use the sound version
of the test files. More test paths can be added to the fileset as
needed until all the testes are running with sound null safety. Then
the bot configuration can switch to use the `js_platform` fileset
instead.

Change-Id: I0542e035b89bb512c61e1259f86e4378590fb178
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294680
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
2023-04-12 23:57:19 +00:00
Ryan Macnak 4bb4b2d68b [infra] Rebalance VM shards.
This should make both JIT and AOT shards take about 15 minutes each in release mode.

Change-Id: Id0668c7f373146dba032cb5c743e0e97dd566297
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294140
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2023-04-12 17:44:17 +00:00
Ryan Macnak 9fc1f76e02 [infra] Copy llvm-strip to shards.
Change-Id: I1a2a8b68c33dd1e3b0071fd1becdeebab3e8a6df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294441
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-04-10 22:52:21 +00:00
Ryan Macnak 956bb9ac57 [infra] Copy llvm-symbolizer to shards.
Change-Id: I7f8010f1b2dee00af10f64621b7bddce6e2926a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294365
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2023-04-10 19:10:18 +00:00
Ryan Macnak e90e43138e [infra] Fix missing process_test for simarm_x64 builders.
Bug: https://github.com/dart-lang/sdk/issues/51949
Change-Id: I8456166b8fbd61e06e59af8cf055c9cf90e2661d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293741
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-04-06 15:59:57 +00:00
Ryan Macnak acfe1aa9cf [infra] Add "vm" or "front_end" prefix to shard names.
Makes it easier to see what's producing load by sorting by task name in the task list.

Most are already prefixed with analyzer/dart2js/ddc/vm.

Change-Id: Ia18757ad593b285401a1d315c172d1ad7b6fbf77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293003
Reviewed-by: Jonas Termansen <sortie@google.com>
2023-04-05 19:44:28 +00:00
Ryan Macnak c8b2d030cf [infra] Remove old names for GCC and MSVC builders.
Change-Id: Ia644a70e0a5a1cf84eafeafb451016d962ff39c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293081
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-04-05 16:28:24 +00:00
Ryan Macnak 432467ec19 [infra] Add configurations to rename GCC and MSVC builders.
Change-Id: I793e9532cbf9b9af43f91644ba328a6cfc06e1db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293060
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-04-04 17:17:57 +00:00
Aske Simon Christensen d1d232776a [dart2wasm] Rename the dart:wasm library to dart:_wasm.
This is an internal library not meant to be used in application code.

CoreLibraryReviewExempt: Changes only Wasm specific libraries.
Change-Id: I2f5b463382d35a442e782067ef7d9063183fe5e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292021
Reviewed-by: Ömer Ağacan <omersa@google.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
2023-04-04 11:52:18 +00:00
Ryan Macnak 58a3324adf [infra] Remove old AOT NNBD configurations.
Change-Id: I2d444f5c6735197d9bfcb10863ff5a9f34b580f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286361
Reviewed-by: Alexander Thomas <athom@google.com>
2023-04-02 08:34:23 +00:00
Ryan Macnak fdabbc9d10 [infra] Add configurations to rename AOT NNBD.
Change-Id: I56044e0fcfdb4623595971354a01164d8ae708e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286360
Reviewed-by: Alexander Thomas <athom@google.com>
2023-04-02 08:34:23 +00:00
Nicholas Shahan a48b408a5a [dart2js][ddc] Cleanup test matrix file sets
- Rename file sets:
  "web_platform" -> "js_platform_2"
  "web_platform_nnbd" -> "js_platform"
- Sort lists and remove unused paths.

Change-Id: I313559343d5ad3c5c770c79b68245ea446bb1ac0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289300
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2023-03-31 19:59:02 +00:00
Ryan Macnak d01421c837 [test] Recognize exitcode 1 from all sanitizers.
Should avoid test failures triggering spurious infra failures.

TEST=ci
Change-Id: Iece312aa7eba814d7a740b0db16505d480cd3808
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291582
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-03-29 18:04:20 +00:00
Nicholas Shahan 7c0e4d67c7 [dart2js] Prevent unsound compiles
- Remove unsound platform .dill files from the packaged SDK.
- Throw and error referencing the sound null safety requirements of
  Dart 3 when compiling with `--no-sound-null-safety` and an unsound
  platform .dill file is not found.

Change-Id: I703a446e3e92c76a6b48168577fc0161eea83854
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289280
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2023-03-28 21:31:27 +00:00
Ryan Macnak 9e9b3770f4 [infra] Add configuration to migrate VM checked to NNBD.
Move from Linux to Mac because the Mac pool has more capacity.

Change-Id: Ie8beb33ea2f3e84f78a2824db5540249d6977e35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290608
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-03-23 17:45:27 +00:00
Janice Collins 68353d76a4 Add a flag to disable the new unified_analytics for a single session.
- Adds a new flag, `--suppress-analytics` to the `dart` command to
  disable both the unified and the legacy analytics for a single
  session while deprecating the existing flag, `--[no-]analytics` used
  for disabling the legacy analytics on a single pass.
- Pipelines the flag from `dart` through `dart analyze` and `dart fix`
  to the execution of the analysis server.
- Updates all applicable uses of `dart analyze`, `dart fix`, and the
  analysis_server binary entry points in the SDK to disable analytics
  for the test infrastructure.

Bug: https://github.com/dart-lang/sdk/issues/49445
Change-Id: I1302cad7e04b21454aa7d9e8ee72a876b231377d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287661
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2023-03-16 18:00:57 +00:00
Sigurd Meldgaard 24af087585 Bump pub to 4bd757ce1dad04035fb0dbc6156879af23d8b3b8
This includes all the changes reverted in https://dart-review.googlesource.com/c/sdk/+/289062

This also contains `https://dart.googlesource.com/pub.git/+/c939e81f Fix issue with _ in package names in dart add (3838)` fixing the reason for the revert.

Changes:
```
> git log --format="%C(auto) %h %s" 048e3ad..4bd757c
 https://dart.googlesource.com/pub.git/+/4bd757ce Handle http errors gracefully when downloading archive (3811)
 https://dart.googlesource.com/pub.git/+/c939e81f Fix issue with _ in package names in dart add (3838)
 https://dart.googlesource.com/pub.git/+/9df0fddf Lazy construction of cache path. (3837)
 https://dart.googlesource.com/pub.git/+/554b3c32 Lazy loading of pubspec.yaml from entrypoint (3835)
 https://dart.googlesource.com/pub.git/+/cfaec21f Remove support for legacy credentials file (3824)
 https://dart.googlesource.com/pub.git/+/142baa3a Remove the exported deprecatedpubCommand (3825)
 https://dart.googlesource.com/pub.git/+/719afcf4 Remove obsolete TODO. (3827)
 https://dart.googlesource.com/pub.git/+/80d3e0d6 Remove obsolete tests (for features) (3834)
 https://dart.googlesource.com/pub.git/+/09eb6125 Remove barback, build and serve commands (3833)
 https://dart.googlesource.com/pub.git/+/e2e740ca Remove command list-package-dirs (3832)
 https://dart.googlesource.com/pub.git/+/6db5faa2 Remove support for PUB_CACHE in APPDATA on windows (3831)
 https://dart.googlesource.com/pub.git/+/a7a74857 Don't ignore a folder called 'packages' when publishing (3828)
 https://dart.googlesource.com/pub.git/+/70bfc022 Remove support for .pub package-local cache (3823)
 https://dart.googlesource.com/pub.git/+/4cd7a0a5 Use local variable for buffer (3826)
 https://dart.googlesource.com/pub.git/+/397e245e Remove obsolete TODO. (3821)
 https://dart.googlesource.com/pub.git/+/17ec4652 Handle malformatted content-hashes in cache, version listing or pubspec.lock (3818)
 https://dart.googlesource.com/pub.git/+/49c682c7 Add workflow to close need-info issues with responses. (3817)
 https://dart.googlesource.com/pub.git/+/bcb5ce18 Fix wrong action when executing git command (3814)
 https://dart.googlesource.com/pub.git/+/086c2d12 Larger size limit for caching package listings (3815)
 https://dart.googlesource.com/pub.git/+/94b43d05 remove an extra period from a publish message (3812)
 https://dart.googlesource.com/pub.git/+/d69493e5 Don't allow non-null-safety constraints in the root pubspec (3800)
 https://dart.googlesource.com/pub.git/+/3514d7e7 Fail gracefully when tar file contains duplicate entries (3805)
 https://dart.googlesource.com/pub.git/+/0b3b8b44 Give full error even in summary mode (3804)
 https://dart.googlesource.com/pub.git/+/09c29722 Allow adding and removing dependency overrides (3716)
 https://dart.googlesource.com/pub.git/+/7184d1b5 accept 'topics' property in pubspec.yaml (3796)
 https://dart.googlesource.com/pub.git/+/cd106dfd Improve usage text of get (3792)
 https://dart.googlesource.com/pub.git/+/019d61cb Handle bad git revisions (3791)
 https://dart.googlesource.com/pub.git/+/e3ff7a99 Use 'pkg' and 'packages' to trigger suggestions for the pub command (3731)
 https://dart.googlesource.com/pub.git/+/ea24bf22 Better error when path dependency has no pubspec.yaml (3787)
 https://dart.googlesource.com/pub.git/+/da2a0144 Drop --use-data-isolate-strategy flag for tests (3788)
 https://dart.googlesource.com/pub.git/+/a565858e Improve documentation of `pub token` and subcommands (3778)
 https://dart.googlesource.com/pub.git/+/dd320459 Add test for publishing and consuming files with unicode characters in name (3785)
 https://dart.googlesource.com/pub.git/+/c4226d9f Fail tests on errors thrown by test PackageServer (3784)
 https://dart.googlesource.com/pub.git/+/12019939 Consider pubspec_overrides.yaml when publishing (3782)
 https://dart.googlesource.com/pub.git/+/d8a97497 Allow addition of tokens for insecure localhost repositories (3777)

```

Diff: https://dart.googlesource.com/pub.git/+/048e3ad2b5e1b4ebe6883addbc95722be6904a7b..4bd757ce1dad04035fb0dbc6156879af23d8b3b8/
Change-Id: I67babf094b7cc4152c5c4ccc4b3e536634a57fc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289201
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2023-03-16 11:17:33 +00:00
Siva Annamalai 91844f1212 Revert "Reland "Bump pub to d69493e5163553bde53c0889b7479dee02f550bf""
This reverts commit ef8aaa3301.

Reason for revert: It doesn't seem to solve the flutter issue, A roll into flutter showed the same error https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8786538012879301585/+/u/run_entrypoint_dart_registrant/test_stdout

Original change's description:
> Reland "Bump pub to d69493e5163553bde53c0889b7479dee02f550bf"
>
> This is a reland of commit a06ade1d14
>
> Fix of flutter issue was landed here:
> https://github.com/flutter/flutter/commit/3f2cca8eebfd3de8b846ef9f3bfa50dcf8eb179d
>
> Original change's description:
> > Bump pub to d69493e5163553bde53c0889b7479dee02f550bf
> >
> > Changes:
> > ```
> > > git log --format="%C(auto) %h %s" 048e3ad..d69493e
> >  https://dart.googlesource.com/pub.git/+/d69493e5 Don't allow non-null-safety constraints in the root pubspec (3800)
> >  https://dart.googlesource.com/pub.git/+/3514d7e7 Fail gracefully when tar file contains duplicate entries (3805)
> >  https://dart.googlesource.com/pub.git/+/0b3b8b44 Give full error even in summary mode (3804)
> >  https://dart.googlesource.com/pub.git/+/09c29722 Allow adding and removing dependency overrides (3716)
> >  https://dart.googlesource.com/pub.git/+/7184d1b5 accept 'topics' property in pubspec.yaml (3796)
> >  https://dart.googlesource.com/pub.git/+/cd106dfd Improve usage text of get (3792)
> >  https://dart.googlesource.com/pub.git/+/019d61cb Handle bad git revisions (3791)
> >  https://dart.googlesource.com/pub.git/+/e3ff7a99 Use 'pkg' and 'packages' to trigger suggestions for the pub command (3731)
> >  https://dart.googlesource.com/pub.git/+/ea24bf22 Better error when path dependency has no pubspec.yaml (3787)
> >  https://dart.googlesource.com/pub.git/+/da2a0144 Drop --use-data-isolate-strategy flag for tests (3788)
> >  https://dart.googlesource.com/pub.git/+/a565858e Improve documentation of `pub token` and subcommands (3778)
> >  https://dart.googlesource.com/pub.git/+/dd320459 Add test for publishing and consuming files with unicode characters in name (3785)
> >  https://dart.googlesource.com/pub.git/+/c4226d9f Fail tests on errors thrown by test PackageServer (3784)
> >  https://dart.googlesource.com/pub.git/+/12019939 Consider pubspec_overrides.yaml when publishing (3782)
> >  https://dart.googlesource.com/pub.git/+/d8a97497 Allow addition of tokens for insecure localhost repositories (3777)
> >
> > ```
> >
> > Diff: https://dart.googlesource.com/pub.git/+/048e3ad2b5e1b4ebe6883addbc95722be6904a7b..d69493e5163553bde53c0889b7479dee02f550bf/
> > Change-Id: I92af981e9cb6aaedfcd75a7327dfef071645306b
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285908
> > Reviewed-by: Jonas Jensen <jonasfj@google.com>
> > Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
> > Reviewed-by: William Hesse <whesse@google.com>
>
> Change-Id: Ieeab0b4782afa216b353b91c57bde90957ce0aff
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288440
> Reviewed-by: William Hesse <whesse@google.com>
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>

Change-Id: Ibf3e7ec9080b137672ad2b9179090e6c980c6962
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289062
Reviewed-by: William Hesse <whesse@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2023-03-15 21:45:39 +00:00
William Hesse 4b3bd7564c Add upload tool for analysis_server benchmarks.
Bug: b/74375756
Change-Id: I480188f7f021e571cb276bddaf1da2eef4991b08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283660
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2023-03-15 15:59:25 +00:00
Nicholas Shahan d4c1eb7509 [dart2js] Remove test configs that are now unused
Cleanup unused paths from file sets.

Change-Id: Iaacec17e14383dc9901df76902aa94a9cec30314
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281349
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2023-03-15 08:33:42 +00:00
Ryan Macnak 05225d587e [infra] Don't test multiple Fuchsia architectures on the same builder.
Change-Id: Ic54e445e3b3074df8f670e24feaeb4862d3d8717
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288620
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-03-14 19:25:36 +00:00
Ryan Macnak 4578b36999 [infra] Remove old JIT NNBD configurations.
Change-Id: I82e196b7f40fe783ef8b919c3a34ab08c549a735
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286240
Reviewed-by: Alexander Thomas <athom@google.com>
2023-03-14 08:58:45 +00:00
Sigurd Meldgaard ef8aaa3301 Reland "Bump pub to d69493e5163553bde53c0889b7479dee02f550bf"
This is a reland of commit a06ade1d14

Fix of flutter issue was landed here:
https://github.com/flutter/flutter/commit/3f2cca8eebfd3de8b846ef9f3bfa50dcf8eb179d

Original change's description:
> Bump pub to d69493e5163553bde53c0889b7479dee02f550bf
>
> Changes:
> ```
> > git log --format="%C(auto) %h %s" 048e3ad..d69493e
>  https://dart.googlesource.com/pub.git/+/d69493e5 Don't allow non-null-safety constraints in the root pubspec (3800)
>  https://dart.googlesource.com/pub.git/+/3514d7e7 Fail gracefully when tar file contains duplicate entries (3805)
>  https://dart.googlesource.com/pub.git/+/0b3b8b44 Give full error even in summary mode (3804)
>  https://dart.googlesource.com/pub.git/+/09c29722 Allow adding and removing dependency overrides (3716)
>  https://dart.googlesource.com/pub.git/+/7184d1b5 accept 'topics' property in pubspec.yaml (3796)
>  https://dart.googlesource.com/pub.git/+/cd106dfd Improve usage text of get (3792)
>  https://dart.googlesource.com/pub.git/+/019d61cb Handle bad git revisions (3791)
>  https://dart.googlesource.com/pub.git/+/e3ff7a99 Use 'pkg' and 'packages' to trigger suggestions for the pub command (3731)
>  https://dart.googlesource.com/pub.git/+/ea24bf22 Better error when path dependency has no pubspec.yaml (3787)
>  https://dart.googlesource.com/pub.git/+/da2a0144 Drop --use-data-isolate-strategy flag for tests (3788)
>  https://dart.googlesource.com/pub.git/+/a565858e Improve documentation of `pub token` and subcommands (3778)
>  https://dart.googlesource.com/pub.git/+/dd320459 Add test for publishing and consuming files with unicode characters in name (3785)
>  https://dart.googlesource.com/pub.git/+/c4226d9f Fail tests on errors thrown by test PackageServer (3784)
>  https://dart.googlesource.com/pub.git/+/12019939 Consider pubspec_overrides.yaml when publishing (3782)
>  https://dart.googlesource.com/pub.git/+/d8a97497 Allow addition of tokens for insecure localhost repositories (3777)
>
> ```
>
> Diff: https://dart.googlesource.com/pub.git/+/048e3ad2b5e1b4ebe6883addbc95722be6904a7b..d69493e5163553bde53c0889b7479dee02f550bf/
> Change-Id: I92af981e9cb6aaedfcd75a7327dfef071645306b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285908
> Reviewed-by: Jonas Jensen <jonasfj@google.com>
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
> Reviewed-by: William Hesse <whesse@google.com>

Change-Id: Ieeab0b4782afa216b353b91c57bde90957ce0aff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288440
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2023-03-13 11:52:28 +00:00
Sigurd Meldgaard 46324e49da Revert "Bump pub to d69493e5163553bde53c0889b7479dee02f550bf"
This reverts commit a06ade1d14.

Reason for revert: Broke flutter: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-engine-linux/19264/overview

Original change's description:
> Bump pub to d69493e5163553bde53c0889b7479dee02f550bf
>
> Changes:
> ```
> > git log --format="%C(auto) %h %s" 048e3ad..d69493e
>  https://dart.googlesource.com/pub.git/+/d69493e5 Don't allow non-null-safety constraints in the root pubspec (3800)
>  https://dart.googlesource.com/pub.git/+/3514d7e7 Fail gracefully when tar file contains duplicate entries (3805)
>  https://dart.googlesource.com/pub.git/+/0b3b8b44 Give full error even in summary mode (3804)
>  https://dart.googlesource.com/pub.git/+/09c29722 Allow adding and removing dependency overrides (3716)
>  https://dart.googlesource.com/pub.git/+/7184d1b5 accept 'topics' property in pubspec.yaml (3796)
>  https://dart.googlesource.com/pub.git/+/cd106dfd Improve usage text of get (3792)
>  https://dart.googlesource.com/pub.git/+/019d61cb Handle bad git revisions (3791)
>  https://dart.googlesource.com/pub.git/+/e3ff7a99 Use 'pkg' and 'packages' to trigger suggestions for the pub command (3731)
>  https://dart.googlesource.com/pub.git/+/ea24bf22 Better error when path dependency has no pubspec.yaml (3787)
>  https://dart.googlesource.com/pub.git/+/da2a0144 Drop --use-data-isolate-strategy flag for tests (3788)
>  https://dart.googlesource.com/pub.git/+/a565858e Improve documentation of `pub token` and subcommands (3778)
>  https://dart.googlesource.com/pub.git/+/dd320459 Add test for publishing and consuming files with unicode characters in name (3785)
>  https://dart.googlesource.com/pub.git/+/c4226d9f Fail tests on errors thrown by test PackageServer (3784)
>  https://dart.googlesource.com/pub.git/+/12019939 Consider pubspec_overrides.yaml when publishing (3782)
>  https://dart.googlesource.com/pub.git/+/d8a97497 Allow addition of tokens for insecure localhost repositories (3777)
>
> ```
>
> Diff: https://dart.googlesource.com/pub.git/+/048e3ad2b5e1b4ebe6883addbc95722be6904a7b..d69493e5163553bde53c0889b7479dee02f550bf/
> Change-Id: I92af981e9cb6aaedfcd75a7327dfef071645306b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285908
> Reviewed-by: Jonas Jensen <jonasfj@google.com>
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
> Reviewed-by: William Hesse <whesse@google.com>

Change-Id: I0cb55a2cf4602868649c153dd1d86ba91c751ce5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288200
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Auto-Submit: Sigurd Meldgaard <sigurdm@google.com>
2023-03-10 08:17:17 +00:00
Sigurd Meldgaard a06ade1d14 Bump pub to d69493e5163553bde53c0889b7479dee02f550bf
Changes:
```
> git log --format="%C(auto) %h %s" 048e3ad..d69493e
 https://dart.googlesource.com/pub.git/+/d69493e5 Don't allow non-null-safety constraints in the root pubspec (3800)
 https://dart.googlesource.com/pub.git/+/3514d7e7 Fail gracefully when tar file contains duplicate entries (3805)
 https://dart.googlesource.com/pub.git/+/0b3b8b44 Give full error even in summary mode (3804)
 https://dart.googlesource.com/pub.git/+/09c29722 Allow adding and removing dependency overrides (3716)
 https://dart.googlesource.com/pub.git/+/7184d1b5 accept 'topics' property in pubspec.yaml (3796)
 https://dart.googlesource.com/pub.git/+/cd106dfd Improve usage text of get (3792)
 https://dart.googlesource.com/pub.git/+/019d61cb Handle bad git revisions (3791)
 https://dart.googlesource.com/pub.git/+/e3ff7a99 Use 'pkg' and 'packages' to trigger suggestions for the pub command (3731)
 https://dart.googlesource.com/pub.git/+/ea24bf22 Better error when path dependency has no pubspec.yaml (3787)
 https://dart.googlesource.com/pub.git/+/da2a0144 Drop --use-data-isolate-strategy flag for tests (3788)
 https://dart.googlesource.com/pub.git/+/a565858e Improve documentation of `pub token` and subcommands (3778)
 https://dart.googlesource.com/pub.git/+/dd320459 Add test for publishing and consuming files with unicode characters in name (3785)
 https://dart.googlesource.com/pub.git/+/c4226d9f Fail tests on errors thrown by test PackageServer (3784)
 https://dart.googlesource.com/pub.git/+/12019939 Consider pubspec_overrides.yaml when publishing (3782)
 https://dart.googlesource.com/pub.git/+/d8a97497 Allow addition of tokens for insecure localhost repositories (3777)

```

Diff: https://dart.googlesource.com/pub.git/+/048e3ad2b5e1b4ebe6883addbc95722be6904a7b..d69493e5163553bde53c0889b7479dee02f550bf/
Change-Id: I92af981e9cb6aaedfcd75a7327dfef071645306b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285908
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2023-03-09 13:48:51 +00:00
Nicholas Shahan d77e22a20b [dart2js] Update tests matrix entries
- Update options for existing configurations.
- Add one new configuration for running _2 test suites.
- Rename builders and update to run new configurations.

Tested: Tested with led runs.
Change-Id: I87de456b6b2e53d9e211cbd716fef18910aba69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281348
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2023-03-08 08:40:57 +00:00
Ryan Macnak c7569492aa [infra] Add configurations to rename JIT NNBD.
Change-Id: I139200ddbec0da456c38d495141b0122ed034a08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286222
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2023-03-03 18:21:01 +00:00
Ryan Macnak befb2e2edf [infra] Remove old configurations for Linux ARM64.
Change-Id: I8b2941c43f142ccc02e316a5ecdac4ceb27e9b83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285381
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-03-01 19:02:53 +00:00
Nicholas Shahan f0fb9db6c8 [ddc] Remove unused configurations and builders
Cleanup unused `xcodebuild/ReleaseX64/` paths from file sets.

Change-Id: I6c109d693a1dc2bf7b7e095703fdeab7113d89df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282484
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2023-02-28 20:01:02 +00:00
Ryan Macnak 1d0146984c [infra] Add configurations to migrate Linux ARM64 to NNBD.
Change-Id: Iafe32528a4516817d6770e5e87686c97bd58da8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285160
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-02-27 18:40:28 +00:00
Ryan Macnak 3583c63b18 [infra] Remove old configurations for the "compressed" group.
Change-Id: I7c49fa13f67eb0f2f662f1a393cdf5614644604a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284483
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-02-23 19:16:30 +00:00
stuartmorgan dd128e7634 Replace flutter/plugins analysis
Closes https://github.com/dart-lang/sdk/pull/51494

GitOrigin-RevId: 8e0394371fbe65e2c56096b081c22122bf36e2a0
Change-Id: Ib89119b1bcbcae558d8f1a5884c4baf22c99d672
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284741
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2023-02-22 20:52:10 +00:00
Ryan Macnak 3ff9699185 [infra] Add configurations to migrate the "compressed" group.
Change-Id: I15018b1c50b7c3a75b9b0c958ee7cb439b3cd350
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284482
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-02-22 17:27:46 +00:00
Nicholas Shahan fc2c9269f0 [ddc] Add new test and builder configs
Change-Id: If337869b80cb440b6c15cc7834bda5a5cfdd80fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279750
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2023-02-17 19:45:39 +00:00
Ryan Macnak 7e4357b63d [infra] Remove old configurations for the "product" group.
Change-Id: I8cd9dbaef903c1283bfdca481a6924e81fbfa869
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282822
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-02-17 18:30:12 +00:00
Nate Biggs 75a4625871 [dart2js] Move test bots to use null safety.
Change-Id: I2f499f3a8dc18ede9d8caa182cb6f95cdeb3e7c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282920
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2023-02-15 04:04:48 +00:00
Ryan Macnak bf1b0ee2ba [infra] Add configurations to migrate the "product" group.
Change-Id: Ic321ed35598b5427d741f206cd04aeacdc0607bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282821
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-02-15 01:15:33 +00:00