0ba6f0637b
recognize armv8l host as arm
...
Bug: https://github.com/dart-lang/sdk/issues/52290
Change-Id: I24185ca2a17133f32473f3e81323bc3389c0c8f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/301900
Reviewed-by: Jonas Termansen <sortie@google.com >
Commit-Queue: Jonas Termansen <sortie@google.com >
2023-05-08 08:13:17 +00:00
d7d2dc10ef
[infra] Add vm-aot-mac-release-x64 and vm-aot-mac-product-arm64.
...
Change-Id: I9b8b3384cfe783f1943d0598e5f2e76de36253c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300020
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-05-01 22:33:34 +00:00
5493bc035d
[infra] Remove arm32 from gcc builder.
...
Bug: https://github.com/dart-lang/sdk/issues/52080
Change-Id: I8332638ebb758507403b098f463291fd19f231e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/299240
Reviewed-by: Alexander Thomas <athom@google.com >
2023-04-28 05:33:00 +00:00
4c2ec2ef45
[infra] Remove configurations for legacy QEMU.
...
Change-Id: Iec8bff7573c2b9d7544511916c8e1c0fc3859398
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296063
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2023-04-27 09:39:51 +00:00
07326f7762
[infra] Add configurations for NNBD QEMU.
...
Change-Id: Id3bb6d1b09ccbfe445d2f5132e1f3b07b4edd852
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296060
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2023-04-27 09:39:51 +00:00
60fec9c720
[infra] Adjust sharding for VM JIT builders
...
Cutting the shards from 10 to 4 makes the shards time out after 90
minutes on the slowest builders. Even the fastest builders have shard
runtimes of 30 minutes.
Changing the sharding of JIT builder tests from 4 to 8 for both VM tests
and co19 tests.
Fixup after https://dart-review.googlesource.com/c/sdk/+/294140
Change-Id: I813aa40b6aac0fc5083a9606b71d00e78ce71ffc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297480
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2023-04-24 10:18:05 +00:00
45efccb5e0
Remove left-over patch declarations for List constructor.
...
This CL replaces https://dart-review.googlesource.com/c/sdk/+/296900
The `List` constructor is removed in Dart 3.0.
Some of the `@patch` implementations were not removed.
This is *high priority*. It seems the left-over `@patch factory List` constructor did not cause any errors, instead it *added* a constructor to `List` that can be used in web compiled code. Even if `List` doesn't have such a constructor in the SDK code proper.
The VM and analyzer will say the invocation is an error, but dart2js happily compiles it and runs.
(It used to be that patches couldn't add public members, that security seems to have been removed.)
Also removes code which tries to detect "the unnamed List constructor",
which is no longer a thing, and a number of invocations of the constructor, where it's not clear that the test is aware that the constructor no longer exists, and is not marked as `@dart=2.x` with x < 12.
TEST=ci
Change-Id: I4ffaf3ae2c4e75ca06e7ba0bf19187b6376f3888
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297100
Reviewed-by: Brian Quinlan <bquinlan@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2023-04-22 00:38:28 +00:00
df63c24638
Checked in SDKs are now automatically uploaded.
...
The official dart-sdk packages are now automatically built in the CI and
developers will no longer need to build them manually when rolling the
checked in SDK. The cipd instances are now tagged with the commit hash
instead of the version number, which allows us multiple attempts at
building a particular version (which different commits).
Bug: b/279024347
Change-Id: I4bfb4a5384bb8c671b576afdac0e5008ccfcc8a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296861
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Jonas Termansen <sortie@google.com >
2023-04-21 13:57:15 +00:00
4d8fa9729e
[infra] Remove configurations for legacy obfuscate and stripped modes.
...
Change-Id: I7192ba0fe31f2059c722559c4acaec4bdf0b01f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296022
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2023-04-20 19:11:06 +00:00
6585fcf1d2
Delete promote script.
...
The promote script has been replaced by the promote recipe.
Remove unused code from bot_utils.
Bug: b/277727317
Change-Id: I6a087c11d6e98480d346017c97be82bf23438aed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296260
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Jonas Termansen <sortie@google.com >
2023-04-20 15:41:11 +00:00
1aed900be7
[infra] Migrate Android JIT FFI builders to sound NNBD.
...
Change-Id: Ifa93f7329bf988a73e406e7978488a0abbc06ae4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296020
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
Auto-Submit: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2023-04-20 15:37:20 +00:00
9814aaf662
[infra] Mark new vm-dwarf/obfuscate configs as sound null safe
...
Without this, they will run _2 suites by default.
Change-Id: Ica435675c467875a7f3dbab6cf05994835dd0ab5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296583
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2023-04-20 14:19:51 +00:00
8a5c3d9e3d
[infra] Add configurations to migrate obfuscate and stripped modes.
...
Change-Id: I62581c6874b211c57da61639f460685790acb40d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296021
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2023-04-19 16:26:59 +00:00
22d666d67a
add tools for generating shim headers
...
Closes https://github.com/dart-lang/sdk/pull/51612
GitOrigin-RevId: 7e71761d5f13e9dff8d60c0287cc12fda56f9642
Change-Id: I76400e00ead54d9fc3d0dae26c2468e8401f3de8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286601
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2023-04-19 01:37:48 +00:00
7b2cfdbc8c
[standalone] Remove tcmalloc.
...
Removes build complexity around which combinations of compiler/architecture/sysroot/libc support tcmalloc, reduces binary size, and reduces memory usage at the expense of some throughput.
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/51111
Bug: https://github.com/dart-lang/sdk/issues/51535
Bug: https://github.com/dart-lang/sdk/issues/51639
Change-Id: Id73d5b87e2b16c1cd1e5228ba0cbf1aa2521c01a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287001
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-04-18 20:56:00 +00:00
30518b205d
[infra] Copy llvm to shards, which is the target of the llvm-strip symlink.
...
Bug: https://github.com/dart-lang/sdk/issues/52010
Change-Id: I44d81ebb2f9e3db5ed86e560f7b043bd26804bf1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295747
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2023-04-18 18:33:10 +00:00
f9f1030959
[infra] DEPS and test dart-lang/native packages
...
This CL pulls in dart-lang/native packages and runs them on the
pkg bots.
Bug: https://github.com/dart-lang/sdk/issues/50565
Change-Id: Ifcd8ba25f8bdfeca8f4c161adfc3c20e0ce500d1
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295280
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2023-04-18 08:04:49 +00:00
639a6f06ef
Simplify several non-terminals to use regex-like grammar operators
...
Follow-up to SDK issue #51744 .
Change-Id: Ic713ed5adf99bed49f1e93a70817650d5f0c3c46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295545
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2023-04-17 18:43:31 +00:00
70762f0de0
[ANTLR] Transform recursive definition of onParts to use iteration ...
...
Closes https://github.com/dart-lang/sdk/pull/51744
GitOrigin-RevId: 08a3bb98762275f10f6911f59b7cdf5ac1ae6c1d
Change-Id: Ib50f2361ca392554e9c632d7b780f83008bfbef7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288980
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2023-04-17 17:11:24 +00:00
9466e8d53d
[infra] Fix version ordering in release scripts
...
The prerelease_patch number was being compared before the prerelease
number in the version comparison.
Change-Id: I77cc46d07912ffdbe321ee9d855f928452572a5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295300
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2023-04-14 12:27:01 +00:00
2f30f88916
Mark deprecated Hints with Warning aliases as deprecated
...
This will help with any references to deprecated Hints in other
codebases, like nnbd_migraion or linter...
Change-Id: Iccd43d8e3113e6e3e0e458bf959c7f4d48185f35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294182
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-04-13 20:07:36 +00:00
badd96032d
[infra] Test gcc cross builds instead of simulators.
...
Skipping arm64 for lack of toolchain on the bots.
Disable tcmalloc on arm, where it fails to compile.
The builds are split into separate steps instead of using a shorter invocation like `--mode=debug,release --arch=ia32,x64,arm,riscv64` to avoid per-step timeouts.
Change-Id: Iccf5e6e8d91584147138ac37487560a7cc608b6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283121
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-04-13 18:02:37 +00:00
178063c7f4
[dart2js] Fix fileset used by dill_loader_test
...
Add `tests/corelib/` to the fileset that contains all the "_2" test
suites so it can be read by
`pkg/compiler/test/end_to_end/dill_loader_test.dart`.
The `dart2js-unit-linux-x64-release` bot configuration uses
the `js_platform_2` fileset because many of the tests under `pkg/compiler/test/` are running or referencing unsound test
files. As the tests migrate to use sound null safety, they will
need to update their hard coded paths to use the sound version
of the test files. More test paths can be added to the fileset as
needed until all the testes are running with sound null safety. Then
the bot configuration can switch to use the `js_platform` fileset
instead.
Change-Id: I0542e035b89bb512c61e1259f86e4378590fb178
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294680
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Nate Biggs <natebiggs@google.com >
2023-04-12 23:57:19 +00:00
4bb4b2d68b
[infra] Rebalance VM shards.
...
This should make both JIT and AOT shards take about 15 minutes each in release mode.
Change-Id: Id0668c7f373146dba032cb5c743e0e97dd566297
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294140
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2023-04-12 17:44:17 +00:00
7bac8ed687
[Release] Bump minor version of main to version 3.1.
...
Change-Id: Icf489686d790be195e37db37727782227d2f3704
TEST=Version bump autogenerated by scripts
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294600
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2023-04-12 16:36:20 +00:00
80de9162c8
Retire 2.19 experiment.
...
Tested: No tests. Removing functionality, all existing tests running is a success.
Change-Id: I25eb84347e1d133d465671223f4d3b037116c5e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294241
Reviewed-by: Liam Appelbe <liama@google.com >
Auto-Submit: Lasse Nielsen <lrn@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Kevin Chisholm <kevinjchisholm@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2023-04-12 12:46:41 +00:00
4b5d2087a8
[build] Honor build.py --toolchain for ia32 and x64 like the other architectures.
...
TEST=local build with custom toolchain
Change-Id: I7b9563da54afae0b3057d596d80a778c8db523a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294428
Reviewed-by: Liam Appelbe <liama@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-04-12 02:27:38 +00:00
9fc1f76e02
[infra] Copy llvm-strip to shards.
...
Change-Id: I1a2a8b68c33dd1e3b0071fd1becdeebab3e8a6df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294441
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-04-10 22:52:21 +00:00
956bb9ac57
[infra] Copy llvm-symbolizer to shards.
...
Change-Id: I7f8010f1b2dee00af10f64621b7bddce6e2926a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294365
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2023-04-10 19:10:18 +00:00
e90e43138e
[infra] Fix missing process_test for simarm_x64 builders.
...
Bug: https://github.com/dart-lang/sdk/issues/51949
Change-Id: I8456166b8fbd61e06e59af8cf055c9cf90e2661d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293741
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-04-06 15:59:57 +00:00
acfe1aa9cf
[infra] Add "vm" or "front_end" prefix to shard names.
...
Makes it easier to see what's producing load by sorting by task name in the task list.
Most are already prefixed with analyzer/dart2js/ddc/vm.
Change-Id: Ia18757ad593b285401a1d315c172d1ad7b6fbf77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293003
Reviewed-by: Jonas Termansen <sortie@google.com >
2023-04-05 19:44:28 +00:00
c8b2d030cf
[infra] Remove old names for GCC and MSVC builders.
...
Change-Id: Ia644a70e0a5a1cf84eafeafb451016d962ff39c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293081
Reviewed-by: Jonas Termansen <sortie@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-04-05 16:28:24 +00:00
432467ec19
[infra] Add configurations to rename GCC and MSVC builders.
...
Change-Id: I793e9532cbf9b9af43f91644ba328a6cfc06e1db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293060
Reviewed-by: Jonas Termansen <sortie@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-04-04 17:17:57 +00:00
d1d232776a
[dart2wasm] Rename the dart:wasm library to dart:_wasm.
...
This is an internal library not meant to be used in application code.
CoreLibraryReviewExempt: Changes only Wasm specific libraries.
Change-Id: I2f5b463382d35a442e782067ef7d9063183fe5e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292021
Reviewed-by: Ömer Ağacan <omersa@google.com >
Reviewed-by: Joshua Litt <joshualitt@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2023-04-04 11:52:18 +00:00
0386350aa7
Remove code which no longer compiles.
...
Probably hasn't worked in a while, so it's unlikely
that anything depends on it.
Change-Id: I7b73b92842b897b8367bf48a490a0e25cd306b3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292083
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Auto-Submit: Lasse Nielsen <lrn@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2023-04-03 23:40:05 +00:00
58a3324adf
[infra] Remove old AOT NNBD configurations.
...
Change-Id: I2d444f5c6735197d9bfcb10863ff5a9f34b580f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286361
Reviewed-by: Alexander Thomas <athom@google.com >
2023-04-02 08:34:23 +00:00
fdabbc9d10
[infra] Add configurations to rename AOT NNBD.
...
Change-Id: I56044e0fcfdb4623595971354a01164d8ae708e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286360
Reviewed-by: Alexander Thomas <athom@google.com >
2023-04-02 08:34:23 +00:00
a48b408a5a
[dart2js][ddc] Cleanup test matrix file sets
...
- Rename file sets:
"web_platform" -> "js_platform_2"
"web_platform_nnbd" -> "js_platform"
- Sort lists and remove unused paths.
Change-Id: I313559343d5ad3c5c770c79b68245ea446bb1ac0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289300
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2023-03-31 19:59:02 +00:00
8ebed3d806
[dart:html] Add webkitSpeechRecognition to SpeechRecognition class
...
In Safari, the prototype of a SpeechRecognition object returns a
webkitSpeechRecognition prototype. This name is different than the
one in the @Native annotation, so dart2js fails to recognize it. We
should it to the annotation so we properly intercept it.
CoreLibraryReviewExempt: Changing bindings of dart:html, no change to API.
Change-Id: Ic533e1208dd28e521403998e43009e0f651e2dfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291961
Reviewed-by: Nate Biggs <natebiggs@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2023-03-31 17:32:54 +00:00
d01421c837
[test] Recognize exitcode 1 from all sanitizers.
...
Should avoid test failures triggering spurious infra failures.
TEST=ci
Change-Id: Iece312aa7eba814d7a740b0db16505d480cd3808
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291582
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-03-29 18:04:20 +00:00
410524eb26
[infra/debian] Remove unused import-statement from test script
...
Fixes debian builder broken by https://dart.googlesource.com/sdk/+/77446204dac5eae6f8407e371873612359f8815c
Change-Id: I87f7174d11a88070897a406181169f051addc877
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291720
Commit-Queue: Alexander Aprelev <aam@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2023-03-29 04:19:47 +00:00
7c0e4d67c7
[dart2js] Prevent unsound compiles
...
- Remove unsound platform .dill files from the packaged SDK.
- Throw and error referencing the sound null safety requirements of
Dart 3 when compiling with `--no-sound-null-safety` and an unsound
platform .dill file is not found.
Change-Id: I703a446e3e92c76a6b48168577fc0161eea83854
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289280
Commit-Queue: Nate Biggs <natebiggs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2023-03-28 21:31:27 +00:00
77446204da
Reland "[analyzer] Move 4 more HintCodes to be WarningCodes, UNUSED_*"
...
This reverts commit e48f35b43d0ef7ed2ebdhttps://github.com/dart-lang/sdk/issues/50796
> > Change-Id: Ib5b153bc6e64bc433df1f05c53d82f71b470bbec
> > TEST=presubmit bots
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290703
> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> > Reviewed-by: Alexander Aprelev <aam@google.com >
> > Commit-Queue: Samuel Rawlins <srawlins@google.com >
> > Reviewed-by: Nate Bosch <nbosch@google.com >
>
> Bug: https://github.com/dart-lang/sdk/issues/50796
> Change-Id: If1c460bdcf422033648417da5ba2f5fbc1b459c2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291460
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> Auto-Submit: Oleh Prypin <oprypin@google.com >
> Reviewed-by: Alexander Thomas <athom@google.com >
> Commit-Queue: Alexander Thomas <athom@google.com >
> Commit-Queue: Oleh Prypin <oprypin@google.com >
Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: Ie503b57a19df1a50cb3dfe50c840d20779310e87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Oleh Prypin <oprypin@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
2023-03-28 21:26:58 +00:00
e48f35b43d
Revert "[analyzer] Move 4 more HintCodes to be WarningCodes, UNUSED_*"
...
This reverts commit 0ef7ed2ebdhttps://github.com/dart-lang/sdk/issues/50796
> Change-Id: Ib5b153bc6e64bc433df1f05c53d82f71b470bbec
> TEST=presubmit bots
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290703
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Reviewed-by: Alexander Aprelev <aam@google.com >
> Commit-Queue: Samuel Rawlins <srawlins@google.com >
> Reviewed-by: Nate Bosch <nbosch@google.com >
Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: If1c460bdcf422033648417da5ba2f5fbc1b459c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291460
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Oleh Prypin <oprypin@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
Commit-Queue: Oleh Prypin <oprypin@google.com >
2023-03-28 07:16:42 +00:00
0ef7ed2ebd
[analyzer] Move 4 more HintCodes to be WarningCodes, UNUSED_*
...
Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: Ib5b153bc6e64bc433df1f05c53d82f71b470bbec
TEST=presubmit bots
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2023-03-27 21:41:12 +00:00
ec8688d97a
Reland "[build] Don't combine stdout and stderr when consuming git output."
...
Ignore non-zero exit code during GetGitRevision.
Bug: https://github.com/flutter/flutter/issues/123416
Bug: https://github.com/dart-lang/sdk/issues/51865
Change-Id: Ifff7251d478cfd742a60ba6dcdeb60e581279b75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291300
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-03-27 18:02:38 +00:00
7aaad727fa
Revert "[build] Don't combine stdout and stderr when consuming git output."
...
This reverts commit 1ac8b374a2https://ci.chromium.org/p/dart-internal/builders/ci/debianpackage-linux-main/4682
Original change's description:
> [build] Don't combine stdout and stderr when consuming git output.
>
> When the alternate objects path is broken, `git log -n1 --pretty=format:%cd` will output `error: unable to normalize alternate object path: .git/objects/no/such/path` to stderr, and we don't want this mixed into the version string.
>
> Bug: https://github.com/flutter/flutter/issues/123416
> Change-Id: Ief03e57febd5a42f5cbba2b14a736d949a90ae82
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291050
> Reviewed-by: Alexander Aprelev <aam@google.com >
> Commit-Queue: Ryan Macnak <rmacnak@google.com >
Bug: https://github.com/flutter/flutter/issues/123416
Change-Id: If100a66a7b94a2c540aa9e4f28902ce6f6ab8d64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291056
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2023-03-25 04:37:43 +00:00
1ac8b374a2
[build] Don't combine stdout and stderr when consuming git output.
...
When the alternate objects path is broken, `git log -n1 --pretty=format:%cd` will output `error: unable to normalize alternate object path: .git/objects/no/such/path` to stderr, and we don't want this mixed into the version string.
Bug: https://github.com/flutter/flutter/issues/123416
Change-Id: Ief03e57febd5a42f5cbba2b14a736d949a90ae82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291050
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-03-24 22:00:11 +00:00
fd4602f019
Bump linter to include deprecated_member_use_from_same_package
...
We also stop reporting
`HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE` and
`HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE`
as these are now replaced by the new lint rule.
The biggest change here is in the DEPRECATED_MEMBER_USE tests,
as most of these tests have
`DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE` reported (since it's
easier to write tests with files in one package). We move all
of those tests to `DEPRECATED_MEMBER_USE` tests, without losing
coverage.
Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: I7cada44265cd0e1e47ab77d4354de9a5571db614
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289444
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2023-03-24 16:35:37 +00:00
9e9b3770f4
[infra] Add configuration to migrate VM checked to NNBD.
...
Move from Linux to Mac because the Mac pool has more capacity.
Change-Id: Ie8beb33ea2f3e84f78a2824db5540249d6977e35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290608
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2023-03-23 17:45:27 +00:00
Lauren N. Liberda