 Srujan Gaddam
|
3f1c69dd1d
|
[dart:html] Fix Performance.mark typing to work with Firefox
Closes https://github.com/dart-lang/sdk/issues/48630
'mark' can return undefined in Firefox, and therefore needs to
return a nullable. Similarly, the different syntaxes of 'measure'
don't work in Firefox or Safari, so the incompatible ones are
removed from tests.
Change-Id: Ia137fe0d72ddbaad03ae8cf58c43736b128b3f33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237930
Reviewed-by: Riley Porter <rileyporter@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
|
2022-03-22 19:37:00 +00:00 |
|
|
Srujan Gaddam
|
2444bcca59
|
Fix Performance.mark and measure
Closes https://github.com/dart-lang/sdk/issues/48430
Adds overloads for both methods to accept additional/different options.
Also changes return types:
- mark returns a PerformanceEntry
- measure returns a PerformanceMeasure, but this may be undefined, so it's
marked as nullable
Change-Id: I189c4613b19e214a1f5bcc5bbd780d9dc447d9e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235286
Reviewed-by: Riley Porter <rileyporter@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
|
2022-03-21 18:58:38 +00:00 |
|
|
Leaf Petersen
|
b101a7d002
|
Add language versions to _2 test libraries
Change-Id: Ib33169c3e0ffc870915c189404074a1dea472546
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196548
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
|
2021-04-26 17:58:57 +00:00 |
|
|
Jakob Roland Andersen
|
56c8922c7c
|
Migrated test batch 208 to Dart 2.0.
Bug:
Change-Id: I97b3ca0d43bf68a60cdc2959844888c82c6af9eb
Reviewed-on: https://dart-review.googlesource.com/10260
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
|
2017-10-03 10:23:49 +00:00 |
|