Commit Graph

5 Commits

Author SHA1 Message Date
Robert Nystrom 9789e9d7a0 Migrate "e" and "f" directory language tests off @compile-error.
The "@compile-error" comment is an old not-great way of defining static
error tests.

See: https://github.com/dart-lang/sdk/issues/45634
Change-Id: Idf9012cb8c213b523d1c8bb827e530e0d2cf6609
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296407
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2023-04-20 20:49:17 +00:00
Jens Johansen 7e183b64a9 [test] Fix bug in export/duplicate_import_libd
`git show fc1b1ecc712d` shows - among lots of other changes - this:

```
diff --git a/tests/language_2/duplicate_import_liba.dart b/tests/language_2/export/duplicate_import_liba.dart
similarity index 100%
rename from tests/language_2/duplicate_import_liba.dart
rename to tests/language_2/export/duplicate_import_liba.dart
```

and

```
diff --git a/tests/language_2/duplicate_import_libd.dart b/tests/language_2/export/duplicate_import_libd.dart
similarity index 91%
rename from tests/language_2/duplicate_import_libd.dart
rename to tests/language_2/export/duplicate_import_libd.dart
index ccec81e0ff6..14f1ff413fb 100644
--- a/tests/language_2/duplicate_import_libd.dart
+++ b/tests/language_2/export/duplicate_import_libd.dart
@@ -8,6 +8,6 @@ import 'duplicate_import_liba.dart';
 import 'duplicate_import_libb.dart';
 import 'duplicate_import_libc.dart';

-export 'duplicate_import_liba.dart';
+export '../duplicate_import_liba.dart';
 export 'duplicate_import_libb.dart';
 export 'duplicate_import_libc.dart';
```

Change-Id: I806ba94ae251d574981e06ea88e6189063719785
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205264
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2021-06-30 07:44:52 +00:00
Mark Zhou 9ea431c158 Simplifying and recategorizing cyclic imports test
This bug doesn't depend on exports and instead of the constructed class hierarchy.

See: https://dart-review.googlesource.com/c/sdk/+/162383/comment/9196db98_412d446d/
Change-Id: Ib107d3fa3ab7782bee5db59754583b20976832a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162785
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
2020-09-14 20:20:49 +00:00
Mark Zhou 53895b2270 [dartdevc] Fixing issue related to dual exports of multiple entrypoints in a cyclic import loop.
See: https://github.com/flutter/flutter/issues/64011
Change-Id: I8a11e9d3f19428a516cf7a60ee45c3bacf26545d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162383
Commit-Queue: Mark Zhou <markzipan@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
2020-09-14 18:49:00 +00:00
Robert Nystrom 22b8caff1f Migrate language_2/export to NNBD.
Change-Id: Ib33ec31e1d200d602fd05439101847afbb629f47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142709
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
2020-04-07 23:30:56 +00:00