dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
91,582 Commits 2 Branches 0 Tags
9b42e2d1663ce3855097e7f8acaeaffc511f88a3
Commit Graph

19 Commits

Author SHA1 Message Date
Sam Rawlins cd52ce3f22 Enable new linter rules in nnbd_migration 
Change-Id: I7ba071c9edc23a53cb2f9bd9a37de8306a10ccef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271001
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2022-11-21 21:46:28 +00:00
Konstantin Shcheglov e03170035a Deprecate 'get name2', use 'get name' instead. 
Change-Id: Iee8ef5fb6700d96c857a22a99dc61dac3da88572
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260443
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-22 02:22:47 +00:00
Paul Berry 1f3ff13d98 Reland "Migration: fix generate_resources.dart to use dart compile js." 
This is a reland of commit 6abea1381b

Original change's description:
> Migration: fix generate_resources.dart to use `dart compile js`.
>
> This is necessary because the command `dart2js` is no longer present
> in the SDK.
>
> Change-Id: Iea3cf3092bcda6c889c55a51d1b5601773404fb9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253862
> Reviewed-by: Samuel Rawlins <srawlins@google.com>
> Commit-Queue: Paul Berry <paulberry@google.com>

Change-Id: Ibc25641aca165b578b2c4348ef0b841263298e3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255740
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-08-18 20:21:17 +00:00
Paul Berry 05eb57b0d1 Migration: add assemble_resources.dart script. 
This script does the same job as `generate_resources.dart`, but it
doesn't search the filesystem for the input files to use, nor invoke
the compiler to create the `migration.js` file.  Instead, it simply
accepts a list of input files on the command line, and outputs their
contents in an appropriate form to be stored in `resources.g.dart`.

This script will allow us to integrate more cleanly with the internal
build system.

Change-Id: I4b5445d1f5fd7eccbb5fb36f6ee4fa97d2cea87e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254421
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-08-15 16:40:46 +00:00
Paul Berry 4b61ceb1d2 Revert "Migration: fix generate_resources.dart to use dart compile js." 
This reverts commit 6abea1381b.

Reason for revert: Breaks internal build of migration tool

Original change's description:
> Migration: fix generate_resources.dart to use `dart compile js`.
>
> This is necessary because the command `dart2js` is no longer present
> in the SDK.
>
> Change-Id: Iea3cf3092bcda6c889c55a51d1b5601773404fb9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253862
> Reviewed-by: Samuel Rawlins <srawlins@google.com>
> Commit-Queue: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,srawlins@google.com

Change-Id: I73c3321e6c473f5690eaddd94d13003c978234b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253900
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-08-07 12:31:19 +00:00
Paul Berry 6abea1381b Migration: fix generate_resources.dart to use dart compile js. 
This is necessary because the command `dart2js` is no longer present
in the SDK.

Change-Id: Iea3cf3092bcda6c889c55a51d1b5601773404fb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253862
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-08-06 22:29:28 +00:00
Konstantin Shcheglov 01173e2aa2 Deprecate 'name' in AST, use 'name2' token instead. 
Change-Id: I867f009dca12208f835199297d2ea85c203c8556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252566
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-02 16:25:34 +00:00
Paul Berry 59b6e9dcd0 Sort files in nnbd_migration package. 
Also add a test to ensure that they don't get out of order again.

Change-Id: Ia847b2b21d24de49c2ce74bbc9f2652642b45f38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234663
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-03-01 14:24:38 +00:00
Paul Berry fcb5c4f4b6 Migration: stop explicitly opting generated code into null safety. 
This is no longer needed now that the whole migration engine has null
safety enabled.

Change-Id: I834bfb18f9b4d838c0cc933acb6977566bc1643a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204484
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-06-23 23:35:47 +00:00
Paul Berry 730cbcbe6e Fix hints and lints after migration of the migration tool. 
Change-Id: I90ac7e88686ba6db9b9e64538663ae2044638894
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204483
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-06-23 23:35:47 +00:00
Paul Berry 6594ded7d9 Run the migration tool on itself. 
Change-Id: Ifbdf1c33cc359519fdcf2637d50a9e4d3b054af7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204481
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-06-23 23:35:47 +00:00
Paul Berry ff058cffa6 Migration: Migrate generated file resources.g.dart to null safety. 
Change-Id: Ia7db1e886c66601c47f251fa160001e743302f09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204423
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-06-21 19:18:10 +00:00
Paul Berry 9478b71000 Create a tool for extracting resources from resources.g.dart. 
This should be helpful in debugging minified stacktraces reported for
the migration tool, such as #45326.

Bug: https://github.com/dart-lang/sdk/issues/45326
Change-Id: I44c697cfdfd6a06e8af3a2592321a1e9156ca929
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191380
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-03-16 17:21:08 +00:00
Sam Rawlins 3bd63a4d52 dart migrate: add a dart2js_path option to the resource generator 
This helps build the web app in google3.

Change-Id: Ia5650836b2df37cff7b76f1cc7877776d6210790
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180086
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-01-20 01:10:26 +00:00
Konstantin Shcheglov d219bde703 Enforce await_only_futures and fix violations (in more packages). 
Change-Id: I1812f7721915178e42956f988b9276bf8db0bfaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-24 16:58:50 +00:00
Sam Rawlins b1094db98b Fix Migrator tool generation on Windows 
Bug: https://github.com/dart-lang/sdk/issues/42636#issuecomment-678289547
Change-Id: I426bf87cfc29f19fdabbc5ce7692dd98e25ba33c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159760
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-08-24 13:31:44 +00:00
John Ryan 3c85ade7f9 Migration tool UI improvements 
- Update header text and buttons
- Add Roboto font
- Add Roboto Mono font
- Add Material icons font
- Update color scheme
- Move help button to header
- Change "Report a problem" button to "Send Feedback"
- Update button colors

Change-Id: Ia4d8b71ae8ec7a7c04ab8c238ffb0499becc9620
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151663
Commit-Queue: John Ryan <ryjohn@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-06-22 18:19:16 +00:00
John Ryan 8fe9dac0c8 add Dart logo to null safety migration tool 
Change-Id: Ie9cd580fad0e596f1653e3a87cde75e133d1fe2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151360
Commit-Queue: John Ryan <ryjohn@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-06-17 20:17:21 +00:00
Paul Berry eab774c255 Move much of migration tool UI code into pkg/nnbd_migration 
Change-Id: Ia3b388b274c908dcc6f9cb9ee4bf004b82681c43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144320
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-04-23 23:43:42 +00:00