dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
91,582 Commits 2 Branches 0 Tags
9b42e2d1663ce3855097e7f8acaeaffc511f88a3
Commit Graph

25 Commits

Author SHA1 Message Date
Devon Carew b4072ff64f [pkg/modular_test] use package:lints/recommended.yaml 
Change-Id: Icbd17513120846322df2923feb7d18abd82d3ece
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282385
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2023-02-10 23:50:31 +00:00
Josh Soref ef42a0b110 Spelling pkg analyzer lib 
Closes https://github.com/dart-lang/sdk/pull/50860

GitOrigin-RevId: b27066c37f93c8c6d1123d6ebd6a4c0afcf59844
Change-Id: I15fa4aea1dad45daf168e34d1c4450320ec9b40a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277742
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2023-01-25 14:08:27 +00:00
Kevin Moore 25fb2d6cb6 pkg:js - drop discontinued example, cleanup min SDK 
Delete some very old historical files

Change-Id: I9fffc84d0c1a6b0e4731d360418599390d5470df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279649
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2023-01-24 23:02:39 +00:00
Josh Soref 9e4dc755cb Spelling pkg 
Closes https://github.com/dart-lang/sdk/pull/50921

GitOrigin-RevId: 6b1ca502b6722b0a987f33ace66f65cbd2c24e23
Change-Id: I74e4ff3c8e759c576036d6b791bd7734ebd215d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278536
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-19 10:06:29 +00:00
Devon Carew c677a0c36f [pkg/modular_test] analyze with package:lints 
Change-Id: I8fd66acdc2ad0c39f959785039d0001d0148f1a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250765
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-07-06 21:36:40 +00:00
Sigmund Cherem 02cf9ea69c [modular_test]: migrate modular_test to null safety 
Change-Id: I516d05469dd2c2bf57e4ec079fc1007ccf4b4783
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240653
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2022-04-22 03:13:19 +00:00
Sigmund Cherem d2d810a8e8 [modular_test] Remove uses of .packages altogether. 
Embed in the modules.yaml any extra paths needed for package dependencies
instead.

This is one step to help towards https://github.com/dart-lang/sdk/issues/48275

Change-Id: I22ef02b2b2327a0c798f2fea73d59c758a8bb0bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240651
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2022-04-09 00:35:13 +00:00
Joshua Litt b1fbe0c01d [dart2js] Support running modular analysis alongside building a dill. 
Change-Id: If10385445c5f6267e2de20b090b37e1741b7ace7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237925
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2022-03-30 23:59:00 +00:00
Alexander Aprelev b453c6bcba [gardening] Fix env_test/has_mirror_support. 
Fix the test so it reports that mirrors are not supported in aot configuration.

Fixes https://github.com/dart-lang/sdk/issues/48125

Change-Id: I07fceebf8cbee8048988c8bd5287c8aec1bb8f0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227582
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2022-01-14 23:33:11 +00:00
Ahmed Ashour d041cf0478 Remove extra the, be and of 
Fixes #https://github.com/dart-lang/sdk/issues/47504

TEST=No tests needed, only comments affected.

Change-Id: Ie096307b5ce314d328fea6780f396aaa226ad3b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216182
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2021-10-20 09:29:01 +00:00
Brian Wilkerson 896f874b9f An initial definition of the Target annotation 
Change-Id: I6980da1e869c57b15a8bd068fef17f33d6a884ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154380
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-07-17 19:01:17 +00:00
Robert Nystrom 95499785eb Fix another modular test expectation file. 
Change-Id: I921c94cc84fa1a17b7187d1d5bb8f2a50dee0d10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136062
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2020-02-15 02:39:46 +00:00
Robert Nystrom 61fa0ad090 Remove matchers_lite.dart from loader_test expected packages. 
Change-Id: Ic5c060576ffde10052ee5e59394951dc70298793
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136001
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-02-14 21:38:21 +00:00
Sigmund Cherem baa721ba23 Add an sdk module to the modular_test pipeline 
+ and use it in the dart2js modular tests

Change-Id: I66cf29dcea7fb705135049e7a6ea4eb17052f3d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103575
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-05-24 19:09:12 +00:00
Sigmund Cherem edadc9c881 Add support for caching results of shared modules. 
This is important as we will soon add support for compiling the sdk as a
module and we would like to only compile it once when running a suite of
tests.

+ also enable caching in the dart2js pipeline test.

Change-Id: Ic9043f868123164f3ab425ba73f7428416b05fc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103485
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-05-24 01:27:13 +00:00
Sigmund Cherem 0c2738f616 Allow steps to declare more than one result 
Change-Id: Ifd2a19f8ff771d464737bb27e22cf05a43cc2a9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103020
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-05-20 23:25:22 +00:00
Sigmund Cherem 84fd1254ec Add tests for only-main behavior 
+ move computeTransitiveDependencies to a shared location

Change-Id: I9bfad3d1799df2be36f28fac1a6ea9a8b4c4b023
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102225
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-05-20 23:25:22 +00:00
Sigmund Cherem 475f55d46b Add dart2js modular test suite under a unit test. 
At this time this only compiles to .dill and then compiles from multiple modular
dill files.

Next steps: add the global split and add the modular data bits

Change-Id: I3399776dbd5187ddb0a3e2fdd307622a736570c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102126
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-05-17 22:21:05 +00:00
Sigmund Cherem 1f409716d6 Add packageBase to simplify how we build packages files and how we process 
package import uris

THis is not actively used in the loader unit tests yet, but will be in the
dart2js pipeline.

Change-Id: Ie0db6243c735e2fba396f2a5a156d52ea1e53bbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102125
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-05-17 22:21:05 +00:00
Sigmund Cherem 0edab8264a Support steps that only run on the main module 
I'll work on a follow up CL to add unit tests for it.

Change-Id: Ifa142731eb60ba14fb3187b5f3e9333cef12f751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102124
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-05-10 19:43:58 +00:00
Sigmund Cherem 5de409bfa1 Ensure subfolders in input sources paths are created first 
Change-Id: I35db42f4fc396f33445528bea6e7c9bcc8f8c10e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102141
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-05-10 19:43:58 +00:00
Sigmund Cherem fb29d0e96d Move async_minitest to package:async_helper. 
This allows to break a circular dependency between package:expect and

package:async_helper, which will simplify the support for modular tests using
package:modular_test.
Change-Id: Ie48723d3f35d51a8fbe622e0158450e8104fe3f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102140
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-05-10 19:43:58 +00:00
Sigmund Cherem ef0c812b0d Add support for loading a modular test folder and specifying deps in yaml 
To test the loading logic, I created sample modular test folders which also
illustrate what modular tests will look like in the future.

Change-Id: Iaa8e076e5be66107391d258f5c72456c89841123
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101780
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-05-08 21:18:19 +00:00
Sigmund Cherem 73639f9e1f pkg/modular_test: follow up cleanup 
* resultKind -> resultId (missed this when I renamed dataKind to dataId)
* refactor test/pipeline_common.dart: made the test strategy use generic steps so the concept of
concat/lowercase/replace-join now is encapsulated in pipeline_common, while memory_pipeline_test
and io_pipeline_test know how to create steps that apply an opaque function.

Change-Id: I9e425845931db8722a51c1044f6b74b0c8c26ae4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100940
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-05-01 16:38:59 +00:00
Sigmund Cherem 5896692b42 Introduce pkg/modular_test: a package to specify modular tests 
This initial commit includes: the definitions of a modular test, a module, a
pipeline, and an in-memory implementation of such pipeline, and an IO implementation.

Change-Id: I69056342da8ba126459064d7751d5dbe75ebcfca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100627
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-04-30 20:25:38 +00:00