Commit Graph

19 Commits

Author SHA1 Message Date
Simon Binder 38ac261884 [analyzer] Add byteStore option for build_resolvers client
At the moment, we always use an in-memory store for computed units and
elements. By persisting this to file and re-using it across builds, we
can speed up subsequent build runs.

Change-Id: I6fca9d96f6961a3a802eb1d4cb21682fc0fcc469
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Simon <oss@simonbinder.eu>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-11-23 17:55:41 +00:00
Konstantin Shcheglov b8ffc08d5b Add AnalysisDriverForPackageBuild.sdkLibraryUris
https://github.com/dart-lang/build/pull/3389

Change-Id: Ib54ba5d5411fc6213ecf1733dd056f9347f27462
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265401
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-10-24 21:06:27 +00:00
Konstantin Shcheglov 53898496a6 Use named parameters in few AST nodes.
Change-Id: I16a63c7554d63103e05a783e1c11748d9535ca7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-10-21 22:43:49 +00:00
Konstantin Shcheglov b704bbad7c Use AstNodeImpl for a few NodeList(s).
Change-Id: I2a078c35458ffc509e93108bd189aa29de7a6b7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-10-05 21:10:07 +00:00
Konstantin Shcheglov b90b86492b Use named parameters for few AST nodes.
Change-Id: I11afd971778232cb0205aeb506e01e8e1051b263
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262744
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-10-05 16:58:53 +00:00
Konstantin Shcheglov 8faa2fa4fd Use named parameters for a few AST nodes.
Change-Id: Ia2cef588184d89347b1381af580ee4ca1345be6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262504
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2022-10-04 15:57:59 +00:00
Konstantin Shcheglov f58e9abf12 Use named parameters for a few AST implementations.
Change-Id: I4dcc9dc48c7c4718dff16f01a582f2865a655307
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258502
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-09-09 16:59:44 +00:00
Konstantin Shcheglov 8e1224da23 Use named parameters for more AST implementations.
Change-Id: I710f37870699d728d1ea45bafee47b822418e1ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-08-03 20:13:27 +00:00
Konstantin Shcheglov 886b95da33 Replace several AstFactory methods with direct NodeImpl creations.
Change-Id: Icbc9cbb2c4ec8d467d476231ef4d91b7add291b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243163
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-05-01 16:40:12 +00:00
Konstantin Shcheglov 98fde68b2b Replace SummaryDataStore default constructor.
Change-Id: If34d2365ecd2a643a40d660250bf2d5936ab953f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236305
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-03-09 21:33:35 +00:00
Konstantin Shcheglov 1693908268 Apply file changes between (not during) other operations.
This would be a breaking change, so for now it is disabled, but
the method `applyPendingFileChanges()` can be added, and the clients
will call it to be ready for the switching the flag.

Only clients that call methods like `changeFile` have to await applying
the file changes. Other clients can continue using synchronous
`currentSession`.

Change-Id: I0f8d4cc874f485776f611790f6c80fd7e07c8051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-03-09 18:16:45 +00:00
Konstantin Shcheglov d627e85229 Deprecate 'astFactory'.
Change-Id: I5f1e47328e92cab368d5a8eb9f77f0ea45649b1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235771
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-03-08 07:00:03 +00:00
Konstantin Shcheglov 2192cc6098 Deprecate SummaryDataStore() constructor with paths.
Change-Id: I2317a7ae0dbeefafc7e09ff2032b77fa022eb534
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-03-04 20:01:20 +00:00
Konstantin Shcheglov 1982520d1f Deprecate AnalysisDriver.tmp1, switch to unnamed.
Change-Id: Icdbb11afdcf45c975b999590c7af85d3b049c2ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-01-07 20:37:36 +00:00
Konstantin Shcheglov 1703adf172 Add internal API for package:dart_style
With the goal to stop it using `astFactory`.

Change-Id: Ib94d0a7e2c01f782168f668f9ffce44cecea0c37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-12-20 19:33:13 +00:00
Konstantin Shcheglov 6451799849 API for package:build
Change-Id: I00bb4d6866202d404eee0b8bf6c13b4702cab617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217561
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2021-10-21 19:38:35 +00:00
Konstantin Shcheglov b1a6afba1c Remove specialized API for Angular analysis.
We have removed the Angular plugin, so we don't need the API.

Change-Id: Ifba20fba248b690f429b6a532dc5333a25f5e610
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174400
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-11-30 19:37:24 +00:00
Konstantin Shcheglov 86ec742832 Switch to new Scope(s).
No much changes to resolution itself, only to the way how we create
scopes. But we still use `lookupIdentifier` that is basically the old
approach to resolution.

This also moves the fix of https://github.com/dart-lang/sdk/issues/42620
to TypeNameResolver.

I will continue improving in following CLs.

Change-Id: I89bae5afe0a7978aba9fe9bf7c8bf08fb59b1440
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154920
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-07-21 01:37:34 +00:00
Konstantin Shcheglov 388c983495 Add higher level non-API for angular_analyzer_plugin.
Change-Id: I7eb5a3c7e90b9d86c296dafc95b9f9c750c0095a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-07-13 15:44:59 +00:00