e3a0244b58
Tweak to error formatter to fix LINT display name.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//902383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43582 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-08 21:01:35 +00:00
c2d3ff3b95
Handle exception and clean-up code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//907483004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43563 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:19:55 +00:00
d682527d1e
Fix a stack overflow
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//908603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43559 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 18:00:16 +00:00
cb0f691bb6
Fix analyzer type checking of "await" expressions.
...
This requires implementing the "flatten()" rule defined in the spec;
this rule also needs to be applied to static type checking of return
types in async functions.
BUG=dartbug.com/22291, dartbug.com/22293
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//904743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43537 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 03:32:57 +00:00
ac08a9a570
Async/await/yield[*] support for dart_fmt
...
R=brianwilkerson@google.com , paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//882233004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43529 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 22:37:23 +00:00
3713a9eed7
Invalidate hints instead of computing them in the incremental resolver.
...
So, we don't need to prepare all the library parts before incremental resolution.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//901713004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43526 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 22:06:48 +00:00
ae2e608ff9
Send notificatinos after no-op changes.
...
This should solve the problem when client remove some part of the code,
so removes also error markers for it, and then quickly restores it,
so for the server it looks as an empty/no-op change. But information is
lost, and the server should resend it to the client.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//899753004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43521 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 20:42:17 +00:00
f6da9b87c4
Enum handling for dart_fmt.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//901743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43494 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 03:38:15 +00:00
c7cb9dd4e8
Fix for issue 22110
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//885283007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43453 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 01:16:57 +00:00
d0b87e247c
Implement new "yield*" type checking rules in analyzer.
...
This updates analyzer to reflect the new static type checking rules
for yield each added in r43420.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//888943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43446 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 23:13:09 +00:00
032115ecf3
NPE fix in ExitDetector visitor- in analyzer pkg
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//894453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43440 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 22:15:18 +00:00
3c315ba0bb
Implement new return type checking rules in analyzer.
...
This updates the analyzer to reflect the new static type checking
rules for return types added in r43420.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//897673003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43427 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 21:25:12 +00:00
2cd86b7e29
Add static type checking of "yield*" statements to analyzer.
...
This does not include the new static typing rules that were introduced
in revision 43420. I will address those in a later CL.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//895673005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43424 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 20:32:14 +00:00
03ca35e01e
Fix for issue 22178
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//900683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43422 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 19:30:30 +00:00
a3e5ed3347
Add static type checking of "yield" statements to analyzer.
...
Also fix inference of the return type of generator function expressions.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//895113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43418 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 18:51:27 +00:00
658d3e949e
Check PackageMapUriResolver constructor arguments.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//887943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43405 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 16:06:25 +00:00
25ea0e7ee0
Fix for issue 22245
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//896613003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43404 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 15:48:39 +00:00
fe8ad3584f
Fix return type checking for generator functions.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//894063004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43403 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 15:43:21 +00:00
27627f61f4
Don't use firstWhere as it throws an error if there is no such element
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//896623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43372 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:26:56 +00:00
61d844224e
Match body modifiers in incremental resolver.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//896573003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43371 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:23:09 +00:00
bde433f33a
Report a compile-time error if async/sync/yield used as an identifier.
...
This error is only reported inside methods marked "async", "async*",
or "sync*".
BUG=dartbug.com/22206
R=scheglov@google.com
Review URL: https://codereview.chromium.org//890253003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43368 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:13:08 +00:00
ee39cfde16
Add a getter to TypeProvider for Future<Null>.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//894853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43366 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:09:46 +00:00
b40a5702b3
Fix async/await type checking in analyzer.
...
This required making the "async" library into TypeProvider so that we
can create Future<...> types when doing resolution and error/hint
checking.
BUG=21888,22053,22091,22092,22160,22164
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//898513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43361 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 20:58:37 +00:00
890c99238c
Make source be a target
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//882813007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43355 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 17:08:28 +00:00
651ea223ca
Fix to add lints to error report summary.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//874253004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43354 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 16:02:06 +00:00
21850bf962
Fix to ensure lint analysis option gets properly set.
...
R=brianwilkerson@google.com , danrubel@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//881403005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43298 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:58:13 +00:00
cb6c16922f
Fix for issue 22052
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//881403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43292 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:01:58 +00:00
f16e7b8d2e
Add simple Dart tasks
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//887433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43261 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 21:56:42 +00:00
fe471e8f02
Make test context more accurate
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//879373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43246 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 17:11:38 +00:00
ea333d8459
Fix mixin resolution order when multiple mixins present.
...
BUG=dartbug.com/22069
R=scheglov@google.com
Review URL: https://codereview.chromium.org//879093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43224 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 23:41:21 +00:00
413de8f419
Support for 'async' in the old formatter.
...
We still use it, and now we have asynchronous code to format :-)
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//884513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43205 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 21:00:37 +00:00
b9f355d2a4
Library dependencies server API updates (to pass package maps).
...
R=brianwilkerson@google.com , jwren@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//874373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43193 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:23:09 +00:00
7bf029506d
Fix "reanalyze sources" when there are unsaved files.
...
The analysis server now maintains a single content cache which is
shared by all contexts; this allows it to persist the content cache
across reanalysis (which destroys all contexts and recreates them from
scratch).
Two other bugs are fixed in the process:
- If a file is analyzed in multiple contexts, then editing it will
cause all affected contexts to be notified of the change. (Note
that this could potentially account for some other strange behaviors
we've seen recently, such as incorrect semantic highlighting and
lingering errors/warnings.)
- If the client supplies a ChangeContentOverlay for a file which
currently has no overlay, the proper error is generated.
I plan to submit tests for these two bugs in a follow-up CL.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//880643005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43163 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 23:26:45 +00:00
2b8c66ea79
Rename ChangeNotice resolved Dart/Html unit fields.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//881463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43147 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:58:19 +00:00
0d6228609d
Improvements to task model
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//867563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43146 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:47:12 +00:00
dc144bb870
Issue 22155. Send outline for both parsed and resolved Dart units.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22155
Review URL: https://codereview.chromium.org//876703003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43145 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:39:36 +00:00
a3bf271c88
Initial task support
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//812733004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43120 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 20:18:11 +00:00
23215e71f4
Remove Element.users support.
...
R=brianwilkerson@google.com , pquitslund@google.com
BUG=
Review URL: https://codereview.chromium.org//854363005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43032 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 00:48:02 +00:00
9184f33ecc
Invalidate parsing information when a file is added.
...
We resolve directives URIs during parse, so if a referenced file was
added after parsing, it may fix some "Unresolved URI" problems.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22101
Review URL: https://codereview.chromium.org//860903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43030 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 23:11:58 +00:00
252c19c920
Addition of the new flag "file-read-mode" into the analysis server to fix the offset bug with IntelliJs integration.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//857283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43028 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 21:48:00 +00:00
f7915c7a84
Return outline after parse
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//842533004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43027 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 21:36:14 +00:00
e20c2167a3
Linter API updates.
...
(A trimmed down version of: https://codereview.chromium.org//853123002 in a hopes of not unsettling the build.)
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//850343006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43023 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 19:38:14 +00:00
fd6cef8a8b
Don't perform incremental resolution if curly brackets are not balanced.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//834383005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43022 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 19:28:12 +00:00
3a7594b9fe
Revert "Lint contribution refactoring.", r42967
...
This reverts commit r42967, https://codereview.chromium.org//853123002 .
The change causes an out-of-memory crash in analyzer batch mode, perhaps
a memory leak.
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//834323006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42979 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-19 09:26:45 +00:00
9b132e1032
Lint contribution refactoring.
...
A little shuffle to centralize the linter concern (and reduce the need to touch resolver.dart).
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//853123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42967 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 18:29:41 +00:00
ef7456f199
Update cache size on analysis start/stop.
...
This reduces time of dart2js analysis after rename form 16000 ms
to about 1200 ms, i.e. about 13 times ;-)
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//844493005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42933 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 20:55:57 +00:00
807a4fa8fa
Delegating AST Visitor and Linter refactoring.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//813483007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42923 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 18:09:42 +00:00
dc96eabde3
Display overlays at /overlays URI.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//823123004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42891 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 00:22:44 +00:00
8a495697e6
Move the class TypeTestProvider from the test directory into the lib directory so that other tools can use the class and other tools such as the ElementFactory which require a TypeProvider
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//853553005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42855 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 06:59:51 +00:00
036b652dd1
Use all library units for hints during incremental resolution.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//818173003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42846 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 23:23:20 +00:00
pquitslund@google.com