dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

56224 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kevin Millikin 51fa5c1662 Correctly transform async functions with FutureOr return types 
The async transformer did not allocate a completer with the correct
type in the case for async functions with a FutureOr return type.

Fixes https://github.com/dart-lang/sdk/issues/33196

Change-Id: I72654f24576295e38e8d79dff30aae5c90cb2564
Reviewed-on: https://dart-review.googlesource.com/56488
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-05-24 10:54:03 +00:00
Martin Kustermann bca70073ae [vm/kernel] Move kernel2kenrel "constants" transformation before TFA 
Change-Id: Iffa9cea655a0b731c2784a172096d450571eaf1c
Reviewed-on: https://dart-review.googlesource.com/53220
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-05-24 10:53:42 +00:00
Peter von der Ahé 1d8a72cacd Split StaticAccessGenerator 
This prepares the generator to be implemented by the analyzer.

Change-Id: I99a1e1365da67a867f6c4ed5883649f157306d92
Reviewed-on: https://dart-review.googlesource.com/56502
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-05-24 10:16:11 +00:00
Kevin Millikin 2d46ebd6a5 Fix Dart 2 runtime errors in the front end 
Fix all the Dart 2 runtime errors revealed by compiling dart2js, the
front end itself, the front end tests.

Change-Id: Ic6e6dd9f85db845b6a351ebbcfea9a6045843fc2
Reviewed-on: https://dart-review.googlesource.com/56322
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-24 10:14:20 +00:00
Johnni Winther 89514bd8cf Cleanup library_loader. 
Change-Id: I0255580cd9292bcd3a5997c7d97d83b25d888372
Reviewed-on: https://dart-review.googlesource.com/55960
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-05-24 09:52:50 +00:00
Johnni Winther 21b65a9732 Remove unused typedef code 
We only use the name of typedef type literals. These are passed through
TypeConstantExpression to TypeConstantValue and used directly as the
nominal identity (!) of the emitted typedef type literal constant value.

Note that the emitted typedef type literal has no relation to its alias.

Change-Id: I1cdc5a88a9b3d75faa0786ecd07226b5075df1c4
Reviewed-on: https://dart-review.googlesource.com/55898
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-05-24 09:52:50 +00:00
Johnni Winther 18407141b7 Split deferred load entity computation by class, member and local function 
Change-Id: Ifb612de6ac945d2ececa96871f0eb3fc5ceb4052
Reviewed-on: https://dart-review.googlesource.com/55896
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-05-24 09:52:50 +00:00
Martin Kustermann b84f18e392 [VM] Mark seemingly consistently failing test on windows 
Issue https://github.com/dart-lang/sdk/issues/33224

Change-Id: If9437c7791efd23dd98ad41cf3cf16173046cdaf
Reviewed-on: https://dart-review.googlesource.com/56501
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-05-24 09:17:27 +00:00
Peter von der Ahé d07b9aa0e0 Add explicit type args on generators 
Change-Id: Ia1e4c42b888d9302e23a7e832044b2f59f8c0a8f
Reviewed-on: https://dart-review.googlesource.com/56483
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-05-24 08:55:52 +00:00
Peter von der Ahé b3862d5a92 Split SuperIndexedAccessGenerator 
This prepares the generator to be implemented by the analyzer.

Change-Id: Ia962668e1327b53af968be9efdc41ea6b124b4d0
Reviewed-on: https://dart-review.googlesource.com/56482
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-05-24 08:27:59 +00:00
Johnni Winther 0ec82e24ce Avoid late creation of entities. 
This changes has been reviewed as part of https://dart-review.googlesource.com/c/sdk/+/55898

Change-Id: I28d41110919a592499ee7b5b7605728638bd5ea2
Reviewed-on: https://dart-review.googlesource.com/56481
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-05-24 08:01:00 +00:00
Mike Fairhurst 1d59ab22ce Fix #29014, make function type parameters invariant. 
With the restricted behavior, some tests have been removed, modified,
and added based on the new invariance.

Bug: 29014
Change-Id: I086749bbe40aaa723009f9ae06f58d85554cae53
Reviewed-on: https://dart-review.googlesource.com/56029
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-05-24 07:56:29 +00:00
Johnni Winther 4d7bbb53ab Use AbstractValue in ClosedWorld 
Change-Id: Ib091ec1f251f9d75f9dea5cc4879ab16c9af0215
Reviewed-on: https://dart-review.googlesource.com/55961
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-05-24 07:43:39 +00:00
Mike Fairhurst 89f37416fe Fix windows bot breakage for package:build tests. 
Change-Id: If7c049d0c4db396c8c7ae2fd05005538c1dd1933
Reviewed-on: https://dart-review.googlesource.com/56293
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-05-24 06:57:51 +00:00
Sigmund Cherem 9b44fc39c8 Deprecate chaseDependencies option. 
The option is not used by any client at this time and removing it simplifies the
next stack of changes I'll be making on how we compose file systems.

I also don't believe we will necessarily add this back as an option, but instead
it might be that clients requriing hermeticity will provide a custom file system
that helps with that.

Change-Id: I401efb042920d234382b6c041b13d40ffae5c908
Reviewed-on: https://dart-review.googlesource.com/56462
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-24 04:57:01 +00:00
Ben Konyi 05f96af05a [ VM ] Fix failing non-UTF8 path test on MacOS 
Change-Id: Ieda3661b61b993b71d4bd703e576625a354d4774
Reviewed-on: https://dart-review.googlesource.com/56463
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-05-24 02:07:49 +00:00
Ben Konyi c541cda216 [ VM ] Fixed issue where error code was being clobbered by call to Dart_TypedDataReleaseData on Windows, resulting in OSError returning a 0 error instead of the true error code. 
Bug: 2
Change-Id: I33e9319f57de73d9435936ddf853968834fb5a16
Reviewed-on: https://dart-review.googlesource.com/56461
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-05-24 02:07:39 +00:00
Dan Rubel a00dae2260 Update test_parseAwaitExpression_inSync 
Change-Id: I62796cc9c76bdfa0cfb5afacdaa8a785a3db28e8
Reviewed-on: https://dart-review.googlesource.com/56440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-23 22:47:19 +00:00
Dan Rubel 9cd0e808db Convert more identifier contexts 
Change-Id: I0ead9e15da9d477b26deb13c6880dbfeea4d7724
Reviewed-on: https://dart-review.googlesource.com/56401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-23 21:58:35 +00:00
Emily Fortuna 552680b7f0 First round of changes to dart2js to make it strong mode clean. 
Change-Id: Idc3612072c3cf28a4f58bbb890908f67473d8292
Reviewed-on: https://dart-review.googlesource.com/56284
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-05-23 21:26:04 +00:00
Dan Rubel cc4fe66de8 Replace parseTypeVariables with computeTypeParam 
Change-Id: I6835db80220e09b59a0242140539761f93da3a7e
Reviewed-on: https://dart-review.googlesource.com/56400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-23 21:17:05 +00:00
Janice Collins c3b6df5eb7 Update dartdoc and dependencies to v0.19.1. 
Release notes: https://github.com/dart-lang/dartdoc/releases/tag/v0.19.1



Change-Id: Iab2aa84fd8ce444d14b8eba527709b944ab2557f
Reviewed-on: https://dart-review.googlesource.com/56295
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2018-05-23 21:05:34 +00:00
Ben Konyi 3ab7cf0590 Revert "[dart:io] Revert recent non-utf8 path handling" 
This reverts commit 42bcdcd332.

Change-Id: I11fb7db2aac3b7dc15cb35a22fea38b31069cbc0
Reviewed-on: https://dart-review.googlesource.com/55502
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-05-23 21:01:44 +00:00
Bob Nystrom 7c59fe6332 Flip dartfmt to run in Dart 2 mode. 
Change-Id: I245dce2510ccf99cd443b4d27828790dabe54e8a
Reviewed-on: https://dart-review.googlesource.com/56283
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-05-23 20:45:03 +00:00
Dan Rubel ade600c4b3 Update constructor identifier context 
... and remove unused IdentifierContext instance

Change-Id: I2bd8d350f3ac22c472d00d3854ced594563dab1b
Reviewed-on: https://dart-review.googlesource.com/56380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-23 20:40:43 +00:00
Ben Konyi e35ed9c749 [ VM / Build ] Added '--no-include-kernel-service' to build.py. By default, the kernel service is now included in all build modes, including product mode. Providing '--no-include-kernel-service' will build the specified configuration without the kernel service. 
Change-Id: I682cd7c2895a9bcb215948615f2bdc627abe8d08
Reviewed-on: https://dart-review.googlesource.com/56286
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-05-23 20:35:53 +00:00
Brian Wilkerson e5eee0d57a Add Forest support for labeled statements 
Change-Id: I8ab9fd9ac202268f3be93eb2c92266d387cd0bab
Reviewed-on: https://dart-review.googlesource.com/56261
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-05-23 20:23:52 +00:00
Sigmund Cherem 83e29023f4 Add schema-based file system 
This file-system will be used to compose multiple file-systems together.

Bug: https://github.com/dart-lang/sdk/issues/32633
Change-Id: Ia6c9626b98037c4aaee83be0e09615671f5d0fe7
Reviewed-on: https://dart-review.googlesource.com/56281
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-23 19:51:11 +00:00
Sigmund Cherem 8f4c9bcf15 Add single-root file system. 
A file-system that we'll use to generate machine agnostic dill files.

Bug: https://github.com/dart-lang/sdk/issues/32633
Change-Id: I05b25940764f4af0bc86c5304e8ba4a6650fb362
Reviewed-on: https://dart-review.googlesource.com/56280
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-23 19:51:11 +00:00
Brian Wilkerson 1567b442dd Add Forest support for catch clauses 
Change-Id: I6b28d1a759d51cab59005052e9a47c3cab358dd3
Reviewed-on: https://dart-review.googlesource.com/56080
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-23 18:52:12 +00:00
Terry Lucas 9816fce289 Fixed to use catchError instead of try/catch. 
TBR=sra@google.com

Change-Id: Id3633654d1d9106be0f1169a5452731bafbd8732
Reviewed-on: https://dart-review.googlesource.com/56290
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-05-23 18:48:34 +00:00
Alexander Thomas 88d847ea3e [release] Prepare CHANGELOG.md for 2.0.0-dev.58.0 
TBR=whesse@google.com

Change-Id: Ia8868eba66f22cc3f6475ec3cad0c1c244128de0
Reviewed-on: https://dart-review.googlesource.com/56347
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-05-23 18:37:52 +00:00
Mike Fairhurst 2a5724c75c New package:build workspace before we support it at the language level 
Change-Id: I3252a55d520e7f67666684369467af8ec88aea29
Reviewed-on: https://dart-review.googlesource.com/56285
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-05-23 18:34:45 +00:00
Kevin Moore 4f5db3aef2 Update pub DEP – includes Dart2 type fixes 
Change-Id: I03c9114ae2ef6c72ab8be5093aa8c52a5f0c6d1e
Reviewed-on: https://dart-review.googlesource.com/56292
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2018-05-23 18:02:35 +00:00
Brian Wilkerson 0a9697596e Add Forest support for for statements 
Change-Id: Ic65a09c01012e8a5d0ab2a4f755950c18b00fa9f
Reviewed-on: https://dart-review.googlesource.com/56000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-05-23 17:32:55 +00:00
Alexander Markov 4fb0c60938 [vm/kernel] Set active class when evaluating Dart annotations 
Without active class, kernel reader is not able to finalize types
and fails to parse type literals.

Fixes https://github.com/dart-lang/sdk/issues/33173

Change-Id: Iefe7f33a371f3d4f892f21f8ea0060d70887186c
Reviewed-on: https://dart-review.googlesource.com/56242
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-05-23 16:17:55 +00:00
Aske Simon Christensen 8427d53a4d Extra precedence level in parser to distinguish postfix operators and selectors 
Fixes https://github.com/dart-lang/sdk/issues/31185

Change-Id: I77d617f6abd367d857741d04cf47571ea7492c6a
Reviewed-on: https://dart-review.googlesource.com/56111
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-05-23 16:13:55 +00:00
Dan Rubel 1ce9b2541b Replace call to parseTypeVariablesOpt with computeTypeParam 
Change-Id: Icc4443e9ba4206a3d16cdac5fdd3ffa70459012f
Reviewed-on: https://dart-review.googlesource.com/56043
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-23 16:09:50 +00:00
Peter von der Ahé f7e09684b6 Split IndexedAccessGenerator and ThisIndexedAccessGenerator 
This prepares the generators to be implemented by the analyzer.

Change-Id: I28ada82b602893b427c8d34df68b2c9a7f8439cf
Reviewed-on: https://dart-review.googlesource.com/56341
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-05-23 16:02:55 +00:00
Peter von der Ahé 9f3cd54d3b Remove UnhandledListener 
Change-Id: I693f3352a3e5582456b4f41c9b7dc06d23cf98d3
Reviewed-on: https://dart-review.googlesource.com/56327
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-05-23 16:02:55 +00:00
Peter von der Ahé 98fcc338ca Fix diet_listener.dart imports 
Change-Id: Iff0b5f9eae0080f961c3b0395a65f854f4714e41
Reviewed-on: https://dart-review.googlesource.com/56326
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-23 16:02:55 +00:00
Peter von der Ahé 3a5454a691 Split SuperPropertyAccessGenerator 
This prepares the generator to be implemented by the analyzer.

Change-Id: I7c6ebf43e8dee46ea734d7a245c20fc03fe74b65
Reviewed-on: https://dart-review.googlesource.com/56325
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-23 16:02:55 +00:00
Martin Kustermann e0144d51bb [VM] Add UNREACHABLE() to AOT constant evaluator in the VM 
Since commit 775eeece we use a kernel2kernel constant evaluator for
AOT compilations. We can now start to ensure we never hit the constant
evaluator in the VM anymore.

Issue https://github.com/dart-lang/sdk/issues/33185

Change-Id: If0e3b5c89fba64a7f93af606e7146e52c45b38df
Reviewed-on: https://dart-review.googlesource.com/56340
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-05-23 16:01:45 +00:00
Dan Rubel fa6fd26892 Remove unused IdentifierContext instance 
Change-Id: Ib7f82b2d9a3d367f20bb5e9be7456ef8693bd69f
Reviewed-on: https://dart-review.googlesource.com/56042
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-23 15:50:25 +00:00
Alexander Thomas cbe76eeea0 [release] Prepare changelog for 2.0.0-dev.57.0 
Change-Id: I3f3ea74ee550d6110ebb2cdcf96a1b9f07293d99
Reviewed-on: https://dart-review.googlesource.com/56323
Reviewed-by: William Hesse <whesse@google.com>
 2018-05-23 15:37:08 +00:00
Terry Lucas e62f37f396 Tighten failure and success of test. 
TBR=sra@google.com

Change-Id: Id56baa1f1079ad3433d2402f0eb5749fdcf08c06
Reviewed-on: https://dart-review.googlesource.com/56289
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-05-23 14:38:55 +00:00
Peter von der Ahé a80dfa12d7 Revert "Add colons" 
This reverts commit 29253c57ed.

Reason for revert: Analyzer doesn't use colons on TODOs.

Original change's description:
> Add colons
> 
> Change-Id: Idb51f8d5d3fa65f92ce0d64bbe79d63a9337cf1c
> Reviewed-on: https://dart-review.googlesource.com/56320
> Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

TBR=ahe@google.com,brianwilkerson@google.com,dmitryas@google.com

Change-Id: I19e7f574537a011dd9ad36b795b9b48249d192b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/56360
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-23 14:26:56 +00:00
Peter von der Ahé 443c23c091 Remove subpackage_relationships_test.dart 
This also enables us to remove unsupported front-end API.

Change-Id: I1f655039e9fa4718ef5c941d1932c136eefab3c5
Reviewed-on: https://dart-review.googlesource.com/56342
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-05-23 14:12:36 +00:00
Samir Jindel 7583fb882a [vm] Refactor state bits to free up two bits on Function. 
This was pulled out of old revision by Slava.

Change-Id: I9fa276b0768f4aa908754fec8369b1272ec465be
Reviewed-on: https://dart-review.googlesource.com/56108
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-05-23 13:59:25 +00:00
Dan Rubel 0271003c33 Extract parseFunctionLiteral from parseType 
This is another step towards removing parseType and improving recovery.

Change-Id: Ie2cb1999406bc603355015e8a3b9aaa854f785db
Reviewed-on: https://dart-review.googlesource.com/56120
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-23 13:40:06 +00:00