Stephen Adams
df3c210cbb
dart2js: Local type information erasure
...
Change-Id: I28ed9e313159222982a4093cc898339a558c5fd9
Reviewed-on: https://dart-review.googlesource.com/35813
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2018-02-14 07:58:01 +00:00
Régis Crelier
4c9a842d61
[corelib] Cleanup isValidInt and toInt() in new BigInt implementation.
...
Change-Id: I1f107d4f6e26ea3644bc6c9f7cff5ee6fac43958
Reviewed-on: https://dart-review.googlesource.com/40512
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Régis Crelier <regis@google.com >
2018-02-14 03:43:52 +00:00
Ben Konyi
3c4dccbd46
[VM] Fixed ReadPrecompiledKernelFromFile passing NULL instead of a handle to Library::null() to the LibraryTagHandler.
...
This was causing an assert to fail in tonic, which was expecting the
field to be either a null handle, a String handle, or a Library handle.
Change-Id: I78b44a26c4e0689ad10c5c92e9d757a5c2dc7cc8
Reviewed-on: https://dart-review.googlesource.com/41081
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2018-02-14 01:44:18 +00:00
Régis Crelier
ba75b6939d
[VM] Increase BigInt digit size from 16 to 32 bits.
...
Change-Id: I60e7e34559d11d80fde7955dec98b21b7029e199
Reviewed-on: https://dart-review.googlesource.com/40962
Commit-Queue: Régis Crelier <regis@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2018-02-14 00:41:01 +00:00
Ryan Macnak
3f40488ec4
[vm, isolate] Refactor isolate message snapshotting to centralize construction of the Message.
...
Remove unused special case in ApiMessageWriter for lists of int.
This is in preparation for ensuring we always free any external data that ends up in an isolate message.
Bug: https://github.com/dart-lang/sdk/issues/31959
Change-Id: I999656fc11d2aee9aebe70852be5bb075f234b4d
Reviewed-on: https://dart-review.googlesource.com/41020
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-02-14 00:28:01 +00:00
Ben Konyi
392062c617
Fixed issue where KernelIsolate::AcceptCompilation was being called even when no compilation was done. Fixes #32145 .
...
Change-Id: I043484560b77548cf33847e0d57c6e89a8a178f3
Reviewed-on: https://dart-review.googlesource.com/41025
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2018-02-13 23:46:30 +00:00
Siva Annamalai
4925ed38ac
Revert "Create isolate from the platform kernel when running VM tests under dartk."
...
This reverts commit 3e967d3d76 .
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Create isolate from the platform kernel when running VM tests under dartk.
>
> Status of tests which now start failing has been updated.
>
> Ability to run the vm tests in strong mode has also been added. The
> status of tests which fail in strong mode will be updated when the vm
> tests are moved under the strong mode tests on the bots.
>
> Change-Id: I95f94c09dd0ebbf1fe661ee1f6e0c3e7b07509bd
> Reviewed-on: https://dart-review.googlesource.com/40642
> Commit-Queue: Siva Chandra <sivachandra@google.com >
> Reviewed-by: Siva Annamalai <asiva@google.com >
TBR=sivachandra@google.com ,asiva@google.com
Change-Id: I6144bbe882cdf56ee6be3132c6f9dec2cbafcb47
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/41026
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2018-02-13 23:33:12 +00:00
Konstantin Shcheglov
4749057586
Don't suggest converting unresolved 'child:' to 'children:'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/841
Change-Id: Ib16b8a1e28e18cec9fd30a2f7d364355ce70b757
Reviewed-on: https://dart-review.googlesource.com/41060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-13 23:30:51 +00:00
Konstantin Shcheglov
51eb30dbba
New Quick Assists 'Move widget down/up'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1638
Change-Id: I84dd60d30409fde430bb9ba3eb794c3c404d66b1
Reviewed-on: https://dart-review.googlesource.com/41023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-13 23:01:41 +00:00
pq
f2e063c35e
Selection range calculation for override completions.
...
Change-Id: If3a56c6b5274d5615742ded1ab213918331f4a0c
Reviewed-on: https://dart-review.googlesource.com/41021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-13 22:44:13 +00:00
Dmitry Stefantsov
83c33372bf
Apply instantiate to bound to raw types in supertypes
...
Change-Id: I29226b158f0cb2f98ad54e1f2e6e8cd481e7a1cb
Reviewed-on: https://dart-review.googlesource.com/40900
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2018-02-13 22:41:01 +00:00
Konstantin Shcheglov
83840eef9b
Suggest 'Convert to children:' only when on 'child:'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/32135#issuecomment-365367458
Change-Id: I3891409c1fc1ae9cc4cc8731c1c452be9cba66ea
Reviewed-on: https://dart-review.googlesource.com/40960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-13 21:49:19 +00:00
Zach Anderson
41eef1cbb5
[infra] Fix asan build
...
Change-Id: Ib5b1efbf12bdf7455e2c9d32c37ce5a06ed3195b
Reviewed-on: https://dart-review.googlesource.com/41000
Reviewed-by: Zach Anderson <zra@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2018-02-13 21:10:24 +00:00
Siva Chandra
3e967d3d76
Create isolate from the platform kernel when running VM tests under dartk.
...
Status of tests which now start failing has been updated.
Ability to run the vm tests in strong mode has also been added. The
status of tests which fail in strong mode will be updated when the vm
tests are moved under the strong mode tests on the bots.
Change-Id: I95f94c09dd0ebbf1fe661ee1f6e0c3e7b07509bd
Reviewed-on: https://dart-review.googlesource.com/40642
Commit-Queue: Siva Chandra <sivachandra@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-02-13 20:34:24 +00:00
Konstantin Shcheglov
ff6347e448
Rename 'Replace with children' to 'Remove widget'.
...
R=devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/32135#issuecomment-365377923
Change-Id: I9da2c04590a32a28d109d7722df137e1a31712d1
Reviewed-on: https://dart-review.googlesource.com/40961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2018-02-13 20:10:19 +00:00
Paul Berry
35aea15097
Revert "Implement proper checking for callability of Function class."
...
This reverts commit 6837dafcc3 .
Reason for revert: Broke analyzer bots.
Original change's description:
> Implement proper checking for callability of Function class.
>
> There was some old (incorrect) logic for doing this, behind the flag
> enableStrictCallChecks. This flag has been removed, since the new
> behavior is now standard in Dart 2.0.
>
> Fixes #31509
>
> Change-Id: I4a6da34a4b85ea8409f6e0d14c377a586546056a
> Reviewed-on: https://dart-review.googlesource.com/40509
> Commit-Queue: Paul Berry <paulberry@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com ,mfairhurst@google.com
Change-Id: Ib631ad16bc5e937ff914127d1c5330f3fcaff2c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/40980
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-02-13 19:56:35 +00:00
Danny Tuppeny
56acaee9b1
Normalize Windows drive letters to uppercase for analysis
...
This fixes #32095 , ~~however I'm currently unable to get the tests running locally. I'll continue to work on that, but I'm hoping that creating a PR runs all the tests on CI so we should at least get to see if this (legitimately) broke anything in the meantime?~~
Turns out this also fixes #32042 ! I can't run the latest analyzer code against a version of the SDK that the flutter_tools is happy with, however I rolled my analyzer code back to `2.0-dev.22` and repro'd this error, then applied the same changes from this PR to that version, and the errors went away.
Turns out to also fix #28895 !
@bwilkerson
Closes #32133
https://github.com/dart-lang/sdk/pull/32133
GitOrigin-RevId: 94cc37479214beaf1c8e3e2befa9bef882dbcd5d
Change-Id: I32a5ce52c7b28e1d484c1e5e9a9dd6d64c2b1b3b
Reviewed-on: https://dart-review.googlesource.com/40720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-13 19:36:36 +00:00
Alexander Markov
396ba9b2d2
[vm/kernel/aot] Correctly handle FutureOr in type flow analysis
...
This CL adds special case for FutureOr<T> type (which is a union
of Future<T> and T) into type flow analysis.
As type flow analysis doesn't retain information about generic type
arguments yet, FutureOr<T> is treated as AnyType for now.
Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: Ieb4d862b5a993fe46c9662d9bcb0e1f06058a166
Reviewed-on: https://dart-review.googlesource.com/40463
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-02-13 19:24:44 +00:00
pq
35221ce1fc
Override completion displayText implementation.
...
Change-Id: If19ccb00145ec4befec2be575af48709f122b511
Reviewed-on: https://dart-review.googlesource.com/40510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-13 19:15:26 +00:00
Zach Anderson
4678cdaa24
[infra] Use wheezy sysroot for local builds on linux.
...
I had though that this is how things already worked, but it wasn't.
Change-Id: Iaa6b4e7d9e791f3fad29431c5715fcb19df8a76b
Reviewed-on: https://dart-review.googlesource.com/40840
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2018-02-13 19:11:24 +00:00
Zach Anderson
75dc48e7e4
[infra] Update trusted root certs
...
related #32131
Change-Id: Icfa5322cbb88af625ce612f7b06fb6248bc3d330
Reviewed-on: https://dart-review.googlesource.com/40860
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2018-02-13 19:11:14 +00:00
Konstantin Shcheglov
fdeadfd7e9
Don't suggest to center the Center widget.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/32135
Change-Id: Ic6ab36a2ad5ac9b7737383700a0513feee4f3946
Reviewed-on: https://dart-review.googlesource.com/40920
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-13 18:46:44 +00:00
Konstantin Shcheglov
2cd992663e
Sort assists and fixes by relevance and then by name.
...
We used to get away with sorting just by relevance because the order
of assists and fixes was correct. I think it is time to switch to
sorting. I still would like to keep 'Surround with XXX' ordered in
a specific way, so I'm changing relevance for these assists.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I77f77ec732d70b31c32164759a3ac62dc790e469
Reviewed-on: https://dart-review.googlesource.com/40880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-13 18:18:59 +00:00
Paul Berry
16e60b76a9
Delete unused class NonErrorResolverSpecTest
...
Change-Id: I41d28f102fd04ba9e27451c0c3cc2e0d216aaffc
Reviewed-on: https://dart-review.googlesource.com/40760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-02-13 14:33:57 +00:00
Paul Berry
6837dafcc3
Implement proper checking for callability of Function class.
...
There was some old (incorrect) logic for doing this, behind the flag
enableStrictCallChecks. This flag has been removed, since the new
behavior is now standard in Dart 2.0.
Fixes #31509
Change-Id: I4a6da34a4b85ea8409f6e0d14c377a586546056a
Reviewed-on: https://dart-review.googlesource.com/40509
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2018-02-13 14:19:08 +00:00
Johnni Winther
f2b8cafb44
Handle assert in initializers of constant constructors.
...
Change-Id: Ibb4053af00392b3c43177c60c8551cc6ffe937eb
Reviewed-on: https://dart-review.googlesource.com/38320
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-02-13 14:00:01 +00:00
Jens Johansen
7db26111a3
[gardening] Update simarm64 status file, issue #32134
...
Change-Id: Ia3b6cea2576130380dcc45101ea328f6f1b8dd85
Reviewed-on: https://dart-review.googlesource.com/40801
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-13 13:38:28 +00:00
Jens Johansen
5142fcc774
[gardening] kernel/windows status file updates #3
...
Change-Id: Ia0d6625494eae9d6116b90c15994ef7f07811b42
Reviewed-on: https://dart-review.googlesource.com/40800
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-13 13:35:33 +00:00
Jens Johansen
f5829bb75e
[gardening] kernel/windows status file updates #2
...
Change-Id: I5ba0dd75456ec07c833f5d2e88b30e814139b37a
Reviewed-on: https://dart-review.googlesource.com/40745
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-13 13:08:52 +00:00
Erik Ernst
8c089e18c2
Fixed two typos in void_type_function_types_test
...
Change-Id: I7e33874f9d6361c15fce61292fe0eaf22c3a85c4
Reviewed-on: https://dart-review.googlesource.com/35922
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2018-02-13 12:47:18 +00:00
Jens Johansen
4083ff54e7
[gardening] Status files for kernel optimization_counter_threshold bot
...
Change-Id: I12334bfcec3e31aea753dd815ccb15695f0db5a3
Reviewed-on: https://dart-review.googlesource.com/40780
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-13 12:40:34 +00:00
Alexander Thomas
7702816194
[infra] Add builder tag for vm-kernel-optcounter-threshold builder
...
#31838
Change-Id: I46e681518b569905a8b2b30f7add53e69aeef446
Reviewed-on: https://dart-review.googlesource.com/40742
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-13 12:32:11 +00:00
Jens Johansen
4fac2530de
[gardening] kernel/windows status file updates #1
...
Bugs #32137 and #32138 .
Change-Id: If91591170b342794120076fe6af269e8020d3796
Reviewed-on: https://dart-review.googlesource.com/40744
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-13 11:58:15 +00:00
Johnni Winther
d30aaaa4b8
Ensure no type parameters on constructors.
...
Change-Id: I6a40e2f74b8a89e5873d94d406a56f82db0d0b48
Reviewed-on: https://dart-review.googlesource.com/40526
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-02-13 11:11:05 +00:00
Peter von der Ahé
f6f849e3b9
Pass --strong-mode when testing fasta in strong mode.
...
Change-Id: I534d283d7f604d0f0e686dc23606e81f665ec5e4
Reviewed-on: https://dart-review.googlesource.com/40527
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-02-13 11:08:46 +00:00
Jens Johansen
6da54fc938
[gardening] dart2js --checked --fast-startup status update
...
Change-Id: I577acba4868397645f22ad1f17ba256dcb26d536
Reviewed-on: https://dart-review.googlesource.com/40740
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-13 09:13:46 +00:00
Rafal Wachol
91890156cc
Added ability to set User Agent for Websocket connection.
...
Bug: https://github.com/dart-lang/sdk/issues/32008
Change-Id: Ia74689e808a57b00a518e6a32f1763a40afc5860
Reviewed-on: https://dart-review.googlesource.com/40220
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2018-02-13 06:15:53 +00:00
Stephen Adams
651942ca83
dart2js kernel status
...
TBR=sigmund@google.com
Change-Id: I6b84d51a3fe6f940892637712c9501659612fd75
Reviewed-on: https://dart-review.googlesource.com/40680
Reviewed-by: Stephen Adams <sra@google.com >
2018-02-13 04:43:29 +00:00
Mike Fairhurst
29a44159d0
Remove another override that was left in after some renaming to fix the build
...
Change-Id: Ief6492aed9161b02c28e6b342782b182a1521ff6
Reviewed-on: https://dart-review.googlesource.com/40660
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-02-13 03:23:18 +00:00
Alexander Markov
6ed2ebf6b0
[vm/kernel/aot] Infer parameter types in type flow analysis
...
Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: Iea1480ce2f20b6cb08b4eb57eef5ca14a002e6e0
Reviewed-on: https://dart-review.googlesource.com/40400
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-02-13 01:11:18 +00:00
Alexander Markov
882daf8972
[Tests] Update tests/kernel for Dart 2 fixed-size integers
...
Closes https://github.com/dart-lang/sdk/issues/32072
Change-Id: Ic9bb34d2dbee6852e024f1b79d895e4d8150f03f
Reviewed-on: https://dart-review.googlesource.com/39821
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2018-02-13 00:09:28 +00:00
Stephen Adams
d78c05279a
dart2js runtime Dart 2 subtype check (mostly)
...
This change adds most of Dart 2 subtype checking to js_runtime.
The main observable change is the stronger subtyping of function types.
The subtype code is split into V1 and V2 methods with the intention to
eventually remove the V1 paths.
There is a lot of minor details that are still TODO:
- TODO: generalized void
- TODO: comparison on type variable by it's bound
- TODO: FutureOr
Change-Id: Id05db0aef5ce0d58416a72f1538a90ed67436b3e
Reviewed-on: https://dart-review.googlesource.com/37960
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2018-02-12 23:54:48 +00:00
Brian Wilkerson
850ec64864
Add a fix to make const instance fields static (issue 32128)
...
Change-Id: I1ca5cbf95f28ed36133bd562d3b7ce6a58d19ce6
Reviewed-on: https://dart-review.googlesource.com/40640
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 23:40:08 +00:00
Mike Fairhurst
e9c5abdaca
Remove @override for test method that was renamed & now passes to fix build
...
Change-Id: I69138be190092681d4bdf1d06936f06a9a1bddab
Reviewed-on: https://dart-review.googlesource.com/40621
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-12 22:30:12 +00:00
Konstantin Shcheglov
19500670b9
Rename Flutter assist constants to better reflect what they are doing.
...
Particularly that "reparent" is "wrap", and "move up/down" is "swap".
R=brianwilkerson@google.com
Change-Id: Ie6fcaa178e41a161061f05b81a8b1cff506b0714
Reviewed-on: https://dart-review.googlesource.com/40620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 22:26:29 +00:00
Mike Fairhurst
7a0a9284ba
Relax void errors: no error assigning void to void variable (+tests)
...
Change-Id: I1a6e80125dff6f766c9a74b760b557609a2544fb
Reviewed-on: https://dart-review.googlesource.com/40507
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-02-12 21:24:19 +00:00
Konstantin Shcheglov
3791ddb496
Keep unresolved import/export directives for task based analysis.
...
Bug: https://github.com/dart-lang/angular/issues/801
Change-Id: If8bdcbfdc10d3aae914391573c5eb2e7beb26a8f
Reviewed-on: https://dart-review.googlesource.com/40600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 21:20:49 +00:00
Konstantin Shcheglov
c1d5d843af
Add identifiers for Quick Assists.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I07cd18ae38f98793f960a2c7bd971527eaa6d7d6
Reviewed-on: https://dart-review.googlesource.com/40140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 20:56:09 +00:00
Konstantin Shcheglov
223eeb2ebe
Always shorten function expressions, list/map literals, multiline values.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1762
Change-Id: I742ac6cb0ebbdde78f1326c5e07775d94e335d42
Reviewed-on: https://dart-review.googlesource.com/40560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 19:15:05 +00:00
Samir Jindel
0e6d8c0fc7
Update status files.
...
Change-Id: Icb2249b3e115dbd738136873cf664a2e2412e369
Reviewed-on: https://dart-review.googlesource.com/40580
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-02-12 18:49:33 +00:00