dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

56224 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan Rubel c2d88d024f Improve class implements/with recovery 
Change-Id: I32beebbb9cc5ecec188a5a1557a2ae510d7ba214
Reviewed-on: https://dart-review.googlesource.com/54602
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-10 20:41:34 +00:00
Dan Rubel 7c8a4ae569 Refactor Analyzer/CFE body builder tests 
Change-Id: Icbcd0e16fce448afe340598975d67154a5478df3
Reviewed-on: https://dart-review.googlesource.com/54601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-10 20:13:35 +00:00
Dan Rubel 04af8ace52 Improve top level const/final/var name recovery 
Change-Id: Ie07ca020a5f5a6c3abbe2ee48bd83c4e3ea4075c
Reviewed-on: https://dart-review.googlesource.com/54600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-10 20:07:25 +00:00
Sigmund Cherem b894a69c80 Fix status file: make bots green 
TBR=sra@google.com

Change-Id: I85432f4ccf739c3f9c69c60cb76cdeeaddd49cec
Reviewed-on: https://dart-review.googlesource.com/54623
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-05-10 17:51:34 +00:00
Samir Jindel 0cafdc4fdb [vm] Fix handling of all-dynamic type arguments in noSuchMethod. 
This fixes #33073 for all code which is relevant to Dart 2.

Change-Id: I3956bf9f2bb06f0e67c8b643e8a7765f28464f5f
Reviewed-on: https://dart-review.googlesource.com/54260
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-05-10 17:06:42 +00:00
Ryan Macnak c1b873bb91 [vm, arm] Fix unaligned access to external TypedData in natives. 
Bug: b/78784236
Change-Id: I8235135e9f438c51d0f7e6297498e5ade2eb9659
Reviewed-on: https://dart-review.googlesource.com/54530
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-05-10 16:48:18 +00:00
Brian Wilkerson f62b9781bc Fix the resolution tests associated with simple literals 
Change-Id: Id26eaaa368ea94c83031032b3ab8abdc6ba20d2d
Reviewed-on: https://dart-review.googlesource.com/54620
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-05-10 16:33:09 +00:00
Dan Rubel 17c50d45fa Remove most uses of kernel.Expression 
I'm landing Peter's change:
https://dart-review.googlesource.com/c/sdk/+/54460

Change-Id: I2228d0a0156f67e41515c41788c0b855f1a2a437
Reviewed-on: https://dart-review.googlesource.com/54544
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-10 14:55:50 +00:00
Danny Tuppeny d5f76cc963 Add annotations to folding regions 
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: Ie1917e3bd29b5cc2b6ecbed1238818e4e49f822a
Reviewed-on: https://dart-review.googlesource.com/54580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-05-10 14:22:41 +00:00
Brian Wilkerson cec983a931 Add some initial resolution tests for literals 
Change-Id: I024321b355ed56abaec86c6c423d6af42ee3f6a2
Reviewed-on: https://dart-review.googlesource.com/54527
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-05-10 14:15:21 +00:00
Dan Rubel 6b5361c334 Improve recovery of enum declaration 
Change-Id: I8709e76c38d778d97673e11a8d89d424611a292b
Reviewed-on: https://dart-review.googlesource.com/54543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-10 13:57:51 +00:00
Brian Wilkerson c2f807e487 Implement more overridden methods in parser tests 
Change-Id: I981df7281ab33ada15672f6017a40f88fe3a4784
Reviewed-on: https://dart-review.googlesource.com/54531
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-10 12:44:09 +00:00
Danny Tuppeny 46043004d6 Move folding regions to actual blocks 
This puts the region inside the braces; eg. the bit the user would expect to disappear when the region is collapsed.

Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: I58b347d2e1582bb4a6a35cf45c17085ea1739816
Reviewed-on: https://dart-review.googlesource.com/54402
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-05-10 07:44:10 +00:00
Ryan Macnak 407872b9e5 Revert "[vm] Remove Dart_ReadKernelBinary." 
This reverts commit 2998c32951.

Reason for revert: Failures with kernel + simulators

Original change's description:
> [vm] Remove Dart_ReadKernelBinary.
> 
>  - Fix const-ness of Dart_FileReadCallback and callers.
>  - Fix leak on read error in DartUtils::FileRead.
> 
> This is progress towards sharing kernel memory on Fuchsia.
> 
> Bug: https://github.com/dart-lang/sdk/issues/32618
> Change-Id: I47f8b224905d6a105a5ca0ab2ee4ab6a42b5e342
> Reviewed-on: https://dart-review.googlesource.com/47102
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=aam@google.com,rmacnak@google.com,asiva@google.com

Change-Id: Ibb636b817de1629a062fe0a6ef9462a2fef669ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/32618
Reviewed-on: https://dart-review.googlesource.com/54560
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-05-10 01:36:39 +00:00
Sigmund Cherem c25a9fd46b Remove support for dart:isolate in dart2js. 
Change-Id: I1216a0ac91d8a1d13b441809596e1a8b5e51bb34
Reviewed-on: https://dart-review.googlesource.com/54526
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-05-10 01:20:17 +00:00
Ryan Macnak 2998c32951 [vm] Remove Dart_ReadKernelBinary. 
- Fix const-ness of Dart_FileReadCallback and callers.
 - Fix leak on read error in DartUtils::FileRead.

This is progress towards sharing kernel memory on Fuchsia.

Bug: https://github.com/dart-lang/sdk/issues/32618
Change-Id: I47f8b224905d6a105a5ca0ab2ee4ab6a42b5e342
Reviewed-on: https://dart-review.googlesource.com/47102
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-05-10 00:35:37 +00:00
Jenny Messerly e998c56a72 fix #32980, better error messages for type errors at runtime 
Change-Id: I4666c82b706dcaa963f4acf1c1c5d770e0ab1c6a
Reviewed-on: https://dart-review.googlesource.com/54101
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-05-10 00:13:27 +00:00
Jenny Messerly 0fde28b2dd fix #31393, port utf8 decoder optimizations from dart2js to ddc 
The dart2js changes were made in:
https://github.com/dart-lang/sdk/commit/3836c70a8150bc33a695788deee346b940b40769

Change-Id: I5476c10e3734fa8ab0c027dd258b2fa5ef43287b
Reviewed-on: https://dart-review.googlesource.com/54529
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-05-10 00:06:12 +00:00
Adam Barth 779dc6eb85 Stop leaking file descriptors for HTTP clients 
Previously, we would wait for a Future to terminate before destroying
the underlying raw socket. If that future never terminated, we would
leak the underlying file descriptor.

Now, the "force" codepath in close destroys the socket immediately
(similar to what it did previously for active sockets) and the non-force
codepath has a timeout, as requested by a TODO comment.

Change-Id: I021a93a40e4708ce93b4f1ae6c3f7289764bd69f
Reviewed-on: https://dart-review.googlesource.com/54442
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Adam Barth <abarth@google.com>
 2018-05-09 21:33:09 +00:00
Stephen Adams b294e48bdf Hack to fix sort order 
TBR=sigmund@google.com

Change-Id: I3771405638f85d2f6d3b3a883d00b88114fc49d3
Reviewed-on: https://dart-review.googlesource.com/54525
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-05-09 21:10:57 +00:00
Dan Rubel 5951f1e4f1 Improve enum declaration identifier recovery 
Change-Id: Ib0646fdd405dbe4fe0bd6cb788c0cbfe4d20fc1b
Reviewed-on: https://dart-review.googlesource.com/54542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-09 20:58:28 +00:00
Dan Rubel 1860096702 Use correct type arguments for Forest. 
I'm landing Peter's change:
https://dart-review.googlesource.com/c/sdk/+/54400

Change-Id: I337d4b63a085fbf06f5d5cf93b13b60f70e7cb4f
Reviewed-on: https://dart-review.googlesource.com/54541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-09 20:57:07 +00:00
pq 6e15762556 Bump to linter 0.1.50 
* migration of rules to use analyzer package `NodeLintRule` and `UnitLintRule` yielding significant performance gains all around
* specific performance improvements for `prefer_final_fields` (~6x)
* addressed no such method calls in `void_checks`
* improved lint reporting for various lints

Change-Id: I63896a5367e27241ef596408aea44830c8067c75
Reviewed-on: https://dart-review.googlesource.com/53861
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-05-09 20:52:51 +00:00
Stephen Adams e5820f7e94 Place generator body in same unit as entry 
Change-Id: I897bf8011bde7fcc1acb081c75f17429b948e109
Reviewed-on: https://dart-review.googlesource.com/54524
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-05-09 20:45:47 +00:00
Régis Crelier 41fcbd097c [VM runtime] Initial version of Kernel Bytecode interpreter in VM runtime. 
Not fully working yet, only x64, no gc, no frame walking, etc...

Change-Id: I4d8357f6d46371bf21c3d54266cfe26163e3c8dc
Reviewed-on: https://dart-review.googlesource.com/50021
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-05-09 20:29:27 +00:00
Dan Rubel a4772ea629 Refer to Expression and Statement via prefix 
I'm landing Peter's change:
https://dart-review.googlesource.com/c/sdk/+/54388

Change-Id: Ia3c842d56fb2ea628351cba09180bc351d4b5b4b
Reviewed-on: https://dart-review.googlesource.com/54540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-09 19:58:27 +00:00
Konstantin Shcheglov 310745ca8b Add support for adding missing named parameters to constructors. 
I expected it to be more complex than it turned out to be.

R=brianwilkerson@google.com

Change-Id: I2a41204ea615ec7b65d7858bc4ed3908af17b2c1
Reviewed-on: https://dart-review.googlesource.com/54523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-09 19:32:27 +00:00
Konstantin Shcheglov e8c8557fcb Switch the fix for adding not named required/positional parameter to using _ExecutableParameters. 
R=brianwilkerson@google.com

Change-Id: I7804e2847733b4c4a6effa2c5818e2533454f1c9
Reviewed-on: https://dart-review.googlesource.com/54521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-09 19:32:08 +00:00
Dan Rubel fa071e8ecb Update AstBuildingForest tests 
Change-Id: I01398db759d048b588e5b67637370bd528b7828b
Reviewed-on: https://dart-review.googlesource.com/54480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-09 18:57:17 +00:00
Brian Wilkerson bedf640eca Address review comments from previous CLs 
Change-Id: I07faabb0f59fc716175ab6abfbbc76c09beffef2
Reviewed-on: https://dart-review.googlesource.com/54302
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-09 18:49:37 +00:00
Leaf Petersen 2d95c54392 CHANGELOG for cast/retype changes 
Change-Id: I8d23c6829937de3c1d6c42d7e33b106473f82d1d
Reviewed-on: https://dart-review.googlesource.com/54522
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-05-09 18:36:32 +00:00
Stephen Adams 6efd3b3654 Refactor output code for generators 
sync*/async/async* generators have two parts: an entry, which does
checks and computes the element type of the result, and a body, which
is transformed after lowering to JavaScript.

The split ensures that the code for checks is done at function call
time, rather than e.g. in the moveNext method of a sync* iterator.

A following CL with optimize the split to generate one function when
there are no checks and the type argument is simple enough for textual
substitution.

Change-Id: I5414109ca851f9267871aa113a2e29b16236986d
Reviewed-on: https://dart-review.googlesource.com/54308
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-05-09 18:22:07 +00:00
Vyacheslav Egorov e67222a92b [vm/compiler] Do not use call->ArgumentAt(0) to access receiver. 
If call can have type arguments we can't use call->ArgumentAt(0) to
access receiver, instead we need to use call->ArgumentAt(call->FirstArgIndex()).

This lead to a bug in polymorphic inlining of functions with type
arguments - instead of loading class id from the receiver we would be
loading it from the first argument which contains type arguments.

This CL also cleans up other parts of the compiler that used ArgumentAt(0)
when they needed receiver.

Fixes https://github.com/dart-lang/protobuf/issues/95

Change-Id: I5504f7aff714894ff9fe580710c376f1d1933bfa
Reviewed-on: https://dart-review.googlesource.com/54411
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-05-09 18:01:57 +00:00
Zach Anderson 5afa2dca51 [dart:io] Fix ProcessStartMode.values 
Change-Id: I1bdd98c7e86991e38d6bc7555620d784d595eb2d
Reviewed-on: https://dart-review.googlesource.com/54441
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-05-09 17:27:57 +00:00
Zach Anderson a49fd95d59 [CHANGELOG] Update for dart:io constant rename 
Change-Id: I18c965ebed9fb700b07f879f64d602b5fc985a83
Reviewed-on: https://dart-review.googlesource.com/54440
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-05-09 16:57:53 +00:00
Sigmund Cherem 3ec1b929e3 Remove dependencies on isolates. 
This starts removing support for isolates. I've kept around the
isolate library for now, but I stopped injecting the isolate logic
unless you directly access an isolate API.

Concrete changes:

* Timer no longer uses the event queue: this was only used in worker
isolates, soon to be removed.

* Checking for whether the code is run within a worker is not dependent
   on initializing the isolates global state. This was important to allow
   deferred-loading to work without the isolate logic.

* Workers no longer track pending async calls correctly. This may make it possible
   to terminate worker isolates early, again this wont be relevant shortly.

Bug: https://github.com/dart-lang/sdk/issues/32684
Change-Id: I05025418e05c3641ba1a3bc34ea75ca558a28fbd
Reviewed-on: https://dart-review.googlesource.com/54160
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-05-09 16:36:26 +00:00
Alexander Aprelev 2ad715e706 [vm/hr] Directly compare type arguments count when validate hot reload. 
There might be better fix with using canonical types for comparison, we
just need to make sure we canonicalize class's type when finalizing it.

Bug:https://github.com/dart-lang/sdk/issues/32942
Change-Id: I2301a7cb91146d587893f91f2d6ee7b731ea3c62
Reviewed-on: https://dart-review.googlesource.com/54314
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-05-09 16:34:17 +00:00
Kevin Millikin 8dbe716085 Remove the unused GenericCovariantInterface bit 
None of the back ends are using it and it imposes a cost to have to
compute it and try to preserve it.

Change-Id: I217e1191b535829021fa11f2698cadd8d4baf1c8
Reviewed-on: https://dart-review.googlesource.com/54383
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-09 15:04:43 +00:00
Dmitry Stefantsov f61e1c0fb3 Mark metadata_test as failing on dart_precompiled 
Bug: http://dartbug.com/33086
Change-Id: Id3105e980cf28b8f7bacbe40944f7e28001b23c5
Reviewed-on: https://dart-review.googlesource.com/54406
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-09 13:58:03 +00:00
Martin Kustermann 24224ced5b [VM] Update status file, test became much slower after strong-mode changes to mirrors implementation 
Issue https://github.com/dart-lang/sdk/issues/33057

Change-Id: I02785f43fd16f4396de770972a4e64d64500ea80
Reviewed-on: https://dart-review.googlesource.com/54404
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-05-09 13:33:03 +00:00
Brian Wilkerson a8364e3412 Add missing method to FastaParserTestCase 
Change-Id: I49a10b4843910d3fad0a95cc6165c96a5e8da48d
Reviewed-on: https://dart-review.googlesource.com/54310
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-09 13:26:23 +00:00
Samir Jindel b5154dd01e Revert "[vm/kernel] Expression execution through Kernel. 
This reverts commit afd0a52a5a.

Reason for revert: Breaks kernel-a32 and kernel-rbc bots

Original change's description:
> [vm/kernel] Expression execution through Kernel.
> 
> Change-Id: Id90c91cb3b71f9ce703e21fe48147b86a7764d34
> Reviewed-on: https://dart-review.googlesource.com/42562
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Alexander Aprelev <aam@google.com>
> Commit-Queue: Samir Jindel <sjindel@google.com>

TBR=aam@google.com,rmacnak@google.com,sjindel@google.com

Change-Id: If1ecad6145aeab81d5d3581798a628ead0265c38
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/54420
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-05-09 12:41:00 +00:00
Karl Klose 2daa5610ac Add more issue numbers to fasta status file 
R=dmitryas@google.com

Change-Id: Ib04869c94b2a695ed1ac65b3f50adff84f84ab99
Reviewed-on: https://dart-review.googlesource.com/54231
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-09 11:18:53 +00:00
Dmitry Stefantsov b25e12ddc6 [fasta] Remove BuiltTypeBuilder 
Change-Id: I8a3678e37ef0c51023c5c52f1fc8e7d11d005c86
Reviewed-on: https://dart-review.googlesource.com/54382
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-09 10:36:12 +00:00
Samir Jindel afd0a52a5a [vm/kernel] Expression execution through Kernel. 
Change-Id: Id90c91cb3b71f9ce703e21fe48147b86a7764d34
Reviewed-on: https://dart-review.googlesource.com/42562
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-05-09 10:27:52 +00:00
Karl Klose 41eb5ddfdc Add some issue numbers to fasta status file 
R=dmitryas@google.com

Change-Id: I8091190fbd2ea3eff399b4b568cfb62698cbf954
Reviewed-on: https://dart-review.googlesource.com/54220
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2018-05-09 10:16:22 +00:00
Johnni Winther df9af04061 Remove CompilerOptions.useKernel 
Change-Id: I9ea69addeb18e061280329c233a110fe2d8ca763
Reviewed-on: https://dart-review.googlesource.com/54240
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-05-09 10:13:32 +00:00
Jens Johansen 972d4b0b1d Add frontendInternal key and external example to messages tests 
This CL adds two keys to the messages.yaml file:

 * `frontendInternal` which indicates that we do not require a
    dart2jsCode nor a analyzerCode: there is no corresponding
    error in other tools

 * `external` which can be used instead of an example. The external
   file is not actually run to verify the example, but the file is
   checked for existance. This can for instance be used to test an
   internal frontend error code.

Change-Id: I2426c6ba2a2abe5baaab09c8e0947b4b876df083
Reviewed-on: https://dart-review.googlesource.com/54387
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-09 10:07:42 +00:00
Peter von der Ahé ee0a2cd8bc Restore type arguments on Forest 
Change-Id: I3bdce8f470e31e4b95a028842a3f188102b74ba4
Reviewed-on: https://dart-review.googlesource.com/54386
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-05-09 10:01:47 +00:00
Danny Tuppeny a65dc90bd0 Improve error message for invalid characters 
The order of checks has been swapped so invlaid characters (which give a more specific message) are returned over those for first letters.

Bug: https://github.com/dart-lang/sdk/issues/32678
Change-Id: I784191ea7a0e072cc8994bbb47b03421e33aa90e
Reviewed-on: https://dart-review.googlesource.com/54244
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-05-09 09:56:42 +00:00