Commit Graph

1233 Commits

Author SHA1 Message Date
nweiz@google.com 0e32e0327f Fix pub_lish_test.
This fixes a consistent breakage, not the flakiness.

Review URL: https://codereview.chromium.org//12847002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19970 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 20:45:59 +00:00
rnystrom@google.com 0122b2954e Dev dependencies.
BUG=dartbug.com/5358

Review URL: https://codereview.chromium.org//12433014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19966 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 19:40:25 +00:00
floitsch@google.com 482b2f34e8 Move Options to dart:io.
Review URL: https://codereview.chromium.org//12794002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19927 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 13:12:00 +00:00
floitsch@google.com 65718c56df Rename XMatching to XWhere.
For example firstMatching -> firstWhere.

BUG= http://dartbug.com/8664
BUG= http://dartbug.com/8337

Review URL: https://codereview.chromium.org//12537009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19880 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 17:34:49 +00:00
nweiz@google.com f29ae528f7 Use default-port-aware URI comparisons in pub.
This fixes a usability issue where error messages from
pub.dartlang.org were getting reported as generic HTTP errors.

Review URL: https://codereview.chromium.org//12667016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19826 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 23:07:17 +00:00
amouravski@google.com 6e056b8044 Lots of little changes for dartdoc/apidoc.
* Alphabetized imports.
* Added TODOs.
* Removed some prefixes.
* Cleaned up a LOT of async code to make it work better.
* Much, much, much friendlier status messages for dartdoc/apidoc. More to do...
* Prevented many, many bad warnings from showing up... by fixing them.
* Smarter finding of packages directories.
* Started using pathos all over the place.
* Added indexed_db to html_diff.

Review URL: https://codereview.chromium.org//12448006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19817 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 20:27:53 +00:00
nweiz@google.com 15762df9f4 Stop working around issue 8512.
Review URL: https://codereview.chromium.org//12452008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19743 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 23:04:09 +00:00
nweiz@google.com 845e550cbb Properly handle errors from the OAuth2 token endpoint in pub.
This also adds more detailed HTTP logging to pub.

BUG=8849

Review URL: https://codereview.chromium.org//12428012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19734 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 21:57:27 +00:00
nweiz@google.com c71bb58877 Update pub to use the latest dart:io stream APIs.
Review URL: https://codereview.chromium.org//12613010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19729 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 21:46:08 +00:00
floitsch@google.com dd48256fe5 Remove deprecated StringBuffer.add, addAll and addCharCode.
Review URL: https://codereview.chromium.org//12473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19690 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 13:07:18 +00:00
lrn@google.com cd9bcfe956 Remove references to capital-D-Dynamic.
Review URL: https://codereview.chromium.org//12615002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19687 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 11:57:28 +00:00
lrn@google.com bead146749 Renamed StreamSink to EventSink. Renamed signalError to addError.
Review URL: https://codereview.chromium.org//12610006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19683 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 11:31:19 +00:00
sgjesse@google.com b6096848b1 Make IOSink implement StringSink
Besides adding the StringSink methods I also added writeBytes and
deprecated both add and addString.

To handle the encoding of strings the IOSike has an encoding
property. This property is mutable in situation when it makes sense to
change encoding of what is written. The exception here is for HTTP
where the encoding is determined from the header and the encoding
cannot be changed.

R=ajohnsen@google.com, ager@google.com, nweiz@google.com

BUG=

Review URL: https://codereview.chromium.org//12504006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19676 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 10:06:28 +00:00
johnniwinther@google.com 44b1941b88 Revert "Remove pkg from apidoc."
This reverts commit r19636.

Review URL: https://codereview.chromium.org//12614006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19637 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 15:19:14 +00:00
johnniwinther@google.com 4f40f1d3aa Remove pkg from apidoc.
Review URL: https://codereview.chromium.org//12613008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19636 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 15:01:35 +00:00
rnystrom@google.com b3e5168249 Add a failing test for handling broken symlinks.
BUG=8343

Review URL: https://codereview.chromium.org//12500005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19580 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 20:55:53 +00:00
johnniwinther@google.com 43d6b6a84b Support full dart2js output for dartdoc/apidoc.
Review URL: https://codereview.chromium.org//12446003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19537 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 08:43:33 +00:00
rnystrom@google.com 50d1fc7a99 Delete files synchronously.
BUG=8868

Review URL: https://codereview.chromium.org//12481003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19517 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-05 21:32:35 +00:00
gram@google.com 9b40e6b13e Fix issue with async callbacks that get called synchronously while running test case function causing the test to be marked as complete prematurely.
Added an optional id to completion matchers that can be used in error messages (this was invaluable in tracking down the above problem).

Re-enable pub tests. https://code.google.com/p/dart/issues/detail?id=8862
Review URL: https://codereview.chromium.org//12393017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19339 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 21:49:15 +00:00
devoncarew@google.com 1600f30a14 Cleanup two warning messages when running apidoc, and update the apidoc.gyp file to rerun the tool
when any of its dart source changes.
Review URL: https://codereview.chromium.org//12388048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19336 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 20:01:03 +00:00
ricow@google.com 85b572e7d7 Mark flaky pub tests
Review URL: https://codereview.chromium.org//12377042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19284 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 09:08:20 +00:00
gram@google.com 621650b0e8 Disable breaking tests while I investigate the issue. I don't really want to revert;
I want to understand this as it may indicate some other problem.
Review URL: https://codereview.chromium.org//12387033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19271 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 01:38:57 +00:00
nweiz@google.com a903dfd3a4 Remove the wrapStream workaround for issue 8310.
Review URL: https://codereview.chromium.org//12374033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19266 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:24:21 +00:00
nweiz@google.com 2a0c74a18d Make pub warning-clean.
Review URL: https://codereview.chromium.org//12382031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19265 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:21:58 +00:00
nweiz@google.com 3ce4e71a92 Make use of Completer.isComplete in pub and pkg/scheduled_test.
Review URL: https://codereview.chromium.org//12385027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19264 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:18:27 +00:00
floitsch@google.com cc8cefc004 Timer callbacks don't take arguments anymore.
Review URL: https://codereview.chromium.org//12379013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19231 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 14:22:49 +00:00
floitsch@google.com ff006ed05b Timer callback doesn't take an argument anymore.
Review URL: https://codereview.chromium.org//12380019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19221 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 13:36:22 +00:00
gram@google.com 017d21bdc0 Unit test changes:
- add back KevMoo's assertions now that the bugs they exposed ar efixed
- remove onTestResult methods from a couple of configs; these did nothing other
  than prevent the base class implementation from being called which is wrong.
- fix the TestFunction signature
- change from ExpectException, which is deprecated, to TestFailure.
Review URL: https://codereview.chromium.org//12335113

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19166 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 19:57:40 +00:00
whesse@google.com 6ef35edef1 dart:io | Rename File.name to File.path.
BUG=dartbug.com/8790

Review URL: https://codereview.chromium.org//12314153

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19144 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 15:26:11 +00:00
lrn@google.com fa78a93635 Make arg parser return growable list of rest arguments.
This allows the user to remove them when he's done, which is what
is currently being done.

Review URL: https://codereview.chromium.org//12316155

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19119 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 09:48:17 +00:00
lrn@google.com 6b4f4b1bab Change new List(n) to return fixed length list.
Deprecate List.fixedLength, add List.filled.

Make Iterable.toList and List.from take "growable" argument,
defaulting to false.

Review URL: https://codereview.chromium.org//12328104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19112 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 08:45:04 +00:00
amouravski@google.com edee0d7e8e Updated an error message to inform users that their packages were not installed
when their SDK version does not match.

Review URL: https://codereview.chromium.org//12315059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19026 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 03:12:02 +00:00
rnystrom@google.com 1d62e0a077 Disable test on Windows for now.
Review URL: https://codereview.chromium.org//12313114

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19016 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 23:20:47 +00:00
rnystrom@google.com b88ebea7c3 Handle shared path dependencies.
BUG=https://code.google.com/p/dart/issues/detail?id=8775

Review URL: https://codereview.chromium.org//12335076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19012 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 23:00:16 +00:00
lrn@google.com 3c0ac360e7 Remove deprecated string features.
Make String.codeUnits return a List.

Review URL: https://codereview.chromium.org//12282038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
nweiz@google.com c8f6014ae7 Move pkg/path to pkg/pathos.
Review URL: https://codereview.chromium.org//12316056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18906 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 18:45:55 +00:00
rnystrom@google.com df8647c43f Allow whitespace in version constraints.
BUG=http://code.google.com/p/dart/issues/detail?id=7140

Review URL: https://codereview.chromium.org//12310029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18851 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 19:47:44 +00:00
rnystrom@google.com e3e5d46f32 Make sure package names are URL encoded.
If you happen to have a weird package name like "/* blah *?" you
would get a nasty HTTP error when it tried to jam that in a URL.
Instead, this will give you a friendlier 'package "/* blah */" not found error."
BUG=http://code.google.com/p/dart/issues/detail?id=7466

Review URL: https://codereview.chromium.org//12328021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18849 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 18:59:48 +00:00
sgjesse@google.com 488b016a2f Merge IO v2 branch to bleeding edge
R=ager@google.com, ajohnsen@google.com, whesse@google.com

BUG=

Review URL: https://codereview.chromium.org//12316036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18820 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 11:58:11 +00:00
rnystrom@google.com 8b37852e8a Use relative symlinks for self links and secondary "packages" dirs.
This lets you move a package directory without breaking all of those links.
BUG=http://code.google.com/p/dart/issues/detail?id=8342

Review URL: https://codereview.chromium.org//12321020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18785 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 21:17:16 +00:00
rnystrom@google.com e28a669679 Make some name validation errors warnings.
BUG=http://code.google.com/p/dart/issues/detail?id=8632

Review URL: https://codereview.chromium.org//12313014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18783 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 21:11:47 +00:00
nweiz@google.com d64b7d392a Use the correct set of reserved identifiers in pub validations.
We had been using the set listed in the spec as "BUILT_IN_IDENTIFIER", but
apparently those are the built-in identifiers that are valid for user use. Now
we're using the set listed in the spec as "reserved words".

BUG=8628

Review URL: https://codereview.chromium.org//12301032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18716 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 19:55:40 +00:00
rnystrom@google.com a1702c3578 Support relative paths in path dependencies.
BUG=http://code.google.com/p/dart/issues/detail?id=8527

Review URL: https://codereview.chromium.org//12285010


Review URL: https://codereview.chromium.org//12294039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18715 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 19:49:46 +00:00
floitsch@google.com ecce8a6293 Remove deprecated Strings class.
Review URL: https://codereview.chromium.org//12295014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18686 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 13:57:03 +00:00
lrn@google.com bbfe7b02dc Reapply "Make Comparable generic."
Avoid concurrent modification in dart2js.
Avoid crash in VM by not using self-referential type bound.

Review URL: https://codereview.chromium.org//12288040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18667 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 10:29:44 +00:00
kasperl@google.com d4feeb4910 Revert "Make Comparable generic."
This reverts commit dd714db881a0ad63eaa1e5491e93dd8843eb5929.

R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//12298027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18657 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 08:06:03 +00:00
lrn@google.com a0f22b77be Make Comparable generic.
It's now allowed to write "class X implements Comparable<X>" to make
X comparable only to X's. The argument type of Comparable<T>.compareTo
is now T.

Review URL: https://codereview.chromium.org//12255055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18655 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 07:52:24 +00:00
lrn@google.com 03f5a66836 Recommit changing List.skip/take/revert returns Iterable and remove mappedBy.
This reverts r18591.

Review URL: https://codereview.chromium.org//12295009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18615 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-18 10:35:51 +00:00
rnystrom@google.com 5ed85458d1 Revert "Support relative paths in path dependencies."
This reverts commit 0b0da0d44dde213647e7281bf0914c59fc552b27.

BUG=

Review URL: https://codereview.chromium.org//12280019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18606 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-16 02:00:45 +00:00
rnystrom@google.com 8514e448b7 Support relative paths in path dependencies.
BUG=http://code.google.com/p/dart/issues/detail?id=8527

Review URL: https://codereview.chromium.org//12285010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18605 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-16 01:45:39 +00:00