Commit Graph

1233 Commits

Author SHA1 Message Date
ahe@google.com 5c2839d6c9 Increase the heap growth rate as it decreases compile-time by as much as 10%.
Review URL: https://codereview.chromium.org//11414144

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15377 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 09:56:29 +00:00
ahe@google.com 7a3632d3ee Update dependencies after big lib -> sdk/lib move.
Review URL: https://codereview.chromium.org//11418141

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15374 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 09:24:12 +00:00
aprelev@gmail.com aa82516264 Fixed snapshot name in dart2js.bat, dartdoc.bat invocation scripts.
BUG=dartbug.com/6916
TEST=

Review URL: https://chromiumcodereview.appspot.com//11308193

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15363 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 02:45:29 +00:00
rnystrom@google.com 8ce4fd1895 Mark the pub tests as slow/timeout on Windows.
Review URL: https://codereview.chromium.org//11421085

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15361 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 00:57:36 +00:00
rnystrom@google.com d824a21ef4 Git tests on Windows are fast now.
Review URL: https://codereview.chromium.org//11414170

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15348 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 22:03:36 +00:00
erikcorry@google.com 359736e97a Fix Unicode issues in dart2js and dart2dart.
R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//11418115

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15254 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-22 12:51:14 +00:00
rnystrom@google.com 08b3c5ef6f Avoid passing absolute path to 7zip.
Review URL: https://codereview.chromium.org//11417102

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15186 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-21 00:15:33 +00:00
erikcorry@google.com 84da84c22d Revert "Add some support for the code-point code-unit distinction."
This reverts commit r15150

R=karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//11411092

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15152 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 15:23:41 +00:00
erikcorry@google.com 547cbf9da6 Add some support for the code-point code-unit distinction.
Adds String.fromCodeUnits and String.codeUnitAt, and modifies
String.fromCodePoints and String.codePointAt to actually use code points.
Fixes String.charCodes to use code points and adds String.codeUnits.
Reenables some tests, and adds new ones for non-BMP characters.
Fixes issues 6418, 6501 and 1357.

R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//11368138

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15150 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 14:51:25 +00:00
nweiz@google.com 500db0fb88 Enable CurlClient tests on Windows by bundling curl.exe.
BUG=6777

Review URL: https://codereview.chromium.org//11414044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15117 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 22:55:30 +00:00
nweiz@google.com ed9a474a50 Add a package for authenticating via OAuth2.
Review URL: https://codereview.chromium.org//11420025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15115 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 22:23:33 +00:00
nweiz@google.com f4e557d746 Move CurlClient to Pub so that it can access resources.
This CL also enables tests for the client on Linux and OS X.

Review URL: https://codereview.chromium.org//11299028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15047 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-17 01:15:45 +00:00
ager@google.com 3fb41705e5 Rename File.readAsText to File.readAsString. There is no Text type in Dart
and the methods return Strings.

R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//11412033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15011 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-16 13:10:15 +00:00
erikcorry@google.com fe0c55a728 Rename classes, methods and fields when minifying
This is a retry of a change that was reverted due to test failures.  The
difference to last time you saw this is:

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart b/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
index 9de758e..19fb966 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
@@ -689,9 +689,9 @@ class JavaScriptBackend extends Backend {
   }

   static Namer determineNamer(Compiler compiler) {
-    // TODO(erikcorry): Use the MinifyNamer depending on
-    // compiler.enableMinification.
-    return new Namer(compiler);
+    return compiler.enableMinification ?
+        new MinifyNamer(compiler) :
+        new Namer(compiler);
   }

   Element get cyclicThrowHelper {
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
index 9056858..9485bc1 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
@@ -795,7 +795,7 @@ function(prototype, staticName, fieldName, getterName, lazyValue) {
       additionalArgument = ", '${namer.operatorIs(type.element)}'";
     }
     String setterName =
-        namer.setterName(member.getLibrary(), new SourceString(accessorName));
+        namer.publicSetterName(new SourceString(accessorName));
     buffer.add("$setterName: function(v) { "
         "this.$fieldName = $helperName(v$additionalArgument); }");
   }
@@ -1348,11 +1348,14 @@ $classesCollector.$mangledName = {'':
       }
       String internalName = namer.instanceMethodInvocationName(
           selector.library, new SourceString(methodName), selector);
+      Element createInvocationMirror =
+          compiler.findHelper(const SourceString('createInvocationMirror'));
       CodeBuffer buffer = new CodeBuffer();
       buffer.add('function($args) {\n');
       buffer.add('  return this.$noSuchMethodName('
-                     '\$.createInvocationMirror("$methodName", "$internalName",'
-                     ' $type, [$args], [$argNames]));\n');
+                        '${namer.isolateAccess(createInvocationMirror)}('
+                            '"$methodName", "$internalName",'
+                            '$type, [$args], [$argNames]));\n');
       buffer.add(' }');
       return buffer;
     }
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart b/sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart
index 4ca0554..cd0529f 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart
@@ -16,7 +16,14 @@ class MinifyNamer extends Namer {
   const ALPHANUMERIC_CHARACTERS = 62;  // a-zA-Z0-9.

   String getFreshName(String proposedName, Set<String> usedNames) {
-    var freshName = _getUnusedName(proposedName, usedNames);
+    var freshName;
+    if (proposedName.startsWith(r'call$')) {
+      // We don't mangle the closure invoking function name because it is
+      // generated in applyFunction.
+      freshName = proposedName;
+    } else {
+      freshName = _getUnusedName(proposedName, usedNames);
+    }
     usedNames.add(freshName);
     return freshName;
   }
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
index c8522a0..9f5b65d 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
@@ -211,6 +211,13 @@ class Namer {
     return 'get\$$fieldName';
   }

+  String publicSetterName(SourceString name) {
+    // We dynamically create setter from the field-name. The setter name must
+    // therefore be derived from the instance field-name.
+    String fieldName = name.slowToString();
+    return 'set\$$fieldName';
+  }
+
   String getMappedGlobalName(String proposedName) {
     var newName = globalNameMap[proposedName];
     if (newName == null) {
diff --git a/sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart b/sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart
index 1c9d772..1d50aa4 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart
@@ -188,9 +188,9 @@ class _Manager {
   }

   void _nativeDetectEnvironment() {
-    JS("void", r"#.isWorker = $isWorker", this);
-    JS("void", r"#.supportsWorkers = $supportsWorkers", this);
-    JS("void", r"#.fromCommandLine = typeof(window) == 'undefined'", this);
+    JS("void", r"# = $isWorker", isWorker);
+    JS("void", r"# = $supportsWorkers", supportsWorkers);
+    JS("void", r"# = typeof(window) == 'undefined'", fromCommandLine);
   }

   void _nativeInitWorkerMessageHandler() {

R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//11364213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15005 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-16 10:41:07 +00:00
rnystrom@google.com 90325c70ca Remove support for old package layouts.
Review URL: https://codereview.chromium.org//11280018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14990 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-16 00:23:58 +00:00
rnystrom@google.com 24b6b08b04 Don't require "branches" directory in git repo.
The pub tests just validate that it looks "like" a git repo.
It seems like some git repos (ones from git later than 1.8?)
don't have this directory so let's just not worry about it.

Review URL: https://codereview.chromium.org//11416024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14988 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-15 23:52:05 +00:00
rnystrom@google.com 7cc5243981 Validate that the homepage is using an approved scheme.
Also cleaned up the pubspec tests a bit.

Review URL: https://codereview.chromium.org//11412017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14984 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-15 22:53:16 +00:00
rnystrom@google.com 4fc4f5eb9f Undo bogus change to use old dart:io API.
Review URL: https://codereview.chromium.org//11410102

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14928 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-14 23:29:46 +00:00
rnystrom@google.com 26e59cf859 Fix error reporting on invalid command line args.
It would crash in a few cases if you didn't pass in a valid command
Also fixed a few unrelated warnings since a warning we learned to
ignore was masking the original issue. :(

Review URL: https://codereview.chromium.org//11363249

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14927 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-14 23:22:35 +00:00
floitsch@google.com 3e2f323981 Dynamic -> dynamic.
Review URL: https://codereview.chromium.org//11312237

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14898 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-14 15:33:25 +00:00
rnystrom@google.com 10c9d938ab Place "packages" directories inside "tool".
Review URL: https://codereview.chromium.org//11362233

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14868 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 22:06:35 +00:00
ajohnsen@google.com 970cc5ba68 Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.
After this cleanup, RegExp no longer have a const constructor. Use 'new
RegExp(...)' from now on.

BUG=

Review URL: https://codereview.chromium.org//11365196

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14838 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:41:37 +00:00
ajohnsen@google.com ab69873a42 Make RegExp constructor non-const.
Another take of https://codereview.chromium.org/11410033/ with status changes applied for co19 tests.

BUG=

Review URL: https://codereview.chromium.org//11369210

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14837 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:18:06 +00:00
ajohnsen@google.com ec9fee9858 "Reverting 14829-14832"
BUG=

Review URL: https://codereview.chromium.org//11312203

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14833 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 07:28:13 +00:00
ajohnsen@google.com 0dbc2e6eaa Two more files with const RegExp.
BUG=

Review URL: https://codereview.chromium.org//11377126

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14832 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 07:11:19 +00:00
ajohnsen@google.com 8dc3edd7ce Make RegExp's constructor non-const.
BUG=

Review URL: https://codereview.chromium.org//11410033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14829 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 06:48:43 +00:00
blois@google.com ed44b9285d Splitting SVG types out of dart:html.
Beyond this CL I need to remove the SVG prefix for most of the classes, but this is an additional chunk of work.

Review URL: https://codereview.chromium.org//11398002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14808 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 21:15:06 +00:00
floitsch@google.com 8e6f238f86 a === b -> identical(a, b)
Replace === null with == null.

BUG=http://dartbug.com/6380

Review URL: https://codereview.chromium.org//11361190

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14794 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 17:19:58 +00:00
rnystrom@google.com 46adf67738 Allow an empty "dependencies" key in a pubspec.
Review URL: https://codereview.chromium.org//11361201

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14773 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-10 01:00:58 +00:00
rnystrom@google.com 982aac12e6 Handle URLs in 'git clone' argument.
Review URL: https://codereview.chromium.org//11410016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14763 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-09 22:54:19 +00:00
amouravski@google.com 88c2ed92da Re-included matchers documentation.
Review URL: https://codereview.chromium.org//11377065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14710 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 22:07:42 +00:00
gram@google.com 58a016634c Update utils to new library syntax.
This doesn't include adding partofs; that will have to be done later.
Review URL: https://codereview.chromium.org//11358145

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14693 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 17:42:40 +00:00
rnystrom@google.com c8d4f7dd50 Mark pub windows git tests as potentially timing out.
Review URL: https://codereview.chromium.org//11361163

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14672 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 01:44:08 +00:00
rnystrom@google.com bf31c85b6f Pass absolute path to git.
BUG=

Review URL: https://codereview.chromium.org//11364141

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14670 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 01:01:13 +00:00
rnystrom@google.com 9c0ace0797 Revert "Pass absolute path to git (redux)."
This reverts commit 9d638b8a9a48c7bae854685f9413d2c40a4911a1.

BUG=

Review URL: https://codereview.chromium.org//11361158

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14661 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 23:25:31 +00:00
rnystrom@google.com 930a3f1d7e Pass absolute path to git (redux).
Review URL: https://codereview.chromium.org//11312133

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14659 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 23:20:18 +00:00
rnystrom@google.com 0caf122ecd Revert "Pass absolute path to 'git clone'."
This reverts commit db4155692da9cda80ef558886eeea35e963fe1c6.

BUG=

Review URL: https://codereview.chromium.org//11360133

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14655 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 22:12:20 +00:00
rnystrom@google.com 8bea0cc487 Pass absolute path to 'git clone'.
Review URL: https://codereview.chromium.org//11390003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14654 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 22:03:53 +00:00
rnystrom@google.com f50263acb9 Revert "Try setting the working directory explicitly."
This reverts commit 71ae3f9bcae7ff111a3f360384ec148f1c2079b2.

BUG=

Review URL: https://codereview.chromium.org//11383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14652 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 21:00:43 +00:00
rnystrom@google.com c5fb8014cb Try setting the working directory explicitly.
This shouldn't be necessary but I want to see if this makes the
Windows buildbots happy.

BUG=

Review URL: https://codereview.chromium.org//11377036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14650 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 20:49:40 +00:00
ager@google.com b61bebe636 Allow Directory.create to create all missing path components.
Unified Directory.create/list/delete to take a named 'recursive'
argument.

Fixed bug in Path implementation on Windows.

R=sgjesse@google.com
BUG=dartbug.com/6024

Review URL: https://codereview.chromium.org//11364097

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14572 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-06 15:00:54 +00:00
johnniwinther@google.com 07e6f0d876 Handle (missing) trailing slash in dartdoc
Review URL: https://codereview.chromium.org//11369092

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14561 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-06 11:54:40 +00:00
johnniwinther@google.com 1e96528cc1 Fix move errors.
Review URL: https://codereview.chromium.org//11359059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14557 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-06 10:19:56 +00:00
rnystrom@google.com 5704507534 Show better error messages in network failures.
We had decent messages for a couple of failure modes. This tries
to catch some more.

Review URL: https://codereview.chromium.org//11369066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14543 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-05 20:42:39 +00:00
rnystrom@google.com bfab2791fe Don't show http package docs on api.dartlang.org.
Review URL: https://codereview.chromium.org//11361102

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14542 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-05 20:11:52 +00:00
johnniwinther@google.com b3f4c99af6 Revert "Handle (missing) trailing slash in dartdoc"
This reverts commit r14536.

Review URL: https://codereview.chromium.org//11369076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14537 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-05 16:37:53 +00:00
johnniwinther@google.com b861fa6566 Handle (missing) trailing slash in dartdoc
BUG=2311

Review URL: https://codereview.chromium.org//11369074

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14536 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-05 16:29:36 +00:00
dgrove@google.com 7897a78551 Changes outside pkg/ and lib/ for directory refactoring
Review URL: https://codereview.chromium.org//11358024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14475 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 15:18:11 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
johnniwinther@google.com ec9e32f669 ObjectMirror => ContainerMirror
declaredMembers => members

Review URL: https://codereview.chromium.org//11363005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14325 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-31 10:51:10 +00:00